116529 2013-05-21 03:25:03 -0700 [BlackBerry] FontCache::getFontDataForCharacters() returns nullptr 2013-05-21 08:49:51 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia commit-queue xan.lopez oldest_to_newest 891680 0 berto 2013-05-21 03:25:03 -0700 This cannot be converted to a PassRefPtr and breaks the build: FontCacheBlackBerry.cpp:150:16: error: could not convert 'nullptr' from 'std::nullptr_t' to 'WTF::PassRefPtr<WebCore::SimpleFontData>' FontCacheBlackBerry.cpp:174:16: error: could not convert 'nullptr' from 'std::nullptr_t' to 'WTF::PassRefPtr<WebCore::SimpleFontData>' The change was introduced in r147639 http://trac.webkit.org/changeset/147639/trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp 891682 1 202404 berto 2013-05-21 03:26:14 -0700 Created attachment 202404 Patch 891777 2 202404 kling 2013-05-21 08:28:01 -0700 Comment on attachment 202404 Patch Oops, my bad! r=me 891799 3 202404 commit-queue 2013-05-21 08:49:50 -0700 Comment on attachment 202404 Patch Clearing flags on attachment: 202404 Committed r150442: <http://trac.webkit.org/changeset/150442> 891800 4 commit-queue 2013-05-21 08:49:51 -0700 All reviewed patches have been landed. Closing bug. 202404 2013-05-21 03:26:14 -0700 2013-05-21 08:49:49 -0700 Patch 116529.diff text/plain 1996 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZTI2ZmZjLi5mM2E4OGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDUtMjEgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBGb250Q2FjaGU6OmdldEZvbnREYXRhRm9yQ2hhcmFjdGVycygp IHJldHVybnMgbnVsbHB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE2NTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBjYW5ub3QgYmUgY29udmVydGVkIHRvIGEgUGFzc1JlZlB0ciBhbmQgYnJl YWtzIHRoZSBidWlsZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkv Rm9udENhY2hlQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6Omdl dEZvbnREYXRhRm9yQ2hhcmFjdGVycyk6CisKIDIwMTMtMDUtMjEgIE1paG5lYSBPdmlkZW5pZSAg PG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTU1JlZ2lvbnNdIENvbnN0cmFpbiBhdXRv LWhlaWdodCByZWdpb24gY29tcHV0YXRpb24gaW4gYSBkaWZmZXJlbnQgd2F5CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRDYWNoZUJs YWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJy eS9Gb250Q2FjaGVCbGFja0JlcnJ5LmNwcAppbmRleCAyZmJjMTRiLi4xMGI3YWRlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRDYWNo ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvRm9udENhY2hlQmxhY2tCZXJyeS5jcHAKQEAgLTE0Nyw3ICsxNDcsNyBAQCBQYXNz UmVmUHRyPFNpbXBsZUZvbnREYXRhPiBGb250Q2FjaGU6OmdldEZvbnREYXRhRm9yQ2hhcmFjdGVy cyhjb25zdCBGb250JiBmb250LAogICAgIEZvbnRDYWNoZTo6U2ltcGxlRm9udEZhbWlseSBmYW1p bHk7CiAgICAgRm9udENhY2hlOjpnZXRGb250RmFtaWx5Rm9yQ2hhcmFjdGVycyhjaGFyYWN0ZXJz LCBsZW5ndGgsIGxvY2FsZS5nZXRMYW5ndWFnZSgpLCBmb250LmZvbnREZXNjcmlwdGlvbigpLCAm ZmFtaWx5KTsKICAgICBpZiAoZmFtaWx5Lm5hbWUuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4g bnVsbHB0cjsKKyAgICAgICAgcmV0dXJuIDA7CiAKICAgICBBdG9taWNTdHJpbmcgYXRvbWljRmFt aWx5KGZhbWlseS5uYW1lKTsKICAgICAvLyBDaGFuZ2VzIHdlaWdodCBhbmQvb3IgaXRhbGljIG9m IGdpdmVuIEZvbnREZXNjcmlwdGlvbiBkZXBlbmRzIG9uCkBAIC0xNzEsNyArMTcxLDcgQEAgUGFz c1JlZlB0cjxTaW1wbGVGb250RGF0YT4gRm9udENhY2hlOjpnZXRGb250RGF0YUZvckNoYXJhY3Rl cnMoY29uc3QgRm9udCYgZm9udCwKIAogICAgIEZvbnRQbGF0Zm9ybURhdGEqIHN1YnN0aXR1dGVQ bGF0Zm9ybURhdGEgPSBnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGRlc2NyaXB0aW9uLCBhdG9t aWNGYW1pbHksIERvTm90UmV0YWluKTsKICAgICBpZiAoIXN1YnN0aXR1dGVQbGF0Zm9ybURhdGEp Ci0gICAgICAgIHJldHVybiBudWxscHRyOworICAgICAgICByZXR1cm4gMDsKICAgICBGb250UGxh dGZvcm1EYXRhIHBsYXRmb3JtRGF0YSA9IEZvbnRQbGF0Zm9ybURhdGEoKnN1YnN0aXR1dGVQbGF0 Zm9ybURhdGEpOwogICAgIHBsYXRmb3JtRGF0YS5zZXRGYWtlQm9sZChzaG91bGRTZXRGYWtlQm9s ZCk7CiAgICAgcGxhdGZvcm1EYXRhLnNldEZha2VJdGFsaWMoc2hvdWxkU2V0RmFrZUl0YWxpYyk7 Cg==