116516 2013-05-20 23:16:29 -0700 REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails 2013-05-21 14:27:34 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116573 1 rniwa rniwa commit-queue oldest_to_newest 891587 0 rniwa 2013-05-20 23:16:29 -0700 REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html 891608 1 202389 rniwa 2013-05-21 00:36:56 -0700 Created attachment 202389 Fixes the bug 891609 2 rniwa 2013-05-21 00:38:50 -0700 Committed r150425: <http://trac.webkit.org/changeset/150425> 891986 3 commit-queue 2013-05-21 13:40:40 -0700 Re-opened since this is blocked by bug 116573 892011 4 202470 rniwa 2013-05-21 14:23:31 -0700 Created attachment 202470 Fixes DRT 892013 5 202470 ap 2013-05-21 14:25:17 -0700 Comment on attachment 202470 Fixes DRT View in context: https://bugs.webkit.org/attachment.cgi?id=202470&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:549 > - [webView setDefersCallbacks:NO]; > [webView setGrammarCheckingEnabled:YES]; > + > + [webView setDefersCallbacks:NO]; Why this change? 892014 6 202470 rniwa 2013-05-21 14:26:42 -0700 Comment on attachment 202470 Fixes DRT View in context: https://bugs.webkit.org/attachment.cgi?id=202470&action=review >> Tools/DumpRenderTree/mac/DumpRenderTree.mm:549 >> + [webView setDefersCallbacks:NO]; > > Why this change? I matched the ordering. 892016 7 rniwa 2013-05-21 14:27:34 -0700 Committed r150479: <http://trac.webkit.org/changeset/150479> 202389 2013-05-21 00:36:56 -0700 2013-05-21 14:23:30 -0700 Fixes the bug bug-116516-20130521003544.patch text/plain 2154 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDQyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTIxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1MDM5Myk6 IGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy1hdC1lbmQtb2YtbGluZS5odG1sIGZhaWxzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY1MTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBj YXVzZWQgYnkgRFJUIG5vdCByZXNldHRpbmcgdmFyaW91cyBhdXRvIGNvcnJlY3Rpb24gc3RhdGVz LgorICAgICAgICBEbyB0aGF0IGluIEludGVybmFsczo6cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZS4K KworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oklu dGVybmFsczo6cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZSk6CisKIDIwMTMtMDUtMjAgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEZpeCBjb25jYXRl bmF0aW9ucyBvZiBzdHJpbmcgbGl0ZXJhbHMgdGhhdCBhcmUgbm90IEMrKzExLWNvbXBsaWFudApJ bmRleDogU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAkocmV2aXNpb24gMTUwNDE1KQor KysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yODUsNiArMjg1LDIwIEBAIHZvaWQgSW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRl KFAKICNlbmRpZgogICAgIGlmICghcGFnZS0+bWFpbkZyYW1lKCktPmVkaXRvcigpLmlzQ29udGlu dW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCkpCiAgICAgICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5l ZGl0b3IoKS50b2dnbGVDb250aW51b3VzU3BlbGxDaGVja2luZygpOworCisjaWYgVVNFKEFVVE9N QVRJQ19URVhUX1JFUExBQ0VNRU5UKQorICAgIGlmIChwYWdlLT5tYWluRnJhbWUoKS0+ZWRpdG9y KCkuaXNBdXRvbWF0aWNRdW90ZVN1YnN0aXR1dGlvbkVuYWJsZWQoKSkKKyAgICAgICAgcGFnZS0+ bWFpbkZyYW1lKCktPmVkaXRvcigpLnRvZ2dsZUF1dG9tYXRpY1F1b3RlU3Vic3RpdHV0aW9uKCk7 CisgICAgaWYgKHBhZ2UtPm1haW5GcmFtZSgpLT5lZGl0b3IoKS5pc0F1dG9tYXRpY0xpbmtEZXRl Y3Rpb25FbmFibGVkKCkpCisgICAgICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5lZGl0b3IoKS50b2dn bGVBdXRvbWF0aWNMaW5rRGV0ZWN0aW9uKCk7CisgICAgaWYgKHBhZ2UtPm1haW5GcmFtZSgpLT5l ZGl0b3IoKS5pc0F1dG9tYXRpY0Rhc2hTdWJzdGl0dXRpb25FbmFibGVkKCkpCisgICAgICAgIHBh Z2UtPm1haW5GcmFtZSgpLT5lZGl0b3IoKS50b2dnbGVBdXRvbWF0aWNEYXNoU3Vic3RpdHV0aW9u KCk7CisgICAgaWYgKHBhZ2UtPm1haW5GcmFtZSgpLT5lZGl0b3IoKS5pc0F1dG9tYXRpY1RleHRS ZXBsYWNlbWVudEVuYWJsZWQoKSkKKyAgICAgICAgcGFnZS0+bWFpbkZyYW1lKCktPmVkaXRvcigp LnRvZ2dsZUF1dG9tYXRpY1RleHRSZXBsYWNlbWVudCgpOworICAgIGlmICghcGFnZS0+bWFpbkZy YW1lKCktPmVkaXRvcigpLmlzQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxlZCgpKQor ICAgICAgICBwYWdlLT5tYWluRnJhbWUoKS0+ZWRpdG9yKCkudG9nZ2xlQXV0b21hdGljU3BlbGxp bmdDb3JyZWN0aW9uKCk7CisjZW5kaWYKKwogICAgIGlmIChwYWdlLT5tYWluRnJhbWUoKS0+ZWRp dG9yKCkuaXNPdmVyd3JpdGVNb2RlRW5hYmxlZCgpKQogICAgICAgICBwYWdlLT5tYWluRnJhbWUo KS0+ZWRpdG9yKCkudG9nZ2xlT3ZlcndyaXRlTW9kZUVuYWJsZWQoKTsKIH0K 202470 2013-05-21 14:23:31 -0700 2013-05-21 14:26:42 -0700 Fixes DRT bug-116516-20130521142219.patch text/plain 2156 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1MDQ3OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEzLTA1LTIxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT04ocjE1MDM5Myk6IGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy1h dC1lbmQtb2YtbGluZS5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTY1MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZXNldCBzdGF0ZXMgaW4gRHVtcFJlbmRlclRyZWUuIFRoZSBmaXgg Zm9yIFdlYktpdFRlc3RSdW5uZXIgc2hvdWxkIGJlIGltcGxlbWVudGVkIGluIHRoZSBidWcgMTE2 NTc3LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOgor ICAgICAgICAoY3JlYXRlV2ViVmlld0FuZE9mZnNjcmVlbldpbmRvdyk6CisgICAgICAgIChyZXNl dFdlYlZpZXdUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcpOgorCiAyMDEzLTA1LTIxICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8xMzkyOTcwND4gW1dLMl0gV2ViS2l0VGVzdFJ1bm5lciBhbHdheXMgY3Jhc2hlcyBvbiBl eGl0CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCShy ZXZpc2lvbiAxNTA0NzgpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRy ZWUubW0JKHdvcmtpbmcgY29weSkKQEAgLTU0NCw4ICs1NDQsOSBAQCBXZWJWaWV3ICpjcmVhdGVX ZWJWaWV3QW5kT2Zmc2NyZWVuV2luZG93CiAgICAgW3dlYlZpZXcgc2V0QXV0b21hdGljRGFzaFN1 YnN0aXR1dGlvbkVuYWJsZWQ6Tk9dOwogICAgIFt3ZWJWaWV3IHNldEF1dG9tYXRpY1RleHRSZXBs YWNlbWVudEVuYWJsZWQ6Tk9dOwogICAgIFt3ZWJWaWV3IHNldEF1dG9tYXRpY1NwZWxsaW5nQ29y cmVjdGlvbkVuYWJsZWQ6WUVTXTsKLSAgICBbd2ViVmlldyBzZXREZWZlcnNDYWxsYmFja3M6Tk9d OwogICAgIFt3ZWJWaWV3IHNldEdyYW1tYXJDaGVja2luZ0VuYWJsZWQ6WUVTXTsKKworICAgIFt3 ZWJWaWV3IHNldERlZmVyc0NhbGxiYWNrczpOT107CiAgICAgW3dlYlZpZXcgc2V0SW50ZXJhY3Rp dmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQ6WUVTXTsKICAgICBbd2ViVmlldyBzZXRWYWxpZGF0aW9u TWVzc2FnZVRpbWVyTWFnbmlmaWNhdGlvbjotMV07CiAgICAgCkBAIC0xMjkwLDYgKzEyOTEsMTQg QEAgc3RhdGljIHZvaWQgcmVzZXRXZWJWaWV3VG9Db25zaXN0ZW50U3RhdAogICAgICAgICBnVGVz dFJ1bm5lci0+cmVtb3ZlQ2hyb21lSW5wdXRGaWVsZCgpOwogICAgIH0KIAorICAgIFt3ZWJWaWV3 IHNldENvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDpZRVNdOworICAgIFt3ZWJWaWV3IHNl dEF1dG9tYXRpY1F1b3RlU3Vic3RpdHV0aW9uRW5hYmxlZDpOT107CisgICAgW3dlYlZpZXcgc2V0 QXV0b21hdGljTGlua0RldGVjdGlvbkVuYWJsZWQ6Tk9dOworICAgIFt3ZWJWaWV3IHNldEF1dG9t YXRpY0Rhc2hTdWJzdGl0dXRpb25FbmFibGVkOk5PXTsKKyAgICBbd2ViVmlldyBzZXRBdXRvbWF0 aWNUZXh0UmVwbGFjZW1lbnRFbmFibGVkOk5PXTsKKyAgICBbd2ViVmlldyBzZXRBdXRvbWF0aWNT cGVsbGluZ0NvcnJlY3Rpb25FbmFibGVkOllFU107CisgICAgW3dlYlZpZXcgc2V0R3JhbW1hckNo ZWNraW5nRW5hYmxlZDpZRVNdOworCiAgICAgW1dlYlZpZXcgX3NldFVzZXNUZXN0TW9kZUZvY3Vz UmluZ0NvbG9yOllFU107CiAgICAgW1dlYlZpZXcgX3Jlc2V0T3JpZ2luQWNjZXNzV2hpdGVsaXN0 c107CiAgICAgW1dlYlZpZXcgX3NldEFsbG93c1JvdW5kaW5nSGFja3M6Tk9dOwo=