116514 2013-05-20 22:43:53 -0700 New Flickr doesn't get fast scrolling but should 2013-05-22 12:06:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue esprehn+autocc glenn simon.fraser thorton webkit-bug-importer oldest_to_newest 891566 0 simon.fraser 2013-05-20 22:43:53 -0700 We don't get fast scrolling on the new Flickr pages, e.g. <http://www.flickr.com/photos/smfr/> During loading, there's a background-attachment:fixed that kicks us out. However, when loading is complete this fixed background is removed, but we fail to go into fast scrolling mode. <rdar://problem/13946443> 891577 1 202379 simon.fraser 2013-05-20 23:09:17 -0700 Created attachment 202379 Patch 891579 2 commit-queue 2013-05-20 23:10:44 -0700 Attachment 202379 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle-expected.txt', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-expected.txt', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle-expected.txt', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderObject.cpp']" exit_code: 1 Source/WebCore/rendering/RenderObject.cpp:133: Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 891584 3 simon.fraser 2013-05-20 23:13:32 -0700 Style bot complaint is existing code. 891796 4 202379 darin 2013-05-21 08:47:31 -0700 Comment on attachment 202379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202379&action=review > Source/WebCore/rendering/RenderObject.cpp:130 > + UNUSED_PARAM(frameView); Seems wrong to have this UNUSED_PARAM be unconditional, when the use of the parameter is conditional. >> Source/WebCore/rendering/RenderObject.cpp:133 >> +#if PLATFORM(QT) > > Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] I don’t think the style bot is being helpful here. > Source/WebCore/rendering/RenderObject.cpp:2490 > + if (view()->frameView()) { I think we should put the FrameView into a local because it’s used two more times below and the code would be more concise without repeating it. > Source/WebCore/rendering/RenderObject.cpp:2491 > + bool repaintFixedBackgroundsOnScroll = shouldRepaintFixedBackgroundsOnScroll(view()->frameView()); Why the local variable here? I think it makes the code harder to read. 891808 5 simon.fraser 2013-05-21 08:57:02 -0700 (In reply to comment #4) > (From update of attachment 202379 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202379&action=review > > > Source/WebCore/rendering/RenderObject.cpp:130 > > + UNUSED_PARAM(frameView); > > Seems wrong to have this UNUSED_PARAM be unconditional, when the use of the parameter is conditional. I thought it was simpler than having the UNUSED_PARAM inside an #else; it's harmless to have it when the param is actually used, but I can clean this up. > > Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] > > I don’t think the style bot is being helpful here. Agreed! > > Source/WebCore/rendering/RenderObject.cpp:2490 > > + if (view()->frameView()) { > > I think we should put the FrameView into a local because it’s used two more times below and the code would be more concise without repeating it. Will do. > > Source/WebCore/rendering/RenderObject.cpp:2491 > > + bool repaintFixedBackgroundsOnScroll = shouldRepaintFixedBackgroundsOnScroll(view()->frameView()); > > Why the local variable here? I think it makes the code harder to read. I can remove this. Simon 892479 6 simon.fraser 2013-05-22 12:06:07 -0700 https://trac.webkit.org/r150529 202379 2013-05-20 23:09:17 -0700 2013-05-21 08:47:31 -0700 Patch bug-116514-20130520230806.patch text/plain 13666 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q2NGJjODRmMDYwM2I3 MDk0NzhkY2M4ZmRjY2VlMDg5MWQ4MTJjNy4uMWIxNzRlZDE4ZGY3ZWQ2NWUyZmE5N2MwMmYyMGFh MWZmZmU4MGU0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEzLTA1LTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE5ldyBGbGlja3Ig ZG9lc24ndCBnZXQgZmFzdCBzY3JvbGxpbmcgYnV0IHNob3VsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NTE0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBSZW5kZXJPYmplY3QgaW5jcmVt ZW50cyBhbmQgZGVjcmVtZW50cyBhIGNvdW50ZXIgb2Ygc2xvdyByZXBhaW50IG9iamVjdHMgb24K KyAgICAgICAgRnJhbWVWaWV3IHdoZW4gaXQgc2VlcyBzdHlsZSBjaGFuZ2VzIHJlbGF0ZWQgdG8g YmFja2dyb3VuZC1hdHRhY2htZW50OmZpeGVkLgorICAgICAgICBIb3dldmVyLCBpdCBvbWl0dGVk IHRvIGRlY3JlbWVudCB0aGUgY291bnQgd2hlbiBhIHJlbmRlcmVyIHdpdGggYSBmaXhlZCBiYWNr Z3JvdW5kCisgICAgICAgIHdhcyBkZXN0cm95ZWQuCisgICAgICAgIAorICAgICAgICBUaGlzIGNh dXNlZCBGbGlja3IgdG8gbmV2ZXIgZmFsbCBpbnRvIGZhc3Qgc2Nyb2xsaW5nIG1vZGUsIHNpbmNl IGl0IHRvZ2dsZWQKKyAgICAgICAgZGlzcGxheTpub25lIG9uIGFuIGVsZW1lbnQgd2l0aCBhIGZp eGVkIGJhY2tncm91bmQgZHVyaW5nIGxvYWRpbmcsIHRoZW4gcmVtb3ZlZAorICAgICAgICB0aGUg Zml4ZWQgYmFja2dyb3VuZC4KKyAgICAgICAgCisgICAgICAgIERpZCBzb21lIG1pbm9yIGNsZWFu dXAgb2YgI0VOQUJMRShGQVNUX01PQklMRV9TQ1JPTExJTkcpIGNyYXAuCisKKyAgICAgICAgVGVz dHM6IHBsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy1iYWNrZ3Jv dW5kLXRvZ2dsZS5odG1sCisgICAgICAgICAgICAgICBwbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRy YXdpbmcvc2xvdy1zY3JvbGxpbmctaGlkZGVuLWJhY2tncm91bmQtdG9nZ2xlLmh0bWwKKyAgICAg ICAgICAgICAgIHBsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy5o dG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnNob3VsZFJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25TY3JvbGwpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpzdHlsZVdpbGxDaGFuZ2UpOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyT2JqZWN0Ojp3aWxsQmVSZW1vdmVkRnJvbVRyZWUpOgorCiAyMDEzLTA1LTE5ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSB0 aGUgdGVybWlub2xvZ3kgdXNlZCBieSByZW5kZXJpbmcgY29kZSB3aGVuIHBhaW50aW5nIGEgZ2l2 ZW4gbm9kZSBhbmQgaXRzIGNoaWxkcmVuIGZyb20gInBhaW50aW5nUm9vdCIgdG8gInN1YnRyZWVQ YWludFJvb3QiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4 IDViNWRlYTRmNTQ4N2VkNzlmYTEyMjZlMDlhNGIyZDljY2UwMTUzZDIuLjAzODAzMGU4NTAxNjAy MmY5NGUxNDA5NDM0ZWQzYzYxODgwODMwZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCkBAIC0xMjEsNiArMTIxLDIzIEBAIHN0cnVjdCBTYW1lU2l6ZUFzUmVu ZGVyT2JqZWN0IHsKIAogQ09NUElMRV9BU1NFUlQoc2l6ZW9mKFJlbmRlck9iamVjdCkgPT0gc2l6 ZW9mKFNhbWVTaXplQXNSZW5kZXJPYmplY3QpLCBSZW5kZXJPYmplY3Rfc2hvdWxkX3N0YXlfc21h bGwpOwogCisvLyBPbiBsb3ctcG93ZXJlZC9tb2JpbGUgZGV2aWNlcywgcHJldmVudGluZyBibGl0 dGluZyBvbiBhIHNjcm9sbCBjYW4gY2F1c2Ugbm90aWNlYWJsZSBkZWxheXMKKy8vIHdoZW4gc2Ny b2xsaW5nIGEgcGFnZSB3aXRoIGEgZml4ZWQgYmFja2dyb3VuZCBpbWFnZS4gQXMgYW4gb3B0aW1p emF0aW9uLCBhc3N1bWluZyB0aGVyZSBhcmUKKy8vIG5vIGZpeGVkIHBvc2l0b25lZCBlbGVtZW50 cyBvbiB0aGUgcGFnZSwgd2UgY2FuIGFjY2xlcmF0ZSBzY3JvbGxpbmcgKHZpYSBibGl0dGluZykg aWYgd2UKKy8vIGlnbm9yZSB0aGUgQ1NTIHByb3BlcnR5ICJiYWNrZ3JvdW5kLWF0dGFjaG1lbnQ6 IGZpeGVkIi4KK3N0YXRpYyBib29sIHNob3VsZFJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25TY3Jv bGwoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCit7CisgICAgVU5VU0VEX1BBUkFNKGZyYW1lVmlldyk7 CisgICAgYm9vbCByZXBhaW50Rml4ZWRCYWNrZ3JvdW5kc09uU2Nyb2xsID0gdHJ1ZTsKKyNpZiBF TkFCTEUoRkFTVF9NT0JJTEVfU0NST0xMSU5HKQorI2lmIFBMQVRGT1JNKFFUKQorICAgIGlmIChm cmFtZVZpZXctPmRlbGVnYXRlc1Njcm9sbGluZygpKQorI2VuZGlmCisgICAgICAgIHJlcGFpbnRG aXhlZEJhY2tncm91bmRzT25TY3JvbGwgPSBmYWxzZTsKKyNlbmRpZgorICAgIHJldHVybiByZXBh aW50Rml4ZWRCYWNrZ3JvdW5kc09uU2Nyb2xsOworfQorCiBib29sIFJlbmRlck9iamVjdDo6c19h ZmZlY3RzUGFyZW50QmxvY2sgPSBmYWxzZTsKIAogUmVuZGVyT2JqZWN0QW5jZXN0b3JMaW5lYm94 RGlydHlTZXQqIFJlbmRlck9iamVjdDo6c19hbmNlc3RvckxpbmVib3hEaXJ0eVNldCA9IDA7CkBA IC0xOTA3LDI0ICsxOTI0LDE0IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpzdHlsZVdpbGxDaGFuZ2Uo U3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBuZXdTCiAgICAgICAgIHNf YWZmZWN0c1BhcmVudEJsb2NrID0gZmFsc2U7CiAKICAgICBpZiAodmlldygpLT5mcmFtZVZpZXco KSkgewotICAgICAgICBib29sIHNob3VsZEJsaXRPbkZpeGVkQmFja2dyb3VuZEltYWdlID0gZmFs c2U7Ci0jaWYgRU5BQkxFKEZBU1RfTU9CSUxFX1NDUk9MTElORykKLSAgICAgICAgLy8gT24gbG93 LXBvd2VyZWQvbW9iaWxlIGRldmljZXMsIHByZXZlbnRpbmcgYmxpdHRpbmcgb24gYSBzY3JvbGwg Y2FuIGNhdXNlIG5vdGljZWFibGUgZGVsYXlzCi0gICAgICAgIC8vIHdoZW4gc2Nyb2xsaW5nIGEg cGFnZSB3aXRoIGEgZml4ZWQgYmFja2dyb3VuZCBpbWFnZS4gQXMgYW4gb3B0aW1pemF0aW9uLCBh c3N1bWluZyB0aGVyZSBhcmUKLSAgICAgICAgLy8gbm8gZml4ZWQgcG9zaXRvbmVkIGVsZW1lbnRz IG9uIHRoZSBwYWdlLCB3ZSBjYW4gYWNjbGVyYXRlIHNjcm9sbGluZyAodmlhIGJsaXR0aW5nKSBp ZiB3ZQotICAgICAgICAvLyBpZ25vcmUgdGhlIENTUyBwcm9wZXJ0eSAiYmFja2dyb3VuZC1hdHRh Y2htZW50OiBmaXhlZCIuCi0jaWYgUExBVEZPUk0oUVQpCi0gICAgICAgIGlmICh2aWV3KCktPmZy YW1lVmlldygpLT5kZWxlZ2F0ZXNTY3JvbGxpbmcoKSkKLSNlbmRpZgotICAgICAgICAgICAgc2hv dWxkQmxpdE9uRml4ZWRCYWNrZ3JvdW5kSW1hZ2UgPSB0cnVlOwotI2VuZGlmCisgICAgICAgIGJv b2wgcmVwYWludEZpeGVkQmFja2dyb3VuZHNPblNjcm9sbCA9IHNob3VsZFJlcGFpbnRGaXhlZEJh Y2tncm91bmRzT25TY3JvbGwodmlldygpLT5mcmFtZVZpZXcoKSk7CiAKLSAgICAgICAgYm9vbCBu ZXdTdHlsZVNsb3dTY3JvbGwgPSBuZXdTdHlsZSAmJiAhc2hvdWxkQmxpdE9uRml4ZWRCYWNrZ3Jv dW5kSW1hZ2UgJiYgbmV3U3R5bGUtPmhhc0ZpeGVkQmFja2dyb3VuZEltYWdlKCk7Ci0gICAgICAg IGJvb2wgb2xkU3R5bGVTbG93U2Nyb2xsID0gbV9zdHlsZSAmJiAhc2hvdWxkQmxpdE9uRml4ZWRC YWNrZ3JvdW5kSW1hZ2UgJiYgbV9zdHlsZS0+aGFzRml4ZWRCYWNrZ3JvdW5kSW1hZ2UoKTsKKyAg ICAgICAgYm9vbCBuZXdTdHlsZVNsb3dTY3JvbGwgPSBuZXdTdHlsZSAmJiByZXBhaW50Rml4ZWRC YWNrZ3JvdW5kc09uU2Nyb2xsICYmIG5ld1N0eWxlLT5oYXNGaXhlZEJhY2tncm91bmRJbWFnZSgp OworICAgICAgICBib29sIG9sZFN0eWxlU2xvd1Njcm9sbCA9IG1fc3R5bGUgJiYgcmVwYWludEZp eGVkQmFja2dyb3VuZHNPblNjcm9sbCAmJiBtX3N0eWxlLT5oYXNGaXhlZEJhY2tncm91bmRJbWFn ZSgpOwogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgICAgICBib29sIGRy YXdzUm9vdEJhY2tncm91bmQgPSBpc1Jvb3QoKSB8fCAoaXNCb2R5KCkgJiYgIXJlbmRlcmVySGFz QmFja2dyb3VuZChkb2N1bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKS0+cmVuZGVyZXIoKSkpOwot ICAgICAgICBpZiAoZHJhd3NSb290QmFja2dyb3VuZCAmJiAhc2hvdWxkQmxpdE9uRml4ZWRCYWNr Z3JvdW5kSW1hZ2UpIHsKKyAgICAgICAgaWYgKGRyYXdzUm9vdEJhY2tncm91bmQgJiYgcmVwYWlu dEZpeGVkQmFja2dyb3VuZHNPblNjcm9sbCkgewogICAgICAgICAgICAgaWYgKHZpZXcoKS0+Y29t cG9zaXRvcigpLT5zdXBwb3J0c0ZpeGVkUm9vdEJhY2tncm91bmRDb21wb3NpdGluZygpKSB7CiAg ICAgICAgICAgICAgICAgaWYgKG5ld1N0eWxlU2xvd1Njcm9sbCAmJiBuZXdTdHlsZS0+aGFzRW50 aXJlbHlGaXhlZEJhY2tncm91bmQoKSkKICAgICAgICAgICAgICAgICAgICAgbmV3U3R5bGVTbG93 U2Nyb2xsID0gZmFsc2U7CkBAIC0xOTM3LDYgKzE5NDQsNyBAQCB2b2lkIFJlbmRlck9iamVjdDo6 c3R5bGVXaWxsQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSog bmV3UwogICAgICAgICBpZiAob2xkU3R5bGVTbG93U2Nyb2xsICE9IG5ld1N0eWxlU2xvd1Njcm9s bCkgewogICAgICAgICAgICAgaWYgKG9sZFN0eWxlU2xvd1Njcm9sbCkKICAgICAgICAgICAgICAg ICB2aWV3KCktPmZyYW1lVmlldygpLT5yZW1vdmVTbG93UmVwYWludE9iamVjdCgpOworCiAgICAg ICAgICAgICBpZiAobmV3U3R5bGVTbG93U2Nyb2xsKQogICAgICAgICAgICAgICAgIHZpZXcoKS0+ ZnJhbWVWaWV3KCktPmFkZFNsb3dSZXBhaW50T2JqZWN0KCk7CiAgICAgICAgIH0KQEAgLTI0Nzks NiArMjQ4NywxMiBAQCB2b2lkIFJlbmRlck9iamVjdDo6d2lsbEJlUmVtb3ZlZEZyb21UcmVlKCkK IHsKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIEFTU0VSVChpc1Jvb3RlZCgpKSBidXQgd2UgaGF2 ZSBzb21lIG91dC1vZi1vcmRlciByZW1vdmFscyB3aGljaCB3b3VsZCBuZWVkIHRvIGJlIGZpeGVk IGZpcnN0LgogCisgICAgaWYgKHZpZXcoKS0+ZnJhbWVWaWV3KCkpIHsKKyAgICAgICAgYm9vbCBy ZXBhaW50Rml4ZWRCYWNrZ3JvdW5kc09uU2Nyb2xsID0gc2hvdWxkUmVwYWludEZpeGVkQmFja2dy b3VuZHNPblNjcm9sbCh2aWV3KCktPmZyYW1lVmlldygpKTsKKyAgICAgICAgaWYgKHJlcGFpbnRG aXhlZEJhY2tncm91bmRzT25TY3JvbGwgJiYgbV9zdHlsZSAmJiBtX3N0eWxlLT5oYXNGaXhlZEJh Y2tncm91bmRJbWFnZSgpKQorICAgICAgICAgICAgdmlldygpLT5mcmFtZVZpZXcoKS0+cmVtb3Zl U2xvd1JlcGFpbnRPYmplY3QoKTsKKyAgICB9CisKICAgICAvLyBJZiB3ZSByZW1vdmUgYSB2aXNp YmxlIGNoaWxkIGZyb20gYW4gaW52aXNpYmxlIHBhcmVudCwgd2UgZG9uJ3Qga25vdyB0aGUgbGF5 ZXIgdmlzaWJpbGl0eSBhbnkgbW9yZS4KICAgICBSZW5kZXJMYXllciogbGF5ZXIgPSAwOwogICAg IGlmIChwYXJlbnQoKS0+c3R5bGUoKS0+dmlzaWJpbGl0eSgpICE9IFZJU0lCTEUgJiYgc3R5bGUo KS0+dmlzaWJpbGl0eSgpID09IFZJU0lCTEUgJiYgIWhhc0xheWVyKCkpIHsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYTIw MzNmOGMwMTFhMzdjN2I4MjJjZGNhMWIwZTVkOThmMjdhYTlhLi5iMjA3YzdiMDMxMDQ3YWRhZDhm MTg5Yzg2NjdmZDNkMDNiZjAxMDMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMDUtMjAg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgTmV3IEZs aWNrciBkb2Vzbid0IGdldCBmYXN0IHNjcm9sbGluZyBidXQgc2hvdWxkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY1MTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIHNsb3ctc2Nyb2xsaW5n LWhpZGRlbi1iYWNrZ3JvdW5kLXRvZ2dsZS5odG1sIGFjdHVhbGx5IHRlc3RzIHRoaXMgcGF0Y2gu IFRoZSBvdGhlcgorICAgICAgICB0d28gdGVzdHMgd2VyZSBhZGRlZCBiZWNhdXNlIHRoZXJlIGFw cGVhciB0byBiZSBubyB0ZXN0cyBmb3IgYmFzaWMgaW50ZXJuYWxzLm1haW5UaHJlYWRTY3JvbGxp bmdSZWFzb25zKCkKKyAgICAgICAgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy13azIvdGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy1iYWNrZ3JvdW5kLXRvZ2dsZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvdGlsZWQtZHJh d2luZy9zbG93LXNjcm9sbGluZy1iYWNrZ3JvdW5kLXRvZ2dsZS5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmctZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcv c2xvdy1zY3JvbGxpbmctaGlkZGVuLWJhY2tncm91bmQtdG9nZ2xlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3Nsb3ctc2Nyb2xs aW5nLWhpZGRlbi1iYWNrZ3JvdW5kLXRvZ2dsZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmcuaHRtbDogQWRkZWQuCisK IDIwMTMtMDUtMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgc3ZnL2JhdGlrIHRlc3RzIGFyZSBmbGFrZXkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmctYmFja2dyb3Vu ZC10b2dnbGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxl ZC1kcmF3aW5nL3Nsb3ctc2Nyb2xsaW5nLWJhY2tncm91bmQtdG9nZ2xlLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi41YTE3MDA3NzJlMTIxNWE4YjkyNzNmYjVkMTEwNDY1YWQ2ZGI2ZTI1Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5n L3Nsb3ctc2Nyb2xsaW5nLWJhY2tncm91bmQtdG9nZ2xlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDMgQEAKK1Rlc3QgcGFzc2VzIGlmIHRoZXJlIGFyZSBubyByZWFzb25zIGZvciBzbG93IHNjcm9s bGluZyBiZWxvdy4KKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sy L3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmctYmFja2dyb3VuZC10b2dnbGUuaHRtbCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy1i YWNrZ3JvdW5kLXRvZ2dsZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQyOTQ5N2ZlMjdlYzMzODI0NzQ4ZDgw NTRlN2Q5ZTFkZDhjNzk1MzcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmctYmFja2dyb3VuZC10b2dnbGUu aHRtbApAQCAtMCwwICsxLDQ4IEBACis8IURPQ1RZUEUgaHRtbD4KKworPGh0bWw+Cis8aGVhZD4K KyAgICA8c3R5bGU+CisgICAgICAgIGJvZHkgeworICAgICAgICAgICAgaGVpZ2h0OiAxMjAwcHg7 CisgICAgICAgIH0KKyAgICAgICAgLmJveCB7CisgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAg ICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgbWFyZ2luOiA1MHB4OworICAgICAgICAg IGJhY2tncm91bmQtY29sb3I6IGJsdWU7CisgICAgICAgICAgYm9yZGVyOiAycHggc29saWQgYmxh Y2s7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgICNib3ggeworICAgICAgICAgICAgYmFj a2dyb3VuZC1pbWFnZTogbGluZWFyLWdyYWRpZW50KHRvIHRvcCwgd2hpdGUsIGJsYWNrKTsKKyAg ICAgICAgICAgIGJhY2tncm91bmQtYXR0YWNobWVudDogZml4ZWQ7CisgICAgICAgICAgICBiYWNr Z3JvdW5kLXJlcGVhdDogbm8tcmVwZWF0OworICAgICAgICB9CisgICAgICAgIAorICAgICAgICAj Ym94LmxvYWRlZCB7CisgICAgICAgICAgICBiYWNrZ3JvdW5kOiB0cmFuc3BhcmVudDsKKyAgICAg ICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAg ZnVuY3Rpb24gZG9UZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgdmFyIGJveCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdib3gnKTsKKyAgICAgICAgICAgIGJveC5jbGFzc0xpc3QuYWRk KCdsb2FkZWQnKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5h bHMpCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JlYXNvbnMnKS50 ZXh0Q29udGVudCA9IHdpbmRvdy5pbnRlcm5hbHMubWFpblRocmVhZFNjcm9sbGluZ1JlYXNvbnMo ZG9jdW1lbnQpOworICAgICAgICB9CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCds b2FkJywgZG9UZXN0LCBmYWxzZSk7CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKwor ICAgIDxkaXYgaWQ9ImJveCIgY2xhc3M9ImJveCI+PC9kaXY+CisgICAgPHA+VGVzdCBwYXNzZXMg aWYgdGhlcmUgYXJlIG5vIHJlYXNvbnMgZm9yIHNsb3cgc2Nyb2xsaW5nIGJlbG93LjwvcD4KKzxw cmUgaWQ9InJlYXNvbnMiPjwvcHJlPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3Nsb3ctc2Nyb2xsaW5nLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9z bG93LXNjcm9sbGluZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjVhMDNmY2Q2ZTEyNmI3YmRl MDA3OTEwZmY0ZmFlZmY2OTE0ODMzOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy1leHBlY3RlZC50eHQK QEAgLTAsMCArMSwzIEBACitTaG91bGQgYmUgc2xvdyBzY3JvbGxpbmcgYmVjYXVzZSBvZiBzbG93 IHJlcGFpbnQgb2JqZWN0cy4KKworSGFzIHNsb3cgcmVwYWludCBvYmplY3RzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxp bmctaGlkZGVuLWJhY2tncm91bmQtdG9nZ2xlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy1oaWRkZW4tYmFja2dy b3VuZC10b2dnbGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVhMTcwMDc3MmUxMjE1YThiOTI3 M2ZiNWQxMTA0NjVhZDZkYjZlMjUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmctaGlkZGVuLWJhY2tncm91 bmQtdG9nZ2xlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1Rlc3QgcGFzc2VzIGlmIHRo ZXJlIGFyZSBubyByZWFzb25zIGZvciBzbG93IHNjcm9sbGluZyBiZWxvdy4KKworCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3Jv bGxpbmctaGlkZGVuLWJhY2tncm91bmQtdG9nZ2xlLmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3JvbGxpbmctaGlkZGVuLWJhY2tncm91bmQt dG9nZ2xlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzFkODUxYjhjYWY2NDU0MGFmZjM0Y2UwNjYzNDQ2ZDJj MjgxMGE4NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIv dGlsZWQtZHJhd2luZy9zbG93LXNjcm9sbGluZy1oaWRkZW4tYmFja2dyb3VuZC10b2dnbGUuaHRt bApAQCAtMCwwICsxLDU2IEBACis8IURPQ1RZUEUgaHRtbD4KKworPGh0bWw+Cis8aGVhZD4KKyAg ICA8c3R5bGU+CisgICAgICAgIGJvZHkgeworICAgICAgICAgICAgaGVpZ2h0OiAxMjAwcHg7Cisg ICAgICAgIH0KKyAgICAgICAgLmJveCB7CisgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAg ICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgbWFyZ2luOiA1MHB4OworICAgICAgICAgIGJh Y2tncm91bmQtY29sb3I6IGJsdWU7CisgICAgICAgICAgYm9yZGVyOiAycHggc29saWQgYmxhY2s7 CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgICNib3ggeworICAgICAgICAgICAgYmFja2dy b3VuZC1pbWFnZTogbGluZWFyLWdyYWRpZW50KHRvIHRvcCwgd2hpdGUsIGJsYWNrKTsKKyAgICAg ICAgICAgIGJhY2tncm91bmQtYXR0YWNobWVudDogZml4ZWQ7CisgICAgICAgICAgICBiYWNrZ3Jv dW5kLXJlcGVhdDogbm8tcmVwZWF0OworICAgICAgICB9CisgICAgICAgIAorICAgICAgICAjYm94 LmhpZGRlbiB7CisgICAgICAgICAgICBkaXNwbGF5OiBub25lOworICAgICAgICB9CisKKyAgICAg ICAgI2JveC5sb2FkZWQgeworICAgICAgICAgICAgYmFja2dyb3VuZDogdHJhbnNwYXJlbnQ7Cisg ICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cu dGVzdFJ1bm5lcikKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAg ICAgIGZ1bmN0aW9uIGRvVGVzdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBib3ggPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94Jyk7CisgICAgICAgICAgICBib3guY2xhc3NMaXN0 LmFkZCgnaGlkZGVuJyk7CisgICAgICAgICAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFdpZHRoOwor ICAgICAgICAgICAgYm94LmNsYXNzTGlzdC5yZW1vdmUoJ2hpZGRlbicpOworICAgICAgICAgICAg ZG9jdW1lbnQuYm9keS5vZmZzZXRXaWR0aDsKKyAgICAgICAgICAgIGJveC5jbGFzc0xpc3QuYWRk KCdsb2FkZWQnKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5h bHMpCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JlYXNvbnMnKS50 ZXh0Q29udGVudCA9IHdpbmRvdy5pbnRlcm5hbHMubWFpblRocmVhZFNjcm9sbGluZ1JlYXNvbnMo ZG9jdW1lbnQpOworICAgICAgICB9CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCds b2FkJywgZG9UZXN0LCBmYWxzZSk7CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKwor ICAgIDxkaXYgaWQ9ImJveCIgY2xhc3M9ImJveCI+PC9kaXY+CisgICAgPHA+VGVzdCBwYXNzZXMg aWYgdGhlcmUgYXJlIG5vIHJlYXNvbnMgZm9yIHNsb3cgc2Nyb2xsaW5nIGJlbG93LjwvcD4KKzxw cmUgaWQ9InJlYXNvbnMiPjwvcHJlPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3Nsb3ctc2Nyb2xsaW5nLmh0 bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2xvdy1zY3Jv bGxpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYWRjYjdhNTU2MGQ3NzJlMTVhMGMxNzgzMjBkNWE0OTc0 MmU1NWE5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90 aWxlZC1kcmF3aW5nL3Nsb3ctc2Nyb2xsaW5nLmh0bWwKQEAgLTAsMCArMSw0MSBAQAorPCFET0NU WVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICBib2R5IHsK KyAgICAgICAgICAgIGhlaWdodDogMTIwMHB4OworICAgICAgICB9CisgICAgICAgIC5ib3ggewor ICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAg ICAgIG1hcmdpbjogNTBweDsKKyAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworICAg ICAgICAgIGJvcmRlcjogMnB4IHNvbGlkIGJsYWNrOworICAgICAgICB9CisgICAgICAgIAorICAg ICAgICAjYm94IHsKKyAgICAgICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVu dCh0byB0b3AsIHdoaXRlLCBibGFjayk7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWF0dGFjaG1l bnQ6IGZpeGVkOworICAgICAgICAgICAgYmFja2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsKKyAg ICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50 ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKyAgICAg ICAgZnVuY3Rpb24gZG9UZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5p bnRlcm5hbHMpCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JlYXNv bnMnKS50ZXh0Q29udGVudCA9IHdpbmRvdy5pbnRlcm5hbHMubWFpblRocmVhZFNjcm9sbGluZ1Jl YXNvbnMoZG9jdW1lbnQpOworICAgICAgICB9CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3Rl bmVyKCdsb2FkJywgZG9UZXN0LCBmYWxzZSk7CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKyAgICA8ZGl2IGlkPSJib3giIGNsYXNzPSJib3giPjwvZGl2PgorCisgICAgPHA+U2hvdWxk IGJlIHNsb3cgc2Nyb2xsaW5nIGJlY2F1c2Ugb2Ygc2xvdyByZXBhaW50IG9iamVjdHMuPC9wPgor PHByZSBpZD0icmVhc29ucyI+PC9wcmU+Cis8L2JvZHk+Cis8L2h0bWw+Cg==