116493 2013-05-20 19:20:01 -0700 Scrollbars still show sometimes even when WKPageSetSuppressScrollbarAnimations() is set 2013-05-20 19:29:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 891509 0 bdakin 2013-05-20 19:20:01 -0700 Scrollbars still show sometimes even when WKPageSetSuppressScrollbarAnimations() is set <rdar://problem/13912871> 891511 1 202371 bdakin 2013-05-20 19:23:39 -0700 Created attachment 202371 Patch 891516 2 202371 dino 2013-05-20 19:27:28 -0700 Comment on attachment 202371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202371&action=review > Source/WebCore/ChangeLog:23 > + (WebCore): Darin always tells me to remove these! > Source/WebCore/ChangeLog:28 > + (WebCore): And here too, which is why I filed a bug on prepareChangelog :) 891519 3 bdakin 2013-05-20 19:29:13 -0700 Thanks Dean! I fixed the Changelogs: http://trac.webkit.org/changeset/150399 202371 2013-05-20 19:23:39 -0700 2013-05-20 19:27:27 -0700 Patch for-review.txt text/plain 7485 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDM5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQwIEBACisyMDEzLTA1LTIwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JvbGxiYXJzIHN0aWxsIHNob3cg c29tZXRpbWVzIGV2ZW4gd2hlbiBXS1BhZ2VTZXRTdXBwcmVzc1Njcm9sbGJhckFuaW1hdGlvbnMo KSAKKyAgICAgICAgaXMgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTY0OTMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTM5MTI4NzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBiZSBtb3JlIGFnZ3Jlc3NpdmUgd2l0aCBvdXIg YXBwcm9hY2ggc2luY2UgQXBwS2l0IG1heSBzdGlsbCBhc2sgdGhlIAorICAgICAgICBzY3JvbGxi YXJzIHRvIHBhaW50IGhlcmUuCisKKyAgICAgICAgc2Nyb2xsYmFyQW5pbWF0aW9uc0FyZVN1cHBy ZXNzZWQoKSB3aWxsIGFsbG93IHVzIHRvIGZpbmQgb3V0IGlmIHRoZSBzZXR0aW5nIGhhcyAKKyAg ICAgICAgYmVlbiBzZXQuCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVWaWV3OjpzY3JvbGxiYXJBbmltYXRpb25zQXJlU3VwcHJlc3NlZCk6Cisg ICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxhYmxl QXJlYS5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYWJsZUFyZWE6OnNjcm9sbGJhckFuaW1h dGlvbnNBcmVTdXBwcmVzc2VkKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnNjcm9sbGJhckFuaW1hdGlvbnNBcmVT dXBwcmVzc2VkKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJMYXllci5oOgorICAgICAgICAoUmVuZGVyTGF5ZXIpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMaXN0Qm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RCb3g6OnNjcm9s bGJhckFuaW1hdGlvbnNBcmVTdXBwcmVzc2VkKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMaXN0Qm94Lmg6CisKKyAgICAgICAgRG9u4oCZdCBhbGxvdyBh bmltYXRpb25zIGlmIHNjcm9sbGJhcnMgYXJlIHN1cHByZXNzZWQuCisgICAgICAgICogcGxhdGZv cm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAgICAgICAoLVtXZWJTY3JvbGxiYXJQYWlu dGVyRGVsZWdhdGUgc2Nyb2xsZXJJbXA6YW5pbWF0ZUtub2JBbHBoYVRvOmR1cmF0aW9uOl0pOgor CisgICAgICAgIENhbGwgY2FuY2VsQW5pbWF0aW9ucygpIHRvIHByZXZlbnQgYSBqdXN0LXN0YXJ0 ZWQgYW5pbWF0aW9uIGZyb20gY29udGludWluZy4KKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFu aW1hdG9yTWFjOjpmaW5pc2hDdXJyZW50U2Nyb2xsQW5pbWF0aW9ucyk6CisKIDIwMTMtMDUtMjAg IEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIGNhcmV0 IHJlcGFpbnRzIGlmIHdlJ3JlIG5vdCBzaG93aW5nIGNhcmV0cyBhbnl3YXkuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZpc2lvbiAxNTAzMDcpCisrKyBTb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkwNiw2ICs5MDYsMTQgQEAg R3JhcGhpY3NMYXllciogRnJhbWVWaWV3OjpzZXRXYW50c0xheWVyRgogCiAjZW5kaWYgLy8gRU5B QkxFKFJVQkJFUl9CQU5ESU5HKQogCitib29sIEZyYW1lVmlldzo6c2Nyb2xsYmFyQW5pbWF0aW9u c0FyZVN1cHByZXNzZWQoKSBjb25zdAoreworICAgIFBhZ2UqIHBhZ2UgPSBmcmFtZSgpID8gZnJh bWUoKS0+cGFnZSgpIDogMDsKKyAgICBpZiAoIXBhZ2UpCisgICAgICAgIHJldHVybiB0cnVlOwor ICAgIHJldHVybiBwYWdlLT5zaG91bGRTdXBwcmVzc1Njcm9sbGJhckFuaW1hdGlvbnMoKTsKK30K KwogYm9vbCBGcmFtZVZpZXc6OmZsdXNoQ29tcG9zaXRpbmdTdGF0ZUZvclRoaXNGcmFtZShGcmFt ZSogcm9vdEZyYW1lRm9yRmx1c2gpCiB7CiAgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IHRo aXMtPnJlbmRlclZpZXcoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAkocmV2aXNpb24g MTUwMzA3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAkod29ya2luZyBjb3B5 KQpAQCAtNDE5LDYgKzQxOSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFN0YXJ0 TGl2ZVJlc2l6ZSgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCB3aWxsRW5kTGl2ZVJlc2l6 ZSgpIE9WRVJSSURFOwogCisgICAgdmlydHVhbCBib29sIHNjcm9sbGJhckFuaW1hdGlvbnNBcmVT dXBwcmVzc2VkKCkgY29uc3QgT1ZFUlJJREU7CisKICAgICB2b2lkIGFkZFBhaW50UGVuZGluZ01p bGVzdG9uZXMoTGF5b3V0TWlsZXN0b25lcyk7CiAgICAgdm9pZCBmaXJlUGFpbnRSZWxhdGVkTWls ZXN0b25lcygpOwogICAgIExheW91dE1pbGVzdG9uZXMgbWlsZXN0b25lc1BlbmRpbmdQYWludCgp IGNvbnN0IHsgcmV0dXJuIG1fbWlsZXN0b25lc1BlbmRpbmdQYWludDsgfQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oCShyZXZpc2lvbiAxNTAzMDcpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oCSh3b3JraW5nIGNvcHkpCkBA IC04Miw2ICs4Miw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGNvbnRlbnRBcmVhRGlkSGlkZSgpIGNv bnN0OwogCiAgICAgdm9pZCBmaW5pc2hDdXJyZW50U2Nyb2xsQW5pbWF0aW9ucygpIGNvbnN0Owor ICAgIHZpcnR1YWwgYm9vbCBzY3JvbGxiYXJBbmltYXRpb25zQXJlU3VwcHJlc3NlZCgpIGNvbnN0 IHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlkQWRkU2Nyb2xsYmFyKFNj cm9sbGJhciosIFNjcm9sbGJhck9yaWVudGF0aW9uKTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFJl bW92ZVNjcm9sbGJhcihTY3JvbGxiYXIqLCBTY3JvbGxiYXJPcmllbnRhdGlvbik7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCShy ZXZpc2lvbiAxNTAzMDcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5p bWF0b3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTUwMSw2ICs1MDEsMTIgQEAgLSAodm9pZClz Y3JvbGxlckltcDooaWQpc2Nyb2xsZXJJbXAgYW5pbQogICAgIEFTU0VSVChzY3JvbGxlckltcCA9 PSBzY3JvbGxiYXJQYWludGVyRm9yU2Nyb2xsYmFyKF9zY3JvbGxiYXIpKTsKIAogICAgIFNjcm9s bGJhclBhaW50ZXIgc2Nyb2xsZXJQYWludGVyID0gKFNjcm9sbGJhclBhaW50ZXIpc2Nyb2xsZXJJ bXA7CisgICAgaWYgKF9zY3JvbGxiYXItPnNjcm9sbGFibGVBcmVhKCktPnNjcm9sbGJhckFuaW1h dGlvbnNBcmVTdXBwcmVzc2VkKCkpIHsKKyAgICAgICAgW3Njcm9sbGVySW1wIHNldEtub2JBbHBo YTowXTsKKyAgICAgICAgX3Njcm9sbGJhci0+aW52YWxpZGF0ZSgpOworICAgICAgICByZXR1cm47 CisgICAgfQorCiAgICAgW3NlbGYgc2V0VXBBbHBoYUFuaW1hdGlvbjpfa25vYkFscGhhQW5pbWF0 aW9uIHNjcm9sbGVyUGFpbnRlcjpzY3JvbGxlclBhaW50ZXIgcGFydDpXZWJDb3JlOjpUaHVtYlBh cnQgYW5pbWF0ZUFscGhhVG86bmV3S25vYkFscGhhIGR1cmF0aW9uOmR1cmF0aW9uXTsKIH0KIApA QCAtODgwLDkgKzg4NiwxMCBAQCB2b2lkIFNjcm9sbEFuaW1hdG9yTWFjOjptYXlCZWdpblNjcm9s bEdlCiAKIHZvaWQgU2Nyb2xsQW5pbWF0b3JNYWM6OmZpbmlzaEN1cnJlbnRTY3JvbGxBbmltYXRp b25zKCkKIHsKLSAgICBpZiAoaXNTY3JvbGxiYXJPdmVybGF5QVBJQXZhaWxhYmxlKCkpIHsKKyAg ICBjYW5jZWxBbmltYXRpb25zKCk7CisKKyAgICBpZiAoaXNTY3JvbGxiYXJPdmVybGF5QVBJQXZh aWxhYmxlKCkpCiAgICAgICAgIFttX3Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyLmdldCgpIGhp ZGVPdmVybGF5U2Nyb2xsZXJzXTsKLSAgICB9CiB9CiAKIHZvaWQgU2Nyb2xsQW5pbWF0b3JNYWM6 OmRpZEFkZFZlcnRpY2FsU2Nyb2xsYmFyKFNjcm9sbGJhciogc2Nyb2xsYmFyKQpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAxNTAzMDcpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMzg3LDYgKzEzODcsMTQgQEAgSW50UmVjdCBSZW5kZXJMYXllcjo6c2Nyb2xsYWJsZUFy ZWFCb3VuZAogICAgIHJldHVybiByZW5kZXJlcigpLT5hYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgp OwogfQogCitib29sIFJlbmRlckxheWVyOjpzY3JvbGxiYXJBbmltYXRpb25zQXJlU3VwcHJlc3Nl ZCgpIGNvbnN0Cit7CisgICAgUmVuZGVyVmlldyogdmlldyA9IHJlbmRlcmVyKCktPnZpZXcoKTsK KyAgICBpZiAoIXZpZXcpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gdmlldy0+ ZnJhbWVWaWV3KCktPnNjcm9sbGJhcnNDYW5CZUFjdGl2ZSgpOworfQorCiBSZW5kZXJMYXllciog UmVuZGVyTGF5ZXI6OmVuY2xvc2luZ1RyYW5zZm9ybWVkQW5jZXN0b3IoKSBjb25zdAogewogICAg IFJlbmRlckxheWVyKiBjdXJyID0gcGFyZW50KCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuaAkocmV2aXNpb24gMTUwMzA3KQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMjYsNiArMTAyNiw3IEBA IHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIHNob3VsZFN1c3BlbmRTY3JvbGxBbmltYXRpb25z KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHNjcm9sbGJhcnNDYW5CZUFjdGl2ZSgpIGNvbnN0 OwogICAgIHZpcnR1YWwgSW50UmVjdCBzY3JvbGxhYmxlQXJlYUJvdW5kaW5nQm94KCkgY29uc3Qg T1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIHNjcm9sbGJhckFuaW1hdGlvbnNBcmVTdXBwcmVz c2VkKCkgY29uc3QgT1ZFUlJJREU7CiAKICAgICAvLyBSZWN0YW5nbGUgZW5jb21wYXNzaW5nIHRo ZSBzY3JvbGwgY29ybmVyIGFuZCByZXNpemVyIHJlY3QuCiAgICAgSW50UmVjdCBzY3JvbGxDb3Ju ZXJBbmRSZXNpemVyUmVjdCgpIGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxpc3RCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMaXN0Qm94LmNwcAkocmV2aXNpb24gMTUwMzA3KQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NDUsNiArODQ1 LDE0IEBAIGJvb2wgUmVuZGVyTGlzdEJveDo6c2Nyb2xsYmFyc0NhbkJlQWN0aXYKICAgICByZXR1 cm4gdmlldy0+ZnJhbWVWaWV3KCktPnNjcm9sbGJhcnNDYW5CZUFjdGl2ZSgpOwogfQogCitib29s IFJlbmRlckxpc3RCb3g6OnNjcm9sbGJhckFuaW1hdGlvbnNBcmVTdXBwcmVzc2VkKCkgY29uc3QK K3sKKyAgICBSZW5kZXJWaWV3KiB2aWV3ID0gdGhpcy0+dmlldygpOworICAgIGlmICghdmlldykK KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiB2aWV3LT5mcmFtZVZpZXcoKS0+c2Ny b2xsYmFyQW5pbWF0aW9uc0FyZVN1cHByZXNzZWQoKTsKK30KKwogU2Nyb2xsYWJsZUFyZWEqIFJl bmRlckxpc3RCb3g6OmVuY2xvc2luZ1Njcm9sbGFibGVBcmVhKCkgY29uc3QKIHsKICAgICAvLyBG SVhNRTogUmV0dXJuIGEgUmVuZGVyTGF5ZXIgdGhhdCdzIHNjcm9sbGFibGUuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEJveC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmgJKHJldmlzaW9uIDE1MDMwNykKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmgJKHdvcmtpbmcgY29weSkK QEAgLTEyMiw2ICsxMjIsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBpc0hhbmRsaW5n V2hlZWxFdmVudCgpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRTdXNw ZW5kU2Nyb2xsQW5pbWF0aW9ucygpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCBz Y3JvbGxiYXJzQ2FuQmVBY3RpdmUoKSBjb25zdCBPVkVSUklERTsKKyAgICB2aXJ0dWFsIGJvb2wg c2Nyb2xsYmFyQW5pbWF0aW9uc0FyZVN1cHByZXNzZWQoKSBjb25zdCBPVkVSUklERTsKIAogICAg IHZpcnR1YWwgU2Nyb2xsYWJsZUFyZWEqIGVuY2xvc2luZ1Njcm9sbGFibGVBcmVhKCkgY29uc3Qg T1ZFUlJJREU7CiAgICAgdmlydHVhbCBJbnRSZWN0IHNjcm9sbGFibGVBcmVhQm91bmRpbmdCb3go KSBjb25zdCBPVkVSUklERTsK