116484 2013-05-20 18:22:26 -0700 Simplify RenderFlexibleBox::computeMainAxisExtentForChild 2022-08-22 20:27:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 168657 BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned ahmad.saleem792 ap bfulgham dino hyatt mmaxfield rreno simon.fraser vitor.roriz zalan oldest_to_newest 891471 0 rniwa 2013-05-20 18:22:26 -0700 We should consider merging https://chromium.googlesource.com/chromium/blink/+/b2181608f7b4697190b880d8a2d7b302a96d031e Simplify RenderFlexibleBox::computeMainAxisExtentForChild We only need to check size.isIntrinsic(), not all of height/min-height/max-height. We can also use layoutIfNeeded(). No new tests - no behavior change. 1893120 1 ahmad.saleem792 2022-08-22 17:00:01 -0700 I don't understand the refactoring done - https://github.com/WebKit/WebKit/blob/62e012dfc64a13172b55d9115d77119ec8dbe794/Source/WebCore/rendering/RenderFlexibleBox.cpp#L653 Appreciate if someone can have a look and see if anything else is needed here or not? Thanks! 1893144 2 rreno 2022-08-22 20:27:26 -0700 This was resolved in a mass Blink flexbox import. https://bugs.webkit.org/show_bug.cgi?id=168657 *** This bug has been marked as a duplicate of bug 168657 ***