116479 2013-05-20 17:42:30 -0700 REGRESSION: Null pointer deference in WebCore::AppendNodeCommand::create 2013-05-20 20:17:58 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Major --- 1 rniwa rniwa commit-queue darin enrica ojan webkit-bug-importer oldest_to_newest 891409 0 rniwa 2013-05-20 17:42:30 -0700 We should merge https://chromium.googlesource.com/chromium/blink/+/5cb43002a44f67a60ecf5a7ed76de2d0bcf89eb2 891410 1 rniwa 2013-05-20 17:46:35 -0700 http://crbug.com/177470 891422 2 202337 rniwa 2013-05-20 18:12:52 -0700 Created attachment 202337 Fixes the bug 891423 3 rniwa 2013-05-20 18:14:34 -0700 I can reproduce the crash. 891424 4 webkit-bug-importer 2013-05-20 18:14:45 -0700 <rdar://problem/13945311> 891533 5 202337 kling 2013-05-20 19:56:46 -0700 Comment on attachment 202337 Fixes the bug r=me 891538 6 202337 commit-queue 2013-05-20 20:17:56 -0700 Comment on attachment 202337 Fixes the bug Clearing flags on attachment: 202337 Committed r150402: <http://trac.webkit.org/changeset/150402> 891539 7 commit-queue 2013-05-20 20:17:58 -0700 All reviewed patches have been landed. Closing bug. 202337 2013-05-20 18:12:52 -0700 2013-05-20 20:17:56 -0700 Fixes the bug bug-116479-20130520181141.patch text/plain 4342 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDM5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE51bGwgcG9pbnRlciBkZWZlcmVu Y2UgaW4gV2ViQ29yZTo6QXBwZW5kTm9kZUNvbW1hbmQ6OmNyZWF0ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NDc5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBNZXJnZSBodHRwczovL2No cm9taXVtLmdvb2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy81Y2I0MzAwMmE0NGY2N2E2 MGVjZjVhN2VkNzZkZTJkMGJjZjg5ZWIyCisKKyAgICAgICAgRGVsZXRlU2VsZWN0aW9uOjptYWtl U3R5bGluZ0VsZW1lbnRzRGlyZWN0Q2hpbGRyZW5PZkVkaXRhYmxlUm9vdFRvUHJldmVudFN0eWxl TG9zcygpIG1ha2Ugc3R5bGUgYW5kIGxpbmsgZWxlbWVudHMKKyAgICAgICAgdG8gYmUgdGhlIGRp cmVjdCBjaGlsZHJlbiBvZiB0aGUgZWRpdGFibGUgcm9vdC4gSG93ZXZlciwgdGhlc2Ugc3R5bGUg YW5kIGxpbmsgZWxlbWVudHMgYXJlIG5vdCBuZWNlc3NhcnkgZWRpdGFibGUKKyAgICAgICAgYW5k IFdlYktpdCBjcmFzaGVzIHdoZW4gdGhleSBhcmUgbm90LgorCisgICAgICAgIFRlc3Q6IGVkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLXVuZWRpdGFibGUtc3R5bGUuaHRtbAorCisgICAgICAgICogZWRp dGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlbGV0 ZVNlbGVjdGlvbkNvbW1hbmQ6Om1ha2VTdHlsaW5nRWxlbWVudHNEaXJlY3RDaGlsZHJlbk9mRWRp dGFibGVSb290VG9QcmV2ZW50U3R5bGVMb3NzKToKKwogMjAxMy0wNS0yMCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGllbnRzIHNob3VsZCBoYXZl IGEgd2F5IHRvIGV4dGVuZCByZW5kZXJpbmcgc3VwcHJlc3Npb24KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcAkocmV2aXNpb24g MTUwMzc2KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5k LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDI2LDggKzQyNiwxMCBAQCB2b2lkIERlbGV0ZVNlbGVj dGlvbkNvbW1hbmQ6Om1ha2VTdHlsaW5nCiAgICAgICAgIGlmICgobm9kZS0+aGFzVGFnTmFtZShz dHlsZVRhZykgJiYgISh0b0VsZW1lbnQobm9kZS5nZXQoKSktPmhhc0F0dHJpYnV0ZShzY29wZWRB dHRyKSkpIHx8IG5vZGUtPmhhc1RhZ05hbWUobGlua1RhZykpIHsKICAgICAgICAgICAgIG5leHRO b2RlID0gTm9kZVRyYXZlcnNhbDo6bmV4dFNraXBwaW5nQ2hpbGRyZW4obm9kZS5nZXQoKSk7CiAg ICAgICAgICAgICBSZWZQdHI8Q29udGFpbmVyTm9kZT4gcm9vdEVkaXRhYmxlRWxlbWVudCA9IG5v ZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKLSAgICAgICAgICAgIHJlbW92ZU5vZGUobm9kZSk7 Ci0gICAgICAgICAgICBhcHBlbmROb2RlKG5vZGUsIHJvb3RFZGl0YWJsZUVsZW1lbnQpOworICAg ICAgICAgICAgaWYgKHJvb3RFZGl0YWJsZUVsZW1lbnQpIHsKKyAgICAgICAgICAgICAgICByZW1v dmVOb2RlKG5vZGUpOworICAgICAgICAgICAgICAgIGFwcGVuZE5vZGUobm9kZSwgcm9vdEVkaXRh YmxlRWxlbWVudCk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgbm9kZSA9IG5l eHROb2RlOwogICAgIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDM5MykKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTIwICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE51bGwgcG9pbnRlciBk ZWZlcmVuY2UgaW4gV2ViQ29yZTo6QXBwZW5kTm9kZUNvbW1hbmQ6OmNyZWF0ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NDc5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0 ZXN0LgorCisgICAgICAgICogZWRpdGluZy9kZWxldGluZy9kZWxldGUtdW5lZGl0YWJsZS1zdHls ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRl LXVuZWRpdGFibGUtc3R5bGUuaHRtbDogQWRkZWQuCisKIDIwMTMtMDUtMjAgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGluc2VydGlu ZyBhIGNoYXJhY3RlciBpbnNpZGUgYSBVUkwgZG9lc24ndCBtb3ZlIGNhcmV0IHBlciBhdXRvIGNv cnJlY3Rpb24KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLXVuZWRp dGFibGUtc3R5bGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLXVuZWRpdGFibGUtc3R5bGUtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtdW5lZGl0YWJsZS1z dHlsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorVGVzdCB0aGF0 IGhhdmluZyBhIG5vbi1lZGl0YWJsZSBzdHlsZSBhbmQgbGluayBlbGVtZW50cyBkb2VzIG5vdCBj YXVzZSBhIGNyYXNoCit8IDxzcGFuPgorfCAgIGlkPSJlbmQiCit8ICAgIjwjc2VsZWN0aW9uLWNh cmV0PmVuZCIKK3wgIgorIgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxl dGUtdW5lZGl0YWJsZS1zdHlsZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLXVuZWRpdGFibGUtc3R5bGUuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLXVuZWRpdGFibGUtc3R5bGUuaHRt bAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMyBAQAorPCFET0NUWVBFPgorPGh0bWw+Cis8Ym9k eT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvZHVtcC1hcy1tYXJrdXAuanMiPjwvc2Ny aXB0PgorPGRpdiBjb250ZW50RWRpdGFibGUgaWQ9InRlc3QiPgorICAgIDxzcGFuIGlkPSJzdGFy dCI+c3RhcnQ8L3NwYW4+CisgICAgZWRpdGFibGUtMQorICAgIDxkaXYgY29udGVudEVkaXRhYmxl PSJmYWxzZSI+CisgICAgICAgIDxzdHlsZT4jZW5kIHsgY29sb3I6IHJlZDsgfTwvc3R5bGU+Cisg ICAgICAgIDxsaW5rIHR5cGU9ImZvbyIgaHJlZj0iYmFyIj4KKyAgICAgICAgdW5lZGl0YWJsZQor ICAgIDwvZGl2PgorICAgIGVkaXRhYmxlLTIKKzxzcGFuIGlkPSJlbmQiPmVuZDwvc3Bhbj4KKzwv ZGl2PgorPHNjcmlwdD4KK01hcmt1cC5kZXNjcmlwdGlvbignVGVzdCB0aGF0IGhhdmluZyBhIG5v bi1lZGl0YWJsZSBzdHlsZSBhbmQgbGluayBlbGVtZW50cyBkb2VzIG5vdCBjYXVzZSBhIGNyYXNo Jyk7CisKK2Z1bmN0aW9uICQoaWQpIHsgcmV0dXJuIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGlk KTsgfQorCit2YXIgcmFuZ2UgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOworcmFuZ2Uuc2V0U3Rh cnQoJCgnc3RhcnQnKSk7CityYW5nZS5zZXRFbmQoJCgnZW5kJyksIE5hTik7CisKK2dldFNlbGVj dGlvbigpLmFkZFJhbmdlKHJhbmdlKTsKKworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0RlbGV0ZScs IG51bGwsICcnKTsKKworTWFya3VwLmR1bXAoJ3Rlc3QnKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==