<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>11647</bug_id>
          
          <creation_ts>2006-11-18 20:04:31 -0800</creation_ts>
          <short_desc>Fix Win32 build</short_desc>
          <delta_ts>2006-11-20 05:10:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>420+</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>45233</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2006-11-18 20:04:31 -0800</bug_when>
    <thetext>r17837 killed the win32 build.  Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>45234</commentid>
    <comment_count>1</comment_count>
      <attachid>11569</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2006-11-18 20:20:13 -0800</bug_when>
    <thetext>Created attachment 11569
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44892</commentid>
    <comment_count>2</comment_count>
      <attachid>11569</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2006-11-19 19:43:14 -0800</bug_when>
    <thetext>Comment on attachment 11569
patch

r=me

The comment in Vector.h could maybe be more clear that just using NOMINMAX doesn&apos;t appear to work for some reason.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44907</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2006-11-20 05:10:09 -0800</bug_when>
    <thetext>Landed in r17856.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>11569</attachid>
            <date>2006-11-18 20:20:13 -0800</date>
            <delta_ts>2006-11-19 19:43:14 -0800</delta_ts>
            <desc>patch</desc>
            <filename>win32fix.diff</filename>
            <type>text/plain</type>
            <size>6500</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODUwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMTEtMTggIFNhbXVlbCBX
ZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTExNjQ3CisgICAgICAgIEZpeCBXaW4zMiBidWlsZAorCisgICAgICAgICoga2pzL2Nv
bmZpZy5oOiBkZWZpbmUgTk9NSU5NQVggaW5zdGVhZCBvZiBtaW4vbWF4CisgICAgICAgIGFzIHRo
ZW1zZWx2ZXMuCisgICAgICAgICogd3RmL1ZlY3Rvci5oOiBwdXQgYmFjayBoYWNrIHRvIGVuc3Vy
ZSB0aGF0IG1pbi9tYXgKKyAgICAgICAgYXJlIG5vdCBkZWZpbmVkIGFzIG1hY3Jvcy4KKwogMjAw
Ni0xMS0xNyAgQW5kZXJzIENhcmxzc29uICA8YWNhcmxzc29uQGFwcGxlLmNvbT4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBBZGFtLgpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL2NvbmZpZy5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9jb25maWcuaAkocmV2aXNpb24gMTc4NDcp
CisrKyBKYXZhU2NyaXB0Q29yZS9ranMvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr
MSwyNCBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAwNiBBcHBsZSBDb21wdXRlciwgSW5jLgor
ICogQ29weXJpZ2h0IChDKSAyMDA2IFNhbXVlbCBXZWluaWcgPHNhbS53ZWluaWdAZ21haWwuY29t
PgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJp
YnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBM
aWJyYXJ5IEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJl
ZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUgTGljZW5z
ZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBUaGlzIGxp
YnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwK
KyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdh
cnJhbnR5IG9mCisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFS
IFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl
IGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29w
eSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0
aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUg
dG8KKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDU5IFRlbXBsZSBQbGFj
ZSAtIFN1aXRlIDMzMCwKKyAqIEJvc3RvbiwgTUEgMDIxMTEtMTMwNywgVVNBLgorICoKKyAqLwor
CiAjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAKICNpZiBQTEFURk9STShEQVJXSU4pCkBAIC0x
NCwxNiArMzUsMTQgQEAKIAogI2VsaWYgUExBVEZPUk0oV0lOX09TKQogCi0vLyBJZiB3ZSBkb24n
dCBkZWZpbmUgdGhlc2UsIHRoZXkgZ2V0IGRlZmluZWQgaW4gd2luZGVmLmguIAotLy8gV2Ugd2Fu
dCB0byB1c2Ugc3RkOjptaW4gYW5kIHN0ZDo6bWF4Ci0jZGVmaW5lIG1heCBtYXgKLSNkZWZpbmUg
bWluIG1pbgorLy8gV2UgbmVlZCB0byBkZWZpbmUgdGhpcyBpbiBvcmRlciB0byB1c2UgdGhlIG51
bWVyaWMgbGltaXQgCisvLyB2YWx1ZXMgcHJvdmlkZWQgYnkgdGhlIEMrKyBzdGFuZGFyZCBsaWJy
YXJ5LgorI2RlZmluZSBOT01JTk1BWAogCiAjZGVmaW5lIEhBVkVfRkxPQVRfSCAxCiAjZGVmaW5l
IEhBVkVfRlVOQ19fRklOSVRFIDEKICNkZWZpbmUgSEFWRV9TWVNfVElNRUJfSCAxCiAKLQogI2Rl
ZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCiAKICNlbHNlCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93
dGYvVmVjdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShy
ZXZpc2lvbiAxNzg0NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAkod29ya2luZyBj
b3B5KQpAQCAtMzAsNiArMzAsMTYgQEAKICNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDx1
dGlsaXR5PgogCisvLyBUZW1wb3Jhcnkgd29ya2Fyb3VuZCBmb3IgV2luMzIuCisvLyBXZSBzaG91
bGQgdXNlIE5PTUlOTUFYIGluc3RlYWQuCisjaWZkZWYgbWF4CisjdW5kZWYgbWF4CisjZW5kaWYK
KworI2lmZGVmIG1pbgorI3VuZGVmIG1pbgorI2VuZGlmCisKIG5hbWVzcGFjZSBXVEYgewogCiAg
ICAgdXNpbmcgc3RkOjptaW47CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc4NTApCisrKyBXZWJDb3JlL0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDA2LTExLTE4ICBTYW11ZWwgV2Vp
bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgRml4IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xMTY0NworICAgICAgICBGaXggV2luMzIgYnVpbGQKKworICAgICAgICAqIGNvbmZpZy5o
OiBhZGQgI2RlZmluZSBOT01JTk1BWCBmb3Igd2luZG93cyBidWlsZAorICAgICAgICAqIHBsYXRm
b3JtL3dpbi9Gb250Q2FjaGVXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpj
cmVhdGVGb250UGxhdGZvcm1EYXRhKToKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVGVtcG9yYXJ5
TGlua1N0dWJzLmNwcDogYWRkIGRlZmluaXRpb25zIGZvciAKKyAgICAgICAgbmV3IGN1cnNvcnMu
CisgICAgICAgIChXZWJDb3JlOjphbGlhc0N1cnNvcik6CisgICAgICAgIChXZWJDb3JlOjpub0Ry
b3BDdXJzb3IpOgorICAgICAgICAoV2ViQ29yZTo6cHJvZ3Jlc3NDdXJzb3IpOgorCiAyMDA2LTEx
LTE5ICBOaWtvbGFzIFppbW1lcm1hbm4gIDx6aW1tZXJtYW5uQGtkZS5vcmc+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgT2xpdmVyLgpJbmRleDogV2ViQ29yZS9jb25maWcuaAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBXZWJDb3JlL2NvbmZpZy5oCShyZXZpc2lvbiAxNzg0NykKKysrIFdlYkNvcmUvY29uZmlnLmgJ
KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw2IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDA0
LCAyMDA1LCAyMDA2IEFwcGxlIENvbXB1dGVyLCBJbmMuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDYg
U2FtdWVsIFdlaW5pZyA8c2FtLndlaW5pZ0BnbWFpbC5jb20+CiAgKgogICogVGhpcyBsaWJyYXJ5
IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9k
aWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMK
QEAgLTQ4LDYgKzQ5LDEwIEBAIHR5cGVkZWYgZmxvYXQgQ0dGbG9hdDsKICNkZWZpbmUgV0lOVkVS
IDB4MDUwMAogI2VuZGlmCiAKKy8vIFdlIG5lZWQgdG8gZGVmaW5lIHRoaXMgaW4gb3JkZXIgdG8g
dXNlIHRoZSBudW1lcmljIGxpbWl0IAorLy8gdmFsdWVzIHByb3ZpZGVkIGJ5IHRoZSBDKysgc3Rh
bmRhcmQgbGlicmFyeS4KKyNkZWZpbmUgTk9NSU5NQVgKKwogLy8gSGFjayB0byBtYXRjaCBjb25m
aWd1cmF0aW9uIG9mIEphdmFTY3JpcHRDb3JlLgogLy8gTWF5YmUgdGhlcmUncyBhIGJldHRlciB3
YXkgdG8gZG8gdGhpcy4KICNkZWZpbmUgVVNFX1NZU1RFTV9NQUxMT0MgMQpJbmRleDogV2ViQ29y
ZS9wbGF0Zm9ybS93aW4vRm9udENhY2hlV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs
YXRmb3JtL3dpbi9Gb250Q2FjaGVXaW4uY3BwCShyZXZpc2lvbiAxNzg0NykKKysrIFdlYkNvcmUv
cGxhdGZvcm0vd2luL0ZvbnRDYWNoZVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4LDEzICsy
OCwxNiBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRm9udENhY2hlLmgiCisK
ICNpbmNsdWRlICJGb250RGF0YS5oIgogI2luY2x1ZGUgIkZvbnQuaCIKLSNpbmNsdWRlIDx3aW5k
b3dzLmg+CisjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUgPG1sYW5nLmg+CisjaW5jbHVk
ZSA8d2luZG93cy5oPgogCi1uYW1lc3BhY2UgV2ViQ29yZQotewordXNpbmcgc3RkOjptaW47CisK
K25hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBGb250Q2FjaGU6OnBsYXRmb3JtSW5pdCgpCiB7
CkBAIC0xMTUsNyArMTE4LDcgQEAgRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hlOjpjcmVhdGVG
b250UAogICAgIHdpbmZvbnQubGZQaXRjaEFuZEZhbWlseSA9IERFRkFVTFRfUElUQ0ggfCBGRl9E
T05UQ0FSRTsKICAgICB3aW5mb250LmxmSXRhbGljID0gZm9udERlc2NyaXB0aW9uLml0YWxpYygp
OwogICAgIHdpbmZvbnQubGZXZWlnaHQgPSBmb250RGVzY3JpcHRpb24uYm9sZCgpID8gNzAwIDog
NDAwOyAvLyBGSVhNRTogU3VwcG9ydCB3ZWlnaHRzIGZvciByZWFsLgotICAgIGludCBsZW4gPSBt
aW4oZmFtaWx5Lmxlbmd0aCgpLCBMRl9GQUNFU0laRSAtIDEpOworICAgIGludCBsZW4gPSBtaW4o
c3RhdGljX2Nhc3Q8aW50PihmYW1pbHkubGVuZ3RoKCkpLCBMRl9GQUNFU0laRSAtIDEpOwogICAg
IG1lbWNweSh3aW5mb250LmxmRmFjZU5hbWUsIGZhbWlseS5jaGFyYWN0ZXJzKCksIGxlbiAqIHNp
emVvZihXT1JEKSk7CiAgICAgd2luZm9udC5sZkZhY2VOYW1lW2xlbl0gPSAnXDAnOwogCkluZGV4
OiBXZWJDb3JlL3BsYXRmb3JtL3dpbi9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYkNvcmUvcGxhdGZvcm0vd2luL1RlbXBvcmFyeUxpbmtTdHVicy5jcHAJKHJldmlzaW9u
IDE3ODQ3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS93aW4vVGVtcG9yYXJ5TGlua1N0dWJzLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMTAxLDkgKzEwMSwxMiBAQCBDb2xvciBmb2N1c1JpbmdDb2xvcigp
IHsgbm90SW1wbGVtZW50ZWQoCiBib29sIGhpc3RvcnlDb250YWlucyhEZXByZWNhdGVkU3RyaW5n
IGNvbnN0JikgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gZmFsc2U7IH0KIFN0cmluZyBpbnB1
dEVsZW1lbnRBbHRUZXh0KCkgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gRGVwcmVjYXRlZFN0
cmluZygpOyB9CiBib29sIElzUmVzcG9uc2VVUkxFcXVhbFRvVVJMKFBsYXRmb3JtUmVzcG9uc2Ug
LCBjb25zdCBTdHJpbmcmKSB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVybiBmYWxzZTsgfQorY29u
c3QgQ3Vyc29yJiBhbGlhc0N1cnNvcigpIHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIGxvY2Fs
Q3Vyc29yOyB9CiBjb25zdCBDdXJzb3ImIGNlbGxDdXJzb3IoKSB7IG5vdEltcGxlbWVudGVkKCk7
IHJldHVybiBsb2NhbEN1cnNvcjsgfQogY29uc3QgQ3Vyc29yJiBjb250ZXh0TWVudUN1cnNvcigp
IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIGxvY2FsQ3Vyc29yOyB9CiBjb25zdCBDdXJzb3Im
IG1vdmVDdXJzb3IoKSB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVybiBsb2NhbEN1cnNvcjsgfQor
Y29uc3QgQ3Vyc29yJiBub0Ryb3BDdXJzb3IoKSB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVybiBs
b2NhbEN1cnNvcjsgfQorY29uc3QgQ3Vyc29yJiBwcm9ncmVzc0N1cnNvcigpIHsgbm90SW1wbGVt
ZW50ZWQoKTsgcmV0dXJuIGxvY2FsQ3Vyc29yOyB9CiBjb25zdCBDdXJzb3ImIHZlcnRpY2FsVGV4
dEN1cnNvcigpIHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIGxvY2FsQ3Vyc29yOyB9CiB2b2lk
IHJlZnJlc2hQbHVnaW5zKGJvb2wpIHsgbm90SW1wbGVtZW50ZWQoKTsgfQogU3RyaW5nIHJlc2V0
QnV0dG9uRGVmYXVsdExhYmVsKCkgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gIlJlc2V0Ijsg
fQo=
</data>
<flag name="review"
          id="4118"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>