116453 2013-05-20 11:42:22 -0700 PLATFORM(*) macros used in Source/WebCore/loader/archive/ArchiveFactory.cpp 2013-05-21 09:02:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 21354 1 zan zan ap commit-queue japhet oldest_to_newest 891278 0 zan 2013-05-20 11:42:22 -0700 There's a couple of PLATFORM(*) macros used in ArchiveFactory.cpp, specifying which mime types are supported on what platform. http://trac.webkit.org/browser/trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp#L58 This should be moved into the platform layer. 891381 1 ap 2013-05-20 16:03:10 -0700 Can you please elaborate on the reason? Note that platform directory contains the "platform" on which WebCore builds. While much of that is platform specific, keeping platforms specific code together in one place is not the reason for its existence. 891591 2 zan 2013-05-20 23:32:54 -0700 I've filed this due to the layering violation reported by the check-webkit-style script in bug #116442. https://bugs.webkit.org/show_bug.cgi?id=116442#c2 The patch took on a different path later, removing most of the PLATFORM macros in r150418. http://trac.webkit.org/changeset/150418 There's still one PLATFORM(QT) left in the file: http://trac.webkit.org/browser/trunk/Source/WebCore/loader/archive/ArchiveFactory.cpp#L34 I think it can be removed because the Qt port does not enable WebArchive support even when using CoreFoundations. 891593 3 202381 zan 2013-05-20 23:44:54 -0700 Created attachment 202381 Patch 891779 4 202381 ap 2013-05-21 08:29:25 -0700 Comment on attachment 202381 Patch I think that the style bot is wrong complaining about this. Do you know when the check was added? r=me on this change. 891793 5 zan 2013-05-21 08:45:06 -0700 That would be r149635. http://trac.webkit.org/changeset/149635 891817 6 202381 zan 2013-05-21 09:02:41 -0700 Comment on attachment 202381 Patch Clearing flags on attachment: 202381 Committed r150444: <http://trac.webkit.org/changeset/150444> 891818 7 zan 2013-05-21 09:02:52 -0700 All reviewed patches have been landed. Closing bug. 202381 2013-05-20 23:44:54 -0700 2013-05-21 09:02:40 -0700 Patch bug-116453-20130521084343.patch text/plain 1664 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI1ZDhhM2QwZjAwZGFm NjFiNTUxNmIxOGE3YTY2NDIyMTY1MWQxMi4uYzVkYTk2MjI1YTRjMDkwMzQ2OTA5YWYzM2EyMGVj ZWNjODVmOWQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA1LTIwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBQTEFURk9STSgqKSBt YWNyb3MgdXNlZCBpbiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXJjaGl2ZS9BcmNoaXZlRmFjdG9y eS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NjQ1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog bG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3BwOiBSZW1vdmUgYSByZWR1bmRhbnQgUExB VEZPUk0oUVQpIG1hY3JvIHdoZW4gY2hlY2tpbmcgd2hldGhlcgorICAgICAgICB0byBpbmNsdWRl IHRoZSBMZWdhY3lXZWJBcmNoaXZlLmggaGVhZGVyIHRoYXQncyBzcGVjaWZpYyB0byB0aGUgV2Vi QXJjaGl2ZSBzdXBwb3J0LiBUaGUgUXQgcG9ydAorICAgICAgICBkb2VzIG5vdCBlbmFibGUgdGhl IFdlYkFyY2hpdmUgZmVhdHVyZSBhdCBhbGwgKHdoaWNoIGlzIGVuYWJsZWQgb25seSBvbiBBcHBs ZU1hYywgQXBwbGVXaW4gYW5kIGlPUworICAgICAgICBwbGF0Zm9ybXMpIHNvIHRoZXJlJ3Mgbm8g cmVhc29uIHRvIGFkZGl0aW9uYWxseSBjb25kaXRpb24gdGhlIGhlYWRlciBpbmNsdWRlIHdpdGgg YnVpbGRpbmcgb24KKyAgICAgICAgbm9uLVF0IHBsYXRmb3Jtcy4KKworMjAxMy0wNS0yMCAgWmFu IERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gRml4IGNv bmNhdGVuYXRpb25zIG9mIHN0cmluZyBsaXRlcmFscyB0aGF0IGFyZSBub3QgQysrMTEtY29tcGxp YW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY0 NDkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZh Y3RvcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3Rvcnku Y3BwCmluZGV4IDYyNzAwOWYxNjI0ZWJlZjgxYzkzODA4NGY2OTQ4ODY0ZWVjNjNkNDEuLmZiYmJh YTFmNjg0ZDY4Y2IwZjQ1OWIyNmJjNDdmYjk4ZDFhZGE1NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9hcmNoaXZlL0FyY2hpdmVGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvYXJjaGl2ZS9BcmNoaXZlRmFjdG9yeS5jcHAKQEAgLTMxLDcgKzMxLDcgQEAK IAogI2luY2x1ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKIAotI2lmIFVTRShDRikgJiYgIVBMQVRG T1JNKFFUKSAmJiBFTkFCTEUoV0VCX0FSQ0hJVkUpCisjaWYgRU5BQkxFKFdFQl9BUkNISVZFKSAm JiBVU0UoQ0YpCiAjaW5jbHVkZSAiTGVnYWN5V2ViQXJjaGl2ZS5oIgogI2VuZGlmCiAjaWYgRU5B QkxFKE1IVE1MKQo=