116449 2013-05-20 11:10:05 -0700 [GTK] Fix concatenations of string literals that are not C++11-compliant 2013-05-20 23:16:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia commit-queue eric.carlson glenn gustavo jer.noble mrobinson oldest_to_newest 891262 0 zan 2013-05-20 11:10:05 -0700 [GTK] Fix concatenations of string literals that are not C++11-compliant 891264 1 202294 zan 2013-05-20 11:13:10 -0700 Created attachment 202294 Patch 891266 2 commit-queue 2013-05-20 11:14:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 891585 3 202294 zan 2013-05-20 23:16:07 -0700 Comment on attachment 202294 Patch Clearing flags on attachment: 202294 Committed r150421: <http://trac.webkit.org/changeset/150421> 891586 4 zan 2013-05-20 23:16:13 -0700 All reviewed patches have been landed. Closing bug. 202294 2013-05-20 11:13:10 -0700 2013-05-20 23:16:07 -0700 Patch bug-116449-20130520201159.patch text/plain 7070 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRkN2ZjNDQ1MzMzYzI5 MTE5Y2VjZTZiOWY4NTdiZjY5NDkzMmEyMy4uMzY5Njc4ZWFiZGFjYzA1MmNmZThjYTc5NWFlN2Vj OTY3M2U0MzU0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTIwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGaXggY29u Y2F0ZW5hdGlvbnMgb2Ygc3RyaW5nIGxpdGVyYWxzIHRoYXQgYXJlIG5vdCBDKysxMS1jb21wbGlh bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjQ0 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0 aGUgcHJvYmxlbWF0aWMgY29uY2F0ZW5hdGlvbnMgb2Ygc3RyaW5nIGxpdGVyYWxzIHNvIHRoZXkg YXJlIGNvbXBpbGFibGUgdW5kZXIgdGhlIEMrKzExIHN0YW5kYXJkLiBUaGlzCisgICAgICAgIGlz IHNpbXBseSBhIG1hdHRlciBvZiBzZXBhcmF0aW5nIHRoZSBzdHJpbmcgYW5kIHRoZSBzdHJpbmcg bGl0ZXJhbCB0aGF0IGFyZSBiZWluZyBjb25jYXRlbmF0ZWQgd2l0aCBhIHNwYWNlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXJHdGsu Y3BwOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OnNoYXJlZFJlc291cmNlc1BhdGgpOgorCiAyMDEzLTA1LTIwICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIG1lZGlhL2V2ZW50 LXF1ZXVlLWNyYXNoLmh0bWwgQVNTRVJUcyBpbiBub3RpZnlDaGlsZEluc2VydGVkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK aW5kZXggYzZmN2M2NWJhMTU3YjBiODgxMjI4MGNhZjVlMTRjNzdkMWNhYTM0MC4uN2UwM2Q2Zjg1 ZDM5M2NhMzllMTdmOTJiMzUwOWZhNDk3MDMwMWRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA1LTIwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXSBGaXggY29uY2F0ZW5hdGlvbnMgb2Ygc3RyaW5nIGxpdGVyYWxzIHRoYXQg YXJlIG5vdCBDKysxMS1jb21wbGlhbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNjQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB0aGUgcHJvYmxlbWF0aWMgY29uY2F0ZW5hdGlvbnMgb2Ygc3Ry aW5nIGxpdGVyYWxzIHNvIHRoZXkgYXJlIGNvbXBpbGFibGUgdW5kZXIgdGhlIEMrKzExIHN0YW5k YXJkLiBUaGlzCisgICAgICAgIGlzIHNpbXBseSBhIG1hdHRlciBvZiBzZXBhcmF0aW5nIHRoZSBz dHJpbmcgYW5kIHRoZSBzdHJpbmcgbGl0ZXJhbCB0aGF0IGFyZSBiZWluZyBjb25jYXRlbmF0ZWQg d2l0aCBhIHNwYWNlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFBy aW50aW5nLmNwcDoKKyAgICAgICAgKHRlc3RQcmludE9wZXJhdGlvblByaW50KToKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9XZWJFeHRlbnNpb25UZXN0LmNwcDoKKyAgICAgICAg KG1ldGhvZENhbGxDYWxsYmFjayk6CisKIDIwMTMtMDUtMTkgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBCdW1wIFdLQnVuZGxlUGFnZUxvYWRlckNsaWVudCB2ZXJzaW9u IG51bWJlciBzbyBhcyBub3QgdG8gYnJlYWsgc29tZSBjbGllbnRzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvRnVsbHNjcmVlblZpZGVvQ29udHJvbGxl ckd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvRnVsbHNjcmVl blZpZGVvQ29udHJvbGxlckd0ay5jcHAKaW5kZXggNDY4MTNiZTc1OTY0NTVmNWM5MzQ4YmU4NzIx MDg4MDU2MTU2ODg1Yy4uYTJmMDhiNjU1YzYyNmIyMmMwZjhhNjIxY2FlZmRkZjFiZmY1Y2FmYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0Z1bGxzY3Jl ZW5WaWRlb0NvbnRyb2xsZXJHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2d0ay9GdWxsc2NyZWVuVmlkZW9Db250cm9sbGVyR3RrLmNwcApAQCAtNDgsOSArNDgs OSBAQAogI2RlZmluZSBJQ09OX05BTUVfU1VGRklYCiAjZW5kaWYKIAotI2RlZmluZSBQTEFZX0lD T05fTkFNRSAibWVkaWEtcGxheWJhY2stc3RhcnQiSUNPTl9OQU1FX1NVRkZJWAotI2RlZmluZSBQ QVVTRV9JQ09OX05BTUUgIm1lZGlhLXBsYXliYWNrLXBhdXNlIklDT05fTkFNRV9TVUZGSVgKLSNk ZWZpbmUgRVhJVF9GVUxMU0NSRUVOX0lDT05fTkFNRSAidmlldy1yZXN0b3JlIklDT05fTkFNRV9T VUZGSVgKKyNkZWZpbmUgUExBWV9JQ09OX05BTUUgIm1lZGlhLXBsYXliYWNrLXN0YXJ0IiBJQ09O X05BTUVfU1VGRklYCisjZGVmaW5lIFBBVVNFX0lDT05fTkFNRSAibWVkaWEtcGxheWJhY2stcGF1 c2UiIElDT05fTkFNRV9TVUZGSVgKKyNkZWZpbmUgRVhJVF9GVUxMU0NSRUVOX0lDT05fTkFNRSAi dmlldy1yZXN0b3JlIiBJQ09OX05BTUVfU1VGRklYCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1HdGsuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1HdGsuY3BwCmluZGV4IGZh MjA3Mjk2YzZhNmNiNDY2MjhmNzcwOTYzNGUyNGU3MmY4ODdjOWYuLjg0ZWVjNjIyZGQzMzAxYjYw ODY3MTgyMjFiNjJlMGM0Y2Y0MGU2ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvRmlsZVN5c3RlbUd0ay5jcHAKQEAgLTIyMiw3ICsyMjIsNyBAQCBDU3RyaW5nIHNoYXJlZFJl c291cmNlc1BhdGgoKQogICAgIEdPd25QdHI8Z2NoYXI+IHJ1bnRpbWVEaXIoZ193aW4zMl9nZXRf cGFja2FnZV9pbnN0YWxsYXRpb25fZGlyZWN0b3J5X29mX21vZHVsZShobW9kdWxlKSk7CiAgICAg R093blB0cjxnY2hhcj4gZGF0YVBhdGgoZ19idWlsZF9maWxlbmFtZShydW50aW1lRGlyLmdldCgp LCAic2hhcmUiLCAid2Via2l0Z3RrLSJXRUJLSVRHVEtfQVBJX1ZFUlNJT05fU1RSSU5HLCBOVUxM KSk7CiAjZWxzZQotICAgIEdPd25QdHI8Z2NoYXI+IGRhdGFQYXRoKGdfYnVpbGRfZmlsZW5hbWUo REFUQV9ESVIsICJ3ZWJraXRndGstIldFQktJVEdUS19BUElfVkVSU0lPTl9TVFJJTkcsIE5VTEwp KTsKKyAgICBHT3duUHRyPGdjaGFyPiBkYXRhUGF0aChnX2J1aWxkX2ZpbGVuYW1lKERBVEFfRElS LCAid2Via2l0Z3RrLSIgV0VCS0lUR1RLX0FQSV9WRVJTSU9OX1NUUklORywgTlVMTCkpOwogI2Vu ZGlmCiAKICAgICBjYWNoZWRQYXRoID0gZGF0YVBhdGguZ2V0KCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0UHJpbnRpbmcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFByaW50aW5nLmNwcAppbmRl eCAxMjM4MzFmNzY1MTM5YjAxM2NkZDU0MjdhNDI4N2M2YzZhYjYzMTBlLi43MmMyY2ZiYmRjMjY0 OTQzNjA3OTI2ZDM0MGJlNzkwOTU0MDJlMjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0UHJpbnRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RQcmludGluZy5jcHAKQEAgLTE0Niw3ICsx NDYsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0UHJpbnRPcGVyYXRpb25QcmludChQcmludFRlc3QqIHRl c3QsIGdjb25zdHBvaW50ZXIpCiAgICAgd2Via2l0X3ByaW50X29wZXJhdGlvbl9wcmludCh0ZXN0 LT5tX3ByaW50T3BlcmF0aW9uLmdldCgpKTsKICAgICB0ZXN0LT53YWl0VW50aWxQcmludEZpbmlz aGVkKCk7CiAKLSAgICBHUmVmUHRyPEdGaWxlSW5mbz4gZmlsZUluZm8gPSBhZG9wdEdSZWYoZ19m aWxlX3F1ZXJ5X2luZm8ob3V0cHV0RmlsZS5nZXQoKSwgR19GSUxFX0FUVFJJQlVURV9TVEFOREFS RF9TSVpFIiwiR19GSUxFX0FUVFJJQlVURV9TVEFOREFSRF9DT05URU5UX1RZUEUsCisgICAgR1Jl ZlB0cjxHRmlsZUluZm8+IGZpbGVJbmZvID0gYWRvcHRHUmVmKGdfZmlsZV9xdWVyeV9pbmZvKG91 dHB1dEZpbGUuZ2V0KCksIEdfRklMRV9BVFRSSUJVVEVfU1RBTkRBUkRfU0laRSAiLCIgR19GSUxF X0FUVFJJQlVURV9TVEFOREFSRF9DT05URU5UX1RZUEUsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PEdGaWxl UXVlcnlJbmZvRmxhZ3M+KDApLCAwLCAwKSk7CiAgICAgZ19hc3NlcnQoZmlsZUluZm8uZ2V0KCkp OwogICAgIGdfYXNzZXJ0X2NtcGludChnX2ZpbGVfaW5mb19nZXRfc2l6ZShmaWxlSW5mby5nZXQo KSksID4sIDApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv dGVzdHMvV2ViRXh0ZW5zaW9uVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay90ZXN0cy9XZWJFeHRlbnNpb25UZXN0LmNwcAppbmRleCAyMDYwMTQ3MTNhMjhjZDA2MDY3 M2U5NTQwMzQ4NDU0NGJlYTRiNDIwLi4yODdjNjEwZTdhNzNmNzY4OTM3YWQ1NmY4MTU4OGE0Mzc1 ZTk5ODBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0 cy9XZWJFeHRlbnNpb25UZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay90ZXN0cy9XZWJFeHRlbnNpb25UZXN0LmNwcApAQCAtMTA3LDcgKzEwNyw3IEBAIHN0YXRp YyB2b2lkIG1ldGhvZENhbGxDYWxsYmFjayhHREJ1c0Nvbm5lY3Rpb24qIGNvbm5lY3Rpb24sIGNv bnN0IGNoYXIqIHNlbmRlciwKICAgICAgICAgaWYgKCFwYWdlKSB7CiAgICAgICAgICAgICBnX2Ri dXNfbWV0aG9kX2ludm9jYXRpb25fcmV0dXJuX2Vycm9yKAogICAgICAgICAgICAgICAgIGludm9j YXRpb24sIEdfREJVU19FUlJPUiwgR19EQlVTX0VSUk9SX0lOVkFMSURfQVJHUywKLSAgICAgICAg ICAgICAgICAiSW52YWxpZCBwYWdlIElEOiAlIkdfR1VJTlQ2NF9GT1JNQVQsIHBhZ2VJRCk7Cisg ICAgICAgICAgICAgICAgIkludmFsaWQgcGFnZSBJRDogJSIgR19HVUlOVDY0X0ZPUk1BVCwgcGFn ZUlEKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAgICAgICBnX2Fzc2VydF9j bXB1aW50KHdlYmtpdF93ZWJfcGFnZV9nZXRfaWQocGFnZSksID09LCBwYWdlSUQpOwpkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDEyYzYwNGZiNTE1 NmY2MmFhNGNhNmQ5ZjhjNDBiZTAyMjgzNGJmMTYuLjgzMjcwZTc1Nzk0NTU0NjBhYWU1NTkyYmE4 ZjA1ZWEwMWNlMmYxMzQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wNS0yMCAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IGNvbmNhdGVuYXRpb25zIG9m IHN0cmluZyBsaXRlcmFscyB0aGF0IGFyZSBub3QgQysrMTEtY29tcGxpYW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY0NDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIHByb2JsZW1hdGlj IGNvbmNhdGVuYXRpb25zIG9mIHN0cmluZyBsaXRlcmFscyBzbyB0aGV5IGFyZSBjb21waWxhYmxl IHVuZGVyIHRoZSBDKysxMSBzdGFuZGFyZC4gVGhpcworICAgICAgICBpcyBzaW1wbHkgYSBtYXR0 ZXIgb2Ygc2VwYXJhdGluZyB0aGUgc3RyaW5nIGFuZCB0aGUgc3RyaW5nIGxpdGVyYWwgdGhhdCBh cmUgYmVpbmcgY29uY2F0ZW5hdGVkIHdpdGggYSBzcGFjZS4KKworICAgICAgICAqIEltYWdlRGlm Zi9ndGsvSW1hZ2VEaWZmLmNwcDoKKyAgICAgICAgKHByaW50SW1hZ2UpOgorCiAyMDEzLTA1LTIw ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAg ICBbRUZMXSBSZWVuYWJsZWQgSU5ERVhFRF9EQVRBQkFTRSBhZnRlciByMTUwMzQ0CmRpZmYgLS1n aXQgYS9Ub29scy9JbWFnZURpZmYvZ3RrL0ltYWdlRGlmZi5jcHAgYi9Ub29scy9JbWFnZURpZmYv Z3RrL0ltYWdlRGlmZi5jcHAKaW5kZXggODRjNDAwMzZmMjdiMmJlMTE5MDUzODMwNTg1MzhjZWQ2 NDYwN2ZlMC4uMmNiOWYzYmNlNWE3ZTYyMmEzNjRjYjdhZTllMTUxZWI5NmRkNmRjNiAxMDA2NDQK LS0tIGEvVG9vbHMvSW1hZ2VEaWZmL2d0ay9JbWFnZURpZmYuY3BwCisrKyBiL1Rvb2xzL0ltYWdl RGlmZi9ndGsvSW1hZ2VEaWZmLmNwcApAQCAtMTU3LDcgKzE1Nyw3IEBAIHZvaWQgcHJpbnRJbWFn ZShHZGtQaXhidWYqIGltYWdlKQogICAgICAgICByZXR1cm47IC8vIERvbid0IGJhaWwgb3V0LCBh cyB3ZSBjYW4gc3RpbGwgdXNlIHRoZSBwZXJjZW50YWdlIG91dHB1dC4KICAgICB9CiAKLSAgICBw cmludGYoIkNvbnRlbnQtTGVuZ3RoOiAlIkdfR1NJWkVfRk9STUFUIlxuIiwgYnVmZmVyU2l6ZSk7 CisgICAgcHJpbnRmKCJDb250ZW50LUxlbmd0aDogJSIgR19HU0laRV9GT1JNQVQgIlxuIiwgYnVm ZmVyU2l6ZSk7CiAgICAgZndyaXRlKGJ1ZmZlciwgMSwgYnVmZmVyU2l6ZSwgc3Rkb3V0KTsKIH0K IAo=