116447 2013-05-20 10:52:00 -0700 Use '__typeof__' keyword to avoid problems when compiling in C++11 standard compliance 2013-05-20 23:11:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan benjamin cmarcelo commit-queue jrogers oldest_to_newest 891254 0 zan 2013-05-20 10:52:00 -0700 Use '__typeof__' keyword to avoid problems when compiling in C++11 standard compliance 891258 1 202293 zan 2013-05-20 11:06:50 -0700 Created attachment 202293 Patch 891259 2 202293 darin 2013-05-20 11:09:03 -0700 Comment on attachment 202293 Patch OK, as long as it supports all the compilers we need it to. 891297 3 zan 2013-05-20 12:36:54 -0700 This should cover GCC and Clang, I'll get someone familiar with BlackBerry's qcc compiler to confirm this wouldn't break anything for them. Thanks for reviewing. 891451 4 jrogers 2013-05-20 18:19:29 -0700 (In reply to comment #3) > This should cover GCC and Clang, I'll get someone familiar with BlackBerry's qcc compiler to confirm this wouldn't break anything for them. Thanks for reviewing. This is fine for BlackBerry. 891578 5 zan 2013-05-20 23:10:30 -0700 (In reply to comment #4) > (In reply to comment #3) > > This should cover GCC and Clang, I'll get someone familiar with BlackBerry's qcc compiler to confirm this wouldn't break anything for them. Thanks for reviewing. > > This is fine for BlackBerry. Thanks for the input. 891580 6 202293 zan 2013-05-20 23:11:05 -0700 Comment on attachment 202293 Patch Clearing flags on attachment: 202293 Committed r150419: <http://trac.webkit.org/changeset/150419> 891581 7 zan 2013-05-20 23:11:10 -0700 All reviewed patches have been landed. Closing bug. 202293 2013-05-20 11:06:50 -0700 2013-05-20 23:11:04 -0700 Patch bug-116447-20130520200539.patch text/plain 1864 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVlNjQ4ZmJiNDQxNWVjODA5Zjg3YTky NDU4OTU4OTM1OGJhYTA3M2UuLjc1M2FjYjcwOGQyNGJmNGI0NWIwYTk0MTMxMTcwODkxY2IzNmQz MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDUtMjAgIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFVzZSAnX190eXBlb2ZfXycga2V5d29yZCB0byBh dm9pZCBwcm9ibGVtcyB3aGVuIGNvbXBpbGluZyBpbiBDKysxMSBzdGFuZGFyZCBjb21wbGlhbmNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY0NDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgJ3R5 cGVvZicga2V5d29yZCBpcyBhIEdOVSBDIGV4dGVuc2lvbiB3aGljaCBiZWNvbWVzIHVuYXZhaWxh YmxlIHdoZW4gY29tcGlsaW5nIGluIEFOU0kgb3Igc3BlY2lmaWMgc3RhbmRhcmQgbW9kZQorICAg ICAgICAoc3VjaCBhcyAtc3RkPWMrKzExKS4gVGhlICdfX3R5cGVvZl9fJyBrZXl3b3JkIHNob3Vs ZCBiZSB1c2VkIGluc3RlYWQgYXMgaXQncyBhdmFpbGFibGUgaW4gYWxsIG1vZGVzIGJvdGggdW5k ZXIgR0NDIGFuZCBDbGFuZy4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNwcDoKKyAgICAg ICAgKFdURik6IFJlcGxhY2UgdGhlICd0eXBlb2YnIGtleXdvcmQgd2l0aCAnX190eXBlb2ZfXycu CisKIDIwMTMtMDUtMTkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgbGluayBwcmVyZW5kZXJpbmcgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvRmFzdE1hbGxvYy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcApp bmRleCAwYjQ2MTA3YTYzY2M1ODA1MmU2YWIyOWQ4YmU3NTJiZDhkYTdhOTBkLi42NjdiMmVlMzQ1 NTYyNjNlZThmYmFjYzc4Y2RiZTZlN2FhZTliNDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9GYXN0TWFsbG9jLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcApAQCAt NTU1LDcgKzU1NSw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHVpbnRwdHJfdCBpbnRlcm5hbEVu dHJvcHlWYWx1ZSgpCiAKICNkZWZpbmUgSEFSREVOSU5HX0VOVFJPUFkgaW50ZXJuYWxFbnRyb3B5 VmFsdWUoKQogI2RlZmluZSBST1RBVEVfVkFMVUUodmFsdWUsIGFtb3VudCkgKCgodmFsdWUpID4+ IChhbW91bnQpKSB8ICgodmFsdWUpIDw8IChzaXplb2YodmFsdWUpICogOCAtIChhbW91bnQpKSkp Ci0jZGVmaW5lIFhPUl9NQVNLX1BUUl9XSVRIX0tFWShwdHIsIGtleSwgZW50cm9weSkgKHJlaW50 ZXJwcmV0X2Nhc3Q8dHlwZW9mKHB0cik+KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihwdHIp XihST1RBVEVfVkFMVUUocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KGtleSksIE1hc2tLZXlT aGlmdCleZW50cm9weSkpKQorI2RlZmluZSBYT1JfTUFTS19QVFJfV0lUSF9LRVkocHRyLCBrZXks IGVudHJvcHkpIChyZWludGVycHJldF9jYXN0PF9fdHlwZW9mX18ocHRyKT4ocmVpbnRlcnByZXRf Y2FzdDx1aW50cHRyX3Q+KHB0cileKFJPVEFURV9WQUxVRShyZWludGVycHJldF9jYXN0PHVpbnRw dHJfdD4oa2V5KSwgTWFza0tleVNoaWZ0KV5lbnRyb3B5KSkpCiAKIAogc3RhdGljIEFMV0FZU19J TkxJTkUgdWludDMyX3QgZnJlZWRPYmplY3RTdGFydFBvaXNvbigpCg==