116442 2013-05-20 09:39:19 -0700 [GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822 2013-05-20 23:07:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue japhet mrobinson oldest_to_newest 891213 0 zan 2013-05-20 09:39:19 -0700 [GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822 891215 1 202282 zan 2013-05-20 09:44:14 -0700 Created attachment 202282 Patch 891216 2 commit-queue 2013-05-20 09:45:01 -0700 Attachment 202282 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/archive/ArchiveFactory.cpp']" exit_code: 1 Source/WebCore/loader/archive/ArchiveFactory.cpp:71: Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 891279 3 zan 2013-05-20 11:43:32 -0700 (In reply to comment #2) > Attachment 202282 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/archive/ArchiveFactory.cpp']" exit_code: 1 > Source/WebCore/loader/archive/ArchiveFactory.cpp:71: Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] > Total errors found: 1 in 2 files I've kept the current approach, but filed bug #116453 to cover the layering violation. 891286 4 202282 mrobinson 2013-05-20 12:04:52 -0700 Comment on attachment 202282 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202282&action=review >> Source/WebCore/loader/archive/ArchiveFactory.cpp:71 >> +#if PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(QT) > > Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] Do you know what other platform enable MHTML other than EFL/GTK/Qt? Perhaps that platform should use the new mime-type as well. 891294 5 202282 zan 2013-05-20 12:34:34 -0700 Comment on attachment 202282 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202282&action=review >>> Source/WebCore/loader/archive/ArchiveFactory.cpp:71 >>> +#if PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(QT) >> >> Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] > > Do you know what other platform enable MHTML other than EFL/GTK/Qt? Perhaps that platform should use the new mime-type as well. The build systems of the in-tree ports and the FeatureList.pm module show that only these three ports enable MHTML. 891295 6 mrobinson 2013-05-20 12:36:11 -0700 (In reply to comment #5) > The build systems of the in-tree ports and the FeatureList.pm module show that only these three ports enable MHTML. So perhaps this can just be simplified to #if ENABLE(MATHML) then? 891298 7 zan 2013-05-20 12:38:56 -0700 Ah, of course. Wasn't looking at it that way. 891305 8 202307 zan 2013-05-20 12:48:22 -0700 Created attachment 202307 Patch 891574 9 zan 2013-05-20 23:03:23 -0700 The relevant shared-mime-info patch: http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4 891575 10 202307 zan 2013-05-20 23:07:50 -0700 Comment on attachment 202307 Patch Clearing flags on attachment: 202307 Committed r150418: <http://trac.webkit.org/changeset/150418> 891576 11 zan 2013-05-20 23:07:56 -0700 All reviewed patches have been landed. Closing bug. 202282 2013-05-20 09:44:14 -0700 2013-05-20 12:48:17 -0700 Patch bug-116442-20130520184303.patch text/plain 1664 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjVjMGNkZTY0MDk1MTI1 YzdmZTU1ODE2MjM2NDA3NzU0Njg5NmMxNS4uMmEyM2MyMTI3Mzk1NTNlYjU0MjA0YWViMTRiZGFj MDA3MTMyNWY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTIwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTdXBwb3J0 IGFwcGxpY2F0aW9uL3gtbWltZWFyY2hpdmUgbWltZXR5cGUgZm9yIE1IVE1MIGFyY2hpdmVzIGlu c3RlYWQgb2YgbWVzc2FnZS9yZmM4MjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNjQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6YXJjaGl2ZU1JTUVUeXBlcyk6IExpa2UgRUZMIGFuZCBRdCwgcmVnaXN0 ZXIgdGhlIGFwcGxpY2F0aW9uL3gtbWltZWFyY2hpdmUgbWltZSB0eXBlIGFzIGEgTUhUTUwgYXJj aGl2ZSB0eXBlCisgICAgICAgIGFuZCBzdG9wIHByb3BhZ2F0aW5nIHRoZSBtZXNzYWdlL3JmYzgy MiBtaW1lIHR5cGUgYXMgc3VjaC4KKwogMjAxMy0wNS0yMCAgTGFtYXJxdWUgVi4gU291emEgIDxM YW1hcnF1ZS5Tb3V6YUBiYXN5c2tvbS5jb20+CiAKICAgICAgICAgLXdlYmtpdC10ZXh0LXVuZGVy bGluZS1wb3NpdGlvbiBzaG91bGQgbm90IGJlIGluaGVyaXRlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3BwIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3BwCmluZGV4IGE5ODkxNTQ0MGQ2NDlj ZjZkODg2NWIyZmUxMWVmYTg1NWJhZjk3ODMuLmU1ZWQ1M2YxYzJkMjg3ZGQ5ODU3M2Q0MWM2Nzc2 YWJmZDYzNTE1NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9hcmNoaXZlL0Fy Y2hpdmVGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXJjaGl2ZS9BcmNo aXZlRmFjdG9yeS5jcHAKQEAgLTY4LDkgKzY4LDcgQEAgc3RhdGljIEFyY2hpdmVNSU1FVHlwZXNN YXAmIGFyY2hpdmVNSU1FVHlwZXMoKQogI2VuZGlmCiAjaWYgRU5BQkxFKE1IVE1MKQogICAgIG1p bWVUeXBlcy5zZXQoIm11bHRpcGFydC9yZWxhdGVkIiwgYXJjaGl2ZUZhY3RvcnlDcmVhdGU8TUhU TUxBcmNoaXZlPik7Ci0jaWYgUExBVEZPUk0oR1RLKQotICAgIG1pbWVUeXBlcy5zZXQoIm1lc3Nh Z2UvcmZjODIyIiwgYXJjaGl2ZUZhY3RvcnlDcmVhdGU8TUhUTUxBcmNoaXZlPik7Ci0jZWxpZiBQ TEFURk9STShRVCkgfHwgUExBVEZPUk0oRUZMKQorI2lmIFBMQVRGT1JNKEVGTCkgfHwgUExBVEZP Uk0oR1RLKSB8fCBQTEFURk9STShRVCkKICAgICBtaW1lVHlwZXMuc2V0KCJhcHBsaWNhdGlvbi94 LW1pbWVhcmNoaXZlIiwgYXJjaGl2ZUZhY3RvcnlDcmVhdGU8TUhUTUxBcmNoaXZlPik7CiAjZW5k aWYKICNlbmRpZgo= 202307 2013-05-20 12:48:22 -0700 2013-05-20 23:07:49 -0700 Patch bug-116442-20130520214712.patch text/plain 1741 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM1NGU5NTE3ODQwOWNh MThiYzM3MjlmMDVkZjJmNDliNjFiNmE3MC4uMzlkYjMzZWIyMmQ3YmUxOWYwMDk1MTAyNGY4N2Yw MjJkNDZmMjFhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTIwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTdXBwb3J0 IGFwcGxpY2F0aW9uL3gtbWltZWFyY2hpdmUgbWltZXR5cGUgZm9yIE1IVE1MIGFyY2hpdmVzIGlu c3RlYWQgb2YgbWVzc2FnZS9yZmM4MjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNjQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6YXJjaGl2ZU1JTUVUeXBlcyk6IExpa2UgRUZMIGFuZCBRdCwgcmVnaXN0 ZXIgdGhlIGFwcGxpY2F0aW9uL3gtbWltZWFyY2hpdmUgbWltZSB0eXBlIGFzIGEgTUhUTUwgYXJj aGl2ZSB0eXBlCisgICAgICAgIGFuZCBzdG9wIHByb3BhZ2F0aW5nIHRoZSBtZXNzYWdlL3JmYzgy MiBtaW1lIHR5cGUgYXMgc3VjaC4gVGhpcyBhbHNvIHJlbW92ZXMgYSBjb3VwbGUgb2YgUExBVEZP Uk0gaWZkZWZzLgorCiAyMDEzLTA1LTIwICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc11bQ1NTIEV4Y2x1c2lvbnNdIHNoYXBlLWluc2lk ZSBvbiByZWdpb25zIHNob3VsZCByZXNwZWN0IHBvc2l0aW9uZWQgc2hhcGVzIGFuZCBvdmVyZmxv dwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3Rv cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvQXJjaGl2ZUZhY3RvcnkuY3Bw CmluZGV4IGE5ODkxNTQ0MGQ2NDljZjZkODg2NWIyZmUxMWVmYTg1NWJhZjk3ODMuLjYyNzAwOWYx NjI0ZWJlZjgxYzkzODA4NGY2OTQ4ODY0ZWVjNjNkNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9hcmNoaXZlL0FyY2hpdmVGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvYXJjaGl2ZS9BcmNoaXZlRmFjdG9yeS5jcHAKQEAgLTY4LDEyICs2OCw4IEBAIHN0 YXRpYyBBcmNoaXZlTUlNRVR5cGVzTWFwJiBhcmNoaXZlTUlNRVR5cGVzKCkKICNlbmRpZgogI2lm IEVOQUJMRShNSFRNTCkKICAgICBtaW1lVHlwZXMuc2V0KCJtdWx0aXBhcnQvcmVsYXRlZCIsIGFy Y2hpdmVGYWN0b3J5Q3JlYXRlPE1IVE1MQXJjaGl2ZT4pOwotI2lmIFBMQVRGT1JNKEdUSykKLSAg ICBtaW1lVHlwZXMuc2V0KCJtZXNzYWdlL3JmYzgyMiIsIGFyY2hpdmVGYWN0b3J5Q3JlYXRlPE1I VE1MQXJjaGl2ZT4pOwotI2VsaWYgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEVGTCkKICAgICBt aW1lVHlwZXMuc2V0KCJhcHBsaWNhdGlvbi94LW1pbWVhcmNoaXZlIiwgYXJjaGl2ZUZhY3RvcnlD cmVhdGU8TUhUTUxBcmNoaXZlPik7CiAjZW5kaWYKLSNlbmRpZgogCiAgICAgaW5pdGlhbGl6ZWQg PSB0cnVlOwogICAgIHJldHVybiBtaW1lVHlwZXM7Cg==