116420 2013-05-19 16:42:16 -0700 [Mac] REGRESSION (r107844): text/url-list handling in Clipboard’s getData is wrong 2017-09-27 12:51:36 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 darin wenson_hsieh sam webkit-bug-importer wenson_hsieh oldest_to_newest 891078 0 darin 2013-05-19 16:42:16 -0700 I noticed a mistake by code inspection. Only the last URL in the list works. And I guess we have no regression tests for this. I suppose I’ll have to make one. 891079 1 202246 darin 2013-05-19 16:44:49 -0700 Created attachment 202246 Patch 891080 2 darin 2013-05-19 16:45:13 -0700 No review flag because there’s no test yet. 891090 3 sam 2013-05-19 17:15:46 -0700 (In reply to comment #2) > No review flag because there’s no test yet. I think setData is wrong as well. What we probably should be doing is parsing the string in setData to get the list of URLs (the format for text/uri-list specified at http://tools.ietf.org/html/rfc2483#section-5) and then we should be writing those URLs to the NSPasteboard using [pasteboard writeObjects:nsArrayOfURLs]; 1347275 4 darin 2017-09-10 13:31:11 -0700 Wenson, any interest in tackling this? You can see reading Pasteboard::readString that it has a loop, but throws away the results from all but the last iteration of the loop. 1347276 5 wenson_hsieh 2017-09-10 13:36:15 -0700 (In reply to Darin Adler from comment #4) > Wenson, any interest in tackling this? > > You can see reading Pasteboard::readString that it has a loop, but throws > away the results from all but the last iteration of the loop. Yep, sounds like something I can look into! 1350856 6 darin 2017-09-20 11:09:03 -0700 This code and feature was removed in r222257 so this no longer needs to be done. 1350858 7 darin 2017-09-20 11:10:01 -0700 https://trac.webkit.org/changeset/222257 1353689 8 webkit-bug-importer 2017-09-27 12:51:36 -0700 <rdar://problem/34694155> 202246 2013-05-19 16:44:49 -0700 2013-05-19 16:44:49 -0700 Patch bug-116420-20130519164340.patch text/plain 2219 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ3OTNhMzM1OWQwYzI3 Y2UyYzUyOTc1ZGQ2ZDkxNDlkYTEzYzA3YS4uODYyMjNmODBkYmUyNjY3MGM2NTE2Y2NhYzA5ZDhl MDlkZWRkZDcyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA1LTE5ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBbTWFjXSBSRUdSRVNTSU9OIChy MTA3ODQ0KTogdGV4dC91cmwtbGlzdCBoYW5kbGluZyBpbiBDbGlwYm9hcmTigJlzIGdldERhdGEg aXMgd3JvbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjQyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Bhc3RlYm9h cmRNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjpyZWFkU3RyaW5nKTogVXNl IGEgU3RyaW5nQnVpbGRlciB0byBidWlsZCB1cCB0aGUgc3RyaW5nLgorICAgICAgICBUaGUgb2xk IGNvZGUgd291bGQganVzdCBvYmxpdGVyYXRlIGVhY2ggc3RyaW5nIHdpdGggdGhlIG5leHQgb25l LgorCisyMDEzLTA1LTE5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKwogICAgICAg ICBVc2UgRWxlbWVudCBpbnN0ZWFkIG9mIE5vZGUgaW4gRHJhZ1N0YXRlLCBhbHNvIHJlZG8gRHJh Z1N0YXRlIHN0cnVjdAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE2NDExCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9Q YXN0ZWJvYXJkTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Bhc3RlYm9hcmRN YWMubW0KaW5kZXggMWRkNGE2MGU5ODJmNzg5NzMyZjBhZjBlYmVjYWM4NDM1NGVhZDBmNC4uZmQy MTMyZjdjMjQwZTMwOTYxODVlYTY4Y2MwYTkzZGQ4YzAwZjNlZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Bhc3RlYm9hcmRNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Bhc3RlYm9hcmRNYWMubW0KQEAgLTcwNiw4ICs3MDYsMTMgQEAgU3Ry aW5nIFBhc3RlYm9hcmQ6OnJlYWRTdHJpbmcoY29uc3QgU3RyaW5nJiB0eXBlKQogICAgICAgICAv LyAidXJsIiBhbmQgInRleHQvdXJsLWxpc3QiIGJvdGggbWFwIHRvIE5TVVJMUGJvYXJkVHlwZSBp biBjb2NvYVR5cGVGcm9tSFRNTENsaXBib2FyZFR5cGUoKSwgInVybCIgb25seSB3YW50cyB0aGUg Zmlyc3QgVVJMCiAgICAgICAgIGJvb2wgb25seUZpcnN0VVJMID0gKGVxdWFsSWdub3JpbmdDYXNl KHR5cGUsICJ1cmwiKSk7CiAgICAgICAgIFZlY3RvcjxTdHJpbmc+IGFic29sdXRlVVJMcyA9IGFi c29sdXRlVVJMc0Zyb21QYXN0ZWJvYXJkKG1fcGFzdGVib2FyZE5hbWUsIG9ubHlGaXJzdFVSTCk7 Ci0gICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgYWJzb2x1dGVVUkxzLnNpemUoKTsgaSsr KQotICAgICAgICAgICAgY29jb2FWYWx1ZSA9IGkgPyAiXG4iICsgYWJzb2x1dGVVUkxzW2ldOiBh YnNvbHV0ZVVSTHNbaV07CisgICAgICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICAgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBhYnNvbHV0ZVVSTHMuc2l6ZSgpOyBpKyspIHsKKyAgICAg ICAgICAgIGlmIChpKQorICAgICAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCdcbicpOworICAg ICAgICAgICAgYnVpbGRlci5hcHBlbmQoYWJzb2x1dGVVUkxzW2ldKTsKKyAgICAgICAgfQorICAg ICAgICBjb2NvYVZhbHVlID0gYnVpbGRlci50b1N0cmluZygpOwogICAgIH0gZWxzZSBpZiAoY29j b2FUeXBlID09IFN0cmluZyhOU1N0cmluZ1Bib2FyZFR5cGUpKQogICAgICAgICBjb2NvYVZhbHVl ID0gW3BsYXRmb3JtU3RyYXRlZ2llcygpLT5wYXN0ZWJvYXJkU3RyYXRlZ3koKS0+c3RyaW5nRm9y VHlwZShjb2NvYVR5cGUsIG1fcGFzdGVib2FyZE5hbWUpIHByZWNvbXBvc2VkU3RyaW5nV2l0aENh bm9uaWNhbE1hcHBpbmddOwogICAgIGVsc2UgaWYgKCFjb2NvYVR5cGUuaXNFbXB0eSgpKQo=