116410 2013-05-19 04:53:49 -0700 Eliminate the Editor::newGeneralClipboard function 2013-05-19 08:39:52 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue oldest_to_newest 891015 0 darin 2013-05-19 04:53:49 -0700 Eliminate the Editor::newGeneralClipboard function 891016 1 202230 darin 2013-05-19 04:57:01 -0700 Created attachment 202230 Patch 891028 2 202230 kling 2013-05-19 08:18:31 -0700 Comment on attachment 202230 Patch r=me. Not sure what's up with mac-wk2 ews, it looks suspicious but I don't see how this patch would be the cause: Regressions: Unexpected text-only failures (3) editing/execCommand/copy-without-selection.html [ Failure ] editing/pasteboard/copy-two-pasteboard-types-both-work.html [ Failure ] editing/pasteboard/pasting-empty-html-falls-back-to-text.html [ Failure ] 891032 3 202230 commit-queue 2013-05-19 08:39:51 -0700 Comment on attachment 202230 Patch Clearing flags on attachment: 202230 Committed r150351: <http://trac.webkit.org/changeset/150351> 891033 4 commit-queue 2013-05-19 08:39:52 -0700 All reviewed patches have been landed. Closing bug. 202230 2013-05-19 04:57:01 -0700 2013-05-19 08:39:51 -0700 Patch bug-116410-20130519045552.patch text/plain 7049 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTA2NTBiYTRiNjI0NGZl MjJjMTc1ZTk3M2E1NzViMWJhMWViYzkyOC4uOTU2MTEwMmUyNTNkYTZiMjdhYmZiZmM4NmVkYzQ0 YWFkNDBlMzRkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTA1LTE5ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBFbGltaW5hdGUgdGhlIEVkaXRv cjo6bmV3R2VuZXJhbENsaXBib2FyZCBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBvbmUgb2YgdGhlIGNsZWFuLXVwcyBtYWRl IHBvc3NpYmxlIGJ5IHRoZSBjaGFuZ2VzIHRvIHRoZSBET00gY2xpcGJvYXJkIGNsYXNzLgorICAg ICAgICBJIGhhZCBiZWVuIHdhaXRpbmcgdW50aWwgYWxsIHRoZSBwbGF0Zm9ybXMgd2VyZSBtb3Zl ZCBvdmVyIHRvIGl0LCBidXQgaXQgdHVybnMgb3V0IHRvIGJlCisgICAgICAgIGVhc3kgdG8gZG8g dGhpcyBub3csIGp1c3Qgd2l0aCAjaWZkZWZzLgorCisgICAgICAgICogUGxhdGZvcm1CbGFja0Jl cnJ5LmNtYWtlOiBEZWxldGVkIEVkaXRvckJsYWNrQmVycnkuY3BwLgorCisgICAgICAgICogZWRp dGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpkaXNwYXRjaENQUEV2 ZW50KTogQ2FsbCBDbGlwYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSBkaXJlY3RseSB3aGVu CisgICAgICAgIHVzaW5nIHRoZSBuZXcgdmVyc2lvbiBvZiB0aGUgQ2xpcGJvYXJkIGNsYXNzLiBB bHNvIHNvbWUgc21hbGwgc3R5bGUgY2xlYW51cCBuZWFyYnkuCisKKyAgICAgICAgKiBlZGl0aW5n L2JsYWNrYmVycnkvRWRpdG9yQmxhY2tCZXJyeS5jcHA6IFJlbW92ZWQuIFRoZSBvbmx5IGZ1bmN0 aW9uIGluIHRoaXMgZmlsZSB3YXMKKyAgICAgICAgbmV3R2VuZXJhbENsaXBib2FyZC4KKworICAg ICAgICAqIGVkaXRpbmcvbWFjL0VkaXRvck1hYy5tbTogRGVsZXRlZCBuZXdHZW5lcmFsQ2xpcGJv YXJkLgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9DbGlwYm9hcmRFZmwuY3BwOiBEaXR0by4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmNwcDogRGl0dG8uCisKIDIwMTMtMDUt MTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgSG9p c3Qgc2V2ZXJhbCBjaHVua3Mgb2YgY29kZSBhdCB0aGUgdG9wIG9mIFJlbmRlckxheWVyOjpwYWlu dExheWVyQ29udGVudHMoKSBvbnRvIG5ldyBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3Jt QmxhY2tCZXJyeS5jbWFrZQppbmRleCBlOTAwOWE3M2JmNTkwYTQ0NTc4NGVkMjg0NmRmOTRjMzEw YjQ2MzNkLi4xNzM2ZjVmNDJiZDlkOTVlMmJmMDY3OTM5NWNhMGU3M2YxZGQ3MGIzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKKysrIGIvU291cmNl L1dlYkNvcmUvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlCkBAIC05Myw3ICs5Myw2IEBAIGxpc3Qo QVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogCiAjIEJsYWNrQmVycnkgc291cmNl cwogbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgZWRpdGluZy9ibGFja2JlcnJ5L0Vk aXRvckJsYWNrQmVycnkuY3BwCiAgICAgZWRpdGluZy9ibGFja2JlcnJ5L1NtYXJ0UmVwbGFjZUJs YWNrQmVycnkuY3BwCiAgICAgaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sc0JsYWNrQmVycnkuY3Bw CiAgICAgcGFnZS9ibGFja2JlcnJ5L0FjY2Vzc2liaWxpdHlPYmplY3RCbGFja0JlcnJ5LmNwcApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwIGIvU291cmNlL1dl YkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4IGVjNWM4OWRkYWUyNDFjMjUzYmQ4YzAxZTA3 YjA2M2QwMTAzYWE4MjEuLmMyNTkzMzljMjJlOWZiZTEwYmEzMzFmZWYwNTQ2NWVjYzc3YWNhN2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTY5NywxNyArNjk3LDIyIEBAIHZvaWQg RWRpdG9yOjpjbGVhckxhc3RFZGl0Q29tbWFuZCgpCiAKIC8vIFJldHVybnMgd2hldGhlciBjYWxs ZXIgc2hvdWxkIGNvbnRpbnVlIHdpdGggInRoZSBkZWZhdWx0IHByb2Nlc3NpbmciLCB3aGljaCBp cyB0aGUgc2FtZSBhcyAKIC8vIHRoZSBldmVudCBoYW5kbGVyIE5PVCBzZXR0aW5nIHRoZSByZXR1 cm4gdmFsdWUgdG8gZmFsc2UKLWJvb2wgRWRpdG9yOjpkaXNwYXRjaENQUEV2ZW50KGNvbnN0IEF0 b21pY1N0cmluZyAmZXZlbnRUeXBlLCBDbGlwYm9hcmRBY2Nlc3NQb2xpY3kgcG9saWN5KQorYm9v bCBFZGl0b3I6OmRpc3BhdGNoQ1BQRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUs IENsaXBib2FyZEFjY2Vzc1BvbGljeSBwb2xpY3kpCiB7CiAgICAgTm9kZSogdGFyZ2V0ID0gZmlu ZEV2ZW50VGFyZ2V0RnJvbVNlbGVjdGlvbigpOwogICAgIGlmICghdGFyZ2V0KQogICAgICAgICBy ZXR1cm4gdHJ1ZTsKLSAgICAKKworI2lmICFVU0UoTEVHQUNZX1NUWUxFX0FCU1RSQUNUX0NMSVBC T0FSRF9DTEFTUykKKyAgICBSZWZQdHI8Q2xpcGJvYXJkPiBjbGlwYm9hcmQgPSBDbGlwYm9hcmQ6 OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZShwb2xpY3kpOworI2Vsc2UKKyAgICAvLyBGSVhNRTogUmVt b3ZlIGRlY2xhcmF0aW9uIG9mIG5ld0dlbmVyYWxDbGlwYm9hcmQgd2hlbiByZW1vdmluZyBMRUdB Q1lfU1RZTEVfQUJTVFJBQ1RfQ0xJUEJPQVJEX0NMQVNTLgogICAgIFJlZlB0cjxDbGlwYm9hcmQ+ IGNsaXBib2FyZCA9IG5ld0dlbmVyYWxDbGlwYm9hcmQocG9saWN5LCBtX2ZyYW1lKTsKKyNlbmRp ZgogCi0gICAgUmVmUHRyPEV2ZW50PiBldnQgPSBDbGlwYm9hcmRFdmVudDo6Y3JlYXRlKGV2ZW50 VHlwZSwgdHJ1ZSwgdHJ1ZSwgY2xpcGJvYXJkKTsKLSAgICB0YXJnZXQtPmRpc3BhdGNoRXZlbnQo ZXZ0LCBJR05PUkVfRVhDRVBUSU9OKTsKLSAgICBib29sIG5vRGVmYXVsdFByb2Nlc3NpbmcgPSBl dnQtPmRlZmF1bHRQcmV2ZW50ZWQoKTsKKyAgICBSZWZQdHI8RXZlbnQ+IGV2ZW50ID0gQ2xpcGJv YXJkRXZlbnQ6OmNyZWF0ZShldmVudFR5cGUsIHRydWUsIHRydWUsIGNsaXBib2FyZCk7CisgICAg dGFyZ2V0LT5kaXNwYXRjaEV2ZW50KGV2ZW50LCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBib29s IG5vRGVmYXVsdFByb2Nlc3NpbmcgPSBldmVudC0+ZGVmYXVsdFByZXZlbnRlZCgpOwogICAgIGlm IChub0RlZmF1bHRQcm9jZXNzaW5nICYmIHBvbGljeSA9PSBDbGlwYm9hcmRXcml0YWJsZSkgewog ICAgICAgICBQYXN0ZWJvYXJkKiBwYXN0ZWJvYXJkID0gUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3Rl Ym9hcmQoKTsKICAgICAgICAgcGFzdGVib2FyZC0+Y2xlYXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvYmxhY2tiZXJyeS9FZGl0b3JCbGFja0JlcnJ5LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvYmxhY2tiZXJyeS9FZGl0b3JCbGFja0JlcnJ5LmNwcApkZWxldGVk IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMWFkZWNmM2IzMjI5NmQ1OWM0ZTBhNTdkODcyMzIwMGFi MmQ2YjQ5My4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL2JsYWNrYmVycnkvRWRpdG9yQmxhY2tCZXJyeS5jcHAKKysr IC9kZXYvbnVsbApAQCAtMSwzMiArMCwwIEBACi0vKgotICogQ29weXJpZ2h0IChDKSAyMDA5IFRv cmNoIE1vYmlsZSBJbmMuIGh0dHA6Ly93d3cudG9yY2htb2JpbGUuY29tLwotICogQ29weXJpZ2h0 IChDKSAyMDEwLCAyMDExIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJl c2VydmVkLgotICoKLSAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl ZGlzdHJpYnV0ZSBpdCBhbmQvb3IKLSAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKLSAqIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRo ZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgotICogdmVyc2lvbiAyIG9mIHRoZSBM aWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgotICoKLSAqIFRo aXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAotICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxp ZWQgd2FycmFudHkgb2YKLSAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCi0gKiBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGlj ZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgotICoKLSAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBh IGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKLSAqIExpY2Vuc2UgYWxvbmcg d2l0aCB0aGlzIGxpYnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKLSAq IEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3Rv biwgTUEgIDAyMTEwLTEzMDEgIFVTQQotICovCi0KLSNpbmNsdWRlICJjb25maWcuaCIKLSNpbmNs dWRlICJFZGl0b3IuaCIKLQotI2luY2x1ZGUgIkNsaXBib2FyZC5oIgotCi1uYW1lc3BhY2UgV2Vi Q29yZSB7Ci0KLVBhc3NSZWZQdHI8Q2xpcGJvYXJkPiBFZGl0b3I6Om5ld0dlbmVyYWxDbGlwYm9h cmQoQ2xpcGJvYXJkQWNjZXNzUG9saWN5IHBvbGljeSwgRnJhbWUqKQotewotICAgIHJldHVybiBD bGlwYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZShwb2xpY3kpOwotfQotCi19IC8vIG5hbWVz cGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0 b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMubW0KaW5kZXgg M2RhNWUyOTUwZjFhNmFhMDUwMzRjYjcxMjEzNmViODI0ZTE3MmQwMy4uODE4YTUyZTQ0OGVmM2Qy M2RmNThkYzgxOWRlY2M0MDlhOWIyM2I0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9tYWMvRWRpdG9yTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0Vk aXRvck1hYy5tbQpAQCAtNTcsMTEgKzU3LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2lu ZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCi1QYXNzUmVmUHRyPENsaXBib2FyZD4gRWRpdG9yOjpu ZXdHZW5lcmFsQ2xpcGJvYXJkKENsaXBib2FyZEFjY2Vzc1BvbGljeSBwb2xpY3ksIEZyYW1lKikK LXsKLSAgICByZXR1cm4gQ2xpcGJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUocG9saWN5KTsK LX0KLQogdm9pZCBFZGl0b3I6OnNob3dGb250UGFuZWwoKQogewogICAgIFtbTlNGb250TWFuYWdl ciBzaGFyZWRGb250TWFuYWdlcl0gb3JkZXJGcm9udEZvbnRQYW5lbDpuaWxdOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0NsaXBib2FyZEVmbC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ2xpcGJvYXJkRWZsLmNwcAppbmRleCBiZTE5YTVlODMxMmQ2 ZWQ0YjNhZTJmZGVhMDVlYTljOWMwZjcyMDlhLi44YmYxZWM1NDBkYzBhYTNmOTMwYzEzOTc1Zjhi MzVjM2VkNmE1MzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ2xp cGJvYXJkRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ2xpcGJvYXJk RWZsLmNwcApAQCAtMjcsMTEgKzI3LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1QYXNz UmVmUHRyPENsaXBib2FyZD4gRWRpdG9yOjpuZXdHZW5lcmFsQ2xpcGJvYXJkKENsaXBib2FyZEFj Y2Vzc1BvbGljeSBwb2xpY3ksIEZyYW1lKikKLXsKLSAgICByZXR1cm4gQ2xpcGJvYXJkOjpjcmVh dGVGb3JDb3B5QW5kUGFzdGUocG9saWN5KTsKLX0KLQogRHJhZ0ltYWdlUmVmIENsaXBib2FyZDo6 Y3JlYXRlRHJhZ0ltYWdlKEludFBvaW50JikgY29uc3QKIHsKICAgICBub3RJbXBsZW1lbnRlZCgp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZEd0ay5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmNwcAppbmRleCBk Nzk1Y2Y1NzY2NTg2YTA3YzE5NWJmOThjYzNlODgzZjZiNWVjYzJiLi5kMzg4YjViNmMxNzBmN2Nk MzVlYzQwN2VmMWFhZWFmNGM0ZjZiMjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvQ2xpcGJvYXJkR3RrLmNwcApAQCAtMjYsMTIgKzI2LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCi0vLyBGSVhNRTogdGhpcyBzaG91bGQgYmUgbW92ZWQgdG8gZWRpdGluZy9ndGsvRWRp dG9yR3RrLmNwcC4KLVBhc3NSZWZQdHI8Q2xpcGJvYXJkPiBFZGl0b3I6Om5ld0dlbmVyYWxDbGlw Ym9hcmQoQ2xpcGJvYXJkQWNjZXNzUG9saWN5IHBvbGljeSwgRnJhbWUqIGZyYW1lKQotewotICAg IHJldHVybiBDbGlwYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZShwb2xpY3kpOwotfQotCiBE cmFnSW1hZ2VSZWYgQ2xpcGJvYXJkOjpjcmVhdGVEcmFnSW1hZ2UoSW50UG9pbnQmIGxvY2F0aW9u KSBjb25zdAogewogICAgIGxvY2F0aW9uID0gbV9kcmFnTG9jOwo=