116396 2013-05-18 13:21:14 -0700 [GTK] Build filed after removing dead local storage code in r150305 2013-08-29 03:03:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 116389 P1 Blocker --- 0 oleg_smirnov webkit-unassigned andersca bdakin cdumez oleg_smirnov oldest_to_newest 890943 0 oleg_smirnov 2013-05-18 13:21:14 -0700 Steps to reproduce: ./Tools/Scripts/build-webkit --gtk Build error log: GEN DerivedSources/JavaScriptCore/LLIntAssembly.h offlineasm: Parsing ../../Source/JavaScriptCore/llint/LowLevelInterpreter.asm and Programs/LLIntOffsetsExtractor and creating assembly file DerivedSources/JavaScriptCore/LLIntAssembly.h. CXX Source/WebKit2/WebProcess/WebPage/libwebkit2gtk_3_0_la-WebPageGroupProxy.lo ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp: In constructor 'WebKit::WebPageGroupProxy::WebPageGroupProxy(const WebKit::WebPageGroupData&)': ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:66:84: error: 'class WebKit::WebKeyValueStorageManager' has no member named 'indexedDBDatabaseDirectory' In file included from ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:29:0: ../../Source/WebKit2/WebProcess/WebProcess.h: In instantiation of 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:65:116: required from here ../../Source/WebKit2/WebProcess/WebProcess.h:90:70: error: invalid static_cast from type 'WTF::HashMap<const char*, WTF::OwnPtr<WebKit::WebProcessSupplement>, WTF::PtrHash<const char*> >::MappedPeekType {aka WebKit::WebProcessSupplement*}' to type 'WebKit::WebKeyValueStorageManager*' ../../Source/WebKit2/WebProcess/WebProcess.h: In member function 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': ../../Source/WebKit2/WebProcess/WebProcess.h:91:5: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [Source/WebKit2/WebProcess/WebPage/libwebkit2gtk_3_0_la-WebPageGroupProxy.lo] Ошибка 1 make[1]: *** Ожидание завершения заданий... offlineasm: Nothing changed. make[1]: Выход из каталога `/media/DOCUMENTS/WebKit/WebKitBuild/Release' make: *** [all] Ошибка 2 890946 1 202215 oleg_smirnov 2013-05-18 13:52:39 -0700 Created attachment 202215 Patch 890947 2 202215 commit-queue 2013-05-18 14:02:17 -0700 Comment on attachment 202215 Patch Rejecting attachment 202215 from review queue. oleg_smirnov@hotmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 890948 3 202215 commit-queue 2013-05-18 14:02:51 -0700 Comment on attachment 202215 Patch Rejecting attachment 202215 from commit-queue. oleg_smirnov@hotmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 890950 4 cdumez 2013-05-18 14:21:58 -0700 *** This bug has been marked as a duplicate of bug 116389 *** 922385 5 202215 zan 2013-08-29 03:03:10 -0700 Comment on attachment 202215 Patch Clearing the review and commit-queue flags on the patch. 202215 2013-05-18 13:52:39 -0700 2013-08-29 03:03:08 -0700 Patch bug-116396-20130519005130.patch text/plain 1713 oleg_smirnov U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTVjODZhZDU1NDY1MTUy YzE4MWNlNWRjMWMwNjIxNGE3ZDgxYzg4YS4uMmMwMGQzNjNlOTY1MzA3MmZiNWU2OWM5MTdiMTE5 M2Q0MDdmMTUzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTE4ICBPbGVn IFNtaXJub3YgIDxvbGVnX3NtaXJub3ZAaG90bWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gQnVp bGQgZmlsZWQgYWZ0ZXIgcmVtb3ZpbmcgZGVhZCBsb2NhbCBzdG9yYWdlIGNvZGUgaW4gcjE1MDMw NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2Mzk2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl ZCBtaXNzZWQgY29kZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlR3Jv dXBQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VHcm91cFByb3h5OjpXZWJQYWdl R3JvdXBQcm94eSk6CisKIDIwMTMtMDUtMTggIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgW0NNYWtlXSBSZXBsYWNlICpfTElCUkFSWV9OQU1FIHdpdGgg Kl9PVVRQVVRfTkFNRQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2VHcm91cFByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlR3JvdXBQcm94eS5jcHAKaW5kZXggZjQ4OGYyMDhkNjAyMGZhYWY2NTU5M2Ji NWRlOWRhMWI5N2U5NDNjYy4uZGJjN2FlNzA5ZTQwZWY4YmYwZjFiODFjYzFlZDNjMzMxOWVkZmNk NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2VH cm91cFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZUdyb3VwUHJveHkuY3BwCkBAIC02MCwxMSArNjAsNiBAQCBXZWJQYWdlR3JvdXBQcm94eTo6 V2ViUGFnZUdyb3VwUHJveHkoY29uc3QgV2ViUGFnZUdyb3VwRGF0YSYgZGF0YSkKICAgICAgICAg YWRkVXNlclN0eWxlU2hlZXQoZGF0YS51c2VyU3R5bGVTaGVldHNbaV0pOwogICAgIGZvciAoc2l6 ZV90IGkgPSAwOyBpIDwgZGF0YS51c2VyU2NyaXB0cy5zaXplKCk7ICsraSkKICAgICAgICAgYWRk VXNlclNjcmlwdChkYXRhLnVzZXJTY3JpcHRzW2ldKTsKLQotI2lmIEVOQUJMRShJTkRFWEVEX0RB VEFCQVNFKQotICAgIFdlYktleVZhbHVlU3RvcmFnZU1hbmFnZXIqIGtleVZhbHVlU3RvcmFnZU1h bmFnZXIgPSBXZWJQcm9jZXNzOjpzaGFyZWQoKS5zdXBwbGVtZW50PFdlYktleVZhbHVlU3RvcmFn ZU1hbmFnZXI+KCk7Ci0gICAgbV9wYWdlR3JvdXAtPmdyb3VwU2V0dGluZ3MoKS0+c2V0SW5kZXhl ZERCRGF0YWJhc2VQYXRoKGtleVZhbHVlU3RvcmFnZU1hbmFnZXItPmluZGV4ZWREQkRhdGFiYXNl RGlyZWN0b3J5KCkpOwotI2VuZGlmCiB9CiAKIHZvaWQgV2ViUGFnZUdyb3VwUHJveHk6OmFkZFVz ZXJTdHlsZVNoZWV0KGNvbnN0IFdlYkNvcmU6OlVzZXJTdHlsZVNoZWV0JiB1c2VyU3R5bGVTaGVl dCkK