116390 2013-05-18 02:43:51 -0700 [WK2] Regression(r150305): broke build if INDEXED_DATABASE is enabled 2013-05-18 14:25:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 116389 P2 Normal --- 116360 1 cdumez cdumez andersca bdakin benjamin cgarcia commit-queue dbates gyuyoung.kim laszlo.gombos ossy rakuco sam zan zecke oldest_to_newest 890864 0 cdumez 2013-05-18 02:43:51 -0700 <http://trac.webkit.org/changeset/150305> broke the WebKit2 build if INDEXED_DATABASE is enabled at compile time: [ 84%] [ 84%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/WebPageGroupProxy.cpp.o Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/WebUndoStep.cpp.o [ 84%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp.o /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp: In constructor 'WebKit::WebPageGroupProxy::WebPageGroupProxy(const WebKit::WebPageGroupData&)': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:66:84: error: 'class WebKit::WebKeyValueStorageManager' has no member named 'indexedDBDatabaseDirectory' In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:29:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebProcess.h: In member function 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:65:116: instantiated from here /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebProcess.h:90:70: error: invalid static_cast from type 'WTF::HashMap<const char*, WTF::OwnPtr<WebKit::WebProcessSupplement>, WTF::PtrHash<const char*> >::MappedPeekType {aka WebKit::WebProcessSupplement*}' to type 'WebKit::WebKeyValueStorageManager*' /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebProcess.h:91:5: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors 890865 1 cdumez 2013-05-18 02:45:27 -0700 I temporarily disabled INDEXED_DATABASE at compile-time for EFL to quickly fix the build and put our bots back up <http://trac.webkit.org/changeset/150335>. We need to reenable this as soon as the build issue is addressed. 890866 2 202199 cdumez 2013-05-18 03:01:10 -0700 Created attachment 202199 Patch Andersca, is it the proper way to fix it or is more work involved? 890876 3 202199 zan 2013-05-18 04:01:19 -0700 Comment on attachment 202199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202199&action=review > Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:-67 > -#endif Removing this fixes the build failures, but it also stops setting the path for the IDB database. I don't think that's quite OK. 890879 4 zan 2013-05-18 04:27:58 -0700 *** This bug has been marked as a duplicate of bug 116389 *** 890884 5 zan 2013-05-18 04:50:36 -0700 I (accidentally) marked this bug as a dupe of bug #116389, but feel free to switch the duplicate resolution as you please. My main interest is still to get the build failures resolved ASAP. Sorry for the noise. 890957 6 cdumez 2013-05-18 14:25:53 -0700 (In reply to comment #5) > I (accidentally) marked this bug as a dupe of bug #116389, but feel free to switch the duplicate resolution as you please. My main interest is still to get the build failures resolved ASAP. Sorry for the noise. Sure, no problem. Sorry I failed to notice someone had already fixed a bug. I can reenable INDEXED_DATABASE on EFL in a separate patch later on. 202199 2013-05-18 03:01:10 -0700 2013-05-18 14:24:39 -0700 Patch 116390_indexeddb_wk2.patch text/plain 6175 cdumez ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4YWNmNGY2Li4yM2I1MDc1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTMtMDUtMTggIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29t PgogCisgICAgICAgIFtXSzJdIFJlZ3Jlc3Npb24ocjE1MDMwNSk6IGJyb2tlIGJ1aWxkIGlmIElO REVYRURfREFUQUJBU0UgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVuYWJsZSBJTkRFWEVEX0RBVEFCQVNFIGZvciBFRkwgcG9ydC4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorCisyMDEzLTA1LTE4 ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KKwogICAgICAg ICBVbnJldmlld2VkIEVGTCBidWlsZCBmaXguCiAKICAgICAgICAgVGVtcG9yYXJpbHkgZGlzYWJs ZWQgSU5ERVhFRF9EQVRBQkFTRSBhdCBjb21waWxlLXRpbWUgYXMgaXQgYnJlYWtzCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg M2Q5NDRhOS4uYmFjNDRhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA1LTE4ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KIAorICAgICAgICBbV0sy XSBSZWdyZXNzaW9uKHIxNTAzMDUpOiBicm9rZSBidWlsZCBpZiBJTkRFWEVEX0RBVEFCQVNFIGlz IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlZW5hYmxlIGluZGV4ZWRkYiBsYXlvdXQgdGVzdHMgZm9yIEVGTCBwb3J0IG5vdyB0aGF0IHRo ZSBmdW5jdGlvbmFsaXR5CisgICAgICAgIGlzIE9OIGFnYWluLgorCisgICAgICAgICogcGxhdGZv cm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6CisKKzIwMTMtMDUtMTggIENocmlzdG9waGUgRHVtZXog IDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQgRUZMIGJ1 aWxkIGZpeC4KIAogICAgICAgICBTa2lwIGluZGV4ZWRkYiB0ZXN0IGNhc2VzIGFzIHRoZSBmZWF0 dXJlIGlzIHRlbXBvcmFyaWx5IGRpc2FibGVkIGR1ZSB0bwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxNTFiMjM1Li5lOTAzNTA2IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTc2NSwxMCArMTc2NSw2IEBAIHdl YmtpdC5vcmcvYi8xMTAzMzggZmFzdC9ldmVudHMvdG91Y2gvZW11bGF0ZS10b3VjaC1ldmVudHMu aHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTEwNDQ2IHN2Zy9hcy1iYWNrZ3JvdW5k LWltYWdlL3N2Zy10cmFuc2Zvcm1lZC1iYWNrZ3JvdW5kLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl IF0KIAotIyBJTkRFWEVEX0RBVEFCQVNFIGlzIHRlbXBvcmFyaWx5IGRpc2FibGVkIGF0IGJ1aWxk IHRpbWUgdW50aWwgV0syIGJ1aWxkIGlzIGZpeGVkLgotQnVnKEVGTCkgc3RvcmFnZS9pbmRleGVk ZGIKLUJ1ZyhFRkwpIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRkYgotCiAjIE5ldyB0ZXN0 CiB3ZWJraXQub3JnL2IvMTEwNjU0IGNzczMvZmxleGJveC9idXR0b24uaHRtbCBbIEZhaWx1cmUg XQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKaW5kZXggMDcyMjcwNS4uYTAwNjZjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEzLTA1LTE4ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1z dW5nLmNvbT4KKworICAgICAgICBbV0syXSBSZWdyZXNzaW9uKHIxNTAzMDUpOiBicm9rZSBidWls ZCBpZiBJTkRFWEVEX0RBVEFCQVNFIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSByZW1haW5pbmcgaW5kZXhlZERCIGNvZGUg ZnJvbSBXZWJQYWdlR3JvdXBQcm94eSB3aGljaCBzdG9wcGVkIGNvbXBpbGluZworICAgICAgICBh ZnRlciByMTUwMzA1LiBTdG9yYWdlIGlzIGFsbCBoYW5kbGVkIGluIHRoZSBVSSBwcm9jZXNzIG5v dy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlR3JvdXBQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VHcm91cFByb3h5OjpXZWJQYWdlR3JvdXBQcm94eSk6 CisKIDIwMTMtMDUtMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIE1vdmUgR1RLIHBvcnQgb2ZmIGxlZ2FjeSBjbGlwYm9hcmQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlR3JvdXBQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZUdyb3Vw UHJveHkuY3BwCmluZGV4IGY0ODhmMjAuLjkxNjRmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlR3JvdXBQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2VHcm91cFByb3h5LmNwcApAQCAtMzEs MTEgKzMxLDYgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0RPTVdyYXBwZXJXb3JsZC5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvUGFnZUdyb3VwLmg+CiAKLSNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkK LSNpbmNsdWRlICJXZWJLZXlWYWx1ZVN0b3JhZ2VNYW5hZ2VyLmgiCi0jaW5jbHVkZSA8V2ViQ29y ZS9Hcm91cFNldHRpbmdzLmg+Ci0jZW5kaWYKLQogbmFtZXNwYWNlIFdlYktpdCB7CiAKIFBhc3NS ZWZQdHI8V2ViUGFnZUdyb3VwUHJveHk+IFdlYlBhZ2VHcm91cFByb3h5OjpjcmVhdGUoY29uc3Qg V2ViUGFnZUdyb3VwRGF0YSYgZGF0YSkKQEAgLTYwLDExICs1NSw2IEBAIFdlYlBhZ2VHcm91cFBy b3h5OjpXZWJQYWdlR3JvdXBQcm94eShjb25zdCBXZWJQYWdlR3JvdXBEYXRhJiBkYXRhKQogICAg ICAgICBhZGRVc2VyU3R5bGVTaGVldChkYXRhLnVzZXJTdHlsZVNoZWV0c1tpXSk7CiAgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBkYXRhLnVzZXJTY3JpcHRzLnNpemUoKTsgKytpKQogICAgICAg ICBhZGRVc2VyU2NyaXB0KGRhdGEudXNlclNjcmlwdHNbaV0pOwotCi0jaWYgRU5BQkxFKElOREVY RURfREFUQUJBU0UpCi0gICAgV2ViS2V5VmFsdWVTdG9yYWdlTWFuYWdlcioga2V5VmFsdWVTdG9y YWdlTWFuYWdlciA9IFdlYlByb2Nlc3M6OnNoYXJlZCgpLnN1cHBsZW1lbnQ8V2ViS2V5VmFsdWVT dG9yYWdlTWFuYWdlcj4oKTsKLSAgICBtX3BhZ2VHcm91cC0+Z3JvdXBTZXR0aW5ncygpLT5zZXRJ bmRleGVkREJEYXRhYmFzZVBhdGgoa2V5VmFsdWVTdG9yYWdlTWFuYWdlci0+aW5kZXhlZERCRGF0 YWJhc2VEaXJlY3RvcnkoKSk7Ci0jZW5kaWYKIH0KIAogdm9pZCBXZWJQYWdlR3JvdXBQcm94eTo6 YWRkVXNlclN0eWxlU2hlZXQoY29uc3QgV2ViQ29yZTo6VXNlclN0eWxlU2hlZXQmIHVzZXJTdHls ZVNoZWV0KQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCA0MmI3Mzc5Li5lMjVkMWNmIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZQpAQCAtNzMsNyArNzMsNyBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfRkFTVF9NT0JJTEVfU0NST0xMSU5HIE9OKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZJTFRFUlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfRlVMTFNDUkVFTl9BUEkgT04pCiBXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0FNRVBBRCBPTikKLVdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9JTkRFWEVEX0RBVEFCQVNFIE9GRikKK1dFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9JTkRFWEVEX0RBVEFCQVNFIE9OKQogV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1IgT04pCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTElOS19QUkVGRVRDSCBPTikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MTElOVCBPTikKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOTc5YTI0Li4zNTgy OGJhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTYgQEAKIDIwMTMtMDUtMTggIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBz aXNhLnNhbXN1bmcuY29tPgogCisgICAgICAgIFtXSzJdIFJlZ3Jlc3Npb24ocjE1MDMwNSk6IGJy b2tlIGJ1aWxkIGlmIElOREVYRURfREFUQUJBU0UgaXMgZW5hYmxlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MzkwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVlbmFibGUgSU5ERVhFRF9EQVRBQkFT RSBmb3IgRUZMIHBvcnQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxp c3QucG06CisKKzIwMTMtMDUtMTggIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNh bXN1bmcuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQgRUZMIGJ1aWxkIGZpeC4KIAogICAgICAg ICBUZW1wb3JhcmlseSBkaXNhYmxlZCBJTkRFWEVEX0RBVEFCQVNFIGF0IGNvbXBpbGUtdGltZSBh cyBpdCBicmVha3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJl TGlzdC5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQppbmRleCAz MmQ0MjIyLi45ZTI0MTA4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVh dHVyZUxpc3QucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBt CkBAIC0yODcsNyArMjg3LDcgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgICAgZGVmaW5lID0+ICJF TkFCTEVfSUZSQU1FX1NFQU1MRVNTIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJGlmcmFtZVNl YW1sZXNzU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gImluZGV4ZWQtZGF0YWJhc2UiLCBk ZXNjID0+ICJUb2dnbGUgSW5kZXhlZCBEYXRhYmFzZSBzdXBwb3J0IiwKLSAgICAgIGRlZmluZSA9 PiAiRU5BQkxFX0lOREVYRURfREFUQUJBU0UiLCBkZWZhdWx0ID0+IGlzR3RrKCksIHZhbHVlID0+ IFwkaW5kZXhlZERhdGFiYXNlU3VwcG9ydCB9LAorICAgICAgZGVmaW5lID0+ICJFTkFCTEVfSU5E RVhFRF9EQVRBQkFTRSIsIGRlZmF1bHQgPT4gKGlzR3RrKCkgfHwgaXNFZmwoKSksIHZhbHVlID0+ IFwkaW5kZXhlZERhdGFiYXNlU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gImlucHV0LXNw ZWVjaCIsIGRlc2MgPT4gIlRvZ2dsZSBJbnB1dCBTcGVlY2ggc3VwcG9ydCIsCiAgICAgICBkZWZp bmUgPT4gIkVOQUJMRV9JTlBVVF9TUEVFQ0giLCBkZWZhdWx0ID0+IDAsIHZhbHVlID0+IFwkaW5w dXRTcGVlY2hTdXBwb3J0IH0sCg==