11639 2006-11-17 17:52:56 -0800 Form buttons don't look different when clicked 2006-12-05 04:46:48 -0800 1 1 1 Unclassified WebKit Forms 420+ PC All RESOLVED FIXED P2 Normal --- 0 KwhiteRight webkit-unassigned ap oldest_to_newest 45521 0 KwhiteRight 2006-11-17 17:52:56 -0800 Form buttons don't show an active state when they're clicked. They keep showing hover until they're inactive again. This is the case for both buttons and input elements. Simple testcase: <html><head></head><body> <form> <input type=submit name=input value="Input"></input> <button type=submit name=button value="Button">Button</button> </form> </body></html> 45514 1 11560 KwhiteRight 2006-11-17 18:42:02 -0800 Created attachment 11560 Makes active: override hover: Do I need a new testcase? How do I find out which testcase failed because of this bug, or make one that would? 43242 2 11560 ap 2006-12-05 04:42:17 -0800 Comment on attachment 11560 Makes active: override hover: r=me I don't think an automated test can be made for this issue - and adding manual test seems to be an overkill. 43232 3 ap 2006-12-05 04:46:48 -0800 Committed revision 18020. Made the same change to RenderThemeGdk (it's sad that this logic is duplicated!) 11560 2006-11-17 18:42:02 -0800 2006-12-05 04:42:17 -0800 Makes active: override hover: bug11639a.txt text/plain 1483 KwhiteRight SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMTc4 MzUpDQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwzICsxLDE2IEBADQorMjAw Ni0xMS0xNyAgS2lyYnkgV2hpdGUgIDxLV2hpdGVSaWdodEBnbWFpbC5jb20+DQorDQorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAgIFdBUk5JTkc6IE5PIFRF U1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRA0KKw0KKwk8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE2Mzk+IEZvcm0gYnV0dG9ucyBkb24ndCBsb29rIGRpZmZlcmVudCB3 aGVuIGNsaWNrZWQNCisJDQorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHA6 DQorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW46OmRldGVybWluZVN0YXRlKTogTW92 ZWQgdGVzdCBmb3IgYWN0aXZlIA0KKyAgICAgICAgc3RhdGUgYmVmb3JlIHRlc3QgZm9yIGhvdmVy IHN0YXRlLCBzaW5jZSBhY3RpdmUgc2hvdWxkIG92ZXJyaWRlIGhvdmVyIA0KKyAgICAgICAgd2hl biBib3RoIGFyZSB0cnVlDQorDQogPT09IFNhZmFyaS01MjEuMzEgPT09DQogDQogMjAwNi0xMS0x NyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+DQpJbmRleDogcmVuZGVyaW5n L1JlbmRlclRoZW1lV2luLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHJlbmRlcmluZy9SZW5kZXJUaGVt ZVdpbi5jcHAJKHJldmlzaW9uIDE3ODMxKQ0KKysrIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5j cHAJKHdvcmtpbmcgY29weSkNCkBAIC0xNzAsMTAgKzE3MCwxMCBAQCB1bnNpZ25lZCBSZW5kZXJU aGVtZVdpbjo6ZGV0ZXJtaW5lU3RhdGUoDQogICAgICAgICByZXN1bHQgPSBURlNfUkVBRE9OTFk7 IC8vIFJlYWRvbmx5IGlzIHN1cHBvcnRlZCBvbiB0ZXh0ZmllbGRzLg0KICAgICBlbHNlIGlmIChz dXBwb3J0c0ZvY3VzKG8tPnN0eWxlKCktPmFwcGVhcmFuY2UoKSkgJiYgaXNGb2N1c2VkKG8pKQ0K ICAgICAgICAgcmVzdWx0ID0gVFNfRk9DVVNFRDsNCisgICAgZWxzZSBpZiAoaXNQcmVzc2VkKG8p KSAvLyBBY3RpdmUgb3ZlcnJpZGVzIGhvdmVyLg0KKyAgICAgICAgcmVzdWx0ID0gVFNfQUNUSVZF Ow0KICAgICBlbHNlIGlmIChpc0hvdmVyZWQobykpDQogICAgICAgICByZXN1bHQgPSBUU19IT1ZF UjsNCi0gICAgZWxzZSBpZiAoaXNQcmVzc2VkKG8pKQ0KLSAgICAgICAgcmVzdWx0ID0gVFNfQUNU SVZFOw0KICAgICBpZiAoaXNDaGVja2VkKG8pKQ0KICAgICAgICAgcmVzdWx0ICs9IDQ7IC8vIDQg dW5jaGVja2VkIHN0YXRlcywgNCBjaGVja2VkIHN0YXRlcy4NCiAgICAgcmV0dXJuIHJlc3VsdDsN Cg==