116389 2013-05-18 02:25:35 -0700 REGRESSION(r150305): WebKit2 build broken with INDEXED_DATABASE enabled 2013-05-19 23:33:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116430 1 cgarcia webkit-unassigned andersca bdakin cdumez mrobinson oleg_smirnov oldest_to_newest 890861 0 cgarcia 2013-05-18 02:25:35 -0700 ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp: In constructor 'WebKit::WebPageGroupProxy::WebPageGroupProxy(const WebKit::WebPageGroupData&)': ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:66:84: error: 'class WebKit::WebKeyValueStorageManager' has no member named 'indexedDBDatabaseDirectory' In file included from ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:29:0: ../../Source/WebKit2/WebProcess/WebProcess.h: In instantiation of 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': ../../Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:65:116: required from here ../../Source/WebKit2/WebProcess/WebProcess.h:90:70: error: invalid static_cast from type 'WTF::HashMap<const char*, WTF::OwnPtr<WebKit::WebProcessSupplement>, WTF::PtrHash<const char*> >::MappedPeekType {aka WebKit::WebProcessSupplement*}' to type 'WebKit::WebKeyValueStorageManager*' ../../Source/WebKit2/WebProcess/WebProcess.h: In member function 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]': ../../Source/WebKit2/WebProcess/WebProcess.h:91:5: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [Source/WebKit2/WebProcess/WebPage/libwebkit2gtk_3_0_la-WebPageGroupProxy.lo] Error 1 There's no longer WebKeyValueStorageManager in the web process after r150305 890862 1 202197 cgarcia 2013-05-18 02:27:55 -0700 Created attachment 202197 Fix the build I'm not sure whether this is the right fix or it should be moved to the ui process now, but it fixes the build for now. 890880 2 zan 2013-05-18 04:27:58 -0700 *** Bug 116390 has been marked as a duplicate of this bug. *** 890951 3 cdumez 2013-05-18 14:21:58 -0700 *** Bug 116396 has been marked as a duplicate of this bug. *** 890974 4 202197 mrobinson 2013-05-18 16:13:47 -0700 Comment on attachment 202197 Fix the build Going to review and land this one since it's a build fix, which means it's blocking forward progress. If someone has a better idea for how to fix this let's work it out later. 890975 5 202197 mrobinson 2013-05-18 16:14:40 -0700 Comment on attachment 202197 Fix the build Clearing flags on attachment: 202197 Committed r150344: <http://trac.webkit.org/changeset/150344> 890976 6 mrobinson 2013-05-18 16:14:43 -0700 All reviewed patches have been landed. Closing bug. 202197 2013-05-18 02:27:55 -0700 2013-05-18 16:14:40 -0700 Fix the build wk2-build-fix.diff text/plain 1994 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNzIyNzA1Li5mMjQ1NmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTMtMDUtMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJFR1JFU1NJT04ocjE1MDMwNSk6IFdlYktpdDIgYnVpbGQgYnJva2VuIHdp dGggSU5ERVhFRF9EQVRBQkFTRSBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYzODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIGxvbmdlciBXZWJLZXlWYWx1ZVN0b3JhZ2VN YW5hZ2VyIGluIHRoZSB3ZWIgcHJvY2VzcworICAgICAgICBhZnRlciByMTUwMzA1LgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2VHcm91cFByb3h5LmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZUdyb3VwUHJveHk6OldlYlBhZ2VHcm91cFByb3h5KToKKworMjAxMy0w NS0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAg ICAgW0dUS10gTW92ZSBHVEsgcG9ydCBvZmYgbGVnYWN5IGNsaXBib2FyZAogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MjIxCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlR3JvdXBQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZUdyb3VwUHJveHkuY3Bw CmluZGV4IGY0ODhmMjAuLjkxNjRmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlR3JvdXBQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2VHcm91cFByb3h5LmNwcApAQCAtMzEsMTEgKzMxLDYg QEAKICNpbmNsdWRlIDxXZWJDb3JlL0RPTVdyYXBwZXJXb3JsZC5oPgogI2luY2x1ZGUgPFdlYkNv cmUvUGFnZUdyb3VwLmg+CiAKLSNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKLSNpbmNsdWRl ICJXZWJLZXlWYWx1ZVN0b3JhZ2VNYW5hZ2VyLmgiCi0jaW5jbHVkZSA8V2ViQ29yZS9Hcm91cFNl dHRpbmdzLmg+Ci0jZW5kaWYKLQogbmFtZXNwYWNlIFdlYktpdCB7CiAKIFBhc3NSZWZQdHI8V2Vi UGFnZUdyb3VwUHJveHk+IFdlYlBhZ2VHcm91cFByb3h5OjpjcmVhdGUoY29uc3QgV2ViUGFnZUdy b3VwRGF0YSYgZGF0YSkKQEAgLTYwLDExICs1NSw2IEBAIFdlYlBhZ2VHcm91cFByb3h5OjpXZWJQ YWdlR3JvdXBQcm94eShjb25zdCBXZWJQYWdlR3JvdXBEYXRhJiBkYXRhKQogICAgICAgICBhZGRV c2VyU3R5bGVTaGVldChkYXRhLnVzZXJTdHlsZVNoZWV0c1tpXSk7CiAgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBkYXRhLnVzZXJTY3JpcHRzLnNpemUoKTsgKytpKQogICAgICAgICBhZGRVc2Vy U2NyaXB0KGRhdGEudXNlclNjcmlwdHNbaV0pOwotCi0jaWYgRU5BQkxFKElOREVYRURfREFUQUJB U0UpCi0gICAgV2ViS2V5VmFsdWVTdG9yYWdlTWFuYWdlcioga2V5VmFsdWVTdG9yYWdlTWFuYWdl ciA9IFdlYlByb2Nlc3M6OnNoYXJlZCgpLnN1cHBsZW1lbnQ8V2ViS2V5VmFsdWVTdG9yYWdlTWFu YWdlcj4oKTsKLSAgICBtX3BhZ2VHcm91cC0+Z3JvdXBTZXR0aW5ncygpLT5zZXRJbmRleGVkREJE YXRhYmFzZVBhdGgoa2V5VmFsdWVTdG9yYWdlTWFuYWdlci0+aW5kZXhlZERCRGF0YWJhc2VEaXJl Y3RvcnkoKSk7Ci0jZW5kaWYKIH0KIAogdm9pZCBXZWJQYWdlR3JvdXBQcm94eTo6YWRkVXNlclN0 eWxlU2hlZXQoY29uc3QgV2ViQ29yZTo6VXNlclN0eWxlU2hlZXQmIHVzZXJTdHlsZVNoZWV0KQo=