116364 2013-05-17 16:30:27 -0700 Move Storage member functions out of line 2013-05-17 16:44:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 890731 0 andersca 2013-05-17 16:30:27 -0700 Move Storage member functions out of line 890734 1 202172 andersca 2013-05-17 16:33:45 -0700 Created attachment 202172 Patch 890737 2 202172 kling 2013-05-17 16:35:59 -0700 Comment on attachment 202172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202172&action=review > Source/WebCore/storage/Storage.h:60 > + RefPtr<StorageArea> m_storageArea; Can we make this const someday? :) 890738 3 andersca 2013-05-17 16:44:53 -0700 Committed r150309: <http://trac.webkit.org/changeset/150309> 202172 2013-05-17 16:33:45 -0700 2013-05-17 16:35:59 -0700 Patch bug-116364-20130517163238.patch text/plain 4964 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZlZTIyMzg1MzRlNWYx Yjc4NGJiM2VkZjg2MmZlYjdiYzUyNTNhYS4uZmNiMDQwZWM0ZDE0ZDc3OWJjNzhjYWEzNTdmYzEx OTcyM2JlMTk4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA1LTE3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBTdG9yYWdl IG1lbWJlciBmdW5jdGlvbnMgb3V0IG9mIGxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjM2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgcHJlcGFyYXRpb24gZm9yIHNoYXJpbmcgbW9y ZSBjb2RlIGJldHdlZW4gdGhlIFdlYktpdDEgYW5kIFdlYktpdDIgc3RvcmFnZSBhcmVhIHN1YmNs YXNzZXMuCisKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U3RvcmFnZTo6bGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2U6OmtleSk6Cisg ICAgICAgIChXZWJDb3JlOjpTdG9yYWdlOjpnZXRJdGVtKToKKyAgICAgICAgKFdlYkNvcmU6OlN0 b3JhZ2U6OnNldEl0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZTo6cmVtb3ZlSXRlbSk6 CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlOjpjbGVhcik6CisgICAgICAgIChXZWJDb3JlOjpT dG9yYWdlOjpjb250YWlucyk6CisgICAgICAgICogc3RvcmFnZS9TdG9yYWdlLmg6CisgICAgICAg IChXZWJDb3JlOjpTdG9yYWdlOjphcmVhKToKKwogMjAxMy0wNS0xOCAgQ2xhdWRpbyBTYWF2ZWRy YSAgPGNzYWF2ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDU1NdIE1pbm9yIGNsZWFudXBz IGluIENTUyB2YXJpYWJsZXMgaGFuZGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0 b3JhZ2UvU3RvcmFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2UuY3BwCmlu ZGV4IDc5M2E4MzZkNzMwNzFlMzEwOGRlMjY4MTY1MjFmMDYzNjQyNWNlOGIuLjY4ZTZjMmQ2OWIz NmQ1NzU0N2QzODE3YTUxNDE0MjIyMWEyNmIyODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3N0b3JhZ2UvU3RvcmFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdl LmNwcApAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiUGFn ZS5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCisjaW5jbHVkZSAiU3RvcmFnZUFyZWEuaCIKICNp bmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5o PgogCkBAIC01NSw0ICs1NiwzOSBAQCBTdG9yYWdlOjp+U3RvcmFnZSgpCiAgICAgICAgIG1fc3Rv cmFnZUFyZWEtPmRlY3JlbWVudEFjY2Vzc0NvdW50KCk7CiB9CiAKK3Vuc2lnbmVkIFN0b3JhZ2U6 Omxlbmd0aChFeGNlcHRpb25Db2RlJiBlYykgY29uc3QKK3sKKyAgICByZXR1cm4gbV9zdG9yYWdl QXJlYS0+bGVuZ3RoKGVjLCBtX2ZyYW1lKTsKK30KKworU3RyaW5nIFN0b3JhZ2U6OmtleSh1bnNp Z25lZCBpbmRleCwgRXhjZXB0aW9uQ29kZSYgZWMpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fc3Rv cmFnZUFyZWEtPmtleShpbmRleCwgZWMsIG1fZnJhbWUpOworfQorCitTdHJpbmcgU3RvcmFnZTo6 Z2V0SXRlbShjb25zdCBTdHJpbmcmIGtleSwgRXhjZXB0aW9uQ29kZSYgZWMpIGNvbnN0Cit7Cisg ICAgcmV0dXJuIG1fc3RvcmFnZUFyZWEtPmdldEl0ZW0oa2V5LCBlYywgbV9mcmFtZSk7Cit9CisK K3ZvaWQgU3RvcmFnZTo6c2V0SXRlbShjb25zdCBTdHJpbmcmIGtleSwgY29uc3QgU3RyaW5nJiB2 YWx1ZSwgRXhjZXB0aW9uQ29kZSYgZWMpCit7CisgICAgbV9zdG9yYWdlQXJlYS0+c2V0SXRlbShr ZXksIHZhbHVlLCBlYywgbV9mcmFtZSk7Cit9CisKK3ZvaWQgU3RvcmFnZTo6cmVtb3ZlSXRlbShj b25zdCBTdHJpbmcmIGtleSwgRXhjZXB0aW9uQ29kZSYgZWMpCit7CisgICAgbV9zdG9yYWdlQXJl YS0+cmVtb3ZlSXRlbShrZXksIGVjLCBtX2ZyYW1lKTsKK30KKwordm9pZCBTdG9yYWdlOjpjbGVh cihFeGNlcHRpb25Db2RlJiBlYykKK3sKKyAgICBtX3N0b3JhZ2VBcmVhLT5jbGVhcihlYywgbV9m cmFtZSk7Cit9CisKK2Jvb2wgU3RvcmFnZTo6Y29udGFpbnMoY29uc3QgU3RyaW5nJiBrZXksIEV4 Y2VwdGlvbkNvZGUmIGVjKSBjb25zdAoreworICAgIHJldHVybiBtX3N0b3JhZ2VBcmVhLT5jb250 YWlucyhrZXksIGVjLCBtX2ZyYW1lKTsKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3RvcmFnZS9TdG9yYWdlLmggYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2UuaApp bmRleCBmNzE0ZjY5ZjZmMjAwYTI2YmYzYWMwOTUyYmRjYjI5ODJlMzRkZWUxLi40YmIzOGUzMWUy Y2ZiNmIzMzI0ZTU0NDNkNGZlNDI0MTA1YmU0MzhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9zdG9yYWdlL1N0b3JhZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2Uu aApAQCAtMjgsMzYgKzI4LDM3IEBACiAKICNpbmNsdWRlICJET01XaW5kb3dQcm9wZXJ0eS5oIgog I2luY2x1ZGUgIlNjcmlwdFdyYXBwYWJsZS5oIgotI2luY2x1ZGUgIlN0b3JhZ2VBcmVhLmgiCiAj aW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2lu Y2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0gICAgY2xhc3Mg RnJhbWU7Ci0gICAgdHlwZWRlZiBpbnQgRXhjZXB0aW9uQ29kZTsKK2NsYXNzIEZyYW1lOworY2xh c3MgU3RvcmFnZUFyZWE7CiAKLSAgICBjbGFzcyBTdG9yYWdlIDogcHVibGljIFNjcmlwdFdyYXBw YWJsZSwgcHVibGljIFJlZkNvdW50ZWQ8U3RvcmFnZT4sIHB1YmxpYyBET01XaW5kb3dQcm9wZXJ0 eSB7Ci0gICAgcHVibGljOgotICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxTdG9yYWdlPiBjcmVh dGUoRnJhbWUqLCBQYXNzUmVmUHRyPFN0b3JhZ2VBcmVhPik7Ci0gICAgICAgIH5TdG9yYWdlKCk7 Cit0eXBlZGVmIGludCBFeGNlcHRpb25Db2RlOwogCi0gICAgICAgIHVuc2lnbmVkIGxlbmd0aChF eGNlcHRpb25Db2RlJiBlYykgY29uc3QgeyByZXR1cm4gbV9zdG9yYWdlQXJlYS0+bGVuZ3RoKGVj LCBtX2ZyYW1lKTsgfQotICAgICAgICBTdHJpbmcga2V5KHVuc2lnbmVkIGluZGV4LCBFeGNlcHRp b25Db2RlJiBlYykgY29uc3QgeyByZXR1cm4gbV9zdG9yYWdlQXJlYS0+a2V5KGluZGV4LCBlYywg bV9mcmFtZSk7IH0KLSAgICAgICAgU3RyaW5nIGdldEl0ZW0oY29uc3QgU3RyaW5nJiBrZXksIEV4 Y2VwdGlvbkNvZGUmIGVjKSBjb25zdCB7IHJldHVybiBtX3N0b3JhZ2VBcmVhLT5nZXRJdGVtKGtl eSwgZWMsIG1fZnJhbWUpOyB9Ci0gICAgICAgIHZvaWQgc2V0SXRlbShjb25zdCBTdHJpbmcmIGtl eSwgY29uc3QgU3RyaW5nJiB2YWx1ZSwgRXhjZXB0aW9uQ29kZSYgZWMpIHsgbV9zdG9yYWdlQXJl YS0+c2V0SXRlbShrZXksIHZhbHVlLCBlYywgbV9mcmFtZSk7IH0KLSAgICAgICAgdm9pZCByZW1v dmVJdGVtKGNvbnN0IFN0cmluZyYga2V5LCBFeGNlcHRpb25Db2RlJiBlYykgeyBtX3N0b3JhZ2VB cmVhLT5yZW1vdmVJdGVtKGtleSwgZWMsIG1fZnJhbWUpOyB9Ci0gICAgICAgIHZvaWQgY2xlYXIo RXhjZXB0aW9uQ29kZSYgZWMpIHsgbV9zdG9yYWdlQXJlYS0+Y2xlYXIoZWMsIG1fZnJhbWUpOyB9 Ci0gICAgICAgIGJvb2wgY29udGFpbnMoY29uc3QgU3RyaW5nJiBrZXksIEV4Y2VwdGlvbkNvZGUm IGVjKSBjb25zdCB7IHJldHVybiBtX3N0b3JhZ2VBcmVhLT5jb250YWlucyhrZXksIGVjLCBtX2Zy YW1lKTsgfQorY2xhc3MgU3RvcmFnZSA6IHB1YmxpYyBTY3JpcHRXcmFwcGFibGUsIHB1YmxpYyBS ZWZDb3VudGVkPFN0b3JhZ2U+LCBwdWJsaWMgRE9NV2luZG93UHJvcGVydHkgeworcHVibGljOgor ICAgIHN0YXRpYyBQYXNzUmVmUHRyPFN0b3JhZ2U+IGNyZWF0ZShGcmFtZSosIFBhc3NSZWZQdHI8 U3RvcmFnZUFyZWE+KTsKKyAgICB+U3RvcmFnZSgpOwogCi0gICAgICAgIFN0b3JhZ2VBcmVhKiBh cmVhKCkgY29uc3QgeyByZXR1cm4gbV9zdG9yYWdlQXJlYS5nZXQoKTsgfQorICAgIHVuc2lnbmVk IGxlbmd0aChFeGNlcHRpb25Db2RlJikgY29uc3Q7CisgICAgU3RyaW5nIGtleSh1bnNpZ25lZCBp bmRleCwgRXhjZXB0aW9uQ29kZSYpIGNvbnN0OworICAgIFN0cmluZyBnZXRJdGVtKGNvbnN0IFN0 cmluZyYga2V5LCBFeGNlcHRpb25Db2RlJikgY29uc3Q7CisgICAgdm9pZCBzZXRJdGVtKGNvbnN0 IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlLCBFeGNlcHRpb25Db2RlJik7CisgICAg dm9pZCByZW1vdmVJdGVtKGNvbnN0IFN0cmluZyYga2V5LCBFeGNlcHRpb25Db2RlJik7CisgICAg dm9pZCBjbGVhcihFeGNlcHRpb25Db2RlJik7CisgICAgYm9vbCBjb250YWlucyhjb25zdCBTdHJp bmcmIGtleSwgRXhjZXB0aW9uQ29kZSYpIGNvbnN0OwogCi0gICAgcHJpdmF0ZToKLSAgICAgICAg U3RvcmFnZShGcmFtZSosIFBhc3NSZWZQdHI8U3RvcmFnZUFyZWE+KTsKKyAgICBTdG9yYWdlQXJl YSogYXJlYSgpIGNvbnN0IHsgcmV0dXJuIG1fc3RvcmFnZUFyZWEuZ2V0KCk7IH0KIAotICAgICAg ICBSZWZQdHI8U3RvcmFnZUFyZWE+IG1fc3RvcmFnZUFyZWE7Ci0gICAgfTsKK3ByaXZhdGU6Cisg ICAgU3RvcmFnZShGcmFtZSosIFBhc3NSZWZQdHI8U3RvcmFnZUFyZWE+KTsKKworICAgIFJlZlB0 cjxTdG9yYWdlQXJlYT4gbV9zdG9yYWdlQXJlYTsKK307CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUKIAo=