116338 2013-05-17 11:58:22 -0700 [Windows] Don't use pdevenv when building with VS2010 2013-05-17 12:06:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue dbates oldest_to_newest 890561 0 bfulgham 2013-05-17 11:58:22 -0700 Visual Studio 2005 did not provide a mode for running the build across multiple cores. Consequently, a manual load-splitting system (pdevenv) was created (see <trac.webkit.org/changeset/23775>) to spread the build across available hardware. Visual Studio 2010 and newer now support the "/MP" flag, which does this for us without requiring Perl scripts or firing off bash shells to do the work. The new VS2010 project files already have the "/MP" flag turned on. So the only change needed is for our build scripts to avoid using pdevenv, since this would actually reduce performance compared to the native parallelization feature. 890562 1 202132 bfulgham 2013-05-17 12:00:20 -0700 Created attachment 202132 Patch 890564 2 202132 aroben 2013-05-17 12:02:15 -0700 Comment on attachment 202132 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202132&action=review r=me! > Tools/ChangeLog:11 > + * Scripts/webkitdirs.pm: > + (setupCygwinEnv): Check if we are using VS2005, and only use > + the 'pdevenv' hack if we are. Otherwise, just build with > + our standard project. Might be worth mentioning somewhere in here that the VS2010 build is already compiling files in parallel. 890567 3 bfulgham 2013-05-17 12:06:13 -0700 Committed r150281: <http://trac.webkit.org/changeset/150281> 202132 2013-05-17 12:00:20 -0700 2013-05-17 12:02:13 -0700 Patch bug-116338-20130517115907.patch text/plain 1743 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1MDI3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA1LTE3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5kb3dzXSBEb24ndCB1c2UgcGRldmVudiB3aGVuIGJ1aWxkaW5nIHdp dGggVlMyMDEwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE2MzM4LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoc2V0dXBDeWd3aW5FbnYpOiBD aGVjayBpZiB3ZSBhcmUgdXNpbmcgVlMyMDA1LCBhbmQgb25seSB1c2UKKyAgICAgICAgdGhlICdw ZGV2ZW52JyBoYWNrIGlmIHdlIGFyZS4gT3RoZXJ3aXNlLCBqdXN0IGJ1aWxkIHdpdGgKKyAgICAg ICAgb3VyIHN0YW5kYXJkIHByb2plY3QuCisKIDIwMTMtMDUtMTcgIEd1c3Rhdm8gTm9yb25oYSBT aWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQuIERpc2FibGUgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgdW50aWwgd2UgZmlndXJlIG91dCB3 aHkgaXQgZG9lcyBub3Qgd29yawpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTUwMTgz KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xNjM0 LDggKzE2MzQsMTAgQEAgc3ViIHNldHVwQ3lnd2luRW52KCkKICAgICAkdmNCdWlsZFBhdGggPSBG aWxlOjpTcGVjLT5jYXRmaWxlKHZpc3VhbFN0dWRpb0luc3RhbGxEaXIoKSwgcXcoQ29tbW9uNyBJ REUgZGV2ZW52LmNvbSkpOwogICAgIGlmICgtZSAkdmNCdWlsZFBhdGgpIHsKICAgICAgICAgIyBW aXN1YWwgU3R1ZGlvIGlzIGluc3RhbGxlZDsgd2UgY2FuIHVzZSBwZGV2ZW52IHRvIGJ1aWxkLgot ICAgICAgICAjIEZJWE1FOiBNYWtlIHBkZXZlbnYgd29yayB3aXRoIG5vbi1DeWd3aW4gUGVybC4K LSAgICAgICAgJHZjQnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZShzb3VyY2VEaXIoKSwg cXcoVG9vbHMgU2NyaXB0cyBwZGV2ZW52KSkgaWYgaXNDeWd3aW4oKTsKKyAgICAgICAgaWYgKHZp c3VhbFN0dWRpb1ZlcnNpb24oKSBlcSAiOCIpIHsKKyAgICAgICAgICAgICMgRklYTUU6IE1ha2Ug cGRldmVudiB3b3JrIHdpdGggbm9uLUN5Z3dpbiBQZXJsLgorICAgICAgICAgICAgJHZjQnVpbGRQ YXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZShzb3VyY2VEaXIoKSwgcXcoVG9vbHMgU2NyaXB0cyBw ZGV2ZW52KSkgaWYgaXNDeWd3aW4oKTsKKyAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAg ICMgVmlzdWFsIFN0dWRpbyBub3QgZm91bmQsIHRyeSBWQysrIEV4cHJlc3MKICAgICAgICAgJHZj QnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSh2aXN1YWxTdHVkaW9JbnN0YWxsRGlyKCks IHF3KENvbW1vbjcgSURFIFZDRXhwcmVzcy5leGUpKTsK