116324 2013-05-17 09:52:34 -0700 Make kit(Frame*) more robust 2013-05-17 12:21:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca beidson oldest_to_newest 890462 0 andersca 2013-05-17 09:52:34 -0700 Make kit(Frame*) more robust 890465 1 202104 andersca 2013-05-17 09:54:17 -0700 Created attachment 202104 Patch 890467 2 202104 darin 2013-05-17 09:55:57 -0700 Comment on attachment 202104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202104&action=review > Source/WebKit/mac/WebView/WebFrame.mm:234 > + FrameLoaderClient* frameLoaderClient = frame->loader()->client(); > + if (frameLoaderClient->isEmptyFrameLoaderClient()) > + return nil; Man that really stinks. I wondered why you were doing this refactoring. I would have named the local variable just client. 890471 3 andersca 2013-05-17 09:58:35 -0700 Committed r150269: <http://trac.webkit.org/changeset/150269> 890580 4 beidson 2013-05-17 12:21:41 -0700 *** Bug 116255 has been marked as a duplicate of this bug. *** 202104 2013-05-17 09:54:17 -0700 2013-05-17 09:55:57 -0700 Patch bug-116324-20130517095309.patch text/plain 1607 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggY2YzNzQ3NTgy MDdhMTAwZTkwN2E2YzY2MjA2YTEwYzFjZWM1OTY3ZS4uYjhhZDJkNTgyMjExYWQ2YTU4NTk5NTI0 ZjI3YWYzYTgyZjZlNzNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEz LTA1LTE3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg TWFrZSBraXQoRnJhbWUqKSBtb3JlIHJvYnVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgdGhhdCB0aGUgZnJhbWUgbG9hZGVyJ3MgY2xpZW50 IGlzbid0IHRoZSBFbXB0eUZyYW1lTG9hZGVyQ2xpZW50IChvciBhIHN1YmNsYXNzIHRoZXJlb2Yp CisgICAgICAgIGJlZm9yZSBjYXN0aW5nIHRvIFdlYkZyYW1lTG9hZGVyQ2xpZW50LgorCisgICAg ICAgICogV2ViVmlldy9XZWJGcmFtZS5tbToKKyAgICAgICAgKGtpdCk6CisKKzIwMTMtMDUtMTcg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBNb3ZlIHRo ZSBwb2xpY3kgZnVuY3Rpb24gdG8gV2ViRnJhbWVQb2xpY3lMaXN0ZW5lcgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MzIzCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0gYi9Tb3VyY2UvV2ViS2l0L21h Yy9XZWJWaWV3L1dlYkZyYW1lLm1tCmluZGV4IDM5M2FlMjU0ZGRmZTE3ZjA4NjA0ZGZhYWNiZDcz ZjI0NzkzZmZiOGUuLjJhNzZmNTI1ZGM0NDU0OWVmYzQwOWQxNWE5MWNjM2M5MWIzNWI1NzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KKysrIGIvU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQpAQCAtMjI2LDcgKzIyNiwxNCBAQCBG cmFtZSogY29yZShXZWJGcmFtZSAqZnJhbWUpCiAKIFdlYkZyYW1lICpraXQoRnJhbWUqIGZyYW1l KQogewotICAgIHJldHVybiBmcmFtZSA/IHN0YXRpY19jYXN0PFdlYkZyYW1lTG9hZGVyQ2xpZW50 Kj4oZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPndlYkZyYW1lKCkgOiBuaWw7CisgICAgaWYg KCFmcmFtZSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKworICAgIEZyYW1lTG9hZGVyQ2xpZW50KiBm cmFtZUxvYWRlckNsaWVudCA9IGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCk7CisgICAgaWYgKGZy YW1lTG9hZGVyQ2xpZW50LT5pc0VtcHR5RnJhbWVMb2FkZXJDbGllbnQoKSkKKyAgICAgICAgcmV0 dXJuIG5pbDsKKworICAgIHJldHVybiBzdGF0aWNfY2FzdDxXZWJGcmFtZUxvYWRlckNsaWVudCo+ KGZyYW1lTG9hZGVyQ2xpZW50KS0+d2ViRnJhbWUoKTsKIH0KIAogUGFnZSogY29yZShXZWJWaWV3 ICp3ZWJWaWV3KQo=