116323 2013-05-17 09:38:02 -0700 Move the policy function to WebFramePolicyListener 2013-05-17 09:47:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 890445 0 andersca 2013-05-17 09:38:02 -0700 Move the policy function to WebFramePolicyListener 890448 1 202102 andersca 2013-05-17 09:42:46 -0700 Created attachment 202102 Patch 890450 2 202102 darin 2013-05-17 09:44:02 -0700 Comment on attachment 202102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202102&action=review > Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:2024 > + _policyFunction = nullptr; OK but unneeded. 890454 3 andersca 2013-05-17 09:47:45 -0700 Committed r150266: <http://trac.webkit.org/changeset/150266> 202102 2013-05-17 09:42:46 -0700 2013-05-17 09:44:02 -0700 Patch bug-116323-20130517094139.patch text/plain 5008 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMzU2ZDQ4Mzgz MDE1OGU4ZTYyZmYzM2ZjMmQxZjcwMTBjNWYzZWZiYS4uMzQ5ZTZmNGUyYjVjNWNkMmY5MjM0NjQ4 MmQ2NjU4NGVjYmI5ODFlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEz LTA1LTE3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg TW92ZSB0aGUgcG9saWN5IGZ1bmN0aW9uIHRvIFdlYkZyYW1lUG9saWN5TGlzdGVuZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjMyMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlJ3Mgbm8gbmVl ZCBmb3IgdGhlIFdlYkZyYW1lTG9hYWRlckNsaWVudCB0byBob2xkIG9uIHRvIHRoZSBwb2xpY3kg ZnVuY3Rpb24sCisgICAgICAgIHNvIG1vdmUgaXQgdG8gV2ViRnJhbWVQb2xpY3lMaXN0ZW5lci4g VGhpcyBnZXRzIHJpZCBvZiBhbm90aGVyIFdlYkZyYW1lTG9hZGVyQ2xpZW50IGNhc3QuCisKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbToKKyAgICAgICAg KFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpzZXRVcFBvbGljeUxpc3RlbmVyKToKKyAgICAgICAgUGFz cyB0aGUgcG9saWN5IGZ1bmN0aW9uIHdoZW4gY3JlYXRpbmcgdGhlIFdlYkZyYW1lUG9saWN5TGlz dGVuZXIgb2JqZWN0LgorCisyMDEzLTA1LTE3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CisKICAgICAgICAgV2ViRnJhbWVQb2xpY3lMaXN0ZW5lciBzaG91bGQga2VlcCBp dHMgRnJhbWUgaW4gYSBSZWZQdHIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNjMyMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5oIGIvU291cmNlL1dlYktpdC9tYWMvV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuaAppbmRleCBjYTY3YmRmMmJjZmM2YmJh ZTAzY2IwYzdmOGNmZjYwNGMxOTA5ZDgxLi40NzBhMTBhOTFhOWIyNTk0OTJjNjgxODMyM2VlM2I5 MjYyNDY2ZWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZUxvYWRlckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBw b3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmgKQEAgLTU1LDEwICs1NSw4IEBAIHB1YmxpYzoKIAog ICAgIFdlYkZyYW1lKiB3ZWJGcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fd2ViRnJhbWUuZ2V0KCk7 IH0KIAotICAgIHZpcnR1YWwgdm9pZCBmcmFtZUxvYWRlckRlc3Ryb3llZCgpIE9WRVJSSURFOwot ICAgIHZvaWQgcmVjZWl2ZWRQb2xpY3lEZWNpc29uKFdlYkNvcmU6OlBvbGljeUFjdGlvbik7Ci0K IHByaXZhdGU6CisgICAgdmlydHVhbCB2b2lkIGZyYW1lTG9hZGVyRGVzdHJveWVkKCkgT1ZFUlJJ REU7CiAgICAgdmlydHVhbCBib29sIGhhc1dlYlZpZXcoKSBjb25zdCBPVkVSUklERTsgLy8gbWFp bmx5IGZvciBhc3NlcnRpb25zCiAKICAgICB2aXJ0dWFsIHZvaWQgbWFrZVJlcHJlc2VudGF0aW9u KFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyKikgT1ZFUlJJREU7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbSBiL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tCmluZGV4 IDkwYmQ4Nzc5YWQ3ZTNkYTZjYzQ3N2ZjMjhmMGE2ODdjN2M4NjA4YWIuLmVhZmY0M2IwZmE0MWE5 YmRkMWQ5NTBlYWRmMDFiN2UyNzE1MzRhOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFj L1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tCkBAIC0xNDksMTAg KzE0OSwxMCBAQCBOU1N0cmluZyAqV2ViUGx1Z2luQ29udGFpbmVyS2V5ID0gQCJXZWJQbHVnaW5D b250YWluZXIiOwogCiBAaW50ZXJmYWNlIFdlYkZyYW1lUG9saWN5TGlzdGVuZXIgOiBOU09iamVj dCA8V2ViUG9saWN5RGVjaXNpb25MaXN0ZW5lciwgV2ViRm9ybVN1Ym1pc3Npb25MaXN0ZW5lcj4g ewogICAgIFJlZlB0cjxGcmFtZT4gX2ZyYW1lOwotICAgIEZyYW1lUG9saWN5RnVuY3Rpb24gX2Zy YW1lUG9saWN5RnVuY3Rpb247CisgICAgRnJhbWVQb2xpY3lGdW5jdGlvbiBfcG9saWN5RnVuY3Rp b247CiB9CiAKLS0gKGlkKWluaXRXaXRoV2ViQ29yZUZyYW1lOihGcmFtZSopZnJhbWU7CistIChp ZClpbml0V2l0aEZyYW1lOihGcmFtZSopZnJhbWUgcG9saWN5RnVuY3Rpb246KEZyYW1lUG9saWN5 RnVuY3Rpb24pcG9saWN5RnVuY3Rpb247CiAtICh2b2lkKWludmFsaWRhdGU7CiAKIEBlbmQKQEAg LTEyODksMjggKzEyODksMTEgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hE aWRCZWNvbWVGcmFtZXNldChib29sKQogUmV0YWluUHRyPFdlYkZyYW1lUG9saWN5TGlzdGVuZXI+ IFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpzZXRVcFBvbGljeUxpc3RlbmVyKEZyYW1lUG9saWN5RnVu Y3Rpb24gZnVuY3Rpb24pCiB7CiAgICAgLy8gRklYTUU6IDxyZGFyOi8vNTYzNDM4MT4gV2UgbmVl ZCB0byBzdXBwb3J0IG11bHRpcGxlIGFjdGl2ZSBwb2xpY3kgbGlzdGVuZXJzLgorICAgIFttX3Bv bGljeUxpc3RlbmVyIGludmFsaWRhdGVdOwogCi0gICAgW21fcG9saWN5TGlzdGVuZXIuZ2V0KCkg aW52YWxpZGF0ZV07Ci0KLSAgICBXZWJGcmFtZVBvbGljeUxpc3RlbmVyICpsaXN0ZW5lciA9IFtb V2ViRnJhbWVQb2xpY3lMaXN0ZW5lciBhbGxvY10gaW5pdFdpdGhXZWJDb3JlRnJhbWU6Y29yZSht X3dlYkZyYW1lLmdldCgpKV07Ci0gICAgbV9wb2xpY3lMaXN0ZW5lciA9IGxpc3RlbmVyOwotICAg IFtsaXN0ZW5lciByZWxlYXNlXTsKLSAgICBtX3BvbGljeUZ1bmN0aW9uID0gZnVuY3Rpb247Ci0K LSAgICByZXR1cm4gbGlzdGVuZXI7Ci19Ci0KLXZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OnJl Y2VpdmVkUG9saWN5RGVjaXNvbihQb2xpY3lBY3Rpb24gYWN0aW9uKQotewotICAgIEFTU0VSVCht X3BvbGljeUxpc3RlbmVyKTsKLSAgICBBU1NFUlQobV9wb2xpY3lGdW5jdGlvbik7Ci0KLSAgICBG cmFtZVBvbGljeUZ1bmN0aW9uIGZ1bmN0aW9uID0gbV9wb2xpY3lGdW5jdGlvbjsKLQotICAgIG1f cG9saWN5TGlzdGVuZXIgPSBuaWw7Ci0gICAgbV9wb2xpY3lGdW5jdGlvbiA9IDA7CisgICAgbV9w b2xpY3lMaXN0ZW5lciA9IGFkb3B0TlMoW1tXZWJGcmFtZVBvbGljeUxpc3RlbmVyIGFsbG9jXSBp bml0V2l0aEZyYW1lOmNvcmUobV93ZWJGcmFtZS5nZXQoKSkgcG9saWN5RnVuY3Rpb246ZnVuY3Rp b25dKTsKIAotICAgIChjb3JlKG1fd2ViRnJhbWUuZ2V0KCkpLT5sb2FkZXIoKS0+cG9saWN5Q2hl Y2tlcigpLT4qZnVuY3Rpb24pKGFjdGlvbik7CisgICAgcmV0dXJuIG1fcG9saWN5TGlzdGVuZXI7 CiB9CiAKIFN0cmluZyBXZWJGcmFtZUxvYWRlckNsaWVudDo6dXNlckFnZW50KGNvbnN0IEtVUkwm IHVybCkKQEAgLTIwMjMsMTMgKzIwMDYsMTQgQEAgUGFzc1JlZlB0cjxGcmFtZU5ldHdvcmtpbmdD b250ZXh0PiBXZWJGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlTmV0d29ya2luZ0NvbnRleHQKICAg ICBXZWJDb3JlT2JqQ0ZpbmFsaXplT25NYWluVGhyZWFkKHNlbGYpOwogfQogCi0tIChpZClpbml0 V2l0aFdlYkNvcmVGcmFtZTooRnJhbWUqKWZyYW1lCistIChpZClpbml0V2l0aEZyYW1lOihGcmFt ZSopZnJhbWUgcG9saWN5RnVuY3Rpb246KEZyYW1lUG9saWN5RnVuY3Rpb24pcG9saWN5RnVuY3Rp b24KIHsKICAgICBzZWxmID0gW3NlbGYgaW5pdF07CiAgICAgaWYgKCFzZWxmKQogICAgICAgICBy ZXR1cm4gbmlsOwogCiAgICAgX2ZyYW1lID0gZnJhbWU7CisgICAgX3BvbGljeUZ1bmN0aW9uID0g cG9saWN5RnVuY3Rpb247CiAKICAgICByZXR1cm4gc2VsZjsKIH0KQEAgLTIwMzcsNiArMjAyMSw3 IEBAIFBhc3NSZWZQdHI8RnJhbWVOZXR3b3JraW5nQ29udGV4dD4gV2ViRnJhbWVMb2FkZXJDbGll bnQ6OmNyZWF0ZU5ldHdvcmtpbmdDb250ZXh0CiAtICh2b2lkKWludmFsaWRhdGUKIHsKICAgICBf ZnJhbWUgPSBudWxscHRyOworICAgIF9wb2xpY3lGdW5jdGlvbiA9IG51bGxwdHI7CiB9CiAKIC0g KHZvaWQpZGVhbGxvYwpAQCAtMjA0OSw4ICsyMDM0LDE1IEBAIFBhc3NSZWZQdHI8RnJhbWVOZXR3 b3JraW5nQ29udGV4dD4gV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZU5ldHdvcmtpbmdDb250 ZXh0CiAKIC0gKHZvaWQpcmVjZWl2ZWRQb2xpY3lEZWNpc2lvbjooUG9saWN5QWN0aW9uKWFjdGlv bgogewotICAgIGlmIChSZWZQdHI8RnJhbWU+IGZyYW1lID0gX2ZyYW1lLnJlbGVhc2UoKSkKLSAg ICAgICAgc3RhdGljX2Nhc3Q8V2ViRnJhbWVMb2FkZXJDbGllbnQqPihmcmFtZS0+bG9hZGVyKCkt PmNsaWVudCgpKS0+cmVjZWl2ZWRQb2xpY3lEZWNpc29uKGFjdGlvbik7CisgICAgUmVmUHRyPEZy YW1lPiBmcmFtZSA9IF9mcmFtZS5yZWxlYXNlKCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAg cmV0dXJuOworCisgICAgRnJhbWVQb2xpY3lGdW5jdGlvbiBwb2xpY3lGdW5jdGlvbiA9IF9wb2xp Y3lGdW5jdGlvbjsKKyAgICBfcG9saWN5RnVuY3Rpb24gPSBudWxscHRyOworCisgICAgQVNTRVJU KHBvbGljeUZ1bmN0aW9uKTsKKyAgICAoZnJhbWUtPmxvYWRlcigpLT5wb2xpY3lDaGVja2VyKCkt PipfcG9saWN5RnVuY3Rpb24pKGFjdGlvbik7CiB9CiAKIC0gKHZvaWQpaWdub3JlCg==