116307 2013-05-17 05:30:48 -0700 Make sure to call release() on our smart pointers when we should. 2013-05-17 07:04:39 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard commit-queue esprehn+autocc glenn kling macpherson oldest_to_newest 890309 0 menard 2013-05-17 05:30:48 -0700 Make sure to call release() on our smart pointers when we should. 890310 1 202067 menard 2013-05-17 05:32:12 -0700 Created attachment 202067 Patch 890345 2 202067 commit-queue 2013-05-17 07:04:37 -0700 Comment on attachment 202067 Patch Clearing flags on attachment: 202067 Committed r150255: <http://trac.webkit.org/changeset/150255> 890346 3 commit-queue 2013-05-17 07:04:39 -0700 All reviewed patches have been landed. Closing bug. 202067 2013-05-17 05:32:12 -0700 2013-05-17 07:04:37 -0700 Patch bug-116307-20130517093105.patch text/plain 7460 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmYwYWM0OTNhYjFkMTc1 MTdlNzRjMTc1YTJlNTU0Mjk2NmYwOWNiYy4uNWZlOTZmYjE5OTFkODUyMzMzY2E2YWMwODVhYjAy NGMyMTVlN2I2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTA1LTE3ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBzdXJlIHRvIGNh bGwgcmVsZWFzZSgpIG9uIG91ciBzbWFydCBwb2ludGVycyB3aGVuIHdlIHNob3VsZC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjMwNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgcmVsZWFzZSgp IHdoZW4gd2Ugc2hvdWxkIGNhbGwgaXQuIFRoZXJlIGlzIHByb2JhYmx5IG1vcmUgb2NjdXJlbmNl CisgICAgICAgIG9mIHRoaXMgcHJvYmxlbSBvbiB0aGUgY29kZWJhc2UgYnV0IHRoaXMgaXMgYSBm aXJzdCBidW5jaCBvZiBmaXhlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMgOiBleGlzdGluZyBv bmVzIHNob3VsZCBjb3Zlci4KKworICAgICAgICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFy YXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6dmFsdWVGb3JOaW5lUGllY2VJbWFnZSk6Cisg ICAgICAgIChXZWJDb3JlOjpnZXRCb3JkZXJSYWRpdXNTaG9ydGhhbmRWYWx1ZSk6CisgICAgICAg IChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OnZhbHVlRm9yRmlsdGVyKToK KyAgICAgICAgKFdlYkNvcmU6OkNTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Z2V0UHJvcGVy dHlDU1NWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b246OmdldENTU1Byb3BlcnR5VmFsdWVzRm9yU2lkZXNTaG9ydGhhbmQpOgorICAgICAgICAoV2Vi Q29yZTo6Q1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpnZXRDU1NQcm9wZXJ0eVZhbHVlc0Zv ckdyaWRTaG9ydGhhbmQpOgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUJvcmRlckltYWdlKToKKyAgICAgICAgKiBodG1sL0hU TUxCb2R5RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQm9keUVsZW1lbnQ6OmNv bGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0dHJpYnV0ZSk6CisKIDIwMTMtMDUtMTYgIEplc3Vz IFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAg ICAgIEFkZCBzdHVicyBmb3IgQ29udGV4dE1lbnUgYW5kIENvbnRleHRNZW51SXRlbQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRl eCA1NTQzMDgxMzBhNGQ5MGJiMTMxODA0NjQzZTgxNmU5MGM1ZmQ1ZWY0Li5hYjcxOTI2M2UwMjc2 YzMwM2M1OWE5YWRkMzM4YTdlZDg4ZTY5OTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcApAQCAtNTgyLDcgKzU4Miw3IEBAIHN0 YXRpYyBQYXNzUmVmUHRyPENTU1ZhbHVlPiB2YWx1ZUZvck5pbmVQaWVjZUltYWdlKGNvbnN0IE5p bmVQaWVjZUltYWdlJiBpbWFnZSkKICAgICAvLyBDcmVhdGUgdGhlIHJlcGVhdCBydWxlcy4KICAg ICBSZWZQdHI8Q1NTVmFsdWU+IHJlcGVhdCA9IHZhbHVlRm9yTmluZVBpZWNlSW1hZ2VSZXBlYXQo aW1hZ2UpOwogCi0gICAgcmV0dXJuIGNyZWF0ZUJvcmRlckltYWdlVmFsdWUoaW1hZ2VWYWx1ZSwg aW1hZ2VTbGljZXMsIGJvcmRlclNsaWNlcywgb3V0c2V0LCByZXBlYXQpOworICAgIHJldHVybiBj cmVhdGVCb3JkZXJJbWFnZVZhbHVlKGltYWdlVmFsdWUucmVsZWFzZSgpLCBpbWFnZVNsaWNlcy5y ZWxlYXNlKCksIGJvcmRlclNsaWNlcy5yZWxlYXNlKCksIG91dHNldC5yZWxlYXNlKCksIHJlcGVh dC5yZWxlYXNlKCkpOwogfQogCiBpbmxpbmUgc3RhdGljIFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZl VmFsdWU+IHpvb21BZGp1c3RlZFBpeGVsVmFsdWUoZG91YmxlIHZhbHVlLCBjb25zdCBSZW5kZXJT dHlsZSogc3R5bGUpCkBAIC03NDcsNyArNzQ3LDcgQEAgc3RhdGljIFBhc3NSZWZQdHI8Q1NTVmFs dWVMaXN0PiBnZXRCb3JkZXJSYWRpdXNTaG9ydGhhbmRWYWx1ZShjb25zdCBSZW5kZXJTdHlsZSoK ICAgICBpZiAoc2hvd0hvcml6b250YWxCb3R0b21MZWZ0KQogICAgICAgICBob3Jpem9udGFsUmFk aWktPmFwcGVuZChib3R0b21MZWZ0UmFkaXVzLT5pdGVtKDApKTsKIAotICAgIGxpc3QtPmFwcGVu ZChob3Jpem9udGFsUmFkaWkpOworICAgIGxpc3QtPmFwcGVuZChob3Jpem9udGFsUmFkaWkucmVs ZWFzZSgpKTsKIAogICAgIGlmIChzaG93VmVydGljYWxUb3BMZWZ0KSB7CiAgICAgICAgIFJlZlB0 cjxDU1NWYWx1ZUxpc3Q+IHZlcnRpY2FsUmFkaWkgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZVNwYWNl U2VwYXJhdGVkKCk7CkBAIC03NTgsNyArNzU4LDcgQEAgc3RhdGljIFBhc3NSZWZQdHI8Q1NTVmFs dWVMaXN0PiBnZXRCb3JkZXJSYWRpdXNTaG9ydGhhbmRWYWx1ZShjb25zdCBSZW5kZXJTdHlsZSoK ICAgICAgICAgICAgIHZlcnRpY2FsUmFkaWktPmFwcGVuZChib3R0b21SaWdodFJhZGl1cy0+aXRl bSgxKSk7CiAgICAgICAgIGlmIChzaG93VmVydGljYWxCb3R0b21MZWZ0KQogICAgICAgICAgICAg dmVydGljYWxSYWRpaS0+YXBwZW5kKGJvdHRvbUxlZnRSYWRpdXMtPml0ZW0oMSkpOwotICAgICAg ICBsaXN0LT5hcHBlbmQodmVydGljYWxSYWRpaSk7CisgICAgICAgIGxpc3QtPmFwcGVuZCh2ZXJ0 aWNhbFJhZGlpLnJlbGVhc2UoKSk7CiAgICAgfQogICAgIHJldHVybiBsaXN0LnJlbGVhc2UoKTsK IH0KQEAgLTEwNDcsNyArMTA0Nyw3IEBAIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IENTU0NvbXB1dGVk U3R5bGVEZWNsYXJhdGlvbjo6dmFsdWVGb3JGaWx0ZXIoY29uc3QgUmVuZGVyT2JqCiAgICAgICAg ICAgICBmaWx0ZXJWYWx1ZSA9IFdlYktpdENTU0ZpbHRlclZhbHVlOjpjcmVhdGUoV2ViS2l0Q1NT RmlsdGVyVmFsdWU6OlVua25vd25GaWx0ZXJPcGVyYXRpb24pOwogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIH0KLSAgICAgICAgbGlzdC0+YXBwZW5kKGZpbHRlclZhbHVlKTsKKyAgICAgICAg bGlzdC0+YXBwZW5kKGZpbHRlclZhbHVlLnJlbGVhc2UoKSk7CiAgICAgfQogCiAgICAgcmV0dXJu IGxpc3QucmVsZWFzZSgpOwpAQCAtMTg2NCw3ICsxODY0LDcgQEAgUGFzc1JlZlB0cjxDU1NWYWx1 ZT4gQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpnZXRQcm9wZXJ0eUNTU1ZhbHVlKENTU1By b3BlcnQKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIFJlZlB0cjxDU1NWYWx1ZT4gdmFsdWUg PSBjc3NWYWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShzdHlsZS0+Y3Vyc29yKCkpOwogICAgICAgICAg ICAgaWYgKGxpc3QpIHsKLSAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQodmFsdWUpOworICAg ICAgICAgICAgICAgIGxpc3QtPmFwcGVuZCh2YWx1ZS5yZWxlYXNlKCkpOwogICAgICAgICAgICAg ICAgIHJldHVybiBsaXN0LnJlbGVhc2UoKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHJl dHVybiB2YWx1ZS5yZWxlYXNlKCk7CkBAIC0yOTg0LDEzICsyOTg0LDEzIEBAIFBhc3NSZWZQdHI8 Q1NTVmFsdWVMaXN0PiBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OmdldENTU1Byb3BlcnR5 VmFsdWVzRm9yU2lkCiAgICAgYm9vbCBzaG93Qm90dG9tID0gIWNvbXBhcmVDU1NWYWx1ZVB0cih0 b3BWYWx1ZSwgYm90dG9tVmFsdWUpIHx8IHNob3dMZWZ0OwogICAgIGJvb2wgc2hvd1JpZ2h0ID0g IWNvbXBhcmVDU1NWYWx1ZVB0cih0b3BWYWx1ZSwgcmlnaHRWYWx1ZSkgfHwgc2hvd0JvdHRvbTsK IAotICAgIGxpc3QtPmFwcGVuZCh0b3BWYWx1ZSk7CisgICAgbGlzdC0+YXBwZW5kKHRvcFZhbHVl LnJlbGVhc2UoKSk7CiAgICAgaWYgKHNob3dSaWdodCkKLSAgICAgICAgbGlzdC0+YXBwZW5kKHJp Z2h0VmFsdWUpOworICAgICAgICBsaXN0LT5hcHBlbmQocmlnaHRWYWx1ZS5yZWxlYXNlKCkpOwog ICAgIGlmIChzaG93Qm90dG9tKQotICAgICAgICBsaXN0LT5hcHBlbmQoYm90dG9tVmFsdWUpOwor ICAgICAgICBsaXN0LT5hcHBlbmQoYm90dG9tVmFsdWUucmVsZWFzZSgpKTsKICAgICBpZiAoc2hv d0xlZnQpCi0gICAgICAgIGxpc3QtPmFwcGVuZChsZWZ0VmFsdWUpOworICAgICAgICBsaXN0LT5h cHBlbmQobGVmdFZhbHVlLnJlbGVhc2UoKSk7CiAKICAgICByZXR1cm4gbGlzdC5yZWxlYXNlKCk7 CiB9CkBAIC0zMDAwLDcgKzMwMDAsNyBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlTGlzdD4gQ1NTQ29t cHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpnZXRDU1NQcm9wZXJ0eVZhbHVlc0ZvckdyaQogICAgIFJl ZlB0cjxDU1NWYWx1ZUxpc3Q+IGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZVNsYXNoU2VwYXJh dGVkKCk7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaG9ydGhhbmQubGVuZ3RoKCk7ICsr aSkgewogICAgICAgICBSZWZQdHI8Q1NTVmFsdWU+IHZhbHVlID0gZ2V0UHJvcGVydHlDU1NWYWx1 ZShzaG9ydGhhbmQucHJvcGVydGllcygpW2ldLCBEb05vdFVwZGF0ZUxheW91dCk7Ci0gICAgICAg IGxpc3QtPmFwcGVuZCh2YWx1ZSk7CisgICAgICAgIGxpc3QtPmFwcGVuZCh2YWx1ZS5yZWxlYXNl KCkpOwogICAgIH0KICAgICByZXR1cm4gbGlzdC5yZWxlYXNlKCk7CiB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwCmluZGV4IDY5MGI3NDU2NzFjNWFjYWU5YzhhZTAzZmFjNTNiNjcwODIyNDZlZWMu LjRlZGZiYWI2ZThmZDc2YjY2M2I0NGViNmEyNjE0OWM0NTI1ODFmMzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCkBAIC02NjgwLDE0ICs2NjgwLDE0IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJz ZUJvcmRlckltYWdlKENTU1Byb3BlcnR5SUQgcHJvcElkLCBSZWZQdHI8Q1NTVmFsdWU+JiByZXN1 bHQsCiAgICAgICAgICAgICBlbHNlIGlmIChpc0dlbmVyYXRlZEltYWdlVmFsdWUodmFsKSkgewog ICAgICAgICAgICAgICAgIFJlZlB0cjxDU1NWYWx1ZT4gdmFsdWU7CiAgICAgICAgICAgICAgICAg aWYgKHBhcnNlR2VuZXJhdGVkSW1hZ2UobV92YWx1ZUxpc3QuZ2V0KCksIHZhbHVlKSkKLSAgICAg ICAgICAgICAgICAgICAgY29udGV4dC5jb21taXRJbWFnZSh2YWx1ZSk7CisgICAgICAgICAgICAg ICAgICAgIGNvbnRleHQuY29tbWl0SW1hZ2UodmFsdWUucmVsZWFzZSgpKTsKICAgICAgICAgICAg ICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICNpZiBFTkFCTEUo Q1NTX0lNQUdFX1NFVCkKICAgICAgICAgICAgIH0gZWxzZSBpZiAodmFsLT51bml0ID09IENTU1Bh cnNlclZhbHVlOjpGdW5jdGlvbiAmJiBlcXVhbElnbm9yaW5nQ2FzZSh2YWwtPmZ1bmN0aW9uLT5u YW1lLCAiLXdlYmtpdC1pbWFnZS1zZXQoIikpIHsKICAgICAgICAgICAgICAgICBSZWZQdHI8Q1NT VmFsdWU+IHZhbHVlID0gcGFyc2VJbWFnZVNldChtX3ZhbHVlTGlzdC5nZXQoKSk7CiAgICAgICAg ICAgICAgICAgaWYgKHZhbHVlKQotICAgICAgICAgICAgICAgICAgICBjb250ZXh0LmNvbW1pdElt YWdlKHZhbHVlKTsKKyAgICAgICAgICAgICAgICAgICAgY29udGV4dC5jb21taXRJbWFnZSh2YWx1 ZS5yZWxlYXNlKCkpOwogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogI2VuZGlmCkBAIC02NzA0LDcgKzY3MDQsNyBAQCBib29sIENTU1BhcnNl cjo6cGFyc2VCb3JkZXJJbWFnZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgUmVmUHRyPENTU1ZhbHVl PiYgcmVzdWx0LAogICAgICAgICBpZiAoIWNvbnRleHQuY2FuQWR2YW5jZSgpICYmIGNvbnRleHQu YWxsb3dSZXBlYXQoKSkgewogICAgICAgICAgICAgUmVmUHRyPENTU1ZhbHVlPiByZXBlYXQ7CiAg ICAgICAgICAgICBpZiAocGFyc2VCb3JkZXJJbWFnZVJlcGVhdChyZXBlYXQpKQotICAgICAgICAg ICAgICAgIGNvbnRleHQuY29tbWl0UmVwZWF0KHJlcGVhdCk7CisgICAgICAgICAgICAgICAgY29u dGV4dC5jb21taXRSZXBlYXQocmVwZWF0LnJlbGVhc2UoKSk7CiAgICAgICAgIH0KIAogICAgICAg ICBpZiAoIWNvbnRleHQuY2FuQWR2YW5jZSgpICYmIGNvbnRleHQucmVxdWlyZVdpZHRoKCkpIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNwcAppbmRleCA4ZTNiOTAyZWJmNzFm NDE3YzRkYmUzZGNiMmVjZTgyNDM3MTk2NjNhLi40N2VkNjRkMGY2NGJjYTRiODBmODExYjBjYTM3 MjM1MTYzMzdhYjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuY3BwCkBA IC03Niw3ICs3Niw3IEBAIHZvaWQgSFRNTEJvZHlFbGVtZW50Ojpjb2xsZWN0U3R5bGVGb3JQcmVz ZW50YXRpb25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYKICAgICAgICAgaWYgKCF1cmwu aXNFbXB0eSgpKSB7CiAgICAgICAgICAgICBSZWZQdHI8Q1NTSW1hZ2VWYWx1ZT4gaW1hZ2VWYWx1 ZSA9IENTU0ltYWdlVmFsdWU6OmNyZWF0ZShkb2N1bWVudCgpLT5jb21wbGV0ZVVSTCh1cmwpLnN0 cmluZygpKTsKICAgICAgICAgICAgIGltYWdlVmFsdWUtPnNldEluaXRpYXRvcihsb2NhbE5hbWUo KSk7Ci0gICAgICAgICAgICBzdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHkoQ1NTUHJvcGVy dHlCYWNrZ3JvdW5kSW1hZ2UsIGltYWdlVmFsdWUpKTsKKyAgICAgICAgICAgIHN0eWxlLT5zZXRQ cm9wZXJ0eShDU1NQcm9wZXJ0eShDU1NQcm9wZXJ0eUJhY2tncm91bmRJbWFnZSwgaW1hZ2VWYWx1 ZS5yZWxlYXNlKCkpKTsKICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAobmFtZSA9PSBtYXJnaW53 aWR0aEF0dHIgfHwgbmFtZSA9PSBsZWZ0bWFyZ2luQXR0cikgewogICAgICAgICBhZGRIVE1MTGVu Z3RoVG9TdHlsZShzdHlsZSwgQ1NTUHJvcGVydHlNYXJnaW5SaWdodCwgdmFsdWUpOwo=