116289 2013-05-16 22:02:37 -0700 [Qt] REGRESSION(r150227): It made zillion tests crash 2013-05-18 01:11:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 75790 79668 1 ossy webkit-unassigned abecsi allan.jensen andersca hausmann jturcotte kadam michael.bruning ossy thorton zarvai oldest_to_newest 890205 0 ossy 2013-05-16 22:02:37 -0700 See the Qt bots or details: - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/60179 - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/28973 - http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20NRWT/builds/33226 - http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Debug/builds/25779 ( Before you asked me to generate backtrace ... No I can't and I won't, because I don't work on Qt port I only reported this regression for you by courtesy. ) 890207 1 ossy 2013-05-16 22:11:40 -0700 OK, I changed my mind. :) It took only 10 minutes for me during my breakfast tee ... Here you are: $ gdb WebKitBuild/Debug/bin/DumpRenderTree GNU gdb (Ubuntu/Linaro 7.4-2012.04-0ubuntu2.1) 7.4-2012.04 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". For bug reporting instructions, please see: <http://bugs.launchpad.net/gdb-linaro/>... Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree...done. (gdb) run LayoutTests/css2.1/20110323/background-intrinsic-008.htm Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree LayoutTests/css2.1/20110323/background-intrinsic-008.htm [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". [New Thread 0x7fffe61ab700 (LWP 25098)] [New Thread 0x7fffe4b1c700 (LWP 25100)] [Thread 0x7fffe4b1c700 (LWP 25100) exited] [New Thread 0x7fffe4b1c700 (LWP 25102)] [New Thread 0x7fff9f7ee700 (LWP 25112)] Program received signal SIGSEGV, Segmentation fault. 0x00007ffff3ee64b9 in QListData::size (this=0x7fffffffcd10) at /usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtCore/qlist.h:92 92 inline int size() const { return d->end - d->begin; } (gdb) bt #0 0x00007ffff3ee64b9 in QListData::size (this=0x7fffffffcd10) at /usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtCore/qlist.h:92 #1 0x00007ffff3f321c8 in QList<QWebPluginFactory::Plugin>::count (this=0x7fffffffcd10) at /usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtCore/qlist.h:286 #2 0x00007ffff3f31c0f in PlatformStrategiesQt::getPluginInfo (this=0x6b3bb0, page=0x7a1ec0, outPlugins=...) at /home/oszi/WebKit/Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:145 #3 0x00007ffff4a2cda7 in WebCore::PluginData::initPlugins (this=0x753690, page=0x7a1ec0) at /home/oszi/WebKit/Source/WebCore/plugins/PluginData.cpp:89 #4 0x00007ffff4a2ca26 in WebCore::PluginData::PluginData (this=0x753690, page=0x7a1ec0) at /home/oszi/WebKit/Source/WebCore/plugins/PluginData.cpp:34 #5 0x00007ffff49fd61b in WebCore::PluginData::create (page=0x7a1ec0) at /home/oszi/WebKit/Source/WebCore/plugins/PluginData.h:54 #6 0x00007ffff49ff5db in WebCore::Page::pluginData (this=0x7a1ec0) at /home/oszi/WebKit/Source/WebCore/page/Page.cpp:517 #7 0x00007ffff457460d in WebCore::DOMImplementation::createDocument (type=..., frame=0x787e90, url=..., inViewSourceMode=false) at /home/oszi/WebKit/Source/WebCore/dom/DOMImplementation.cpp:405 #8 0x00007ffff491d902 in WebCore::DocumentWriter::createDocument (this=0x75f790, url=...) at /home/oszi/WebKit/Source/WebCore/loader/DocumentWriter.cpp:111 #9 0x00007ffff491d96b in WebCore::DocumentWriter::begin (this=0x75f790, urlReference=..., dispatch=true, ownerDocument=0x0) at /home/oszi/WebKit/Source/WebCore/loader/DocumentWriter.cpp:123 #10 0x00007ffff4f694f6 in WebCore::SVGImage::dataChanged (this=0x7160f0, allDataReceived=true) at /home/oszi/WebKit/Source/WebCore/svg/graphics/SVGImage.cpp:356 #11 0x00007ffff4a84514 in WebCore::Image::setData (this=0x7160f0, data=..., allDataReceived=true) at /home/oszi/WebKit/Source/WebCore/platform/graphics/Image.cpp:79 #12 0x00007ffff48f1c11 in WebCore::CachedImage::data (this=0x7f56e0, data=..., allDataReceived=true) at /home/oszi/WebKit/Source/WebCore/loader/cache/CachedImage.cpp:368 #13 0x00007ffff4959330 in WebCore::SubresourceLoader::didFinishLoading (this=0x7f52a0, finishTime=0) at /home/oszi/WebKit/Source/WebCore/loader/SubresourceLoader.cpp:282 #14 0x00007ffff494fd41 in WebCore::ResourceLoader::didFinishLoading (this=0x7f52a0, finishTime=0) at /home/oszi/WebKit/Source/WebCore/loader/ResourceLoader.cpp:491 #15 0x00007ffff4dde0c0 in WebCore::QNetworkReplyHandler::finish (this=0x800120) at /home/oszi/WebKit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #16 0x00007ffff4ddccdd in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x800158) at /home/oszi/WebKit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #17 0x00007ffff4ddc9db in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x800158, method= (void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4dddf04 <WebCore::QNetworkReplyHandler::finish()>) at /home/oszi/WebKit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #18 0x00007ffff4ddd9ae in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x7fa790) at /home/oszi/WebKit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #19 0x00007ffff4de0334 in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x7fa790, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffd630) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:175 #20 0x00007ffff22680e1 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #21 0x00007ffff226973e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #22 0x00007ffff32e51f4 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #23 0x00007ffff32e85d1 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #24 0x00007ffff2242a24 in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #25 0x00007ffff2244961 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #26 0x00007ffff228a1f3 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #27 0x00007fffef064d53 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #28 0x00007fffef0650a0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 ---Type <return> to continue, or q <return> to quit--- #29 0x00007fffef065164 in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #30 0x00007ffff228a634 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #31 0x00007ffff22418fb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #32 0x00007ffff2244e9e in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #33 0x0000000000439b79 in main (argc=2, argv=0x7fffffffe3b8) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/DumpRenderTreeMain.cpp:199 (gdb) 890208 2 ossy 2013-05-16 22:13:09 -0700 s/tee/tea ( I use too much linux terminal :) ) 890223 3 thorton 2013-05-16 23:42:39 -0700 Interesting! I'll take a peek. 890502 4 michael.bruning 2013-05-17 10:21:41 -0700 From what I can see, at least some of the crashes are due to an SVGImageChromeClient being static_cast to a ChromeClientQt. I can continue to look at this next week unless it gets solved in the meantime. 890630 5 202145 thorton 2013-05-17 13:25:34 -0700 Created attachment 202145 patch that I can't test 890845 6 202145 ossy 2013-05-18 01:09:43 -0700 Comment on attachment 202145 patch that I can't test LGTM and I tested it too and works fine, so r=me. Thanks for the fix. 890846 7 202145 ossy 2013-05-18 01:11:22 -0700 Comment on attachment 202145 patch that I can't test Clearing flags on attachment: 202145 Committed r150328: <http://trac.webkit.org/changeset/150328> 890847 8 ossy 2013-05-18 01:11:29 -0700 All reviewed patches have been landed. Closing bug. 202145 2013-05-17 13:25:34 -0700 2013-05-18 01:11:22 -0700 patch that I can't test crash.diff text/plain 1678 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggMmNmZTlhYi4uYmM4OWNkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNS0xNyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjE1MDIyNyk6IEl0IG1hZGUgemlsbGlv biB0ZXN0cyBjcmFzaCB1bmRlciBQbGF0Zm9ybVN0cmF0ZWdpZXNRdDo6Z2V0UGx1Z2luSW5mbwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2Mjg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgdHJ5 IHRvIHN0YXRpYyBjYXN0IHNvbWV0aGluZyB0aGF0IGlzbid0IGEgQ2hyb21lQ2xpZW50UXQgdG8g Q2hyb21lQ2xpZW50UXQuCisgICAgICAgIEl0J3MgYWN0dWFsbHkgU1ZHSW1hZ2UncyBFbXB0eUNo cm9tZUNsaWVudC1kZXJpdmVkIGNsaWVudCAob3Igb3RoZXIgc3VjaCB0aGluZ3MpLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvUGxhdGZvcm1TdHJhdGVnaWVzUXQuY3BwOgorICAgICAgICAo UGxhdGZvcm1TdHJhdGVnaWVzUXQ6OmdldFBsdWdpbkluZm8pOgorCiAyMDEzLTA1LTE2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFBERlBsdWdpbnMg ZG9uJ3QgbG9hZCB3aGVuIHBsdWdpbnMgYXJlIGRpc2FibGVkLCBidXQgdGhleSBzaG91bGQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGxhdGZvcm1TdHJhdGVn aWVzUXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0 ZWdpZXNRdC5jcHAKaW5kZXggMDJkMGIyOC4uNTJjMjM4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNRdC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNRdC5jcHAKQEAg LTEzNyw3ICsxMzcsMTAgQEAgdm9pZCBQbGF0Zm9ybVN0cmF0ZWdpZXNRdDo6cmVmcmVzaFBsdWdp bnMoKQogCiB2b2lkIFBsYXRmb3JtU3RyYXRlZ2llc1F0OjpnZXRQbHVnaW5JbmZvKGNvbnN0IFdl YkNvcmU6OlBhZ2UqIHBhZ2UsIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYgb3V0UGx1Z2lu cykKIHsKLSAgICBRV2ViUGFnZUFkYXB0ZXIqIHFQYWdlID0gc3RhdGljX2Nhc3Q8Q2hyb21lQ2xp ZW50UXQqPihwYWdlLT5jaHJvbWUoKS5jbGllbnQoKSktPm1fd2ViUGFnZTsKKyAgICBRV2ViUGFn ZUFkYXB0ZXIqIHFQYWdlID0gMDsKKyAgICBpZiAoIXBhZ2UtPmNocm9tZSgpLmNsaWVudCgpLT5p c0VtcHR5Q2hyb21lQ2xpZW50KCkpCisgICAgICAgIHFQYWdlID0gc3RhdGljX2Nhc3Q8Q2hyb21l Q2xpZW50UXQqPihwYWdlLT5jaHJvbWUoKS5jbGllbnQoKSktPm1fd2ViUGFnZTsKKwogICAgIFFX ZWJQbHVnaW5GYWN0b3J5KiBmYWN0b3J5OwogICAgIGlmIChxUGFnZSAmJiAoZmFjdG9yeSA9IHFQ YWdlLT5wbHVnaW5GYWN0b3J5KSkgewogCg==