116251 2013-05-16 16:29:21 -0700 [wk2] didGetImageForFindMatch can return a null image 2013-05-16 16:48:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue sam simon.fraser oldest_to_newest 890034 0 thorton 2013-05-16 16:29:21 -0700 FindController::getFindIndicatorBitmapAndRect says: // Selection rect can be empty for matches that are currently obscured from view. And then returns a null handle. Which we then try to create a ShareableBitmap from, and then a WebImage from that. We end up getting a null ShareableBitmap in debug builds, or crashing when trying to use the WebImage in release builds (because m_bitmap is null). We should not didGetImageForFindMatch if we didn't get an image for the find match... <rdar://problem/13277246> 890039 1 201999 thorton 2013-05-16 16:39:50 -0700 Created attachment 201999 patch 890040 2 commit-queue 2013-05-16 16:41:55 -0700 Attachment 201999 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 890042 3 201999 thorton 2013-05-16 16:43:40 -0700 Comment on attachment 201999 patch View in context: https://bugs.webkit.org/attachment.cgi?id=201999&action=review > Source/WebKit2/ChangeLog:4 > + https://bugs.webkit.org/process_bug.cgi :\ 890044 4 201999 simon.fraser 2013-05-16 16:45:49 -0700 Comment on attachment 201999 patch r=me if you fix stuff. 890046 5 thorton 2013-05-16 16:48:35 -0700 http://trac.webkit.org/changeset/150212 201999 2013-05-16 16:39:50 -0700 2013-05-16 16:45:48 -0700 patch find.diff text/plain 1360 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2NDljMWFkLi43ZGYyMjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDUtMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gZGlkR2V0SW1hZ2VGb3JGaW5kTWF0Y2ggY2FuIHJldHVybiBhIG51bGwg aW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvcHJvY2Vzc19idWcuY2dpCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzI3NzI0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBzZW5kIGRpZEdldEltYWdlRm9yRmluZE1h dGNoIGlmIHdlIGRpZG4ndCBnZXQgYW4gaW1hZ2UgZm9yCisgICAgICAgIHRoZSBmaW5kIG1hdGNo LCB3aGljaCBjYW4gaGFwcGVuIGlmIHRoZSBzZWxlY3Rpb24gaXMgbm90IHZpc2libGUuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwOgorICAgICAgICAo V2ViS2l0OjpGaW5kQ29udHJvbGxlcjo6Z2V0SW1hZ2VGb3JGaW5kTWF0Y2gpOgorCiAyMDEzLTA1 LTE2ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtl IHRoZSBGaW5kIEJhbm5lciBpbiBTYWZhcmkgd29yayBhZ2FpbiB3aXRoIHRoZSBkb2NrZWQgV2Vi IEluc3BlY3Rvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9GaW5kQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv RmluZENvbnRyb2xsZXIuY3BwCmluZGV4IDM1MGU2OTguLmQ4MGQxZGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcApAQCAt MjUxLDYgKzI1MSw5IEBAIHZvaWQgRmluZENvbnRyb2xsZXI6OmdldEltYWdlRm9yRmluZE1hdGNo KHVpbnQzMl90IG1hdGNoSW5kZXgpCiAKICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPnNldFNlbGVj dGlvbihvbGRTZWxlY3Rpb24pOwogCisgICAgaWYgKGhhbmRsZS5pc051bGwoKSkKKyAgICAgICAg cmV0dXJuOworCiAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRp ZEdldEltYWdlRm9yRmluZE1hdGNoKGhhbmRsZSwgbWF0Y2hJbmRleCkpOwogfQogCg==