116240 2013-05-16 12:12:50 -0700 [Mac] fast/flexbox/auto-height-with-flex.html fails intermittently 2013-05-17 11:40:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa hyatt bdakin commit-queue esprehn+autocc glenn hyatt simon.fraser oldest_to_newest 889953 0 rniwa 2013-05-16 12:12:50 -0700 fast/flexbox/auto-height-with-flex.html has been failing intermittently on Mac release builders ever since they were added: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fflexbox%2Fauto-height-with-flex.html e.g. http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r150193%20(10028)/results.html 889957 1 rniwa 2013-05-16 12:19:06 -0700 http://trac.webkit.org/changeset/150201 890510 2 202117 hyatt 2013-05-17 10:37:03 -0700 Created attachment 202117 Patch 890516 3 202117 darin 2013-05-17 10:43:00 -0700 Comment on attachment 202117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202117&action=review r=me but consider my better if condition > Source/WebCore/rendering/RenderFlexibleBox.cpp:529 > + if (contentLogicalHeight == LayoutUnit::max()) > + contentLogicalHeight -= borderPaddingAndScrollbar; This should be: if (contentLogicalHeight > LayoutUnit::max() - borderPaddingAndScrollbar) It’s also awkward to change contentLogicalHeight in place. 890549 4 hyatt 2013-05-17 11:40:58 -0700 Fixed in r150278. 202117 2013-05-17 10:37:03 -0700 2013-05-17 10:43:00 -0700 Patch patch.txt text/plain 1918 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDI3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTE3ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBmYXN0L2ZsZXhib3gvYXV0by1oZWln aHQtd2l0aC1mbGV4Lmh0bWwgZmFpbGluZyBvbmx5IG9uIHJlbGVhc2UgYnVpbGRzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MjQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBtYWluQXhp c0NvbnRlbnRFeHRlbnQgbWV0aG9kIHNvIG5vIG92ZXJmbG93IG9jY3Vycywgc2luY2UgaXQKKyAg ICAgICAgZG9lc24ndCB3b3JrIHJpZ2h0IG9uIHJlbGVhc2UgYnVpbGRzLgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckZsZXhpYmxlQm94OjptYWluQXhpc0NvbnRlbnRFeHRlbnQpOgorCiAyMDEzLTA1LTE3ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBbRUZMXSBNb3ZlIEVGTCBwb3J0 IG9mZiBsZWdhY3kgY2xpcGJvYXJkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRmxleGlibGVCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbGV4aWJsZUJveC5jcHAJKHJldmlzaW9uIDE1MDA4NykKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUy NSw4ICs1MjUsOSBAQCBMYXlvdXRVbml0IFJlbmRlckZsZXhpYmxlQm94OjptYWluQXhpc0NvCiAg ICAgaWYgKGlzQ29sdW1uRmxvdygpKSB7CiAgICAgICAgIExvZ2ljYWxFeHRlbnRDb21wdXRlZFZh bHVlcyBjb21wdXRlZFZhbHVlczsKICAgICAgICAgTGF5b3V0VW5pdCBib3JkZXJQYWRkaW5nQW5k U2Nyb2xsYmFyID0gYm9yZGVyQW5kUGFkZGluZ0xvZ2ljYWxIZWlnaHQoKSArIHNjcm9sbGJhckxv Z2ljYWxIZWlnaHQoKTsKLSAgICAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIHN0ZDptYXggb25j ZSB3ZSBlbmFibGUgc2F0dXJhdGVkIGxheW91dCBhcml0aG1ldGljLiBJdCdzIGp1c3QgaGVyZSB0 byBoYW5kbGUgb3ZlcmZsb3cuCi0gICAgICAgIExheW91dFVuaXQgYm9yZGVyQm94TG9naWNhbEhl aWdodCA9IHN0ZDo6bWF4KGNvbnRlbnRMb2dpY2FsSGVpZ2h0LCBjb250ZW50TG9naWNhbEhlaWdo dCArIGJvcmRlclBhZGRpbmdBbmRTY3JvbGxiYXIpOworICAgICAgICBpZiAoY29udGVudExvZ2lj YWxIZWlnaHQgPT0gTGF5b3V0VW5pdDo6bWF4KCkpCisgICAgICAgICAgICBjb250ZW50TG9naWNh bEhlaWdodCAtPSBib3JkZXJQYWRkaW5nQW5kU2Nyb2xsYmFyOworICAgICAgICBMYXlvdXRVbml0 IGJvcmRlckJveExvZ2ljYWxIZWlnaHQgPSBjb250ZW50TG9naWNhbEhlaWdodCArIGJvcmRlclBh ZGRpbmdBbmRTY3JvbGxiYXI7CiAgICAgICAgIGNvbXB1dGVMb2dpY2FsSGVpZ2h0KGJvcmRlckJv eExvZ2ljYWxIZWlnaHQsIGxvZ2ljYWxUb3AoKSwgY29tcHV0ZWRWYWx1ZXMpOwogICAgICAgICBp ZiAoY29tcHV0ZWRWYWx1ZXMubV9leHRlbnQgPT0gTGF5b3V0VW5pdDo6bWF4KCkpCiAgICAgICAg ICAgICByZXR1cm4gY29tcHV0ZWRWYWx1ZXMubV9leHRlbnQ7Cg==