116231 2013-05-16 09:07:44 -0700 Enable the CSSVariables setting in css-variable-definition.html test 2013-05-16 10:06:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar darin svillar oldest_to_newest 889857 0 svillar 2013-05-16 09:07:44 -0700 Enable the CSSVariables setting in css-variable-definition.html test 889858 1 201964 svillar 2013-05-16 09:09:53 -0700 Created attachment 201964 Patch 889859 2 201964 mrobinson 2013-05-16 09:12:17 -0700 Comment on attachment 201964 Patch Doesn't this allow unskipping some tests? 889861 3 svillar 2013-05-16 09:15:45 -0700 (In reply to comment #2) > (From update of attachment 201964 [details]) > Doesn't this allow unskipping some tests? I don't get what you mean. The patch fixes the test. It was not failing because the only difference in the output (if the CSS variables stuff is not enabled) is the text color. So both the test and the ref test where showing the text without any color because the CSS variables setting was not enabled at runtime.. 889872 4 201964 kling 2013-05-16 09:54:17 -0700 Comment on attachment 201964 Patch Oops! Funny bug :) r=me 889884 5 201964 svillar 2013-05-16 10:06:32 -0700 Comment on attachment 201964 Patch Clearing flags on attachment: 201964 Committed r150184: <http://trac.webkit.org/changeset/150184> 889885 6 svillar 2013-05-16 10:06:38 -0700 All reviewed patches have been landed. Closing bug. 201964 2013-05-16 09:09:53 -0700 2013-05-16 10:06:32 -0700 Patch bug-116231-20130516180846.patch text/plain 2713 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTAzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTk0NDExNmEzZWJjMjFhZWEyYmM1 OGYzMGZkNjBmYThlYTc2ZDAxMC4uYzkzMjc0ZGQ0N2UxMDE1MDFiNzlhNDU3NzI4NTk5ODRlOGE3 ZWNlNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTE2ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEVuYWJsZSB0aGUgQ1NTVmFyaWFi bGVzIHNldHRpbmcgaW4gY3NzLXZhcmlhYmxlLWRlZmluaXRpb24uaHRtbCB0ZXN0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYyMzEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDU1NWYXJpYWJsZXNFbmFi bGVkIHNldHRpbmcgbXVzdCBiZSBzZXQgdG8gdHJ1ZSB0byBhbGxvdworICAgICAgICBDU1NWYXJp YWJsZXMgYXQgcnVudGltZS4KKworICAgICAgICBNb2RpZmllZCBhbHNvIHRoZSBpbmRlbnQgc2l6 ZSB0byA0IHNwYWNlcy4KKworICAgICAgICAqIGNzczMvY3NzLXZhcmlhYmxlLWRlZmluaXRpb24t ZXhwZWN0ZWQuaHRtbDoKKyAgICAgICAgKiBjc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLmh0 bWw6CisKIDIwMTMtMDUtMTQgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CiAKICAg ICAgICAgW0NTUyBFeGNsdXNpb25zXSBTb21lIGxheW91dCB0ZXN0cyBmYWlsIHRvIGFjY291bnQg Zm9yIGlubGluZSBwaXhlbCBzbmFwcGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9j c3MtdmFyaWFibGUtZGVmaW5pdGlvbi1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9j c3MtdmFyaWFibGUtZGVmaW5pdGlvbi1leHBlY3RlZC5odG1sCmluZGV4IGY1MzA0YjQ5MDk4MDUw OTcwNDc5YzNhMjE0ZmFlNjRiOTIwOWZiODcuLmUwNThlODY1ZTk1YmRlMmU5ZTExMGEzYmM0NDA1 YTU0YzY2ZDEwYTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NzczMvY3NzLXZhcmlhYmxlLWRl ZmluaXRpb24tZXhwZWN0ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJs ZS1kZWZpbml0aW9uLWV4cGVjdGVkLmh0bWwKQEAgLTEsMTQgKzEsMTcgQEAKIDxodG1sPgorPHNj cmlwdD4KKyAgICBpbnRlcm5hbHMuc2V0dGluZ3Muc2V0Q1NTVmFyaWFibGVzRW5hYmxlZCh0cnVl KTsKKzwvc2NyaXB0PgogPHN0eWxlPgotICA6cm9vdCB7Ci0gICAgICAtd2Via2l0LXZhci1teWNv bG9yOiByZWQ7Ci0gIH0KLSAgZGl2IHsKLSAgICAgIGNvbG9yOiAtd2Via2l0LXZhcihteWNvbG9y KTsKLSAgfQorICAgIDpyb290IHsKKyAgICAgICAgLXdlYmtpdC12YXItbXljb2xvcjogcmVkOwor ICAgIH0KKyAgICBkaXYgeworICAgICAgICBjb2xvcjogLXdlYmtpdC12YXIobXljb2xvcik7Cisg ICAgfQogPC9zdHlsZT4KIDxib2R5PgotICA8cD5DaGVjayB0aGF0IGEgQ1NTIHZhcmlhYmxlIGRl ZmluaXRpb24gYWNjZXB0cyBzcGFjZXMgYmVmb3JlIHRoZSAnOic8L3A+Ci0gIDxkaXY+VGhpcyB0 ZXh0IHNob3VsZCBiZSByZWQ8L2Rpdj4KKyAgICA8cD5DaGVjayB0aGF0IGEgQ1NTIHZhcmlhYmxl IGRlZmluaXRpb24gYWNjZXB0cyBzcGFjZXMgYmVmb3JlIHRoZSAnOic8L3A+CisgICAgPGRpdj5U aGlzIHRleHQgc2hvdWxkIGJlIHJlZDwvZGl2PgogPC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY3NzMy9jc3MtdmFyaWFibGUtZGVmaW5pdGlvbi5odG1sIGIvTGF5b3V0 VGVzdHMvY3NzMy9jc3MtdmFyaWFibGUtZGVmaW5pdGlvbi5odG1sCmluZGV4IGE3Y2Y4NjU5YmNl MzczYWIxNjQ5NTU4MjlmYWM5NGUwZDIwNzFiM2QuLjMyMjNmZGM0OWY3MzUyNjVmNDYxYmQ4ZmE4 OTkzMWI1ODEyNDk3MTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NzczMvY3NzLXZhcmlhYmxl LWRlZmluaXRpb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1kZWZp bml0aW9uLmh0bWwKQEAgLTEsMTQgKzEsMTcgQEAKIDxodG1sPgorPHNjcmlwdD4KKyAgICBpbnRl cm5hbHMuc2V0dGluZ3Muc2V0Q1NTVmFyaWFibGVzRW5hYmxlZCh0cnVlKTsKKzwvc2NyaXB0Pgog PHN0eWxlPgotICA6cm9vdCB7Ci0gICAgICAtd2Via2l0LXZhci1teWNvbG9yIDogcmVkOwotICB9 Ci0gIGRpdiB7Ci0gICAgICBjb2xvcjogLXdlYmtpdC12YXIobXljb2xvcik7Ci0gIH0KKyAgICA6 cm9vdCB7CisgICAgICAgIC13ZWJraXQtdmFyLW15Y29sb3IgOiByZWQ7CisgICAgfQorICAgIGRp diB7CisgICAgICAgIGNvbG9yOiAtd2Via2l0LXZhcihteWNvbG9yKTsKKyAgICB9CiA8L3N0eWxl PgogPGJvZHk+Ci0gIDxwPkNoZWNrIHRoYXQgYSBDU1MgdmFyaWFibGUgZGVmaW5pdGlvbiBhY2Nl cHRzIHNwYWNlcyBiZWZvcmUgdGhlICc6JzwvcD4KLSAgPGRpdj5UaGlzIHRleHQgc2hvdWxkIGJl IHJlZDwvZGl2PgorICAgIDxwPkNoZWNrIHRoYXQgYSBDU1MgdmFyaWFibGUgZGVmaW5pdGlvbiBh Y2NlcHRzIHNwYWNlcyBiZWZvcmUgdGhlICc6JzwvcD4KKyAgICA8ZGl2PlRoaXMgdGV4dCBzaG91 bGQgYmUgcmVkPC9kaXY+CiA8L2JvZHk+CiA8L2h0bWw+Cg==