116230 2013-05-16 08:56:58 -0700 Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInterfaceText 2013-05-16 20:16:56 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 elima webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs mario oldest_to_newest 889851 0 elima 2013-05-16 08:56:58 -0700 webkitAccessibleTextGetTextForOffset() method in WebKitAccessibleInterfaceText is only implemented by GTK port, however the 'textPosition' argument is not listed as unused param for the rest of the ports, causing a warning. 889856 1 201963 elima 2013-05-16 09:02:31 -0700 Created attachment 201963 patch 889860 2 201963 mario 2013-05-16 09:13:01 -0700 Comment on attachment 201963 patch Looks good to me, sorry for having forgotten about this in the first place 890112 3 201963 commit-queue 2013-05-16 20:16:54 -0700 Comment on attachment 201963 patch Clearing flags on attachment: 201963 Committed r150236: <http://trac.webkit.org/changeset/150236> 890113 4 commit-queue 2013-05-16 20:16:56 -0700 All reviewed patches have been landed. Closing bug. 201963 2013-05-16 09:02:31 -0700 2013-05-16 20:16:54 -0700 patch 0001-Missing-UNUSED_PARAM-macro-for-textPosition-argument.patch text/plain 2128 elima RnJvbSA2ZTQzOWE2NTU3MzI5ZjNlNmYzOGY1OTBhYTgyODEzYWViYmYxYWZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFZHVhcmRvIExpbWEgTWl0ZXYgPGVsaW1hQGlnYWxpYS5jb20+ CkRhdGU6IFRodSwgMTYgTWF5IDIwMTMgMTc6NTc6NTUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN aXNzaW5nIFVOVVNFRF9QQVJBTSBtYWNybyBmb3IgdGV4dFBvc2l0aW9uIGFyZ3VtZW50IGluCiBX ZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNjIzMAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcg ZnVuY3Rpb25hbGl0eSwgbm8gbmV3IHRlc3RzLgoKKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHA6Cih3ZWJraXRBY2Nlc3NpYmxlVGV4dEdldFRleHRG b3JPZmZzZXQpOiBMaXN0IHRleHRQb3NpdGlvbiBhcmd1bWVudCBhcwp1bnVzZWQgcGFyYW1ldGVy IGZvciBhbGwgcGxhdGZvcm1zIGV4Y2VwdCBHVEsuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysr CiAuLi4vYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3Bw ICAgfCAgICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBiMDVlNGRkLi5hNTkwMjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMt MDUtMTYgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+CisKKyAgICAgICAg TWlzc2luZyBVTlVTRURfUEFSQU0gbWFjcm8gZm9yIHRleHRQb3NpdGlvbiBhcmd1bWVudCBpbiBX ZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHksIG5vIG5ldyB0ZXN0cy4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VU ZXh0LmNwcDoKKyAgICAgICAgKHdlYmtpdEFjY2Vzc2libGVUZXh0R2V0VGV4dEZvck9mZnNldCk6 IExpc3QgdGV4dFBvc2l0aW9uIGFyZ3VtZW50IGFzCisgICAgICAgIHVudXNlZCBwYXJhbWV0ZXIg Zm9yIGFsbCBwbGF0Zm9ybXMgZXhjZXB0IEdUSy4KKwogMjAxMy0wNS0xNCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTQ3 NTQ4KTogQnJva2VuIGNvbWJvYm94ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VUZXh0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VUZXh0LmNw cAppbmRleCBiOGFlYzM0Li43YzIwM2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRl eHQuY3BwCkBAIC02MDMsNiArNjAzLDcgQEAgc3RhdGljIGdjaGFyKiB3ZWJraXRBY2Nlc3NpYmxl VGV4dEdldFRleHRGb3JPZmZzZXQoQXRrVGV4dCogdGV4dCwgZ2ludCBvZmZzZXQsIEEKICAgICBV TlVTRURfUEFSQU0odGV4dCk7CiAgICAgVU5VU0VEX1BBUkFNKG9mZnNldCk7CiAgICAgVU5VU0VE X1BBUkFNKGJvdW5kYXJ5VHlwZSk7CisgICAgVU5VU0VEX1BBUkFNKHRleHRQb3NpdGlvbik7CiAg ICAgVU5VU0VEX1BBUkFNKHN0YXJ0T2Zmc2V0KTsKICAgICBVTlVTRURfUEFSQU0oZW5kT2Zmc2V0 KTsKIAotLSAKMS43LjEwLjQKCg==