116229 2013-05-16 08:56:53 -0700 [jhbuild] Should remove the sources directory as well when cleaning 2013-05-31 02:28:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo mrobinson pnormand oldest_to_newest 889850 0 gustavo 2013-05-16 08:56:53 -0700 [jhbuild] Should remove the sources directory as well when cleaning 889852 1 201962 gustavo 2013-05-16 08:57:35 -0700 Created attachment 201962 Patch 889854 2 gustavo 2013-05-16 08:59:27 -0700 This build failure resulted from jhbuild not noticing the patches applied to a source tree have changed: https://webkit-queues.appspot.com/results/484327 Although this is arguably a bug in jhbuild, we have suffered problems with builds failing because the clean was not clean enough before, and I couldn't think of a reason why we should not want a full clean rebuild (including checkout and patching) when changing the jhbuild configuration, so this is my proposal. 889893 3 mrobinson 2013-05-16 10:29:43 -0700 Hrm. Isn't it a bit of pain to redownload everything? 889904 4 gustavo 2013-05-16 10:57:56 -0700 It is indeed, but I think we change the jhbuild modules seldom enough that the reduced complexity pays off. 889906 5 201962 mrobinson 2013-05-16 11:02:12 -0700 Comment on attachment 201962 Patch Okay. We can give it a shot and then rework it if there are mobs outside our houses. :) 889950 6 201962 gustavo 2013-05-16 12:09:32 -0700 Comment on attachment 201962 Patch Clearing flags on attachment: 201962 Committed r150198: <http://trac.webkit.org/changeset/150198> 889951 7 gustavo 2013-05-16 12:09:38 -0700 All reviewed patches have been landed. Closing bug. 895832 8 pnormand 2013-05-31 02:28:07 -0700 This is a radical change... Can't we instead make jhbuild smarter? Removing gigabytes of Source/ without even a confirmation prompt was a bad surprise for me this morning... 201962 2013-05-16 08:57:35 -0700 2013-05-16 12:09:32 -0700 Patch bug-116229-20130516125628.patch text/plain 1571 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGFiYjU0NzRjOTdlOTA3NTFkMGYxMzdmYTNjNTg0OTNi NmI2M2Q5NC4uZDNiOGQ0ZmYxYTFkYjFlYTA3NjNkZTJlMzA0MDg1YWYzMzYwODkwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA1LTE2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFA Y29sbGFib3JhLmNvbT4KKworICAgICAgICBbamhidWlsZF0gU2hvdWxkIHJlbW92ZSB0aGUgc291 cmNlcyBkaXJlY3RvcnkgYXMgd2VsbCB3aGVuIGNsZWFuaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYyMjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdC1saWJz LWpoYnVpbGQ6CisgICAgICAgIChjbGVhbkpoYnVpbGQpOiByZW1vdmUgdGhlIFNvdXJjZSBkaXJl Y3RvcnkgYXMgd2VsbCB3aGVuIGNsZWFuaW5nLgorCiAyMDEzLTA1LTE1ICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgQWxsb3cgaHR0cCB0ZXN0cyBvbiBB cmNoIExpbnV4CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtbGlicy1q aGJ1aWxkIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWxpYnMtamhidWlsZAppbmRleCA1 MTYwNWJkZWQwMTg4MzFjM2ZkMmVjMzUyNmFkMjk0MGU2NDA0YTM0Li5hMTQ4ODg3NmE5NWFmYzBj ODRkMGNlMjJmYTY0NjI0NWU0ZDk4ODUyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0 ZS13ZWJraXQtbGlicy1qaGJ1aWxkCisrKyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1s aWJzLWpoYnVpbGQKQEAgLTEwMSw4ICsxMDEsNiBAQCBzdWIgcnVuSmhidWlsZAogCiBzdWIgY2xl YW5KaGJ1aWxkKCkKIHsKLSAgICBydW5KaGJ1aWxkKCJjbGVhbiIpOwotCiAgICAgIyBJZiB0aGUg Y29uZmlndXJhdGlvbiBjaGFuZ2VkLCBkZXBlbmRlbmNpZXMgbWF5IGhhdmUgYmVlbiByZW1vdmVk LgogICAgICMgU2luY2Ugd2UgbGFjayBhIGdyYW51bGFyIHdheSBvZiB1bmluc3RhbGxpbmcgdGhv c2Ugd2Ugd2lwZSBvdXQgdGhlCiAgICAgIyBqaGJ1aWxkIHJvb3QgYW5kIHN0YXJ0IGZyb20gc2Ny YXRjaC4KQEAgLTExMCw2ICsxMDgsMTAgQEAgc3ViIGNsZWFuSmhidWlsZCgpCiAgICAgaWYgKHN5 c3RlbSgicm0gLXJmICRqaGJ1aWxkUGF0aC9Sb290IikgbmUgMCkgewogICAgICAgICBkaWUgIkNs ZWFuaW5nIGpoYnVpbGQgcm9vdCBmYWlsZWQhIjsKICAgICB9CisKKyAgICBpZiAoc3lzdGVtKCJy bSAtcmYgJGpoYnVpbGRQYXRoL1NvdXJjZSIpIG5lIDApIHsKKyAgICAgICAgZGllICJDbGVhbmlu ZyBqaGJ1aWxkIHNvdXJjZXMgZmFpbGVkISI7CisgICAgfQogfQogCiBkZWxldGUgJEVOVntBUl9G TEFHU30gaWYgZXhpc3RzICRFTlZ7QVJfRkxBR1N9Owo=