116208 2013-05-15 23:31:39 -0700 Port functions for path handling to Windows CE in FileSystemWin 2013-05-16 19:46:52 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga ap bfulgham commit-queue darin oldest_to_newest 889704 0 paroga 2013-05-15 23:31:39 -0700 Port funcions for pathhandling to Windows CE in FileSystemWin 889707 1 201926 paroga 2013-05-15 23:37:20 -0700 Created attachment 201926 Patch 889805 2 201953 paroga 2013-05-16 07:18:15 -0700 Created attachment 201953 Patch 889869 3 ap 2013-05-16 09:44:06 -0700 I'm surprised by the direction of this patch. Aren't we usually changing code in the opposite direction, from ifdefs to separate files for each platform? 889897 4 paroga 2013-05-16 10:41:48 -0700 (In reply to comment #3) > I'm surprised by the direction of this patch. Aren't we usually changing code in the opposite direction, from ifdefs to separate files for each platform? WinCE is more like a special version of Windows. If you look at the current Win.cpp files you find many of this kind of #if, since they share 95 percent of the code and imho it would be overkill to do it with different files. Also it's in the _platform_ directory, where it should be ok. It like a BUILDING_FOR_LION guard, where you have no extra files too. 890101 5 201953 commit-queue 2013-05-16 19:46:50 -0700 Comment on attachment 201953 Patch Clearing flags on attachment: 201953 Committed r150231: <http://trac.webkit.org/changeset/150231> 890102 6 commit-queue 2013-05-16 19:46:52 -0700 All reviewed patches have been landed. Closing bug. 201926 2013-05-15 23:37:20 -0700 2013-05-16 07:18:15 -0700 Patch bug-116208.patch text/plain 2561 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjN2MwM2U4Li4xYmEzOTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTMtMDUtMTUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK KyAgICAgICAgUG9ydCBmdW5jaW9ucyBmb3IgcGF0aGhhbmRsaW5nIHRvIFdpbmRvd3MgQ0UgaW4g RmlsZVN5c3RlbVdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE2MjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyB3aWxsIGFsbG93IHVzIHRvIHJlbW92ZSBGaWxlU3lzdGVtV2luQ0UgaW4gYSBu ZXh0IHN0ZXAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6cGF0aEdldEZpbGVOYW1lKToKKworMjAxMy0wNS0xNSAgUGF0cmljayBHYW5zdGVyZXIg IDxwYXJvZ2FAd2Via2l0Lm9yZz4KKwogICAgICAgICBVc2UgU2V0RmlsZVBvaW50ZXIgaW5zdGVh ZCBvZiBTZXRGaWxlUG9pbnRlckV4IGluIEZpbGVTeXN0ZW1XaW4KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjIwNQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKaW5kZXggY2I4MTRlNS4uNmI1MTUwYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcApAQCAt MTM3LDYgKzEzNywxNiBAQCBTdHJpbmcgcGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGNvbnN0IFN0 cmluZyYgcGF0aCwgY29uc3QgU3RyaW5nJiBjb21wb25lbnQpCiB7CiAgICAgVmVjdG9yPFVDaGFy PiBidWZmZXIoTUFYX1BBVEgpOwogCisjaWYgT1MoV0lOQ0UpCisgICAgYnVmZmVyLmFwcGVuZChw YXRoLmNoYXJhY3RlcnMoKSwgcGF0aC5sZW5ndGgoKSk7CisKKyAgICBVQ2hhciBsYXN0UGF0aENo YXJhY3RlciA9IHBhdGhbcGF0aC5sZW5ndGgoKSAtIDFdOworICAgIGlmIChsYXN0UGF0aENoYXJh Y3RlciAhPSBMJ1xcJyAmJiBsYXN0UGF0aENoYXJhY3RlciAhPSBMJy8nICYmIGNvbXBvbmVudFsw XSAhPSBMJ1xcJyAmJiBjb21wb25lbnRbMF0gIT0gTCcvJykKKyAgICAgICAgYnVmZmVyLmFwcGVu ZChQbGF0Zm9ybUZpbGVQYXRoU2VwYXJhdG9yKTsKKworICAgIGJ1ZmZlci5hcHBlbmQoY29tcG9u ZW50LmNoYXJhY3RlcnMoKSwgY29tcG9uZW50Lmxlbmd0aCgpKTsKKyAgICBidWZmZXIuc2hyaW5r VG9GaXQoKTsKKyNlbHNlCiAgICAgaWYgKHBhdGgubGVuZ3RoKCkgKyAxID4gYnVmZmVyLnNpemUo KSkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogCkBAIC0xNDgsNiArMTU4LDcgQEAgU3RyaW5n IHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChjb25zdCBTdHJpbmcmIHBhdGgsIGNvbnN0IFN0cmlu ZyYgY29tcG9uZW50KQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKICAgICBidWZmZXIucmVz aXplKHdjc2xlbihidWZmZXIuZGF0YSgpKSk7CisjZW5kaWYKIAogICAgIHJldHVybiBTdHJpbmc6 OmFkb3B0KGJ1ZmZlcik7CiB9CkBAIC0xOTAsNyArMjAxLDI0IEBAIFN0cmluZyBob21lRGlyZWN0 b3J5UGF0aCgpCiAKIFN0cmluZyBwYXRoR2V0RmlsZU5hbWUoY29uc3QgU3RyaW5nJiBwYXRoKQog eworI2lmIE9TKFdJTkNFKQorICAgIHNpemVfdCBwb3NpdGlvblNsYXNoID0gcGF0aC5yZXZlcnNl RmluZCgnLycpOworICAgIHNpemVfdCBwb3NpdGlvbkJhY2tzbGFzaCA9IHBhdGgucmV2ZXJzZUZp bmQoJ1xcJyk7CisKKyAgICBzaXplX3QgcG9zaXRpb247CisgICAgaWYgKHBvc2l0aW9uU2xhc2gg PT0gbm90Rm91bmQpCisgICAgICAgIHBvc2l0aW9uID0gcG9zaXRpb25CYWNrc2xhc2g7CisgICAg ZWxzZSBpZiAocG9zaXRpb25CYWNrc2xhc2ggPT0gbm90Rm91bmQpCisgICAgICAgIHBvc2l0aW9u ID0gIHBvc2l0aW9uU2xhc2g7CisgICAgZWxzZQorICAgICAgICBwb3NpdGlvbiA9IHN0ZDo6bWF4 KHBvc2l0aW9uU2xhc2gsIHBvc2l0aW9uQmFja3NsYXNoKTsKKworICAgIGlmIChwb3NpdGlvbiA9 PSBub3RGb3VuZCkKKyAgICAgICAgcmV0dXJuIHBhdGg7CisgICAgcmV0dXJuIHBhdGguc3Vic3Ry aW5nKHBvc2l0aW9uICsgMSk7CisjZWxzZQogICAgIHJldHVybiBTdHJpbmcoOjpQYXRoRmluZEZp bGVOYW1lKFN0cmluZyhwYXRoKS5jaGFyYWN0ZXJzV2l0aE51bGxUZXJtaW5hdGlvbigpKSk7Cisj ZW5kaWYKIH0KIAogU3RyaW5nIGRpcmVjdG9yeU5hbWUoY29uc3QgU3RyaW5nJiBwYXRoKQo= 201953 2013-05-16 07:18:15 -0700 2013-05-16 19:46:50 -0700 Patch bug-116208.patch text/plain 2562 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjN2MwM2U4Li4xYmEzOTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTMtMDUtMTUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK KyAgICAgICAgUG9ydCBmdW5jdGlvbnMgZm9yIHBhdGhoYW5kbGluZyB0byBXaW5kb3dzIENFIGlu IEZpbGVTeXN0ZW1XaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNjIwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgd2lsbCBhbGxvdyB1cyB0byByZW1vdmUgRmlsZVN5c3RlbVdpbkNFIGluIGEg bmV4dCBzdGVwLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KToKKyAgICAgICAgKFdl YkNvcmU6OnBhdGhHZXRGaWxlTmFtZSk6CisKKzIwMTMtMDUtMTUgIFBhdHJpY2sgR2Fuc3RlcmVy ICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKICAgICAgICAgVXNlIFNldEZpbGVQb2ludGVyIGluc3Rl YWQgb2YgU2V0RmlsZVBvaW50ZXJFeCBpbiBGaWxlU3lzdGVtV2luCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYyMDUKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCmluZGV4IGNiODE0ZTUuLjZiNTE1MGMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKQEAg LTEzNyw2ICsxMzcsMTYgQEAgU3RyaW5nIHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChjb25zdCBT dHJpbmcmIHBhdGgsIGNvbnN0IFN0cmluZyYgY29tcG9uZW50KQogewogICAgIFZlY3RvcjxVQ2hh cj4gYnVmZmVyKE1BWF9QQVRIKTsKIAorI2lmIE9TKFdJTkNFKQorICAgIGJ1ZmZlci5hcHBlbmQo cGF0aC5jaGFyYWN0ZXJzKCksIHBhdGgubGVuZ3RoKCkpOworCisgICAgVUNoYXIgbGFzdFBhdGhD aGFyYWN0ZXIgPSBwYXRoW3BhdGgubGVuZ3RoKCkgLSAxXTsKKyAgICBpZiAobGFzdFBhdGhDaGFy YWN0ZXIgIT0gTCdcXCcgJiYgbGFzdFBhdGhDaGFyYWN0ZXIgIT0gTCcvJyAmJiBjb21wb25lbnRb MF0gIT0gTCdcXCcgJiYgY29tcG9uZW50WzBdICE9IEwnLycpCisgICAgICAgIGJ1ZmZlci5hcHBl bmQoUGxhdGZvcm1GaWxlUGF0aFNlcGFyYXRvcik7CisKKyAgICBidWZmZXIuYXBwZW5kKGNvbXBv bmVudC5jaGFyYWN0ZXJzKCksIGNvbXBvbmVudC5sZW5ndGgoKSk7CisgICAgYnVmZmVyLnNocmlu a1RvRml0KCk7CisjZWxzZQogICAgIGlmIChwYXRoLmxlbmd0aCgpICsgMSA+IGJ1ZmZlci5zaXpl KCkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKIApAQCAtMTQ4LDYgKzE1OCw3IEBAIFN0cmlu ZyBwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQoY29uc3QgU3RyaW5nJiBwYXRoLCBjb25zdCBTdHJp bmcmIGNvbXBvbmVudCkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogCiAgICAgYnVmZmVyLnJl c2l6ZSh3Y3NsZW4oYnVmZmVyLmRhdGEoKSkpOworI2VuZGlmCiAKICAgICByZXR1cm4gU3RyaW5n OjphZG9wdChidWZmZXIpOwogfQpAQCAtMTkwLDcgKzIwMSwyNCBAQCBTdHJpbmcgaG9tZURpcmVj dG9yeVBhdGgoKQogCiBTdHJpbmcgcGF0aEdldEZpbGVOYW1lKGNvbnN0IFN0cmluZyYgcGF0aCkK IHsKKyNpZiBPUyhXSU5DRSkKKyAgICBzaXplX3QgcG9zaXRpb25TbGFzaCA9IHBhdGgucmV2ZXJz ZUZpbmQoJy8nKTsKKyAgICBzaXplX3QgcG9zaXRpb25CYWNrc2xhc2ggPSBwYXRoLnJldmVyc2VG aW5kKCdcXCcpOworCisgICAgc2l6ZV90IHBvc2l0aW9uOworICAgIGlmIChwb3NpdGlvblNsYXNo ID09IG5vdEZvdW5kKQorICAgICAgICBwb3NpdGlvbiA9IHBvc2l0aW9uQmFja3NsYXNoOworICAg IGVsc2UgaWYgKHBvc2l0aW9uQmFja3NsYXNoID09IG5vdEZvdW5kKQorICAgICAgICBwb3NpdGlv biA9ICBwb3NpdGlvblNsYXNoOworICAgIGVsc2UKKyAgICAgICAgcG9zaXRpb24gPSBzdGQ6Om1h eChwb3NpdGlvblNsYXNoLCBwb3NpdGlvbkJhY2tzbGFzaCk7CisKKyAgICBpZiAocG9zaXRpb24g PT0gbm90Rm91bmQpCisgICAgICAgIHJldHVybiBwYXRoOworICAgIHJldHVybiBwYXRoLnN1YnN0 cmluZyhwb3NpdGlvbiArIDEpOworI2Vsc2UKICAgICByZXR1cm4gU3RyaW5nKDo6UGF0aEZpbmRG aWxlTmFtZShTdHJpbmcocGF0aCkuY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSkpOwor I2VuZGlmCiB9CiAKIFN0cmluZyBkaXJlY3RvcnlOYW1lKGNvbnN0IFN0cmluZyYgcGF0aCkK