116205 2013-05-15 21:49:52 -0700 Use SetFilePointer instead of SetFilePointerEx in FileSystemWin 2013-06-24 07:17:14 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 115246 1 paroga paroga bfulgham commit-queue oldest_to_newest 889679 0 paroga 2013-05-15 21:49:52 -0700 Use SetFilePointer instead of SetFilePointerEx in FileSystemWin 889681 1 201920 paroga 2013-05-15 21:59:42 -0700 Created attachment 201920 Patch 889705 2 201925 paroga 2013-05-15 23:36:04 -0700 Created attachment 201925 Patch 900676 3 201925 rniwa 2013-06-14 15:35:00 -0700 Comment on attachment 201925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201925&action=review > Source/WebCore/platform/win/FileSystemWin.cpp:336 > + if (largeOffset.LowPart == 0xFFFFFFFF && GetLastError() != NO_ERROR) Can we compare LowPart to INVALID_SET_FILE_POINTER instead? 902929 4 205290 paroga 2013-06-24 06:20:09 -0700 Created attachment 205290 Patch for landing 902948 5 205290 commit-queue 2013-06-24 07:17:12 -0700 Comment on attachment 205290 Patch for landing Clearing flags on attachment: 205290 Committed r151909: <http://trac.webkit.org/changeset/151909> 902949 6 commit-queue 2013-06-24 07:17:14 -0700 All reviewed patches have been landed. Closing bug. 201920 2013-05-15 21:59:42 -0700 2013-05-15 23:36:04 -0700 Patch bug-116205.patch text/plain 1626 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzFhNTJmLi5jN2MwM2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDUtMTUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVXNlIFNldEZpbGVQb2ludGVyIGluc3RlYWQgb2YgU2V0RmlsZVBvaW50ZXJFeCBp biBGaWxlU3lzdGVtV2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTYyMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTZXRGaWxlUG9pbnRlckV4IGlzIG5vdCBhdmFpbGFibGUgb24gV2luZG93cyBDRSwg c28gdXNlIFNldEZpbGVQb2ludGVyLgorICAgICAgICBBbHNvIGFkZCBhIGV4dHJhIHJldHVybiBm b3IgdGhlIGNhc2Ugb2YgYW4gZmFpbHVyZS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9GaWxl U3lzdGVtV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9wZW5GaWxlKToKKwogMjAxMy0wNS0x NCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBbV0lO Q0VdIEZpeCBjYWxscyB0byBHbHlwaFBhZ2U6OnNldEdseXBoRGF0YUZvckluZGV4KCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcAppbmRleCA0ODE4Zjg0 Li5jYjgxNGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5 c3RlbVdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1X aW4uY3BwCkBAIC0zMzEsMTIgKzMzMSwxMiBAQCBsb25nIGxvbmcgc2Vla0ZpbGUoUGxhdGZvcm1G aWxlSGFuZGxlIGhhbmRsZSwgbG9uZyBsb25nIG9mZnNldCwgRmlsZVNlZWtPcmlnaW4gbwogICAg IExBUkdFX0lOVEVHRVIgbGFyZ2VPZmZzZXQ7CiAgICAgbGFyZ2VPZmZzZXQuUXVhZFBhcnQgPSBv ZmZzZXQ7CiAKLSAgICBMQVJHRV9JTlRFR0VSIG5ld09mZnNldDsKLSAgICBuZXdPZmZzZXQuUXVh ZFBhcnQgPSAwOworICAgIGxhcmdlT2Zmc2V0Lkxvd1BhcnQgPSBTZXRGaWxlUG9pbnRlcihoYW5k bGUsIGxhcmdlT2Zmc2V0Lkxvd1BhcnQsICZsYXJnZU9mZnNldC5IaWdoUGFydCwgbW92ZU1ldGhv ZCk7CiAKLSAgICBTZXRGaWxlUG9pbnRlckV4KGhhbmRsZSwgbGFyZ2VPZmZzZXQsICZuZXdPZmZz ZXQsIG1vdmVNZXRob2QpOworICAgIGlmIChsYXJnZU9mZnNldC5Mb3dQYXJ0ID09IDB4RkZGRkZG RkYgJiYgR2V0TGFzdEVycm9yKCkgIT0gTk9fRVJST1IpCisgICAgICAgIHJldHVybiAtMTsKIAot ICAgIHJldHVybiBuZXdPZmZzZXQuUXVhZFBhcnQ7CisgICAgcmV0dXJuIGxhcmdlT2Zmc2V0LlF1 YWRQYXJ0OwogfQogCiBpbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlIGhhbmRsZSwg Y29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkK 201925 2013-05-15 23:36:04 -0700 2013-06-24 06:20:09 -0700 Patch bug-116205.patch text/plain 1626 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzFhNTJmLi5jN2MwM2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDUtMTUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVXNlIFNldEZpbGVQb2ludGVyIGluc3RlYWQgb2YgU2V0RmlsZVBvaW50ZXJFeCBp biBGaWxlU3lzdGVtV2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTYyMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTZXRGaWxlUG9pbnRlckV4IGlzIG5vdCBhdmFpbGFibGUgb24gV2luZG93cyBDRSwg c28gdXNlIFNldEZpbGVQb2ludGVyLgorICAgICAgICBBbHNvIGFkZCBhIGV4dHJhIHJldHVybiBm b3IgdGhlIGNhc2Ugb2YgYW4gZmFpbHVyZS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9GaWxl U3lzdGVtV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNlZWtGaWxlKToKKwogMjAxMy0wNS0x NCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBbV0lO Q0VdIEZpeCBjYWxscyB0byBHbHlwaFBhZ2U6OnNldEdseXBoRGF0YUZvckluZGV4KCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcAppbmRleCA0ODE4Zjg0 Li5jYjgxNGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5 c3RlbVdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1X aW4uY3BwCkBAIC0zMzEsMTIgKzMzMSwxMiBAQCBsb25nIGxvbmcgc2Vla0ZpbGUoUGxhdGZvcm1G aWxlSGFuZGxlIGhhbmRsZSwgbG9uZyBsb25nIG9mZnNldCwgRmlsZVNlZWtPcmlnaW4gbwogICAg IExBUkdFX0lOVEVHRVIgbGFyZ2VPZmZzZXQ7CiAgICAgbGFyZ2VPZmZzZXQuUXVhZFBhcnQgPSBv ZmZzZXQ7CiAKLSAgICBMQVJHRV9JTlRFR0VSIG5ld09mZnNldDsKLSAgICBuZXdPZmZzZXQuUXVh ZFBhcnQgPSAwOworICAgIGxhcmdlT2Zmc2V0Lkxvd1BhcnQgPSBTZXRGaWxlUG9pbnRlcihoYW5k bGUsIGxhcmdlT2Zmc2V0Lkxvd1BhcnQsICZsYXJnZU9mZnNldC5IaWdoUGFydCwgbW92ZU1ldGhv ZCk7CiAKLSAgICBTZXRGaWxlUG9pbnRlckV4KGhhbmRsZSwgbGFyZ2VPZmZzZXQsICZuZXdPZmZz ZXQsIG1vdmVNZXRob2QpOworICAgIGlmIChsYXJnZU9mZnNldC5Mb3dQYXJ0ID09IDB4RkZGRkZG RkYgJiYgR2V0TGFzdEVycm9yKCkgIT0gTk9fRVJST1IpCisgICAgICAgIHJldHVybiAtMTsKIAot ICAgIHJldHVybiBuZXdPZmZzZXQuUXVhZFBhcnQ7CisgICAgcmV0dXJuIGxhcmdlT2Zmc2V0LlF1 YWRQYXJ0OwogfQogCiBpbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlIGhhbmRsZSwg Y29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkK 205290 2013-06-24 06:20:09 -0700 2013-06-24 07:17:12 -0700 Patch for landing bug-116205.patch text/plain 1638 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzFhNTJmLi5jN2MwM2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDUtMTUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVXNlIFNldEZpbGVQb2ludGVyIGluc3RlYWQgb2YgU2V0RmlsZVBvaW50ZXJFeCBp biBGaWxlU3lzdGVtV2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTYyMDUKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAg ICAgICAgU2V0RmlsZVBvaW50ZXJFeCBpcyBub3QgYXZhaWxhYmxlIG9uIFdpbmRvd3MgQ0UsIHNv IHVzZSBTZXRGaWxlUG9pbnRlci4KKyAgICAgICAgQWxzbyBhZGQgYSBleHRyYSByZXR1cm4gZm9y IHRoZSBjYXNlIG9mIGFuIGZhaWx1cmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vRmlsZVN5 c3RlbVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzZWVrRmlsZSk6CisKIDIwMTMtMDUtMTQg IFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dJTkNF XSBGaXggY2FsbHMgdG8gR2x5cGhQYWdlOjpzZXRHbHlwaERhdGFGb3JJbmRleCgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKaW5kZXggNDgxOGY4NC4u Y2I4MTRlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0 ZW1XaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2lu LmNwcApAQCAtMzMxLDEyICszMzEsMTIgQEAgbG9uZyBsb25nIHNlZWtGaWxlKFBsYXRmb3JtRmls ZUhhbmRsZSBoYW5kbGUsIGxvbmcgbG9uZyBvZmZzZXQsIEZpbGVTZWVrT3JpZ2luIG8KICAgICBM QVJHRV9JTlRFR0VSIGxhcmdlT2Zmc2V0OwogICAgIGxhcmdlT2Zmc2V0LlF1YWRQYXJ0ID0gb2Zm c2V0OwogCi0gICAgTEFSR0VfSU5URUdFUiBuZXdPZmZzZXQ7Ci0gICAgbmV3T2Zmc2V0LlF1YWRQ YXJ0ID0gMDsKKyAgICBsYXJnZU9mZnNldC5Mb3dQYXJ0ID0gU2V0RmlsZVBvaW50ZXIoaGFuZGxl LCBsYXJnZU9mZnNldC5Mb3dQYXJ0LCAmbGFyZ2VPZmZzZXQuSGlnaFBhcnQsIG1vdmVNZXRob2Qp OwogCi0gICAgU2V0RmlsZVBvaW50ZXJFeChoYW5kbGUsIGxhcmdlT2Zmc2V0LCAmbmV3T2Zmc2V0 LCBtb3ZlTWV0aG9kKTsKKyAgICBpZiAobGFyZ2VPZmZzZXQuTG93UGFydCA9PSBJTlZBTElEX1NF VF9GSUxFX1BPSU5URVIgJiYgR2V0TGFzdEVycm9yKCkgIT0gTk9fRVJST1IpCisgICAgICAgIHJl dHVybiAtMTsKIAotICAgIHJldHVybiBuZXdPZmZzZXQuUXVhZFBhcnQ7CisgICAgcmV0dXJuIGxh cmdlT2Zmc2V0LlF1YWRQYXJ0OwogfQogCiBpbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFu ZGxlIGhhbmRsZSwgY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkK