116202 2013-05-15 19:04:04 -0700 [wk2] Minimum layout width is lost if the WebProcess crashes 2013-05-16 12:08:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca ap sam simon.fraser oldest_to_newest 889629 0 thorton 2013-05-15 19:04:04 -0700 We currently only send the minimum layout width to the WebProcess when the property is set. We also need to send it when the WebProcess is brought up, so that if the WebProcess crashes we send it back over again. <rdar://problem/13202320> 889631 1 201911 thorton 2013-05-15 19:08:21 -0700 Created attachment 201911 patch 889632 2 201911 ap 2013-05-15 19:10:33 -0700 Comment on attachment 201911 patch View in context: https://bugs.webkit.org/attachment.cgi?id=201911&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:539 > + m_process->send(Messages::WebPage::SetMinimumLayoutWidth(m_minimumLayoutWidth), m_pageID, 0); Can this be part of creation parameters, to avoid potential races? 889633 3 201911 thorton 2013-05-15 19:11:44 -0700 Comment on attachment 201911 patch View in context: https://bugs.webkit.org/attachment.cgi?id=201911&action=review >> Source/WebKit2/UIProcess/WebPageProxy.cpp:539 >> + m_process->send(Messages::WebPage::SetMinimumLayoutWidth(m_minimumLayoutWidth), m_pageID, 0); > > Can this be part of creation parameters, to avoid potential races? Aha! I knew there must be an existing mechanism for this. Will fix. 889947 4 201980 thorton 2013-05-16 12:03:59 -0700 Created attachment 201980 patch 889949 5 thorton 2013-05-16 12:08:29 -0700 http://trac.webkit.org/changeset/150197 201911 2013-05-15 19:08:21 -0700 2013-05-16 12:03:59 -0700 patch minimum-width.diff text/plain 2113 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MjNhMmFmLi43ZTcwOGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDUtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gTWluaW11bSBsYXlvdXQgd2lkdGggaXMgbG9zdCBpZiB0aGUgV2ViUHJv Y2VzcyBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTYyMDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzMjAyMzIwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbmQgdGhlIG1pbmltdW0g bGF5b3V0IHdpZHRoIHRvIHRoZSBXZWJQcm9jZXNzIHVwb24gaW5pdGlhbGl6YXRpb24sCisgICAg ICAgIHNvIHRoYXQgY3Jhc2hlZC1hbmQtcmVzdGFydGVkIFdlYlByb2Nlc3NlcyBoYXZlIHRoZSBj b3JyZWN0IHdpZHRoLgorCisgICAgICAgIEFsc28sIHN0b3JlIG1pbmltdW0gbGF5b3V0IHdpZHRo IGNoYW5nZXMgdGhhdCBjb21lIGluIHdoaWxlIHRoZSBXZWJQcm9jZXNzCisgICAgICAgIGlzIG5v dCB2YWxpZCwgc28gdGhhdCB0aGUgY29ycmVjdCB3aWR0aCBpcyBzZW50IG9uY2UgaXQgaXMgcmVz dGFydGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZVdlYlBhZ2UpOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6OnNldE1pbmltdW1MYXlvdXRXaWR0aCk6CisKIDIwMTMtMDUtMTUg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIEFkZCBwYWRkaW5nIHRvIGFsbCBwdWJsaWMgY2xhc3Mgc3RydWN0cyBmb3IgZnV0dXJlIGV4 cGFuc2lvbiB3aXRob3V0IGJyZWFraW5nIEFCSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAppbmRleCAwYzhkZWQ2Li45YzNiNjcxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNTM1LDYgKzUzNSw5IEBAIHZvaWQgV2ViUGFn ZVByb3h5Ojppbml0aWFsaXplV2ViUGFnZSgpCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIG1fcHJv Y2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6U2V0U21hcnRJbnNlcnREZWxldGVFbmFibGVk KG1faXNTbWFydEluc2VydERlbGV0ZUVuYWJsZWQpLCBtX3BhZ2VJRCk7CiAjZW5kaWYKKworICAg IG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6U2V0TWluaW11bUxheW91dFdpZHRo KG1fbWluaW11bUxheW91dFdpZHRoKSwgbV9wYWdlSUQsIDApOworICAgIG1fZHJhd2luZ0FyZWEt Pm1pbmltdW1MYXlvdXRXaWR0aERpZENoYW5nZSgpOwogfQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6 Y2xvc2UoKQpAQCAtNDMxMiwxMCArNDMxNSwxMSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0TWlu aW11bUxheW91dFdpZHRoKGRvdWJsZSBtaW5pbXVtTGF5b3V0V2lkdGgpCiAgICAgaWYgKG1fbWlu aW11bUxheW91dFdpZHRoID09IG1pbmltdW1MYXlvdXRXaWR0aCkKICAgICAgICAgcmV0dXJuOwog CisgICAgbV9taW5pbXVtTGF5b3V0V2lkdGggPSBtaW5pbXVtTGF5b3V0V2lkdGg7CisKICAgICBp ZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9taW5pbXVtTGF5b3V0V2lk dGggPSBtaW5pbXVtTGF5b3V0V2lkdGg7CiAgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlOjpTZXRNaW5pbXVtTGF5b3V0V2lkdGgobWluaW11bUxheW91dFdpZHRoKSwgbV9wYWdl SUQsIDApOwogICAgIG1fZHJhd2luZ0FyZWEtPm1pbmltdW1MYXlvdXRXaWR0aERpZENoYW5nZSgp OwogCg== 201980 2013-05-16 12:03:59 -0700 2013-05-16 12:06:22 -0700 patch minimum-width.diff text/plain 4733 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MjNhMmFmLi41MTZjYWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMg QEAKKzIwMTMtMDUtMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gTWluaW11bSBsYXlvdXQgd2lkdGggaXMgbG9zdCBpZiB0aGUgV2ViUHJv Y2VzcyBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTYyMDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzMjAyMzIwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbmQgdGhlIG1pbmltdW0g bGF5b3V0IHdpZHRoIHRvIHRoZSBXZWJQcm9jZXNzIHVwb24gaW5pdGlhbGl6YXRpb24sCisgICAg ICAgIHNvIHRoYXQgY3Jhc2hlZC1hbmQtcmVzdGFydGVkIFdlYlByb2Nlc3NlcyBoYXZlIHRoZSBj b3JyZWN0IHdpZHRoLgorCisgICAgICAgICogU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRl cnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNv ZGUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzOjpkZWNvZGUp OgorICAgICAgICAqIFNoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmg6CisgICAgICAg IChXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzKToKKyAgICAgICAgQWRkIG1pbmltdW1MYXlvdXRX aWR0aCBXZWJQYWdlIGNyZWF0aW9uIHBhcmFtZXRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNyZWF0aW9u UGFyYW1ldGVycyk6CisgICAgICAgIFNlbmQgdGhlIGN1cnJlbnQgbWluaW11bUxheW91dFdpZHRo IHRvIHRoZSBXZWJQYWdlIHdoZW4gaXQncyBjcmVhdGVkLgorCisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6c2V0TWluaW11bUxheW91dFdpZHRoKToKKyAgICAgICAgU3RvcmUgbWluaW11 bUxheW91dFdpZHRoIGNoYW5nZXMgdGhhdCBjb21lIGluIHdoaWxlIHRoZSBXZWJQcm9jZXNzIGlz CisgICAgICAgIG5vdCB2YWxpZCwgc28gdGhhdCB0aGUgY29ycmVjdCB3aWR0aCBpcyBzZW50IG9u Y2UgaXQgaXMgcmVzdGFydGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdlKToKKyAgICAgICAgU2V0 IG1pbmltdW1MYXlvdXRXaWR0aCB0byB0aGUgdmFsdWUgcHJvdmlkZWQgYnkgb3VyIGNyZWF0aW9u IHBhcmFtZXRlcnMuCisKIDIwMTMtMDUtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBwYWRkaW5nIHRvIGFsbCBwdWJsaWMg Y2xhc3Mgc3RydWN0cyBmb3IgZnV0dXJlIGV4cGFuc2lvbiB3aXRob3V0IGJyZWFraW5nIEFCSQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRl cnMuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMu Y3BwCmluZGV4IDkyZDk4NmYuLjFkNmJmMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5jcHAKQEAgLTYwLDYgKzYwLDcgQEAgdm9p ZCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNvZGUoQ29yZUlQQzo6QXJndW1lbnRFbmNv ZGVyJiBlbmNvZGVyKSBjb25zdAogICAgIGVuY29kZXIgPDwgbWVkaWFWb2x1bWU7CiAgICAgZW5j b2RlciA8PCBtYXlTdGFydE1lZGlhV2hlbkluV2luZG93OwogICAgIGVuY29kZXIgPDwgb3ZlcnJp ZGVQcml2YXRlQnJvd3NpbmdFbmFibGVkOworICAgIGVuY29kZXIgPDwgbWluaW11bUxheW91dFdp ZHRoOwogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIGVuY29kZXIuZW5jb2RlRW51bShsYXllckhv c3RpbmdNb2RlKTsKQEAgLTEyMyw2ICsxMjQsOCBAQCBib29sIFdlYlBhZ2VDcmVhdGlvblBhcmFt ZXRlcnM6OmRlY29kZShDb3JlSVBDOjpBcmd1bWVudERlY29kZXImIGRlY29kZXIsIFdlYlBhZwog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShwYXJhbWV0ZXJz Lm92ZXJyaWRlUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHBhcmFtZXRlcnMubWluaW11bUxheW91dFdpZHRoKSkK KyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICBpZiAo IWRlY29kZXIuZGVjb2RlRW51bShwYXJhbWV0ZXJzLmxheWVySG9zdGluZ01vZGUpKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMuaCBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmgKaW5kZXgg MDAyNzM2MS4uMzNmM2ExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlBh Z2VDcmVhdGlvblBhcmFtZXRlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUGFn ZUNyZWF0aW9uUGFyYW1ldGVycy5oCkBAIC05MSw2ICs5MSw4IEBAIHN0cnVjdCBXZWJQYWdlQ3Jl YXRpb25QYXJhbWV0ZXJzIHsKIAogICAgIGJvb2wgb3ZlcnJpZGVQcml2YXRlQnJvd3NpbmdFbmFi bGVkOwogCisgICAgZmxvYXQgbWluaW11bUxheW91dFdpZHRoOworCiAjaWYgUExBVEZPUk0oTUFD KQogICAgIExheWVySG9zdGluZ01vZGUgbGF5ZXJIb3N0aW5nTW9kZTsKICAgICBDb2xvclNwYWNl RGF0YSBjb2xvclNwYWNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cAppbmRleCAwYzhkZWQ2Li5kNDg2NmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcApAQCAtMzk0Myw2ICszOTQzLDcgQEAgV2ViUGFnZUNyZWF0aW9uUGFyYW1l dGVycyBXZWJQYWdlUHJveHk6OmNyZWF0aW9uUGFyYW1ldGVycygpIGNvbnN0CiAgICAgcGFyYW1l dGVycy5tZWRpYVZvbHVtZSA9IG1fbWVkaWFWb2x1bWU7CiAgICAgcGFyYW1ldGVycy5tYXlTdGFy dE1lZGlhV2hlbkluV2luZG93ID0gbV9tYXlTdGFydE1lZGlhV2hlbkluV2luZG93OwogICAgIHBh cmFtZXRlcnMub3ZlcnJpZGVQcml2YXRlQnJvd3NpbmdFbmFibGVkID0gbV9vdmVycmlkZVByaXZh dGVCcm93c2luZ0VuYWJsZWQ7CisgICAgcGFyYW1ldGVycy5taW5pbXVtTGF5b3V0V2lkdGggPSBt X21pbmltdW1MYXlvdXRXaWR0aDsKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICBwYXJhbWV0ZXJz LmxheWVySG9zdGluZ01vZGUgPSBtX2xheWVySG9zdGluZ01vZGU7CkBAIC00MzEyLDEwICs0MzEz LDExIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRNaW5pbXVtTGF5b3V0V2lkdGgoZG91YmxlIG1p bmltdW1MYXlvdXRXaWR0aCkKICAgICBpZiAobV9taW5pbXVtTGF5b3V0V2lkdGggPT0gbWluaW11 bUxheW91dFdpZHRoKQogICAgICAgICByZXR1cm47CiAKKyAgICBtX21pbmltdW1MYXlvdXRXaWR0 aCA9IG1pbmltdW1MYXlvdXRXaWR0aDsKKwogICAgIGlmICghaXNWYWxpZCgpKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBtX21pbmltdW1MYXlvdXRXaWR0aCA9IG1pbmltdW1MYXlvdXRXaWR0aDsK ICAgICBtX3Byb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlNldE1pbmltdW1MYXlvdXRX aWR0aChtaW5pbXVtTGF5b3V0V2lkdGgpLCBtX3BhZ2VJRCwgMCk7CiAgICAgbV9kcmF3aW5nQXJl YS0+bWluaW11bUxheW91dFdpZHRoRGlkQ2hhbmdlKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCA5OTQ3ZWViLi4yNWI4OGRjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0zNzks NiArMzc5LDggQEAgV2ViUGFnZTo6V2ViUGFnZSh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYlBh Z2VDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMpCiAKICAgICBzZXRJc0luV2luZG93KHBh cmFtZXRlcnMuaXNJbldpbmRvdyk7CiAKKyAgICBzZXRNaW5pbXVtTGF5b3V0V2lkdGgocGFyYW1l dGVycy5taW5pbXVtTGF5b3V0V2lkdGgpOworCiAgICAgbV91c2VyQWdlbnQgPSBwYXJhbWV0ZXJz LnVzZXJBZ2VudDsKIAogICAgIFdlYkJhY2tGb3J3YXJkTGlzdFByb3h5OjpzZXRIaWdoZXN0SXRl bUlERnJvbVVJUHJvY2VzcyhwYXJhbWV0ZXJzLmhpZ2hlc3RVc2VkQmFja0ZvcndhcmRJdGVtSUQp Owo=