116198 2013-05-15 18:11:15 -0700 makeRGBAFromNSColor throws an exception if given a color in a greyscale colorspace 2013-05-15 18:35:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin simon.fraser oldest_to_newest 889606 0 thorton 2013-05-15 18:11:15 -0700 The comment in ColorMac.mm about NSColor things not throwing exceptions is a lie. <rdar://problem/13904395> 889609 1 201904 thorton 2013-05-15 18:19:45 -0700 Created attachment 201904 patch 889610 2 201904 thorton 2013-05-15 18:22:00 -0700 Comment on attachment 201904 patch View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:63 > + return makeRGBA(0, 0, 0, 0); Not sure what a reasonable fallback color is. 889614 3 201904 simon.fraser 2013-05-15 18:30:24 -0700 Comment on attachment 201904 patch View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:61 > + Maybe remove this blank line. 889616 4 thorton 2013-05-15 18:35:12 -0700 http://trac.webkit.org/changeset/150167 201904 2013-05-15 18:19:45 -0700 2013-05-15 18:30:24 -0700 patch colorspace.diff text/plain 2265 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZTQ2N2JlLi5hN2Y4MzQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDUtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgbWFrZVJHQkFGcm9tTlNDb2xvciB0aHJvd3MgYW4gZXhjZXB0aW9uIGlmIGdpdmVu IGEgY29sb3IgaW4gYSBncmV5c2NhbGUgY29sb3JzcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MTk4CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xMzkwNDM5NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCbG9jayBPYmplY3RpdmUtQyBleGNlcHRpb25zIGluIG1ha2VSR0JBRnJvbU5TQ29sb3Iu CisgICAgICAgIFJlbW92ZSBhIGNvbW1lbnQgc2F5aW5nIHRoYXQgdGhleSdyZSBpbXBvc3NpYmxl LgorCisgICAgICAgIENvbnZlcnQgdGhlIGluY29taW5nIGNvbG9yIHRvIHRoZSBEZXZpY2VSR0Ig Y29sb3JzcGFjZSB0byBtYXRjaAorICAgICAgICBleGlzdGluZyBjb2xvciBzb3VyY2VzLiBTb21l IHJhcmUgY2FzZXMgKGF0dHJpYnV0ZWQgc3RyaW5ncyB0aGF0IGNvbWUKKyAgICAgICAgZnJvbSBQ REZLaXQpIGNhbiBoYXZlIERldmljZUdyYXlzY2FsZSBjb2xvciBzcGFjZXMsIHdoaWNoIHdvdWxk CisgICAgICAgIHByZXZpb3VzbHkgdGhyb3cgYW4gZXhjZXB0aW9uIGhlcmUuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29sb3JNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpt YWtlUkdCQUZyb21OU0NvbG9yKToKKwogMjAxMy0wNS0xNSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgW01hY10gUmVtb3ZlIHRoZSBDbGlwYm9hcmRNYWMgY2xhc3Mg YW5kIGhlYWRlciBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvQ29sb3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvQ29sb3JNYWMubW0KaW5kZXggMDdkNjM1My4uYzEzMTk0OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbG9yTWFjLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db2xvck1hYy5tbQpAQCAtMjYsMTMgKzI2LDEy IEBACiAjaW1wb3J0ICJjb25maWcuaCIKICNpbXBvcnQgIkNvbG9yTWFjLmgiCiAKKyNpbXBvcnQg PFdlYkNvcmUvQmxvY2tFeGNlcHRpb25zLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAj aW1wb3J0IDx3dGYvU3RkTGliRXh0cmFzLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotLy8g TlNDb2xvciBjYWxscyBkb24ndCB0aHJvdywgc28gbm8gbmVlZCB0byBibG9jayBDb2NvYSBleGNl cHRpb25zIGluIHRoaXMgZmlsZQotCiBzdGF0aWMgYm9vbCB1c2VPbGRBcXVhRm9jdXNSaW5nQ29s b3I7CiAKIFJHQkEzMiBvbGRBcXVhRm9jdXNSaW5nQ29sb3IoKQpAQCAtNTYsNyArNTUsMTUgQEAg c3RhdGljIFJHQkEzMiBtYWtlUkdCQUZyb21OU0NvbG9yKE5TQ29sb3IgKmMpCiAgICAgQ0dGbG9h dCBncmVlbkNvbXBvbmVudDsKICAgICBDR0Zsb2F0IGJsdWVDb21wb25lbnQ7CiAgICAgQ0dGbG9h dCBhbHBoYTsKLSAgICBbYyBnZXRSZWQ6JnJlZENvbXBvbmVudCBncmVlbjomZ3JlZW5Db21wb25l bnQgYmx1ZTomYmx1ZUNvbXBvbmVudCBhbHBoYTomYWxwaGFdOworCisgICAgQkVHSU5fQkxPQ0tf T0JKQ19FWENFUFRJT05TOworICAgIE5TQ29sb3IgKnJnYkNvbG9yID0gW2MgY29sb3JVc2luZ0Nv bG9yU3BhY2VOYW1lOk5TRGV2aWNlUkdCQ29sb3JTcGFjZV07CisKKyAgICBpZiAoIXJnYkNvbG9y KQorICAgICAgICByZXR1cm4gbWFrZVJHQkEoMCwgMCwgMCwgMCk7CisKKyAgICBbcmdiQ29sb3Ig Z2V0UmVkOiZyZWRDb21wb25lbnQgZ3JlZW46JmdyZWVuQ29tcG9uZW50IGJsdWU6JmJsdWVDb21w b25lbnQgYWxwaGE6JmFscGhhXTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogCiAg ICAgcmV0dXJuIG1ha2VSR0JBKDI1NSAqIHJlZENvbXBvbmVudCwgMjU1ICogZ3JlZW5Db21wb25l bnQsIDI1NSAqIGJsdWVDb21wb25lbnQsIDI1NSAqIGFscGhhKTsKIH0K