116197 2013-05-15 18:08:22 -0700 Stop using the factory pattern in FileIconLoaderClient 2013-05-16 07:46:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116207 1 andersca andersca commit-queue ossy simon.fraser oldest_to_newest 889604 0 andersca 2013-05-15 18:08:22 -0700 Stop using the factory pattern in FileIconLoaderClient 889605 1 201903 andersca 2013-05-15 18:09:12 -0700 Created attachment 201903 Patch 889608 2 andersca 2013-05-15 18:17:27 -0700 Committed r150165: <http://trac.webkit.org/changeset/150165> 889686 3 ossy 2013-05-15 22:15:09 -0700 (In reply to comment #2) > Committed r150165: <http://trac.webkit.org/changeset/150165> It made zillion tests crash everywhere. Could you fix it? for example on Apple Mac bots: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/12484 889694 4 commit-queue 2013-05-15 22:51:07 -0700 Re-opened since this is blocked by bug 116207 889696 5 simon.fraser 2013-05-15 22:52:35 -0700 Pls run tests before committing. 201903 2013-05-15 18:09:12 -0700 2013-05-15 18:16:04 -0700 Patch bug-116197-20130515180807.patch text/plain 4666 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWIyNGIzNDgzM2Y3N2Q5 ZWQwZDE1MjU4ZmFhNGZkOTYyZTk1YjkxYi4uYWUyZjcxZjI4MzMzZWEwYzYzMWUwOTI2MmRjZTNl Y2Q3MjVjN2JlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTA1LTE1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU3RvcCB1c2luZyB0 aGUgZmFjdG9yeSBwYXR0ZXJuIGluIEZpbGVJY29uTG9hZGVyQ2xpZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYxOTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4K KworICAgICAgICBNb3ZlIHRoZSBGaWxlSWNvbkxvYWRlciBtZW1iZXIgb3V0IG9mIEZpbGVJY29u TG9hZGVyQ2xpZW50IGFuZCBpbnRvIEZpbGVJbnB1dFR5cGUgYW5kIHJlbW92ZSB0aGUgZmFjdG9y eSBndW5rLgorCisgICAgICAgICogaHRtbC9GaWxlSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZpbGVJbnB1dFR5cGU6On5GaWxlSW5wdXRUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6 OkZpbGVJbnB1dFR5cGU6OnJlcXVlc3RJY29uKToKKyAgICAgICAgKiBodG1sL0ZpbGVJbnB1dFR5 cGUuaDoKKyAgICAgICAgKEZpbGVJbnB1dFR5cGUpOgorICAgICAgICAqIHBsYXRmb3JtL0ZpbGVJ Y29uTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpbGVJY29uTG9hZGVyOjppbnZhbGlk YXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlSWNvbkxvYWRlci5oOgorICAgICAgICAoV2Vi Q29yZTo6RmlsZUljb25Mb2FkZXJDbGllbnQ6On5GaWxlSWNvbkxvYWRlckNsaWVudCk6CisgICAg ICAgIChGaWxlSWNvbkxvYWRlcik6CisKKzIwMTMtMDUtMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBGaXggRmlsZUNob29zZXJDbGllbnQgZGVzaWdu CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYxOTUK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9GaWxlSW5wdXRUeXBlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5jcHAKaW5kZXggZTg1OTRkMzYwMmEyNTZj NDY1YmM4YjE4ZjUxM2ZkYTcyYWJhZWU2NC4uNzZmNmQ2ZTM1NmI5MDUzYTkyYzRmNjcwMmYxYmQ5 ZGM4ZTM0YTFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9GaWxlSW5wdXRUeXBl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJbnB1dFR5cGUuY3BwCkBAIC0xMDEs NiArMTAxLDkgQEAgRmlsZUlucHV0VHlwZTo6fkZpbGVJbnB1dFR5cGUoKQogewogICAgIGlmICht X2ZpbGVDaG9vc2VyKQogICAgICAgICBtX2ZpbGVDaG9vc2VyLT5pbnZhbGlkYXRlKCk7CisKKyAg ICBpZiAobV9maWxlSWNvbkxvYWRlcikKKyAgICAgICAgbV9maWxlSWNvbkxvYWRlci0+aW52YWxp ZGF0ZSgpOwogfQogCiBWZWN0b3I8RmlsZUNob29zZXJGaWxlSW5mbz4gRmlsZUlucHV0VHlwZTo6 ZmlsZXNGcm9tRm9ybUNvbnRyb2xTdGF0ZShjb25zdCBGb3JtQ29udHJvbFN0YXRlJiBzdGF0ZSkK QEAgLTMzNSw4ICszMzgsMTQgQEAgdm9pZCBGaWxlSW5wdXRUeXBlOjpyZXF1ZXN0SWNvbihjb25z dCBWZWN0b3I8U3RyaW5nPiYgcGF0aHMpCiAgICAgaWYgKCFwYXRocy5zaXplKCkpCiAgICAgICAg IHJldHVybjsKIAotICAgIGlmIChDaHJvbWUqIGNocm9tZSA9IHRoaXMtPmNocm9tZSgpKQotICAg ICAgICBjaHJvbWUtPmxvYWRJY29uRm9yRmlsZXMocGF0aHMsIG5ld0ZpbGVJY29uTG9hZGVyKCkp OworICAgIENocm9tZSogY2hyb21lID0gdGhpcy0+Y2hyb21lKCk7CisgICAgaWYgKCFjaHJvbWUp CisgICAgICAgIHJldHVybjsKKworICAgIGlmIChtX2ZpbGVJY29uTG9hZGVyKQorICAgICAgICBt X2ZpbGVJY29uTG9hZGVyID0gRmlsZUljb25Mb2FkZXI6OmNyZWF0ZSh0aGlzKTsKKworICAgIGNo cm9tZS0+bG9hZEljb25Gb3JGaWxlcyhwYXRocywgbV9maWxlSWNvbkxvYWRlci5nZXQoKSk7CiB9 CiAKIHZvaWQgRmlsZUlucHV0VHlwZTo6YXBwbHlGaWxlQ2hvb3NlclNldHRpbmdzKGNvbnN0IEZp bGVDaG9vc2VyU2V0dGluZ3MmIHNldHRpbmdzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9GaWxlSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJbnB1dFR5cGUu aAppbmRleCBlZGFhMWI0MDQyNmUwMjc0YjAzN2ZhMjhhZWEwMGQ3ODFmNjNjOTIwLi5hMzQ3YzAx MzRkZWQ1YzlhZjE1OGI5YWE2MzJjZjE3NTVlOTdiZTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0ZpbGVJbnB1dFR5cGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJ bnB1dFR5cGUuaApAQCAtOTMsNiArOTMsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgYXBwbHlGaWxl Q2hvb3NlclNldHRpbmdzKGNvbnN0IEZpbGVDaG9vc2VyU2V0dGluZ3MmKTsKIAogICAgIFJlZlB0 cjxGaWxlQ2hvb3Nlcj4gbV9maWxlQ2hvb3NlcjsKKyAgICBSZWZQdHI8RmlsZUljb25Mb2FkZXI+ IG1fZmlsZUljb25Mb2FkZXI7CiAKICAgICBSZWZQdHI8RmlsZUxpc3Q+IG1fZmlsZUxpc3Q7CiAg ICAgUmVmUHRyPEljb24+IG1faWNvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL0ZpbGVJY29uTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVJY29u TG9hZGVyLmNwcAppbmRleCAxNmI1NzkyZGM4ZTNiNTY0NTY2ZDJjMjU5MzM5OTljOTkwMmE3YjEz Li42YzY0MTZjMjhhYjllZmZiZDIwNjgwNGVjYzU1MDRhYWQ1ODY0ZjUzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlSWNvbkxvYWRlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vRmlsZUljb25Mb2FkZXIuY3BwCkBAIC0zNCwzMiArMzQsMTUgQEAKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCi1GaWxlSWNvbkxvYWRlckNsaWVudDo6fkZpbGVJY29uTG9h ZGVyQ2xpZW50KCkKLXsKLSAgICBkaXNjYXJkTG9hZGVyKCk7Ci19Ci0KLUZpbGVJY29uTG9hZGVy KiBGaWxlSWNvbkxvYWRlckNsaWVudDo6bmV3RmlsZUljb25Mb2FkZXIoKQotewotICAgIGRpc2Nh cmRMb2FkZXIoKTsKLQotICAgIG1fbG9hZGVyID0gRmlsZUljb25Mb2FkZXI6OmNyZWF0ZSh0aGlz KTsKLSAgICByZXR1cm4gbV9sb2FkZXIuZ2V0KCk7Ci19Ci0KLXZvaWQgRmlsZUljb25Mb2FkZXJD bGllbnQ6OmRpc2NhcmRMb2FkZXIoKQotewotICAgIGlmIChtX2xvYWRlcikKLSAgICAgICAgbV9s b2FkZXItPmRpc2Nvbm5lY3RDbGllbnQoKTsKLX0KLQogUGFzc1JlZlB0cjxGaWxlSWNvbkxvYWRl cj4gRmlsZUljb25Mb2FkZXI6OmNyZWF0ZShGaWxlSWNvbkxvYWRlckNsaWVudCogY2xpZW50KQog ewogICAgIHJldHVybiBhZG9wdFJlZihuZXcgRmlsZUljb25Mb2FkZXIoY2xpZW50KSk7CiB9CiAK LXZvaWQgRmlsZUljb25Mb2FkZXI6OmRpc2Nvbm5lY3RDbGllbnQoKQordm9pZCBGaWxlSWNvbkxv YWRlcjo6aW52YWxpZGF0ZSgpCiB7CisgICAgQVNTRVJUKG1fY2xpZW50KTsKKwogICAgIG1fY2xp ZW50ID0gMDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZUlj b25Mb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVJY29uTG9hZGVyLmgKaW5k ZXggZGE4Y2EyYWQwMWQ3YWQ4ZDVlYzc0NjJjY2ZhMWZmNTFiNTNiZmU2My4uMDBiNjJjNzMxMGIx NjU1M2I4MGZiZTA4Yzk1ZjdiNGFiYjRhZjk3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vRmlsZUljb25Mb2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9G aWxlSWNvbkxvYWRlci5oCkBAIC00MSwyMyArNDEsMTYgQEAgY2xhc3MgSWNvbjsKIAogY2xhc3Mg RmlsZUljb25Mb2FkZXJDbGllbnQgewogcHVibGljOgorICAgIHZpcnR1YWwgfkZpbGVJY29uTG9h ZGVyQ2xpZW50KCkgeyB9CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZVJlbmRlcmluZyhQYXNzUmVm UHRyPEljb24+KSA9IDA7Ci0gICAgdmlydHVhbCB+RmlsZUljb25Mb2FkZXJDbGllbnQoKTsKLQot cHJvdGVjdGVkOgotICAgIEZpbGVJY29uTG9hZGVyKiBuZXdGaWxlSWNvbkxvYWRlcigpOwotCi1w cml2YXRlOgotICAgIHZvaWQgZGlzY2FyZExvYWRlcigpOwotCi0gICAgUmVmUHRyPEZpbGVJY29u TG9hZGVyPiBtX2xvYWRlcjsKIH07CiAKIGNsYXNzIEZpbGVJY29uTG9hZGVyIDogcHVibGljIFJl ZkNvdW50ZWQ8RmlsZUljb25Mb2FkZXI+IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxGaWxlSWNvbkxvYWRlcj4gY3JlYXRlKEZpbGVJY29uTG9hZGVyQ2xpZW50Kik7CiAKLSAgICB2 b2lkIGRpc2Nvbm5lY3RDbGllbnQoKTsKKyAgICB2b2lkIGludmFsaWRhdGUoKTsKKwogICAgIHZv aWQgbm90aWZ5RmluaXNoZWQoUGFzc1JlZlB0cjxJY29uPik7CiAKIHByaXZhdGU6Cg==