<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>116193</bug_id>
          
          <creation_ts>2013-05-15 16:44:30 -0700</creation_ts>
          <short_desc>ScriptedAnimationController::setThrottled should extend MinimumAnimationInterval</short_desc>
          <delta_ts>2013-05-15 17:42:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gavin Barraclough">barraclough</reporter>
          <assigned_to name="Gavin Barraclough">barraclough</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>rego+ews</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>889570</commentid>
    <comment_count>0</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2013-05-15 16:44:30 -0700</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>889574</commentid>
    <comment_count>1</comment_count>
      <attachid>201896</attachid>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2013-05-15 16:52:22 -0700</bug_when>
    <thetext>Created attachment 201896
Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>889583</commentid>
    <comment_count>2</comment_count>
      <attachid>201898</attachid>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2013-05-15 17:17:25 -0700</bug_when>
    <thetext>Created attachment 201898
Fix GTK build</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>889589</commentid>
    <comment_count>3</comment_count>
      <attachid>201898</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2013-05-15 17:26:02 -0700</bug_when>
    <thetext>Comment on attachment 201898
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=201898&amp;action=review

&gt; Source/WebCore/dom/ScriptedAnimationController.cpp:60
&gt; +    , m_throttled(false)

Typically we try to name boolean data members and such so they finish a phrase “controller &lt;xxx&gt;”. Thus we’d call this m_isThrottled.

&gt; Source/WebCore/dom/ScriptedAnimationController.cpp:91
&gt; +    m_throttled = isThrottled;
&gt; +    if (m_animationTimer.isActive()) {

This seems not quite right to me. If we were not throttled before and are still not throttled, it seems strange to stop and restart the timer. Maybe harmless, but strange nonetheless. We should have an early return when m_throttled is already == isThrottled.

&gt; Source/WebCore/dom/ScriptedAnimationController.cpp:197
&gt; +#if USE(REQUEST_ANIMATION_FRAME_TIMER) &amp;&amp; USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
&gt; +    double animationInterval = m_throttled ? MinimumThrottledAnimationInterval : MinimumAnimationInterval;
&gt; +#else
&gt; +    double animationInterval = MinimumAnimationInterval;
&gt; +#endif

I’d write it like this:

    double animationInterval = MinimumAnimationInterval;
#if USE(REQUEST_ANIMATION_FRAME_TIMER) &amp;&amp; USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
    if (m_isThrottled)
        animationInterval = MinimumThrottledAnimationInterval;
#endif

I think easier to read than the repeated code and #else in the code you posted.

&gt; Source/WebCore/dom/ScriptedAnimationController.h:93
&gt;      bool m_useTimer;

Seems like it should be named m_isUsingTimer or something like that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>889591</commentid>
    <comment_count>4</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2013-05-15 17:28:35 -0700</bug_when>
    <thetext>Fixed in r150159.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>889597</commentid>
    <comment_count>5</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2013-05-15 17:42:48 -0700</bug_when>
    <thetext>Missed Darin&apos;s review comments – fixed in r150162.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>201896</attachid>
            <date>2013-05-15 16:52:22 -0700</date>
            <delta_ts>2013-05-15 17:17:25 -0700</delta_ts>
            <desc>Fix</desc>
            <filename>116193.patch</filename>
            <type>text/plain</type>
            <size>3619</size>
            <attacher name="Gavin Barraclough">barraclough</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDE1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTE1ICBHYXZpbiBC
YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JpcHRlZEFu
aW1hdGlvbkNvbnRyb2xsZXI6OnNldFRocm90dGxlZCBzaG91bGQgZXh0ZW5kIE1pbmltdW1Bbmlt
YXRpb25JbnRlcnZhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTE2MTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBkb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OlNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6U2NyaXB0ZWRBbmltYXRpb25Db250
cm9sbGVyKToKKyAgICAgICAgICAgIC0gaW5pdGlhbGl6ZSBtX3Rocm90dGxlZAorICAgICAgICAo
V2ViQ29yZTo6U2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpzZXRUaHJvdHRsZWQpOgorICAg
ICAgICAgICAgLSBzZXRzIG1fdGhyb3R0bGVkLCByZXNjaGVkdWxlIHdoZW4gdGhpcyBjaGFuZ2Vz
LgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpzY2hlZHVs
ZUFuaW1hdGlvbik6CisgICAgICAgICAgICAtIGlmIHRocm90bGVkIGRvbid0IHVzZSBhIGRpc3Bs
YXkgbGluaywgYW5kIGV4dGVuZCB0aGUgdGltZW91dC4KKyAgICAgICAgKiBkb20vU2NyaXB0ZWRB
bmltYXRpb25Db250cm9sbGVyLmg6CisgICAgICAgIChTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xs
ZXIpOgorICAgICAgICAgICAgLSBBZGRlZCBtX3Rocm90dGxlZAorCiAyMDEzLTA1LTA4ICBHYXZp
biBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm9jZXNz
IHN1cHByZXNzaW9uIHNob3VsZCB0aHJvdHRsZSBzY3JpcHRlZCBhbmltYXRpb25zCkluZGV4OiBT
b3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNw
cAkocmV2aXNpb24gMTUwMTU2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0
aW9uQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDcgQEAgdXNpbmcg
bmFtZXNwYWNlIHN0ZDsKIAogLy8gQWxsb3cgYSBsaXR0bGUgbW9yZSB0aGFuIDYwZnBzIHRvIG1h
a2Ugc3VyZSB3ZSBjYW4gYXQgbGVhc3QgaGl0IHRoYXQgZnJhbWUgcmF0ZS4KICNkZWZpbmUgTWlu
aW11bUFuaW1hdGlvbkludGVydmFsIDAuMDE1CisjZGVmaW5lIE1pbmltdW1UaHJvdHRsZWRBbmlt
YXRpb25JbnRlcnZhbCAxMAogI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU2LDYg
KzU3LDcgQEAgU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpTY3JpcHRlZEFuaQogICAgICwg
bV9sYXN0QW5pbWF0aW9uRnJhbWVUaW1lTW9ub3RvbmljKDApCiAjaWYgVVNFKFJFUVVFU1RfQU5J
TUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRPUikKICAgICAsIG1fdXNlVGltZXIoZmFsc2UpCisg
ICAgLCBtX3Rocm90dGxlZChmYWxzZSkKICNlbmRpZgogI2VuZGlmCiB7CkBAIC04NSw3ICs4Nywx
MSBAQCB2b2lkIFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6cmVzdW1lCiB2b2lkIFNjcmlw
dGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c2V0VGhyb3R0bGVkKGJvb2wgaXNUaHJvdHRsZWQpCiB7
CiAjaWYgVVNFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FX1RJTUVSKSAmJiBVU0UoUkVRVUVTVF9B
TklNQVRJT05fRlJBTUVfRElTUExBWV9NT05JVE9SKQotICAgIG1fdXNlVGltZXIgPSBpc1Rocm90
dGxlZDsKKyAgICBtX3Rocm90dGxlZCA9IGlzVGhyb3R0bGVkOworICAgIGlmIChtX2FuaW1hdGlv
blRpbWVyLmlzQWN0aXZlKCkpIHsKKyAgICAgICAgbV9hbmltYXRpb25UaW1lci5zdG9wKCk7Cisg
ICAgICAgIHNjaGVkdWxlQW5pbWF0aW9uKCk7CisgICAgfQogI2VuZGlmCiB9CiAKQEAgLTE3NCw3
ICsxODAsNyBAQCB2b2lkIFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c2NoZWR1CiAKICNp
ZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfVElNRVIpCiAjaWYgVVNFKFJFUVVFU1RfQU5J
TUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRPUikKLSAgICBpZiAoIW1fdXNlVGltZXIpIHsKKyAg
ICBpZiAoIW1fdXNlVGltZXIgJiYgIW1fdGhyb3R0bGVkKSB7CiAgICAgICAgIGlmIChEaXNwbGF5
UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCktPnNjaGVkdWxlQW5pbWF0aW9u
KHRoaXMpKQogICAgICAgICAgICAgcmV0dXJuOwogCkBAIC0xODQsNyArMTkwLDggQEAgdm9pZCBT
Y3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnNjaGVkdQogICAgIGlmIChtX2FuaW1hdGlvblRp
bWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGRvdWJsZSBzY2hlZHVsZURl
bGF5ID0gbWF4PGRvdWJsZT4oTWluaW11bUFuaW1hdGlvbkludGVydmFsIC0gKG1vbm90b25pY2Fs
bHlJbmNyZWFzaW5nVGltZSgpIC0gbV9sYXN0QW5pbWF0aW9uRnJhbWVUaW1lTW9ub3RvbmljKSwg
MCk7CisgICAgZG91YmxlIGFuaW1hdGlvbkludGVydmFsID0gbV90aHJvdHRsZWQgPyBNaW5pbXVt
VGhyb3R0bGVkQW5pbWF0aW9uSW50ZXJ2YWwgOiBNaW5pbXVtQW5pbWF0aW9uSW50ZXJ2YWw7Cisg
ICAgZG91YmxlIHNjaGVkdWxlRGVsYXkgPSBtYXg8ZG91YmxlPihhbmltYXRpb25JbnRlcnZhbCAt
IChtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIG1fbGFzdEFuaW1hdGlvbkZyYW1lVGlt
ZU1vbm90b25pYyksIDApOwogICAgIG1fYW5pbWF0aW9uVGltZXIuc3RhcnRPbmVTaG90KHNjaGVk
dWxlRGVsYXkpOwogI2Vsc2UKICAgICBpZiAoRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBtX2RvY3Vt
ZW50LT52aWV3KCkpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0ZWRBbmltYXRpb25D
b250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5p
bWF0aW9uQ29udHJvbGxlci5oCShyZXZpc2lvbiAxNTAxNTYpCisrKyBTb3VyY2UvV2ViQ29yZS9k
b20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTkxLDYg
KzkxLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZGlzcGxheVJlZnJlc2hGaXJlZChk
b3VibGUgdGltZXN0YW1wKTsKIAogICAgIGJvb2wgbV91c2VUaW1lcjsKKyAgICBib29sIG1fdGhy
b3R0bGVkOwogI2VuZGlmCiAjZW5kaWYKIH07Cg==
</data>
<flag name="review"
          id="223276"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>201898</attachid>
            <date>2013-05-15 17:17:25 -0700</date>
            <delta_ts>2013-05-15 17:26:02 -0700</delta_ts>
            <desc>Fix GTK build</desc>
            <filename>116193.2.patch</filename>
            <type>text/plain</type>
            <size>3779</size>
            <attacher name="Gavin Barraclough">barraclough</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDE1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTE1ICBHYXZpbiBC
YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JpcHRlZEFu
aW1hdGlvbkNvbnRyb2xsZXI6OnNldFRocm90dGxlZCBzaG91bGQgZXh0ZW5kIE1pbmltdW1Bbmlt
YXRpb25JbnRlcnZhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTE2MTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAg
ICAgICogZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OlNjcmlwdGVkQW5pbWF0aW9uQ29udHJv
bGxlcik6CisgICAgICAgICAgICAtIGluaXRpYWxpemUgbV90aHJvdHRsZWQKKyAgICAgICAgKFdl
YkNvcmU6OlNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c2V0VGhyb3R0bGVkKToKKyAgICAg
ICAgICAgIC0gc2V0cyBtX3Rocm90dGxlZCwgcmVzY2hlZHVsZSB3aGVuIHRoaXMgY2hhbmdlcy4K
KyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c2NoZWR1bGVB
bmltYXRpb24pOgorICAgICAgICAgICAgLSBpZiB0aHJvdGxlZCBkb24ndCB1c2UgYSBkaXNwbGF5
IGxpbmssIGFuZCBleHRlbmQgdGhlIHRpbWVvdXQuCisgICAgICAgICogZG9tL1NjcmlwdGVkQW5p
bWF0aW9uQ29udHJvbGxlci5oOgorICAgICAgICAoU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVy
KToKKyAgICAgICAgICAgIC0gQWRkZWQgbV90aHJvdHRsZWQKKwogMjAxMy0wNS0wOCAgR2F2aW4g
QmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUHJvY2VzcyBz
dXBwcmVzc2lvbiBzaG91bGQgdGhyb3R0bGUgc2NyaXB0ZWQgYW5pbWF0aW9ucwpJbmRleDogU291
cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jcHAJ
KHJldmlzaW9uIDE1MDE1NikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRlZEFuaW1hdGlv
bkNvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Myw2ICs0Myw3IEBAIHVzaW5nIG5h
bWVzcGFjZSBzdGQ7CiAKIC8vIEFsbG93IGEgbGl0dGxlIG1vcmUgdGhhbiA2MGZwcyB0byBtYWtl
IHN1cmUgd2UgY2FuIGF0IGxlYXN0IGhpdCB0aGF0IGZyYW1lIHJhdGUuCiAjZGVmaW5lIE1pbmlt
dW1BbmltYXRpb25JbnRlcnZhbCAwLjAxNQorI2RlZmluZSBNaW5pbXVtVGhyb3R0bGVkQW5pbWF0
aW9uSW50ZXJ2YWwgMTAKICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01Niw2ICs1
Nyw3IEBAIFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6U2NyaXB0ZWRBbmkKICAgICAsIG1f
bGFzdEFuaW1hdGlvbkZyYW1lVGltZU1vbm90b25pYygwKQogI2lmIFVTRShSRVFVRVNUX0FOSU1B
VElPTl9GUkFNRV9ESVNQTEFZX01PTklUT1IpCiAgICAgLCBtX3VzZVRpbWVyKGZhbHNlKQorICAg
ICwgbV90aHJvdHRsZWQoZmFsc2UpCiAjZW5kaWYKICNlbmRpZgogewpAQCAtODUsNyArODcsMTEg
QEAgdm9pZCBTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnJlc3VtZQogdm9pZCBTY3JpcHRl
ZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnNldFRocm90dGxlZChib29sIGlzVGhyb3R0bGVkKQogewog
I2lmIFVTRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRV9USU1FUikgJiYgVVNFKFJFUVVFU1RfQU5J
TUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRPUikKLSAgICBtX3VzZVRpbWVyID0gaXNUaHJvdHRs
ZWQ7CisgICAgbV90aHJvdHRsZWQgPSBpc1Rocm90dGxlZDsKKyAgICBpZiAobV9hbmltYXRpb25U
aW1lci5pc0FjdGl2ZSgpKSB7CisgICAgICAgIG1fYW5pbWF0aW9uVGltZXIuc3RvcCgpOworICAg
ICAgICBzY2hlZHVsZUFuaW1hdGlvbigpOworICAgIH0KICNlbmRpZgogfQogCkBAIC0xNzQsNyAr
MTgwLDcgQEAgdm9pZCBTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnNjaGVkdQogCiAjaWYg
VVNFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FX1RJTUVSKQogI2lmIFVTRShSRVFVRVNUX0FOSU1B
VElPTl9GUkFNRV9ESVNQTEFZX01PTklUT1IpCi0gICAgaWYgKCFtX3VzZVRpbWVyKSB7CisgICAg
aWYgKCFtX3VzZVRpbWVyICYmICFtX3Rocm90dGxlZCkgewogICAgICAgICBpZiAoRGlzcGxheVJl
ZnJlc2hNb25pdG9yTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpLT5zY2hlZHVsZUFuaW1hdGlvbih0
aGlzKSkKICAgICAgICAgICAgIHJldHVybjsKIApAQCAtMTg0LDcgKzE5MCwxMiBAQCB2b2lkIFNj
cmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6c2NoZWR1CiAgICAgaWYgKG1fYW5pbWF0aW9uVGlt
ZXIuaXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgZG91YmxlIHNjaGVkdWxlRGVs
YXkgPSBtYXg8ZG91YmxlPihNaW5pbXVtQW5pbWF0aW9uSW50ZXJ2YWwgLSAobW9ub3RvbmljYWxs
eUluY3JlYXNpbmdUaW1lKCkgLSBtX2xhc3RBbmltYXRpb25GcmFtZVRpbWVNb25vdG9uaWMpLCAw
KTsKKyNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfVElNRVIpICYmIFVTRShSRVFVRVNU
X0FOSU1BVElPTl9GUkFNRV9ESVNQTEFZX01PTklUT1IpCisgICAgZG91YmxlIGFuaW1hdGlvbklu
dGVydmFsID0gbV90aHJvdHRsZWQgPyBNaW5pbXVtVGhyb3R0bGVkQW5pbWF0aW9uSW50ZXJ2YWwg
OiBNaW5pbXVtQW5pbWF0aW9uSW50ZXJ2YWw7CisjZWxzZQorICAgIGRvdWJsZSBhbmltYXRpb25J
bnRlcnZhbCA9IE1pbmltdW1BbmltYXRpb25JbnRlcnZhbDsKKyNlbmRpZgorICAgIGRvdWJsZSBz
Y2hlZHVsZURlbGF5ID0gbWF4PGRvdWJsZT4oYW5pbWF0aW9uSW50ZXJ2YWwgLSAobW9ub3Rvbmlj
YWxseUluY3JlYXNpbmdUaW1lKCkgLSBtX2xhc3RBbmltYXRpb25GcmFtZVRpbWVNb25vdG9uaWMp
LCAwKTsKICAgICBtX2FuaW1hdGlvblRpbWVyLnN0YXJ0T25lU2hvdChzY2hlZHVsZURlbGF5KTsK
ICNlbHNlCiAgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gbV9kb2N1bWVudC0+dmlldygp
KQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRlZEFuaW1hdGlvbkNvbnRy
b2xsZXIuaAkocmV2aXNpb24gMTUwMTU2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVk
QW5pbWF0aW9uQ29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC05MSw2ICs5MSw3IEBAIHBy
aXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGRpc3BsYXlSZWZyZXNoRmlyZWQoZG91YmxlIHRpbWVz
dGFtcCk7CiAKICAgICBib29sIG1fdXNlVGltZXI7CisgICAgYm9vbCBtX3Rocm90dGxlZDsKICNl
bmRpZgogI2VuZGlmCiB9Owo=
</data>
<flag name="review"
          id="223279"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>