116180 2013-05-15 12:46:35 -0700 [Mac] media engine may deliver NULL in-band "cue" 2013-05-15 15:38:23 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer oldest_to_newest 889458 0 eric.carlson 2013-05-15 12:46:35 -0700 r145326 add a NULL check to InbandTextTrackPrivateAVF::processCue, but the debug-only logging added in r149187 is before the NULL check so it will crash when a NULL "cue" is delivered by the media engine. 889461 1 webkit-bug-importer 2013-05-15 12:48:39 -0700 <rdar://problem/13902910> 889467 2 201870 eric.carlson 2013-05-15 12:54:27 -0700 Created attachment 201870 Proposed patch 889469 3 201870 jer.noble 2013-05-15 12:56:17 -0700 Comment on attachment 201870 Proposed patch Yay null checks! 889558 4 201870 commit-queue 2013-05-15 15:38:21 -0700 Comment on attachment 201870 Proposed patch Clearing flags on attachment: 201870 Committed r150153: <http://trac.webkit.org/changeset/150153> 889559 5 commit-queue 2013-05-15 15:38:23 -0700 All reviewed patches have been landed. Closing bug. 201870 2013-05-15 12:54:27 -0700 2013-05-15 15:38:21 -0700 Proposed patch patch_1.txt text/plain 1580 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDE0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTE1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIG1lZGlhIGVu Z2luZSBtYXkgZGVsaXZlciBOVUxMIGluLWJhbmQgImN1ZSIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjE4MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL0luYmFuZFRleHRUcmFja1ByaXZhdGVBVkYuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5i YW5kVGV4dFRyYWNrUHJpdmF0ZUFWRjo6cHJvY2Vzc0N1ZSk6IE5VTEwgY2hlY2sgYmVmb3JlIGxv Z2dpbmcgY3VlIGNvdW50LgorCiAyMDEzLTA1LTEzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgRnJhbWU6OmVkaXRvcigpIHNob3VsZCByZXR1cm4gYSBy ZWZlcmVuY2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRh dGlvbi9JbmJhbmRUZXh0VHJhY2tQcml2YXRlQVZGLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vSW5iYW5kVGV4dFRyYWNrUHJp dmF0ZUFWRi5jcHAJKHJldmlzaW9uIDE1MDA3OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJhbmRUZXh0VHJhY2tQcml2YXRlQVZGLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzQ2LDcgKzM0Niw3IEBAIHZvaWQgSW5iYW5kVGV4dFRyYWNrUHJpdmF0 ZUFWRjo6cHJvY2Vzc0MKICAgICBpZiAoIWNsaWVudCgpKQogICAgICAgICByZXR1cm47CiAKLSAg ICBMT0coTWVkaWEsICJJbmJhbmRUZXh0VHJhY2tQcml2YXRlQVZGOjpwcm9jZXNzQ3VlIC0gJWxp IGN1ZXMgYXQgdGltZSAlLjJmXG4iLCBDRkFycmF5R2V0Q291bnQoYXR0cmlidXRlZFN0cmluZ3Mp LCB0aW1lKTsKKyAgICBMT0coTWVkaWEsICJJbmJhbmRUZXh0VHJhY2tQcml2YXRlQVZGOjpwcm9j ZXNzQ3VlIC0gJWxpIGN1ZXMgYXQgdGltZSAlLjJmXG4iLCBhdHRyaWJ1dGVkU3RyaW5ncyA/IENG QXJyYXlHZXRDb3VudChhdHRyaWJ1dGVkU3RyaW5ncykgOiAwLCB0aW1lKTsKIAogICAgIGlmICht X3BlbmRpbmdDdWVTdGF0dXMgIT0gTm9uZSkgewogICAgICAgICAvLyBDdWVzIGRvIG5vdCBoYXZl IGFuIGV4cGxpY2l0IGR1cmF0aW9uLCB0aGV5IGFyZSBkaXNwbGF5ZWQgdW50aWwgdGhlIG5leHQg ImN1ZSIgKHdoaWNoIG1pZ2h0IGJlIGVtcHR5KSBpcyBlbWl0dGVkLgo=