116176 2013-05-15 12:30:45 -0700 Move drag-specific Clipboard functions inside ENABLE(DRAG_SUPPORT) 2013-05-15 21:36:53 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 115980 116181 1 darin darin commit-queue esprehn+autocc oldest_to_newest 889442 0 darin 2013-05-15 12:30:45 -0700 Move drag-specific Clipboard functions inside ENABLE(DRAG_SUPPORT) 889446 1 201864 darin 2013-05-15 12:35:29 -0700 Created attachment 201864 Patch 889496 2 201864 kling 2013-05-15 13:47:21 -0700 Comment on attachment 201864 Patch r=me mac-wk2 ews says it can't apply the patch. CQing anyway, let's see how it fares. 889539 3 201864 commit-queue 2013-05-15 14:51:19 -0700 Comment on attachment 201864 Patch Rejecting attachment 201864 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 201864, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: --reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/Clipboard.cpp Hunk #1 FAILED at 338. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/dom/Clipboard.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/481211 889671 4 darin 2013-05-15 21:36:53 -0700 Committed r150176: <http://trac.webkit.org/changeset/150176> 201864 2013-05-15 12:35:29 -0700 2013-05-15 14:51:18 -0700 Patch bug-116176-20130515123424.patch text/plain 4036 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU0NjdiZTdhNTQzMzQ1 YTM2OGM5ZTgxYjc0ZWQ5YWFkOTM5YTU2NC4uODk0OTllM2VhMmE5NTY5NTI1MzFiMzRlM2E3Mjc3 OTVkMTU2MDljZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTA1LTE1ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBNb3ZlIGRyYWctc3BlY2lmaWMg Q2xpcGJvYXJkIGZ1bmN0aW9ucyBpbnNpZGUgRU5BQkxFKERSQUdfU1VQUE9SVCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjE3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0NsaXBib2FyZC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmQ6OndyaXRlUmFuZ2UpOgorICAgICAgICAo V2ViQ29yZTo6Q2xpcGJvYXJkOjp3cml0ZVBsYWluVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpD bGlwYm9hcmQ6OndyaXRlVVJMKToKKyAgICAgICAgTW92ZSB0aGVzZSB0aHJlZSBmdW5jdGlvbnMg aW5zaWRlIEVOQUJMRShEUkFHX1NVUFBPUlQpLiBFdmVuIHRob3VnaCB0aGVpciBuYW1lcyBkbwor ICAgICAgICBub3QgbWFrZSBpdCBvYnZpb3VzLCB0aGVzZSBhcmUgaGVyZSBvbmx5IGZvciB1c2Ug YnkgZHJhZ2dpbmcgY29kZS4gTGF0ZXIgd2UgbWF5CisgICAgICAgIHJlZmFjdG9yIHRoZW0gYXdh eSBlbnRpcmVseSwgYnV0IGZvciBub3cgaXQncyBnb29kIG5vdCB0byBjb21waWxlIHRoZW0gaW4g b24gYW55CisgICAgICAgIHBsYXRmb3JtIHRoYXQgZG9lcyBub3Qgc3VwcG9ydCBkcmFnZ2luZy4K KworMjAxMy0wNS0xNSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAgICAg W01hY10gUmVtb3ZlIHRoZSBDbGlwYm9hcmRNYWMgY2xhc3MgYW5kIGhlYWRlciBmaWxlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYxNjUKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vQ2xpcGJvYXJkLmNwcAppbmRleCA3NDQ2OWYwMDI2YzkzMDlhN2MzMWNmODA4Y2MxYjUy Mzg4MGQ0M2UwLi5hMWRiNzA3YzdmNTRjMDkxMTY5NzNkNjAzZGVhYTg3MzU3NGQ2NjYwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vQ2xpcGJvYXJkLmNwcApAQCAtMzM4LDI5ICszMzgsNiBAQCBQYXNzUmVmUHRyPEZp bGVMaXN0PiBDbGlwYm9hcmQ6OmZpbGVzKCkgY29uc3QKICAgICByZXR1cm4gZmlsZUxpc3QucmVs ZWFzZSgpOwogfQogCi12b2lkIENsaXBib2FyZDo6d3JpdGVSYW5nZShSYW5nZSogcmFuZ2UsIEZy YW1lKiBmcmFtZSkKLXsKLSAgICBBU1NFUlQocmFuZ2UpOwotICAgIEFTU0VSVChmcmFtZSk7Ci0g ICAgLy8gRklYTUU6IFRoaXMgaXMgYSBkZXNpZ24gbWlzdGFrZSwgYSBsYXllcmluZyB2aW9sYXRp b24gdGhhdCBzaG91bGQgYmUgZml4ZWQuCi0gICAgLy8gVGhlIGNvZGUgdG8gd3JpdGUgdGhlIHJh bmdlIHRvIGEgcGFzdGVib2FyZCBzaG91bGQgYmUgYW4gRWRpdG9yIGZ1bmN0aW9uIHRoYXQgdGFr ZXMgYSBwYXN0ZWJvYXJkIGFyZ3VtZW50LgotICAgIC8vIEZJWE1FOiBUaGUgZnJhbWUgYXJndW1l bnQgc2VlbXMgcmVkdW5kYW50LCBzaW5jZSBhIFJhbmdlIGlzIGluIGEgcGFydGljdWxhciBkb2N1 bWVudCwgd2hpY2ggaGFzIGEgY29ycmVzcG9uZGluZyBmcmFtZS4KLSAgICBtX3Bhc3RlYm9hcmQt PndyaXRlU2VsZWN0aW9uKHJhbmdlLCBmcmFtZS0+ZWRpdG9yKCktPnNtYXJ0SW5zZXJ0RGVsZXRl RW5hYmxlZCgpICYmIGZyYW1lLT5zZWxlY3Rpb24oKS0+Z3JhbnVsYXJpdHkoKSA9PSBXb3JkR3Jh bnVsYXJpdHksIGZyYW1lLCBJbmNsdWRlSW1hZ2VBbHRUZXh0Rm9yQ2xpcGJvYXJkKTsKLX0KLQot dm9pZCBDbGlwYm9hcmQ6OndyaXRlUGxhaW5UZXh0KGNvbnN0IFN0cmluZyYgdGV4dCkKLXsKLSAg ICBtX3Bhc3RlYm9hcmQtPndyaXRlUGxhaW5UZXh0KHRleHQsIFBhc3RlYm9hcmQ6OkNhbm5vdFNt YXJ0UmVwbGFjZSk7Ci19Ci0KLXZvaWQgQ2xpcGJvYXJkOjp3cml0ZVVSTChjb25zdCBLVVJMJiB1 cmwsIGNvbnN0IFN0cmluZyYgdGl0bGUsIEZyYW1lKiBmcmFtZSkKLXsKLSAgICBBU1NFUlQoZnJh bWUpOwotICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgZGVzaWduIG1pc3Rha2UsIGEgbGF5ZXJpbmcg dmlvbGF0aW9uIHRoYXQgc2hvdWxkIGJlIGZpeGVkLgotICAgIC8vIFRoZSBwYXN0ZWJvYXJkIHdy aXRlVVJMIGZ1bmN0aW9uIHNob3VsZCBub3QgdGFrZSBhIGZyYW1lIGFyZ3VtZW50LCBub3IgZG9l cyB0aGlzIGZ1bmN0aW9uIG5lZWQgYSBmcmFtZS4KLSAgICBtX3Bhc3RlYm9hcmQtPndyaXRlVVJM KHVybCwgdGl0bGUsIGZyYW1lKTsKLX0KLQogI2lmICFFTkFCTEUoRFJBR19TVVBQT1JUKQogCiB2 b2lkIENsaXBib2FyZDo6c2V0RHJhZ0ltYWdlKENhY2hlZEltYWdlKiwgY29uc3QgSW50UG9pbnQm KQpAQCAtNDUyLDggKzQyOSwzMSBAQCB2b2lkIERyYWdJbWFnZUxvYWRlcjo6aW1hZ2VDaGFuZ2Vk KENhY2hlZEltYWdlKiwgY29uc3QgSW50UmVjdCopCiAgICAgbV9jbGlwYm9hcmQtPnVwZGF0ZURy YWdJbWFnZSgpOwogfQogCi0jZW5kaWYKK3ZvaWQgQ2xpcGJvYXJkOjp3cml0ZVJhbmdlKFJhbmdl KiByYW5nZSwgRnJhbWUqIGZyYW1lKQoreworICAgIEFTU0VSVChyYW5nZSk7CisgICAgQVNTRVJU KGZyYW1lKTsKKyAgICAvLyBGSVhNRTogVGhpcyBpcyBhIGRlc2lnbiBtaXN0YWtlLCBhIGxheWVy aW5nIHZpb2xhdGlvbiB0aGF0IHNob3VsZCBiZSBmaXhlZC4KKyAgICAvLyBUaGUgY29kZSB0byB3 cml0ZSB0aGUgcmFuZ2UgdG8gYSBwYXN0ZWJvYXJkIHNob3VsZCBiZSBhbiBFZGl0b3IgZnVuY3Rp b24gdGhhdCB0YWtlcyBhIHBhc3RlYm9hcmQgYXJndW1lbnQuCisgICAgLy8gRklYTUU6IFRoZSBm cmFtZSBhcmd1bWVudCBzZWVtcyByZWR1bmRhbnQsIHNpbmNlIGEgUmFuZ2UgaXMgaW4gYSBwYXJ0 aWN1bGFyIGRvY3VtZW50LCB3aGljaCBoYXMgYSBjb3JyZXNwb25kaW5nIGZyYW1lLgorICAgIG1f cGFzdGVib2FyZC0+d3JpdGVTZWxlY3Rpb24ocmFuZ2UsIGZyYW1lLT5lZGl0b3IoKS0+c21hcnRJ bnNlcnREZWxldGVFbmFibGVkKCkgJiYgZnJhbWUtPnNlbGVjdGlvbigpLT5ncmFudWxhcml0eSgp ID09IFdvcmRHcmFudWxhcml0eSwgZnJhbWUsIEluY2x1ZGVJbWFnZUFsdFRleHRGb3JDbGlwYm9h cmQpOworfQogCi0jZW5kaWYKK3ZvaWQgQ2xpcGJvYXJkOjp3cml0ZVBsYWluVGV4dChjb25zdCBT dHJpbmcmIHRleHQpCit7CisgICAgbV9wYXN0ZWJvYXJkLT53cml0ZVBsYWluVGV4dCh0ZXh0LCBQ YXN0ZWJvYXJkOjpDYW5ub3RTbWFydFJlcGxhY2UpOworfQorCit2b2lkIENsaXBib2FyZDo6d3Jp dGVVUkwoY29uc3QgS1VSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHRpdGxlLCBGcmFtZSogZnJhbWUp Cit7CisgICAgQVNTRVJUKGZyYW1lKTsKKyAgICAvLyBGSVhNRTogVGhpcyBpcyBhIGRlc2lnbiBt aXN0YWtlLCBhIGxheWVyaW5nIHZpb2xhdGlvbiB0aGF0IHNob3VsZCBiZSBmaXhlZC4KKyAgICAv LyBUaGUgcGFzdGVib2FyZCB3cml0ZVVSTCBmdW5jdGlvbiBzaG91bGQgbm90IHRha2UgYSBmcmFt ZSBhcmd1bWVudCwgbm9yIGRvZXMgdGhpcyBmdW5jdGlvbiBuZWVkIGEgZnJhbWUuCisgICAgbV9w YXN0ZWJvYXJkLT53cml0ZVVSTCh1cmwsIHRpdGxlLCBmcmFtZSk7Cit9CisKKyNlbmRpZiAvLyBF TkFCTEUoRFJBR19TVVBQT1JUKQorCisjZW5kaWYgLy8gIVVTRShMRUdBQ1lfU1RZTEVfQUJTVFJB Q1RfQ0xJUEJPQVJEX0NMQVNTKQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==