116172 2013-05-15 11:24:45 -0700 Avoid backing store for the WebFrameView's layer when the WebView is layer-backed 2013-05-16 11:40:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 116214 1 simon.fraser simon.fraser bdakin commit-queue simon.fraser thorton webkit-bug-importer oldest_to_newest 889410 0 simon.fraser 2013-05-15 11:24:45 -0700 Avoid backing store for the WebFrameView's layer when the WebView is layer-backed 889413 1 201859 simon.fraser 2013-05-15 11:29:01 -0700 Created attachment 201859 Patch 889415 2 simon.fraser 2013-05-15 11:29:52 -0700 *** Bug 116171 has been marked as a duplicate of this bug. *** 889417 3 simon.fraser 2013-05-15 11:30:48 -0700 <rdar://problem/13741243> 889419 4 201859 thorton 2013-05-15 11:33:24 -0700 Comment on attachment 201859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201859&action=review > Source/WebKit/mac/WebView/WebFrameView.mm:82 > +@interface NSView (AppKitSecretsIKnow) (Details) > Source/WebKit/mac/WebView/WebFrameView.mm:490 > + if ([self documentView] == nil) { "comparison with nil/0/etc" la la la stylebot 889630 5 simon.fraser 2013-05-15 19:05:05 -0700 r150168 889749 6 commit-queue 2013-05-16 02:59:59 -0700 Re-opened since this is blocked by bug 116214 889751 7 thorton 2013-05-16 03:00:22 -0700 -[WebFrameView setBackgroundColor:]: unrecognized selector sent to instance 0x7f9cc5d64c50 889855 8 simon.fraser 2013-05-16 09:00:40 -0700 Boo. 889925 9 simon.fraser 2013-05-16 11:32:46 -0700 That only happened with the 1Password extension installed, which is why I didn't see it. 889931 10 simon.fraser 2013-05-16 11:40:08 -0700 Re-landed in https://trac.webkit.org/r150194 201859 2013-05-15 11:29:01 -0700 2013-05-15 19:01:07 -0700 Patch bug-116172-20130515112758.patch text/plain 2681 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMzY3NTNkYzYw NGVkMjU3MGQ4NDRkZTZiOGVkMjM3MDliMjU3MzgyZi4uOTI2NjlhNjNhY2ZjYTIxOWM5MzRlNjhl YTUyYjlhNzE2ZDQwN2Q5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEz LTA1LTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAg IEF2b2lkIGJhY2tpbmcgc3RvcmUgZm9yIHRoZSBXZWJGcmFtZVZpZXcncyBsYXllciB3aGVuIHRo ZSBXZWJWaWV3IGlzIGxheWVyLWJhY2tlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgV2ViVmlldyBpcyBsYXllci1iYWNrZWQsIEFwcEtp dCB3aWxsIGNyZWF0ZSBhIGxheWVyIHdpdGggYmFja2luZyBzdG9yZSBmb3IKKyAgICAgICAgdGhl IFdlYkZyYW1lVmlldyBiZWNhdXNlIGl0IGltcGxlbWVudHMgZHJhd1JlY3Q6LiBIb3dldmVyLCB0 aGlzIG1ldGhvZCBvbmx5IHBhaW50cworICAgICAgICB3aGVuIHRoZXJlIGlzIG5vIGRvY3VtZW50 Vmlldywgc28gdGhpcyBsYXllcuKAmXMgYmFja2luZyBzdG9yZSBpcyB3YXN0ZWZ1bC4KKworICAg ICAgICBXZSBjYW4gYXZvaWQgYWxsb2NhdGlvbiBvZiB0aGlzIGJhY2tpbmcgc3RvcmUgYnkgaW1w bGVtZW50aW5nIC13YW50c1VwZGF0ZUxheWVyCisgICAgICAgIGFuZCAtdXBkYXRlTGF5ZXIsIGFu ZCBzZXR0aW5nIHRoZSB2aWV34oCZcyBiYWNrZ3JvdW5kQ29sb3IuCisKKyAgICAgICAgKiBXZWJW aWV3L1dlYkZyYW1lVmlldy5tbToKKyAgICAgICAgKC1bV2ViRnJhbWVWaWV3IHdhbnRzVXBkYXRl TGF5ZXJdKToKKyAgICAgICAgKC1bV2ViRnJhbWVWaWV3IHVwZGF0ZUxheWVyXSk6CisKIDIwMTMt MDUtMTMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJQcm9j ZXNzIGNvbnN1bWluZyB2ZXJ5IGhpZ2ggQ1BVIG9uIGxpbmtlZGluLmNvbQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZVZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYkZyYW1lVmlldy5tbQppbmRleCAxYTg0NzFkZDA5ZWM4ZDliN2YwYTUz OGYzYjgxOTc1NGNhZDQ0YzhhLi5lOGM0MmI5MjU4ZDIyM2U1NjhmZjM2NjY2ZWYyOTA3YmMzM2Ix NTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lVmlldy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lVmlldy5tbQpAQCAtNzks NiArNzksMTAgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAtIChCT09MKV9zY3JvbGxUbzoo Y29uc3QgTlNQb2ludCAqKW5ld09yaWdpbiBhbmltYXRlOihCT09MKWFuaW1hdGU7IC8vIG5lZWQg dGhlIGJvb2xlYW4gcmVzdWx0IGZyb20gdGhpcyBtZXRob2QKIEBlbmQKIAorQGludGVyZmFjZSBO U1ZpZXcgKEFwcEtpdFNlY3JldHNJS25vdykKKy0gKHZvaWQpc2V0QmFja2dyb3VuZENvbG9yOihO U0NvbG9yICopY29sb3I7CitAZW5kCisKIGVudW0gewogICAgIFNwYWNlS2V5ID0gMHgwMDIwCiB9 OwpAQCAtNDc0LDYgKzQ3OCwzMiBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYWRkVHlwZXNGcm9tQ2xh c3MoTlNNdXRhYmxlRGljdGlvbmFyeSAqYWxsVHlwZXMsIENsYXNzIG9iakNDbAogICAgIH0KIH0K IAorLSAoQk9PTCl3YW50c1VwZGF0ZUxheWVyCit7CisgICAgcmV0dXJuIFlFUzsKK30KKworLSAo dm9pZCl1cGRhdGVMYXllcgoreworICAgIC8vIERvIHdoYXQgLWRyYXdSZWN0OiBkb2VzIGJ1dCBi eSBzZXR0aW5nIGEgYmFja2dyb3VuZENvbG9yIG9uIHRoZSB2aWV3LiBUaGlzIGF2b2lkcworICAg IC8vIGJhY2tpbmcgc3RvcmUgZm9yIHRoaXMgdmlldyB3aGVuIHRoZSBXZWJWaWV3IGlzIGxheWVy LWJhY2tlZC4KKyAgICBpZiAoW3NlbGYgZG9jdW1lbnRWaWV3XSA9PSBuaWwpIHsKKyAgICAgICAg aWYgKFtbc2VsZiBfd2ViVmlld10gZHJhd3NCYWNrZ3JvdW5kXSkgeworICAgICAgICAgICAgW3Nl bGYgc2V0QmFja2dyb3VuZENvbG9yOltbc2VsZiBfd2ViVmlld10gYmFja2dyb3VuZENvbG9yXV07 CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICB9IGVsc2UgeworI2lmbmRlZiBO REVCVUcKKyAgICAgICAgaWYgKFtbc2VsZiBfc2Nyb2xsVmlld10gZHJhd3NCYWNrZ3JvdW5kXSkg eworICAgICAgICAgICAgW3NlbGYgc2V0QmFja2dyb3VuZENvbG9yOltOU0NvbG9yIGN5YW5Db2xv cl1dOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisjZW5kaWYKKyAgICB9CisKKyAg ICBbc2VsZiBzZXRCYWNrZ3JvdW5kQ29sb3I6W05TQ29sb3IgY2xlYXJDb2xvcl1dOworfQorCiAt IChOU1JlY3QpdmlzaWJsZVJlY3QKIHsKICAgICAvLyBUaGlzIG1ldGhvZCBjYW4gYmUgY2FsbGVk IGJlbmVhdGggLVtOU1ZpZXcgZGVhbGxvY10gYWZ0ZXIgd2UgaGF2ZSBjbGVhcmVkIF9wcml2YXRl Lgo=