116166 2013-05-15 10:25:14 -0700 [Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions 2013-05-15 12:37:23 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 115980 1 darin darin commit-queue esprehn+autocc oldest_to_newest 889389 0 darin 2013-05-15 10:25:14 -0700 [Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions 889390 1 201854 darin 2013-05-15 10:29:04 -0700 Created attachment 201854 Patch 889426 2 201854 ap 2013-05-15 11:44:56 -0700 Comment on attachment 201854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201854&action=review Does the improvement from making a few functions non-virtual outweigh the confusion from them being different across ports? > Source/WebCore/dom/Clipboard.h:72 > - virtual ~Clipboard(); > + LEGACY_VIRTUAL ~Clipboard(); I'm not sure that LEGACY_VIRTUAL is a great name, I certainly wouldn't understand it if I saw it. 889427 3 ap 2013-05-15 11:45:10 -0700 (I also said r+ with my comment). 889449 4 darin 2013-05-15 12:37:23 -0700 Committed r150138: <http://trac.webkit.org/changeset/150138> 201854 2013-05-15 10:29:04 -0700 2013-05-15 11:44:56 -0700 Patch bug-116166-20130515102800.patch text/plain 2506 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU0NjdiZTdhNTQzMzQ1 YTM2OGM5ZTgxYjc0ZWQ5YWFkOTM5YTU2NC4uNjllODgzMTRmNmNkMDgwNGFmNjFhNGQ0MTkyNTM5 MzI4ZTQ4NjFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA1LTE1ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBbTWFjXSBNYWtlIENsaXBib2Fy ZCBjbGFzcyBubyBsb25nZXIgcG9seW1vcnBoaWMgYnkgcmVtb3ZpbmcgdGhlIGxhc3QgdmlydHVh bCBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNjE2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViQ29yZS5leHAuaW46IEFkZCB+Q2xpcGJvYXJkIHNpbmNlIGl0J3Mgbm8gbG9uZ2Vy IGEgdmlydHVhbCBmdW5jdGlvbiwgYnV0IHRvIHRoZQorICAgICAgICBub24taU9TIHNlY3Rpb24s IHNpbmNlIGlPUyBpcyBzdGlsbCB1c2luZyB0aGUgbGVnYWN5IHZlcnNpb24gb2YgQ2xpcGJvYXJk LgorCisgICAgICAgICogZG9tL0NsaXBib2FyZC5oOiBNYXJrIGl0ZW1zIG5vbi12aXJ0dWFsLCB0 b28uIEl0J3Mgbm90IGltcGxlbWVudGVkIG9uIE1hYyB5ZXQuCisKKzIwMTMtMDUtMTUgIERhcmlu IEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCiAgICAgICAgIFtNYWNdIFJlbW92ZSB0aGUgQ2xp cGJvYXJkTWFjIGNsYXNzIGFuZCBoZWFkZXIgZmlsZQogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MTY1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXgg ZTViMzZmODFjMmI0NDFkM2E2NDdmMmRmMzVjOTBkMTY5ZWI1NWI4Yy4uNjg1OWFkNTkwNTU2YjIz ZGJlNjI5OTQxNjMwODFiMmU1MjhmNzM4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTE5MDEs NiArMTkwMSw3IEBAIF9fWk43V2ViQ29yZTZXaWRnZXRDMkVQNk5TVmlldwogX19aTjdXZWJDb3Jl N25zQ29sb3JFUktOU181Q29sb3JFCiBfX1pON1dlYkNvcmU4SW50UG9pbnRDMUVSSzhfTlNQb2lu dAogX19aTjdXZWJDb3JlOEludFBvaW50QzFFUks3Q0dQb2ludAorX19aTjdXZWJDb3JlOUNsaXBi b2FyZEQxRXYKIF9fWk43V2ViQ29yZTlGbG9hdFJlY3RDMUVSSzdfTlNSZWN0CiBfX1pOSzdXZWJD b3JlMTBGbG9hdFBvaW50Y3Y4X05TUG9pbnRFdgogX19aTks3V2ViQ29yZTE0U2Nyb2xsYWJsZUFy ZWExOHZpc2libGVDb250ZW50UmVjdEVOUzBfMzZWaXNpYmxlQ29udGVudFJlY3RJbmNsdWRlc1Nj cm9sbGJhcnNFCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmggYi9T b3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmgKaW5kZXggZGZmMzUwMTFmN2E2ZWQ5MTgyMDVh YTM2ZTgzNzM4MmVmM2I2ZDRmMS4uYWMzM2NmNWE4NTY1MzNiNjg4OTI4Y2VmMTI1MzUxYzY5MDQ4 ZmM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuaApAQCAtNjksNyArNjksNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgICAgIAogICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxDbGlwYm9hcmQ+ IGNyZWF0ZShDbGlwYm9hcmRBY2Nlc3NQb2xpY3ksIERyYWdEYXRhKiwgRnJhbWUqKTsKIAotICAg ICAgICB2aXJ0dWFsIH5DbGlwYm9hcmQoKTsKKyAgICAgICAgTEVHQUNZX1ZJUlRVQUwgfkNsaXBi b2FyZCgpOwogCiAgICAgICAgIGJvb2wgaXNGb3JDb3B5QW5kUGFzdGUoKSBjb25zdCB7IHJldHVy biBtX2NsaXBib2FyZFR5cGUgPT0gQ29weUFuZFBhc3RlOyB9CiAgICAgICAgIGJvb2wgaXNGb3JE cmFnQW5kRHJvcCgpIGNvbnN0IHsgcmV0dXJuIG1fY2xpcGJvYXJkVHlwZSA9PSBEcmFnQW5kRHJv cDsgfQpAQCAtMTI0LDcgKzEyNCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9p ZCBzZXREcmFnSGFzU3RhcnRlZCgpIHsgbV9kcmFnU3RhcnRlZCA9IHRydWU7IH0KIAogI2lmIEVO QUJMRShEQVRBX1RSQU5TRkVSX0lURU1TKQotICAgICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8RGF0 YVRyYW5zZmVySXRlbUxpc3Q+IGl0ZW1zKCkgPSAwOworICAgICAgICBMRUdBQ1lfVklSVFVBTCBQ YXNzUmVmUHRyPERhdGFUcmFuc2Zlckl0ZW1MaXN0PiBpdGVtcygpID0gMDsKICNlbmRpZgogICAg ICAgICAKICNpZiAhVVNFKExFR0FDWV9TVFlMRV9BQlNUUkFDVF9DTElQQk9BUkRfQ0xBU1MpCg==