116164 2013-05-15 10:12:21 -0700 [BlackBerry] When HTTP auth fails, only purge credentials that match the failed credentials 2013-05-15 14:23:23 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles commit-queue oldest_to_newest 889379 0 joenotcharles 2013-05-15 10:12:21 -0700 When there are multiple HTTP requests in flight with the same bad credentials (common with proxy auth if the user mistyped their password), the first 407 that's received will cause the credentials to be purged and the password dialog to open for new credentials. This means that all 407's received after this should only purge the credentials if they have not already been updated from the dialog; otherwise they will be wiping out credentials that haven't failed yet. 889384 1 201852 joenotcharles 2013-05-15 10:18:10 -0700 Created attachment 201852 fix 889407 2 201852 rwlbuis 2013-05-15 11:20:02 -0700 Comment on attachment 201852 fix Looks good. 889522 3 201852 commit-queue 2013-05-15 14:23:21 -0700 Comment on attachment 201852 fix Clearing flags on attachment: 201852 Committed r150147: <http://trac.webkit.org/changeset/150147> 889523 4 commit-queue 2013-05-15 14:23:23 -0700 All reviewed patches have been landed. Closing bug. 201852 2013-05-15 10:18:10 -0700 2013-05-15 14:23:20 -0700 fix 0001-BlackBerry-When-HTTP-auth-fails-only-purge-credentia.patch text/plain 5041 joenotcharles RnJvbSAyMmY2NWMyMjdhMTIzYmZhYWJjODNiOThkMDAyMjc5YTg3NWE2NGE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkBibGFja2JlcnJ5LmNvbT4KRGF0 ZTogVHVlLCAxNCBNYXkgMjAxMyAxNjo1MzozMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMS8zXSBb QmxhY2tCZXJyeV0gV2hlbiBIVFRQIGF1dGggZmFpbHMsIG9ubHkgcHVyZ2UKIGNyZWRlbnRpYWxz IHRoYXQgbWF0Y2ggdGhlIGZhaWxlZCBjcmVkZW50aWFscwogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNjE2NAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJ bnRlcm5hbCBQUjogMzM4NDkwCkludGVybmFsbHkgUmV2aWV3ZWQgQnk6IEx5b24gQ2hlbgoKV2hl biB0aGVyZSBhcmUgbXVsdGlwbGUgSFRUUCByZXF1ZXN0cyBpbiBmbGlnaHQgd2l0aCB0aGUgc2Ft ZSBiYWQgY3JlZGVudGlhbHMgKGNvbW1vbiB3aXRoCnByb3h5IGF1dGggaWYgdGhlIHVzZXIgbWlz dHlwZWQgdGhlaXIgcGFzc3dvcmQpLCB0aGUgZmlyc3QgNDA3IHRoYXQncyByZWNlaXZlZCB3aWxs IGNhdXNlCnRoZSBjcmVkZW50aWFscyB0byBiZSBwdXJnZWQgYW5kIHRoZSBwYXNzd29yZCBkaWFs b2cgdG8gb3BlbiBmb3IgbmV3IGNyZWRlbnRpYWxzLiBUaGlzIG1lYW5zCnRoYXQgYWxsIDQwNydz IHJlY2VpdmVkIGFmdGVyIHRoaXMgc2hvdWxkIG9ubHkgcHVyZ2UgdGhlIGNyZWRlbnRpYWxzIGlm IHRoZXkgaGF2ZSBub3QKYWxyZWFkeSBiZWVuIHVwZGF0ZWQgZnJvbSB0aGUgZGlhbG9nOyBvdGhl cndpc2UgdGhleSB3aWxsIGJlIHdpcGluZyBvdXQgY3JlZGVudGlhbHMgdGhhdApoYXZlbid0IGZh aWxlZCB5ZXQuCgoqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoK KFdlYkNvcmU6Ok5ldHdvcmtKb2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzKToKKFdlYkNv cmU6Ok5ldHdvcmtKb2I6OnB1cmdlQ3JlZGVudGlhbHMpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyMSArKysrKysrKysrKysrKysr KysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCAgICAg fCAgIDE5ICsrKysrKysrKysrKysrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NmJkOWYzLi4xMjliNDdjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTMtMDUtMTQgIEpvZSBNYXNvbiAgPGptYXNvbkBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gV2hlbiBIVFRQIGF1dGggZmFp bHMsIG9ubHkgcHVyZ2UgY3JlZGVudGlhbHMgdGhhdCBtYXRjaCB0aGUgZmFpbGVkIGNyZWRlbnRp YWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYx NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnRl cm5hbCBQUjogMzM4NDkwCisgICAgICAgIEludGVybmFsbHkgUmV2aWV3ZWQgQnk6IEx5b24gQ2hl bgorCisgICAgICAgIFdoZW4gdGhlcmUgYXJlIG11bHRpcGxlIEhUVFAgcmVxdWVzdHMgaW4gZmxp Z2h0IHdpdGggdGhlIHNhbWUgYmFkIGNyZWRlbnRpYWxzIChjb21tb24gd2l0aAorICAgICAgICBw cm94eSBhdXRoIGlmIHRoZSB1c2VyIG1pc3R5cGVkIHRoZWlyIHBhc3N3b3JkKSwgdGhlIGZpcnN0 IDQwNyB0aGF0J3MgcmVjZWl2ZWQgd2lsbCBjYXVzZQorICAgICAgICB0aGUgY3JlZGVudGlhbHMg dG8gYmUgcHVyZ2VkIGFuZCB0aGUgcGFzc3dvcmQgZGlhbG9nIHRvIG9wZW4gZm9yIG5ldyBjcmVk ZW50aWFscy4gVGhpcyBtZWFucworICAgICAgICB0aGF0IGFsbCA0MDcncyByZWNlaXZlZCBhZnRl ciB0aGlzIHNob3VsZCBvbmx5IHB1cmdlIHRoZSBjcmVkZW50aWFscyBpZiB0aGV5IGhhdmUgbm90 CisgICAgICAgIGFscmVhZHkgYmVlbiB1cGRhdGVkIGZyb20gdGhlIGRpYWxvZzsgb3RoZXJ3aXNl IHRoZXkgd2lsbCBiZSB3aXBpbmcgb3V0IGNyZWRlbnRpYWxzIHRoYXQKKyAgICAgICAgaGF2ZW4n dCBmYWlsZWQgeWV0LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6c2VuZFJlcXVlc3RX aXRoQ3JlZGVudGlhbHMpOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6cHVyZ2VDcmVk ZW50aWFscyk6CisKIDIwMTMtMDQtMDggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgog CiAgICAgICAgIENyYXNoIGluIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjptYWluVGhyZWFkU2Nyb2xs aW5nUmVhc29ucygpIHdoZW4gZ29pbmcgYmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4IGI0Njg4 ZDkuLmNiYjAyMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv YmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTg2NSw2ICs4NjUsNyBAQCBOZXR3 b3JrSm9iOjpTZW5kUmVxdWVzdFJlc3VsdCBOZXR3b3JrSm9iOjpzZW5kUmVxdWVzdFdpdGhDcmVk ZW50aWFscyhQcm90ZWN0aW9uUwogICAgICAgICBjaGFsbGVuZ2Uuc2V0U3RvcmVkKHRydWUpOwog ICAgICAgICB1cGRhdGVDdXJyZW50V2ViQ2hhbGxlbmdlKGNoYWxsZW5nZSk7CiAgICAgfSBlbHNl IHsKKyAgICAgICAgQVNTRVJUKGNyZWRlbnRpYWwuaXNFbXB0eSgpKTsKICAgICAgICAgaWYgKG1f aGFuZGxlLT5maXJzdFJlcXVlc3QoKS50YXJnZXRUeXBlKCkgPT0gUmVzb3VyY2VSZXF1ZXN0OjpU YXJnZXRJc0Zhdmljb24pIHsKICAgICAgICAgICAgIC8vIFRoZSBmYXZpY29uIGxvYWRpbmcgaXMg dHJpZ2dlcnJlZCBhZnRlciB0aGUgbWFpbiByZXNvdXJjZSBoYXMgYmVlbiBsb2FkZWQKICAgICAg ICAgICAgIC8vIGFuZCBwYXJzZWQsIHNvIGlmIHdlIGNhbmNlbCB0aGUgYXV0aGVudGljYXRpb24g Y2hhbGxlbmdlIHdoZW4gbG9hZGluZyB0aGUgbWFpbgpAQCAtOTY3LDYgKzk2OCwxMCBAQCB2b2lk IE5ldHdvcmtKb2I6OnB1cmdlQ3JlZGVudGlhbHMoKQogCiAgICAgcHVyZ2VDcmVkZW50aWFscyht X2hhbmRsZS0+Z2V0SW50ZXJuYWwoKS0+bV9ob3N0V2ViQ2hhbGxlbmdlKTsKICAgICBwdXJnZUNy ZWRlbnRpYWxzKG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX3Byb3h5V2ViQ2hhbGxlbmdlKTsK KworICAgIG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX2N1cnJlbnRXZWJDaGFsbGVuZ2UubnVs bGlmeSgpOworICAgIG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX3Byb3h5V2ViQ2hhbGxlbmdl Lm51bGxpZnkoKTsKKyAgICBtX2hhbmRsZS0+Z2V0SW50ZXJuYWwoKS0+bV9ob3N0V2ViQ2hhbGxl bmdlLm51bGxpZnkoKTsKIH0KIAogdm9pZCBOZXR3b3JrSm9iOjpwdXJnZUNyZWRlbnRpYWxzKEF1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiBjaGFsbGVuZ2UpCkBAIC05OTMsMTEgKzk5OCwxNyBAQCB2 b2lkIE5ldHdvcmtKb2I6OnB1cmdlQ3JlZGVudGlhbHMoQXV0aGVudGljYXRpb25DaGFsbGVuZ2Um IGNoYWxsZW5nZSkKICAgICAgICAgbV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fcGFzcyA9ICIi OwogICAgIH0KIAotICAgIENyZWRlbnRpYWxTdG9yYWdlOjpyZW1vdmUoY2hhbGxlbmdlLnByb3Rl Y3Rpb25TcGFjZSgpKTsKLSAgICBjaGFsbGVuZ2Uuc2V0U3RvcmVkKGZhbHNlKTsKKyAgICAvLyBE byBub3QgY29tcGFyZSBjcmVkZW50aWFsIG9iamVjdHMgd2l0aCA9PSBoZXJlLCBzaW5jZSB3ZSBk b24ndCBjYXJlIGFib3V0IHRoZSBwZXJzaXN0ZW5jZS4KKworICAgIGNvbnN0IENyZWRlbnRpYWwm IHN0b3JlZENyZWRlbnRpYWwgPSBDcmVkZW50aWFsU3RvcmFnZTo6Z2V0KGNoYWxsZW5nZS5wcm90 ZWN0aW9uU3BhY2UoKSk7CisgICAgaWYgKHN0b3JlZENyZWRlbnRpYWwudXNlcigpID09IHB1cmdl VXNlcm5hbWUgJiYgc3RvcmVkQ3JlZGVudGlhbC5wYXNzd29yZCgpID09IHB1cmdlUGFzc3dvcmQp IHsKKyAgICAgICAgQ3JlZGVudGlhbFN0b3JhZ2U6OnJlbW92ZShjaGFsbGVuZ2UucHJvdGVjdGlv blNwYWNlKCkpOworICAgICAgICBjaGFsbGVuZ2Uuc2V0U3RvcmVkKGZhbHNlKTsKKyAgICB9CiAj aWYgRU5BQkxFKEJMQUNLQkVSUllfQ1JFREVOVElBTF9QRVJTSVNUKQotICAgIGlmIChjaGFsbGVu Z2UucHJvcG9zZWRDcmVkZW50aWFsKCkgPT0gY3JlZGVudGlhbEJhY2tpbmdTdG9yZSgpLmdldExv Z2luKGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSkpCi0gICAgICAgIGNyZWRlbnRpYWxCYWNr aW5nU3RvcmUoKS5yZW1vdmVMb2dpbihjaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCksIGNoYWxs ZW5nZS5wcm9wb3NlZENyZWRlbnRpYWwoKS51c2VyKCkpOworICAgIGNvbnN0IENyZWRlbnRpYWwm IHBlcnNpc3RlZENyZWRlbnRpYWwgPSBjcmVkZW50aWFsQmFja2luZ1N0b3JlKCkuZ2V0TG9naW4o Y2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpKTsKKyAgICBpZiAocGVyc2lzdGVkQ3JlZGVudGlh bC51c2VyKCkgPT0gcHVyZ2VVc2VybmFtZSAmJiBwZXJzaXN0ZWRDcmVkZW50aWFsLnBhc3N3b3Jk KCkgPT0gcHVyZ2VQYXNzd29yZCkKKyAgICAgICAgY3JlZGVudGlhbEJhY2tpbmdTdG9yZSgpLnJl bW92ZUxvZ2luKGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSwgcHVyZ2VVc2VybmFtZSk7CiAj ZW5kaWYKIH0KIAotLSAKMS43LjEwLjQKCg==