116154 2013-05-15 08:04:31 -0700 [GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2 2013-05-16 13:30:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 berto webkit-unassigned cgarcia gustavo mrobinson zan oldest_to_newest 889295 0 berto 2013-05-15 08:04:31 -0700 I get .libs/libwebkitgtk-3.0.so: undefined reference to `WebCore::VectorMath::vsmul(float const*, int, float const*, float*, int, unsigned long)' The problem is that the value of ENABLE_WEB_AUDIO from configure is overriden in Source/autotools/SetupWebKitFeatures.m4 diff --git a/Source/autotools/SetupWebKitFeatures.m4 b/Source/autotools/SetupWebKitFeatures.m4 index 5d59b6e..a2a7c45 100644 --- a/Source/autotools/SetupWebKitFeatures.m4 +++ b/Source/autotools/SetupWebKitFeatures.m4 @@ -171,7 +171,6 @@ $srcdir/Tools/gtk/generate-feature-defines-files $CONFIGURABLE_FEATURE_DEFINES \ ENABLE_USER_TIMING=0 \ ENABLE_VIBRATION=0 \ ENABLE_VIDEO_TRACK=0 \ - ENABLE_WEB_AUDIO=0 \ ENABLE_WEB_SOCKETS=1 \ ENABLE_WEB_TIMING=1 \ ENABLE_WORKERS=1 \ This was fixed indirectly in master for bug 113349. 889300 1 zan 2013-05-15 08:18:33 -0700 Unfortunate. Will you be able to provide the patch? 889308 2 201835 berto 2013-05-15 08:32:28 -0700 Created attachment 201835 Patch 889309 3 201836 berto 2013-05-15 08:33:18 -0700 Created attachment 201836 Patch 889397 4 mrobinson 2013-05-15 10:46:29 -0700 I'm a bit confused. You say this was fixed in master for https://bugs.webkit.org/show_bug.cgi?id=113349, but https://bugs.webkit.org/show_bug.cgi?id=113349 was merged into 2.0.1. 889401 5 berto 2013-05-15 11:03:42 -0700 (In reply to comment #4) > I'm a bit confused. You say this was fixed in master for > https://bugs.webkit.org/show_bug.cgi?id=113349, but > https://bugs.webkit.org/show_bug.cgi?id=113349 was merged into > 2.0.1. I've just checked the commit in 2.0.1, it kept the ENABLE_WEB_AUDIO=0 line intact. See line 174 of http://trac.webkit.org/changeset/148428/releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4 Compare it with the commit in master: http://trac.webkit.org/changeset/147967/trunk/Source/autotools/SetupWebKitFeatures.m4 889728 6 berto 2013-05-16 00:50:23 -0700 You can see the problem easily by running configure --enable-web-audio and checking the value of ENABLE_WEB_AUDIO in WebKitFeatures.h 889889 7 gustavo 2013-05-16 10:24:07 -0700 I took the liberty of landing this to the stable branch: http://trac.webkit.org/changeset/150185 889985 8 berto 2013-05-16 13:30:32 -0700 (In reply to comment #7) > I took the liberty of landing this to the stable branch: Great, thanks I think bug 115612 and bug 116227 are also worthwhile. I believe with these all three we can make a full parallel build with all features enabled. 201835 2013-05-15 08:32:28 -0700 2013-05-15 08:33:18 -0700 Patch 115612.diff text/plain 952 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhODQ0 NDI4Li5mMzY1MjhmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDUtMTUgIEFsYmVydG8gR2FyY2lhICA8YWdh cmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZhaWxzIHRvIGJ1aWxkIHdoaWxlIGdl bmVyYXRpbmcgZ3RrZG9jCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTU2MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggdHlwbyBpbiB0aGUgcHJlcmVxdWlzaXRlcyBvZiBkb2NzLWJ1aWxkLnN0YW1w LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTMtMDUtMTMgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIHRlc3RSdW5u ZXIuc2V0UHJpbnRpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9HTlVtYWtlZmlsZS5hbSBiL1Rvb2xz L0dOVW1ha2VmaWxlLmFtCmluZGV4IDQ4MDM1MGUuLmRkMzFhMGUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0dOVW1ha2VmaWxlLmFtCisrKyBiL1Rvb2xzL0dOVW1ha2VmaWxlLmFtCkBAIC0zMzksNyArMzM5 LDcgQEAgZG9jc19idWlsZF9zdGFtcF9saXN0ICs9IFwKIAlTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CiBlbmRpZgogCi1kb2NzLWJ1 aWxkLnN0YW1wOiAkKGRvY19idWlsZF9zdGFtcF9saXN0KQorZG9jcy1idWlsZC5zdGFtcDogJChk b2NzX2J1aWxkX3N0YW1wX2xpc3QpCiAJQ0M9JChDQykgJChzcmNkaXIpL1Rvb2xzL2d0ay9nZW5l cmF0ZS1ndGtkb2MKIAlAdG91Y2ggZG9jcy1idWlsZC5zdGFtcAogCg== 201836 2013-05-15 08:33:18 -0700 2013-05-16 10:23:02 -0700 Patch 116154.diff text/plain 1084 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2ZTU5Y2EzLi5mMzU0MzJh IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTMtMDUtMTUgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIFdlYkF1ZGlvIGRvZXNuJ3QgYnVpbGQgaW4gV2ViS2l0R1RLKyAyLjAuMgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MTU0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qgb3ZlcnJp ZGUgdGhlIHZhbHVlIG9mIEVOQUJMRV9XRUJfQVVESU8gc2VsZWN0ZWQgaW4gdGhlCisgICAgICAg IGNvbmZpZ3VyZSBzY3JpcHQuCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL1NldHVwV2Vi S2l0RmVhdHVyZXMubTQ6CisKIDIwMTMtMDUtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBORVdTIGFuZCBW ZXJzaW9ucy5tNCBmb3IgMi4wLjIgcmVsZWFzZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9hdXRvdG9v bHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRG ZWF0dXJlcy5tNAppbmRleCA1ZDU5YjZlLi5hMmE3YzQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0 b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVyZXMubTQKKysrIGIvU291cmNlL2F1dG90b29scy9TZXR1 cFdlYktpdEZlYXR1cmVzLm00CkBAIC0xNzEsNyArMTcxLDYgQEAgJHNyY2Rpci9Ub29scy9ndGsv Z2VuZXJhdGUtZmVhdHVyZS1kZWZpbmVzLWZpbGVzICRDT05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJ TkVTIFwKIAlFTkFCTEVfVVNFUl9USU1JTkc9MCBcCiAJRU5BQkxFX1ZJQlJBVElPTj0wIFwKIAlF TkFCTEVfVklERU9fVFJBQ0s9MCBcCi0JRU5BQkxFX1dFQl9BVURJTz0wIFwKIAlFTkFCTEVfV0VC X1NPQ0tFVFM9MSBcCiAJRU5BQkxFX1dFQl9USU1JTkc9MSBcCiAJRU5BQkxFX1dPUktFUlM9MSBc Cg==