116143 2013-05-15 03:09:01 -0700 [sh4] savedTimeoutReg should be removed from JITStackFrame 2013-05-15 14:16:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue fpizlo ggaren mark.lam oliver oldest_to_newest 889223 0 jbriance 2013-05-15 03:09:01 -0700 Since r148119, timeoutCheckRegister is removed from baseline JIT. So we don't need to keep r8 register in JITStackFrame anymore for sh4 baseline JIT (see http://trac.webkit.org/changeset/148119/trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h). 889225 1 201811 jbriance 2013-05-15 03:17:50 -0700 Created attachment 201811 Remove savedTimeoutReg from JITStackFrame for sh4 base JIT I've tested this patch on r150106 and I didn't see regressions when running - Tools/Scripts/run-javascriptcore-tests - Tools/Scripts/run-fast-jsc - SunSpider 1.0 889304 2 201811 mark.lam 2013-05-15 08:25:52 -0700 Comment on attachment 201811 Remove savedTimeoutReg from JITStackFrame for sh4 base JIT LGTM but need someone else to r+. 889444 3 201811 ggaren 2013-05-15 12:33:49 -0700 Comment on attachment 201811 Remove savedTimeoutReg from JITStackFrame for sh4 base JIT r=me 889515 4 201811 commit-queue 2013-05-15 14:16:52 -0700 Comment on attachment 201811 Remove savedTimeoutReg from JITStackFrame for sh4 base JIT Clearing flags on attachment: 201811 Committed r150146: <http://trac.webkit.org/changeset/150146> 889516 5 commit-queue 2013-05-15 14:16:54 -0700 All reviewed patches have been landed. Closing bug. 201811 2013-05-15 03:17:50 -0700 2013-05-15 14:16:52 -0700 Remove savedTimeoutReg from JITStackFrame for sh4 base JIT bug-116143.patch text/plain 2420 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUwMTA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTA1LTE1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFJlbW92ZSBzYXZlZFRpbWVvdXRSZWcgZnJvbSBKSVRTdGFja0ZyYW1lIGZvciBzaDQg YmFzZSBKSVQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTYxNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTaW5jZSByMTQ4MTE5LCB0aW1lb3V0Q2hlY2tSZWdpc3RlciBpcyByZW1vdmVkIGZyb20gYmFz ZWxpbmUgSklULgorICAgICAgICBTbyB3ZSBkb24ndCBuZWVkIHRvIHNhdmUgcjggcmVnaXN0ZXIg aW4gSklUU3RhY2tGcmFtZSBhbnltb3JlIGZvciBzaDQuCisKKyAgICAgICAgKiBqaXQvSklUU3R1 YnMuY3BwOgorICAgICAgICAqIGppdC9KSVRTdHVicy5oOgorICAgICAgICAoSklUU3RhY2tGcmFt ZSk6CisKIDIwMTMtMDUtMTMgIEFsdmFybyBMb3BleiBPcnRlZ2EgIDxhbHZhcm9AYWxvYmJzLmNv bT4KIAogICAgICAgICBOaWdodGx5IGJ1aWxkJ3MganNjIGRvZXNuJ3Qgd29yayB3aXRob3V0IERZ TERfRlJBTUVXT1JLLi4uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJz LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNw cAkocmV2aXNpb24gMTUwMTA2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVi cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNSw4ICszMDUsNiBAQCBTWU1CT0xfU1RSSU5HKGN0 aVRyYW1wb2xpbmUpICI6IiAiXG4iCiAgICAgIm1vdi5sIHI3LCBALXIxNSIgIlxuIgogICAgICJt b3YubCByNiwgQC1yMTUiICJcbiIKICAgICAibW92LmwgcjUsIEAtcjE1IiAiXG4iCi0gICAgIm1v di5sIHI4LCBALXIxNSIgIlxuIgotICAgICJtb3YgIzEyNywgcjgiICJcbiIKICAgICAibW92Lmwg cjE0LCBALXIxNSIgIlxuIgogICAgICJzdHMubCBwciwgQC1yMTUiICJcbiIKICAgICAibW92Lmwg cjEzLCBALXIxNSIgIlxuIgpAQCAtMzIyLDcgKzMyMCw2IEBAIFNZTUJPTF9TVFJJTkcoY3RpVHJh bXBvbGluZSkgIjoiICJcbiIKICAgICAibW92LmwgQHIxNSsscjEzIiAiXG4iCiAgICAgImxkcy5s IEByMTUrLHByIiAiXG4iCiAgICAgIm1vdi5sIEByMTUrLHIxNCIgIlxuIgotICAgICJtb3YubCBA cjE1KyxyOCIgIlxuIgogICAgICJhZGQgIzEyLCByMTUiICJcbiIKICAgICAicnRzIiAiXG4iCiAg ICAgIm5vcCIgIlxuIgpAQCAtMzQ2LDcgKzM0Myw2IEBAIFNZTUJPTF9TVFJJTkcoY3RpVk1UaHJv d1RyYW1wb2xpbmUpICI6IiAKICAgICAibW92LmwgQHIxNSsscjEzIiAiXG4iCiAgICAgImxkcy5s IEByMTUrLHByIiAiXG4iCiAgICAgIm1vdi5sIEByMTUrLHIxNCIgIlxuIgotICAgICJtb3YubCBA cjE1KyxyOCIgIlxuIgogICAgICJhZGQgIzEyLCByMTUiICJcbiIKICAgICAicnRzIiAiXG4iCiAg ICAgIm5vcCIgIlxuIgpAQCAtMzY0LDcgKzM2MCw2IEBAIFNZTUJPTF9TVFJJTkcoY3RpT3BUaHJv d05vdENhdWdodCkgIjoiICIKICAgICAibW92LmwgQHIxNSsscjEzIiAiXG4iCiAgICAgImxkcy5s IEByMTUrLHByIiAiXG4iCiAgICAgIm1vdi5sIEByMTUrLHIxNCIgIlxuIgotICAgICJtb3YubCBA cjE1KyxyOCIgIlxuIgogICAgICJhZGQgIzEyLCByMTUiICJcbiIKICAgICAicnRzIiAiXG4iCiAg ICAgIm5vcCIgIlxuIgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaAkocmV2 aXNpb24gMTUwMTA2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5oCSh3 b3JraW5nIGNvcHkpCkBAIC0yNzIsNyArMjcyLDYgQEAgc3RydWN0IEpJVFN0YWNrRnJhbWUgewog ICAgIHZvaWQqIHNhdmVkUjEzOwogICAgIHZvaWQqIHNhdmVkUlBSOwogICAgIHZvaWQqIHNhdmVk UjE0OwotICAgIHZvaWQqIHNhdmVkVGltZW91dFJlZzsKIAogICAgIEpTU3RhY2sqIHN0YWNrOwog ICAgIENhbGxGcmFtZSogY2FsbEZyYW1lOwo=