116136 2013-05-14 21:28:04 -0700 [Mac] Make Clipboard::createDragImage non-virtual 2013-05-15 02:42:45 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 11980 1 darin darin commit-queue esprehn+autocc oldest_to_newest 889130 0 darin 2013-05-14 21:28:04 -0700 [Mac] Make Clipboard::createDragImage non-virtual 889131 1 201789 darin 2013-05-14 21:32:20 -0700 Created attachment 201789 Patch 889161 2 201789 benjamin 2013-05-14 23:36:46 -0700 Comment on attachment 201789 Patch Looks great! 889219 3 201789 commit-queue 2013-05-15 02:42:43 -0700 Comment on attachment 201789 Patch Clearing flags on attachment: 201789 Committed r150107: <http://trac.webkit.org/changeset/150107> 889220 4 commit-queue 2013-05-15 02:42:45 -0700 All reviewed patches have been landed. Closing bug. 201789 2013-05-14 21:32:20 -0700 2013-05-15 02:42:43 -0700 Patch bug-116136-20130514213116.patch text/plain 6755 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y4Nzc2Njk0MzJkMzA4 YzcyNDgxMjA5NzFmMTBiYjk0ZGYxNzJjNi4uNDEzNTM0ZWNhMGUyNzkwNTM4YzE2NGE0MmU2MTc3 ZjhlYmIyNTI5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEzLTA1LTE0ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBbTWFjXSBNYWtlIENsaXBib2Fy ZDo6Y3JlYXRlRHJhZ0ltYWdlIG5vbi12aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYxMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9DbGlwYm9hcmQuaDogTWFkZSBjcmVhdGVEcmFn SW1hZ2Ugbm9uLXZpcnR1YWwgZm9yIG5vbi1sZWdhY3kuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMvQ2xpcGJvYXJkTWFjLmg6IFJlbW92ZWQgZnJhbWUgYXJndW1lbnQgZnJvbSBjcmVhdGUgZnVu Y3Rpb24KKyAgICAgICAgYW5kIGNvbnN0cnVjdG9yLiBSZW1vdmVkIGNyZWF0ZURyYWdJbWFnZSBh bmQgZHJhZ05TSW1hZ2UuIFJlbW92ZWQgbV9mcmFtZQorICAgICAgICBkYXRhIG1lbWJlci4KKwor ICAgICAgICAqIHBsYXRmb3JtL21hYy9DbGlwYm9hcmRNYWMubW06CisgICAgICAgIChXZWJDb3Jl OjpDbGlwYm9hcmRNYWM6OkNsaXBib2FyZE1hYyk6IFJlbW92ZWQgZnJhbWUgYXJndW1lbnQgYW5k IGNvZGUKKyAgICAgICAgdG8gaW5pdGlhbGl6ZSBtX2ZyYW1lLgorICAgICAgICAoV2ViQ29yZTo6 Q2xpcGJvYXJkOjpjcmVhdGVEcmFnSW1hZ2UpOiBNZXJnZWQgdGhlIGNyZWF0ZURyYWdJbWFnZSBh bmQKKyAgICAgICAgZHJhZ05TSW1hZ2UgZnVuY3Rpb25zLCBzaW5jZSB0aGV5IHdlcmUgdGhlIHNh bWUgdGhpbmcuIENoYW5nZWQgY29kZSB0byBnZXQKKyAgICAgICAgdGhlIGZyYW1lIGZyb20gdGhl IGRyYWcgaW1hZ2UgZWxlbWVudC4gTWFkZSB0aGUgY3JlYXRlRHJhZ0ltYWdlIGZ1bmN0aW9uCisg ICAgICAgIGEgQ2xpcGJvYXJkIG1lbWJlciBpbnN0ZWFkIG9mIENsaXBib2FyZE1hYy4KKworMjAx My0wNS0xNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAgICAgW01hY10g TW92ZSBzZXREcmFnSW1hZ2UgZnJvbSBDbGlwYm9hcmRNYWMgdG8gUGFzdGVib2FyZE1hYwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MDM2CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuaCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9DbGlwYm9hcmQuaAppbmRleCAxZDdjZmNkNjkyMjlmZGZiYzdkMDk5YWFlYmEzNGZjYzg4 Yjc2ZDgxLi45NDBhNDA2Y2JlYzAyM2M4ODMwOGU0MmI0MmM2MzRhMjlmYjhmOWRkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmgKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0NsaXBib2FyZC5oCkBAIC05NCw3ICs5NCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAg ICAgICAgTm9kZSogZHJhZ0ltYWdlRWxlbWVudCgpIGNvbnN0IHsgcmV0dXJuIG1fZHJhZ0ltYWdl RWxlbWVudC5nZXQoKTsgfQogICAgICAgICBMRUdBQ1lfVklSVFVBTCB2b2lkIHNldERyYWdJbWFn ZUVsZW1lbnQoTm9kZSosIGNvbnN0IEludFBvaW50JikgTEVHQUNZX1BVUkU7CiAgICAgICAgIAot ICAgICAgICB2aXJ0dWFsIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2UoSW50UG9pbnQmIGRy YWdMb2NhdGlvbikgY29uc3QgPSAwOworICAgICAgICBMRUdBQ1lfVklSVFVBTCBEcmFnSW1hZ2VS ZWYgY3JlYXRlRHJhZ0ltYWdlKEludFBvaW50JiBkcmFnTG9jYXRpb24pIGNvbnN0IExFR0FDWV9Q VVJFOwogI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAgICAgICAgIHZpcnR1YWwgdm9pZCBkZWNs YXJlQW5kV3JpdGVEcmFnSW1hZ2UoRWxlbWVudCosIGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcm IHRpdGxlLCBGcmFtZSopID0gMDsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL0NsaXBib2FyZE1hYy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L0NsaXBib2FyZE1hYy5oCmluZGV4IGJlZjM4NTE0OWJjYTZkMDA3NDhkNWY5MTE1NGUwNDE5Nzk3 YTgyNGQuLmUyMThhNGIzMTdkYTgxOTcwNDRjYWE5NmVlMWNmYWFhZTQ1NTM2MTAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9DbGlwYm9hcmRNYWMuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvQ2xpcGJvYXJkTWFjLmgKQEAgLTQ2LDI4ICs0NiwyNSBA QCBwdWJsaWM6CiAgICAgICAgIENvcHlBbmRQYXN0ZUdlbmVyaWMKICAgICB9OwogCi0gICAgc3Rh dGljIFBhc3NSZWZQdHI8Q2xpcGJvYXJkTWFjPiBjcmVhdGUoQ2xpcGJvYXJkVHlwZSBjbGlwYm9h cmRUeXBlLCBjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lLCBDbGlwYm9hcmRBY2Nlc3NQb2xp Y3kgcG9saWN5LCBDbGlwYm9hcmRDb250ZW50cyBjbGlwYm9hcmRDb250ZW50cywgRnJhbWUqIGZy YW1lKQorICAgIHN0YXRpYyBQYXNzUmVmUHRyPENsaXBib2FyZE1hYz4gY3JlYXRlKENsaXBib2Fy ZFR5cGUgY2xpcGJvYXJkVHlwZSwgY29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSwgQ2xpcGJv YXJkQWNjZXNzUG9saWN5IHBvbGljeSwgQ2xpcGJvYXJkQ29udGVudHMgY2xpcGJvYXJkQ29udGVu dHMsIEZyYW1lKikKICAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgQ2xpcGJvYXJk TWFjKGNsaXBib2FyZFR5cGUsIHBhc3RlYm9hcmROYW1lLCBwb2xpY3ksIGNsaXBib2FyZENvbnRl bnRzLCBmcmFtZSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENsaXBib2FyZE1hYyhj bGlwYm9hcmRUeXBlLCBwYXN0ZWJvYXJkTmFtZSwgcG9saWN5LCBjbGlwYm9hcmRDb250ZW50cykp OwogICAgIH0KIAogICAgIHZpcnR1YWwgfkNsaXBib2FyZE1hYygpOwogCi0gICAgdmlydHVhbCBE cmFnSW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlKEludFBvaW50JiBkcmFnTG9jKSBjb25zdDsKICNp ZiBFTkFCTEUoRFJBR19TVVBQT1JUKQogICAgIHZpcnR1YWwgdm9pZCBkZWNsYXJlQW5kV3JpdGVE cmFnSW1hZ2UoRWxlbWVudCosIGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmIHRpdGxlLCBGcmFt ZSopOwogI2VuZGlmCiAgICAgCiAgICAgLy8gTWV0aG9kcyBmb3IgZ2V0dGluZyBpbmZvIGluIENv Y29hJ3MgdHlwZSBzeXN0ZW0KLSAgICBOU0ltYWdlICpkcmFnTlNJbWFnZShOU1BvaW50JikgY29u c3Q7IC8vIGxvYyBjb252ZXJ0ZWQgZnJvbSBkcmFnTG9jLCBiYXNlZCBvbiB3aG9sZSBpbWFnZSBz aXplCiAgICAgY29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSgpIHsgcmV0dXJuIG1fcGFzdGVi b2FyZE5hbWU7IH0KIAogcHJpdmF0ZToKLSAgICBDbGlwYm9hcmRNYWMoQ2xpcGJvYXJkVHlwZSwg Y29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSwgQ2xpcGJvYXJkQWNjZXNzUG9saWN5LCBDbGlw Ym9hcmRDb250ZW50cywgRnJhbWUqKTsKKyAgICBDbGlwYm9hcmRNYWMoQ2xpcGJvYXJkVHlwZSwg Y29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSwgQ2xpcGJvYXJkQWNjZXNzUG9saWN5LCBDbGlw Ym9hcmRDb250ZW50cyk7CiAKICAgICBTdHJpbmcgbV9wYXN0ZWJvYXJkTmFtZTsKICAgICBpbnQg bV9jaGFuZ2VDb3VudDsKLSAgICBGcmFtZSogbV9mcmFtZTsgLy8gdXNlZCBvbiB0aGUgc291cmNl IHNpZGUgdG8gZ2VuZXJhdGUgZHJhZ2dpbmcgaW1hZ2VzCiB9OwogCiB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvQ2xpcGJvYXJkTWFjLm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL0NsaXBib2FyZE1hYy5tbQppbmRleCA3YjBmODFmYWViZTM2NTJiYzdi ZDgxYzRiYjcwZWY0ODZhMDliMTc4Li4zOWE1YjdjZTMxZGRkNmJmOTE1YjBlNTg3YTg4MDA1ZDAw MmJhNjE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvQ2xpcGJvYXJk TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9DbGlwYm9hcmRNYWMubW0K QEAgLTU1LDEwICs1NSw5IEBAIFBhc3NSZWZQdHI8Q2xpcGJvYXJkPiBDbGlwYm9hcmQ6OmNyZWF0 ZShDbGlwYm9hcmRBY2Nlc3NQb2xpY3kgcG9saWN5LCBEcmFnRGF0YSoKIH0KICNlbmRpZgogCi1D bGlwYm9hcmRNYWM6OkNsaXBib2FyZE1hYyhDbGlwYm9hcmRUeXBlIGNsaXBib2FyZFR5cGUsIGNv bnN0IFN0cmluZyYgcGFzdGVib2FyZE5hbWUsIENsaXBib2FyZEFjY2Vzc1BvbGljeSBwb2xpY3ks IENsaXBib2FyZENvbnRlbnRzIGNsaXBib2FyZENvbnRlbnRzLCBGcmFtZSAqZnJhbWUpCitDbGlw Ym9hcmRNYWM6OkNsaXBib2FyZE1hYyhDbGlwYm9hcmRUeXBlIGNsaXBib2FyZFR5cGUsIGNvbnN0 IFN0cmluZyYgcGFzdGVib2FyZE5hbWUsIENsaXBib2FyZEFjY2Vzc1BvbGljeSBwb2xpY3ksIENs aXBib2FyZENvbnRlbnRzIGNsaXBib2FyZENvbnRlbnRzKQogICAgIDogQ2xpcGJvYXJkKHBvbGlj eSwgY2xpcGJvYXJkVHlwZSwgUGFzdGVib2FyZDo6Y3JlYXRlKHBhc3RlYm9hcmROYW1lKSwgY2xp cGJvYXJkQ29udGVudHMgPT0gRHJhZ0FuZERyb3BGaWxlcykKICAgICAsIG1fcGFzdGVib2FyZE5h bWUocGFzdGVib2FyZE5hbWUpCi0gICAgLCBtX2ZyYW1lKGZyYW1lKQogewogICAgIG1fY2hhbmdl Q291bnQgPSBwbGF0Zm9ybVN0cmF0ZWdpZXMoKS0+cGFzdGVib2FyZFN0cmF0ZWd5KCktPmNoYW5n ZUNvdW50KG1fcGFzdGVib2FyZE5hbWUpOwogfQpAQCAtNzYsMzMgKzc1LDI1IEBAIHZvaWQgQ2xp cGJvYXJkTWFjOjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2UoRWxlbWVudCogZWxlbWVudCwgY29u c3QgS1VSTCYgdXJsLCBjCiB9CiAjZW5kaWYgLy8gRU5BQkxFKERSQUdfU1VQUE9SVCkKICAgICAK LURyYWdJbWFnZVJlZiBDbGlwYm9hcmRNYWM6OmNyZWF0ZURyYWdJbWFnZShJbnRQb2ludCYgbG9j KSBjb25zdAotewotICAgIE5TUG9pbnQgbnNsb2MgPSBOU01ha2VQb2ludChsb2MueCgpLCBsb2Mu eSgpKTsKLSAgICBEcmFnSW1hZ2VSZWYgcmVzdWx0ID0gZHJhZ05TSW1hZ2UobnNsb2MpOwotICAg IGxvYyA9IChJbnRQb2ludCluc2xvYzsKLSAgICByZXR1cm4gcmVzdWx0OwotfQotICAgIAotTlNJ bWFnZSAqQ2xpcGJvYXJkTWFjOjpkcmFnTlNJbWFnZShOU1BvaW50JiBsb2MpIGNvbnN0CitEcmFn SW1hZ2VSZWYgQ2xpcGJvYXJkOjpjcmVhdGVEcmFnSW1hZ2UoSW50UG9pbnQmIGxvY2F0aW9uKSBj b25zdAogewogICAgIE5TSW1hZ2UgKnJlc3VsdCA9IG5pbDsKICAgICBpZiAobV9kcmFnSW1hZ2VF bGVtZW50KSB7Ci0gICAgICAgIGlmIChtX2ZyYW1lKSB7CisgICAgICAgIERvY3VtZW50KiBkb2N1 bWVudCA9IG1fZHJhZ0ltYWdlRWxlbWVudC0+ZG9jdW1lbnQoKTsKKyAgICAgICAgaWYgKEZyYW1l KiBmcmFtZSA9IGRvY3VtZW50LT5mcmFtZSgpKSB7CiAgICAgICAgICAgICBOU1JlY3QgaW1hZ2VS ZWN0OwogICAgICAgICAgICAgTlNSZWN0IGVsZW1lbnRSZWN0OwotICAgICAgICAgICAgcmVzdWx0 ID0gc25hcHNob3REcmFnSW1hZ2UobV9mcmFtZSwgbV9kcmFnSW1hZ2VFbGVtZW50LmdldCgpLCAm aW1hZ2VSZWN0LCAmZWxlbWVudFJlY3QpOworICAgICAgICAgICAgcmVzdWx0ID0gc25hcHNob3RE cmFnSW1hZ2UoZnJhbWUsIG1fZHJhZ0ltYWdlRWxlbWVudC5nZXQoKSwgJmltYWdlUmVjdCwgJmVs ZW1lbnRSZWN0KTsKICAgICAgICAgICAgIC8vIENsaWVudCBzcGVjaWZpZXMgcG9pbnQgcmVsYXRp dmUgdG8gZWxlbWVudCwgbm90IHRoZSB3aG9sZSBpbWFnZSwgd2hpY2ggbWF5IGluY2x1ZGUgY2hp bGQKICAgICAgICAgICAgIC8vIGxheWVycyBzcHJlYWQgb3V0IGFsbCBvdmVyIHRoZSBwbGFjZS4K LSAgICAgICAgICAgIGxvYy54ID0gZWxlbWVudFJlY3Qub3JpZ2luLnggLSBpbWFnZVJlY3Qub3Jp Z2luLnggKyBtX2RyYWdMb2MueCgpOwotICAgICAgICAgICAgbG9jLnkgPSBlbGVtZW50UmVjdC5v cmlnaW4ueSAtIGltYWdlUmVjdC5vcmlnaW4ueSArIG1fZHJhZ0xvYy55KCk7Ci0gICAgICAgICAg ICBsb2MueSA9IGltYWdlUmVjdC5zaXplLmhlaWdodCAtIGxvYy55OworICAgICAgICAgICAgbG9j YXRpb24uc2V0WChlbGVtZW50UmVjdC5vcmlnaW4ueCAtIGltYWdlUmVjdC5vcmlnaW4ueCArIG1f ZHJhZ0xvYy54KCkpOworICAgICAgICAgICAgbG9jYXRpb24uc2V0WShpbWFnZVJlY3Quc2l6ZS5o ZWlnaHQgLSAoZWxlbWVudFJlY3Qub3JpZ2luLnkgLSBpbWFnZVJlY3Qub3JpZ2luLnkgKyBtX2Ry YWdMb2MueSgpKSk7CiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKG1fZHJhZ0ltYWdlKSB7CiAg ICAgICAgIHJlc3VsdCA9IG1fZHJhZ0ltYWdlLT5pbWFnZSgpLT5nZXROU0ltYWdlKCk7CiAgICAg ICAgIAotICAgICAgICBsb2MgPSBtX2RyYWdMb2M7Ci0gICAgICAgIGxvYy55ID0gW3Jlc3VsdCBz aXplXS5oZWlnaHQgLSBsb2MueTsKKyAgICAgICAgbG9jYXRpb24gPSBtX2RyYWdMb2M7CisgICAg ICAgIGxvY2F0aW9uLnNldFkoW3Jlc3VsdCBzaXplXS5oZWlnaHQgLSBsb2NhdGlvbi55KCkpOwog ICAgIH0KICAgICByZXR1cm4gcmVzdWx0OwogfQo=