116098 2013-05-14 04:06:22 -0700 Snapshotted plug-ins shadow tree should reset style inheritance 2013-05-14 11:02:42 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue dino esprehn+autocc graouts jonlee webkit-bug-importer oldest_to_newest 888771 0 graouts 2013-05-14 04:06:22 -0700 In order for styles coming from the page to not affect the content displayed in a snapshotted plug-in's shadow root, we need to reset style inheritance. This way only styles defined by the injected user-agent stylesheets will affect the rendering of the shadow content. 888772 1 graouts 2013-05-14 04:06:33 -0700 <rdar://problem/13885342> 888773 2 201696 graouts 2013-05-14 04:08:10 -0700 Created attachment 201696 Patch 888870 3 201696 darin 2013-05-14 09:22:30 -0700 Comment on attachment 201696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:370 > + root->setResetStyleInheritance(true); This needs a why comment. It’s not at all clear why this is here or what would break if we removed this, and there’s no regression test to help make it clear. 888884 4 graouts 2013-05-14 09:43:22 -0700 (In reply to comment #3) > (From update of attachment 201696 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review > > > Source/WebCore/html/HTMLPlugInImageElement.cpp:370 > > + root->setResetStyleInheritance(true); > > This needs a why comment. It’s not at all clear why this is here or what would break if we removed this, and there’s no regression test to help make it clear. Adding a comment in the commit. 888885 5 201727 graouts 2013-05-14 09:43:38 -0700 Created attachment 201727 Patch for landing 888939 6 201727 commit-queue 2013-05-14 11:02:38 -0700 Comment on attachment 201727 Patch for landing Clearing flags on attachment: 201727 Committed r150081: <http://trac.webkit.org/changeset/150081> 888940 7 commit-queue 2013-05-14 11:02:42 -0700 All reviewed patches have been landed. Closing bug. 201696 2013-05-14 04:08:10 -0700 2013-05-14 09:43:31 -0700 Patch bug-116098-20130514130706.patch text/plain 1423 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIwNzljNzNlZmZkMjY0 Mjc3YjhhYTM0ZmNiZDFlNDUyMDljMjkyNi4uNjY2ZGFhZWNlNmE0M2JlNGRhZDMxYTkxNjQ1NTkw ZjZmNDc4NDI5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTE0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgU25hcHNob3R0ZWQgcGx1 Zy1pbnMgc2hhZG93IHRyZWUgc2hvdWxkIHJlc2V0IHN0eWxlIGluaGVyaXRhbmNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYwOTgKKworICAgICAg ICBSZXNldCB0aGUgc3R5bGVzIHN1Y2ggdGhhdCBvbmx5IGluamVjdGVkIHVzZXItYWdlbnQgc3R5 bGVzaGVldHMgYWZmZWN0CisgICAgICAgIHRoZSByZW5kZXJpbmcgb2Ygc25hcHNob3R0ZWQgcGx1 Zy1pbnMnIHNoYWRvdyBjb250ZW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OmRpZEFkZFVzZXJBZ2VudFNoYWRv d1Jvb3QpOgorCiAyMDEzLTA1LTEzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFtNYWNdIHVwZGF0ZSBpbi1iYW5kIGNhcHRpb24gYXR0cmlidXRlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAKaW5kZXgg MDM5ZjdmZWE3Y2E0ZDE0YjM0NGFkOWJjZWMxMzNmMjlhNGI1YTdjMC4uOTk1ZmZmN2I5MDNhMGVi NTAxZjQ0ZGE1YWJiNjgzMjI1NTQ4ZjRkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCkBAIC0zNjYsNiArMzY2LDggQEAgdm9pZCBIVE1MUGx1 Z0luSW1hZ2VFbGVtZW50OjpkaWRBZGRVc2VyQWdlbnRTaGFkb3dSb290KFNoYWRvd1Jvb3QqIHJv b3QpCiAgICAgUGFnZSogcGFnZSA9IGRvY3VtZW50KCktPnBhZ2UoKTsKICAgICBpZiAoIXBhZ2Up CiAgICAgICAgIHJldHVybjsKKworICAgIHJvb3QtPnNldFJlc2V0U3R5bGVJbmhlcml0YW5jZSh0 cnVlKTsKICAgICAKICAgICBTdHJpbmcgbWltZVR5cGUgPSBsb2FkZWRNaW1lVHlwZSgpOwogCg== 201727 2013-05-14 09:43:38 -0700 2013-05-14 11:02:38 -0700 Patch for landing bug-116098-20130514184234.patch text/plain 1630 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIwNzljNzNlZmZkMjY0 Mjc3YjhhYTM0ZmNiZDFlNDUyMDljMjkyNi4uNDFkOWJkZWIxZTNhYTY1MmRmZGZiMDAzOTY0Y2E1 YzRhYmYxMDE4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTE0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgU25hcHNob3R0ZWQgcGx1 Zy1pbnMgc2hhZG93IHRyZWUgc2hvdWxkIHJlc2V0IHN0eWxlIGluaGVyaXRhbmNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYwOTgKKworICAgICAg ICBSZXNldCB0aGUgc3R5bGVzIHN1Y2ggdGhhdCBvbmx5IGluamVjdGVkIHVzZXItYWdlbnQgc3R5 bGVzaGVldHMgYWZmZWN0CisgICAgICAgIHRoZSByZW5kZXJpbmcgb2Ygc25hcHNob3R0ZWQgcGx1 Zy1pbnMnIHNoYWRvdyBjb250ZW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OmRpZEFkZFVzZXJBZ2VudFNoYWRvd1Jv b3QpOgorCiAyMDEzLTA1LTEzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29t PgogCiAgICAgICAgIFtNYWNdIHVwZGF0ZSBpbi1iYW5kIGNhcHRpb24gYXR0cmlidXRlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAKaW5kZXggMDM5 ZjdmZWE3Y2E0ZDE0YjM0NGFkOWJjZWMxMzNmMjlhNGI1YTdjMC4uMTQ0NWMzNWQ2YzJjOWQ2NjRj N2U3YTk5YTYyNmNiZDUxZjNiNTJjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQ bHVnSW5JbWFnZUVsZW1lbnQuY3BwCkBAIC0zNjYsNiArMzY2LDExIEBAIHZvaWQgSFRNTFBsdWdJ bkltYWdlRWxlbWVudDo6ZGlkQWRkVXNlckFnZW50U2hhZG93Um9vdChTaGFkb3dSb290KiByb290 KQogICAgIFBhZ2UqIHBhZ2UgPSBkb2N1bWVudCgpLT5wYWdlKCk7CiAgICAgaWYgKCFwYWdlKQog ICAgICAgICByZXR1cm47CisKKyAgICAvLyBSZXNldCBhbnkgYXV0aG9yIHN0eWxlcyB0aGF0IG1h eSBhcHBseSBhcyB3ZSBvbmx5IHdhbnQgZXhwbGljaXQKKyAgICAvLyBzdHlsZXMgZGVmaW5lZCBp biB0aGUgaW5qZWN0ZWQgdXNlciBhZ2VudHMgc3R5bGVzaGVldHMgdG8gc3BlY2lmeQorICAgIC8v IHRoZSBsb29rLWFuZC1mZWVsIG9mIHRoZSBzbmFwc2hvdHRlZCBwbHVnLWluIG92ZXJsYXkuIAor ICAgIHJvb3QtPnNldFJlc2V0U3R5bGVJbmhlcml0YW5jZSh0cnVlKTsKICAgICAKICAgICBTdHJp bmcgbWltZVR5cGUgPSBsb2FkZWRNaW1lVHlwZSgpOwogCg==