116089 2013-05-13 22:31:28 -0700 Get rid of Gradient::getColor() 2013-05-14 14:14:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue esprehn+autocc oldest_to_newest 888699 0 benjamin 2013-05-13 22:31:28 -0700 Get rid of Gradient::getColor() 888700 1 201679 benjamin 2013-05-13 22:31:59 -0700 Created attachment 201679 Patch 888812 2 201679 kling 2013-05-14 06:32:51 -0700 Comment on attachment 201679 Patch r=me 889026 3 201679 benjamin 2013-05-14 14:14:13 -0700 Comment on attachment 201679 Patch Clearing flags on attachment: 201679 Committed r150088: <http://trac.webkit.org/changeset/150088> 889027 4 benjamin 2013-05-14 14:14:16 -0700 All reviewed patches have been landed. Closing bug. 201679 2013-05-13 22:31:59 -0700 2013-05-14 14:14:13 -0700 Patch bug-116089-20130513223056.patch text/plain 6236 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThjMzliNWZjMWY5MDgz N2JlOWU2YjNhNjNlMzY1ZDcxYjI3NTc4Yi4uODY5NDZjMjgzNGQxZDQ1MzU2Y2U0MTAxN2QyZWUw MTIzMWU3ZGRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA1LTEzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIEdldCByaWQgb2Yg R3JhZGllbnQ6OmdldENvbG9yKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNjA4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgY29kZSBpcyBub3cgdXNlbGVzcywgcmVtb3ZlIGl0LgorCisgICAg ICAgICogaHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQuaDoKKyAgICAgICAgKENhbnZhc0dyYWRp ZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFkaWVudDo6R3JhZGllbnQpOgorICAgICAgICAoV2ViQ29yZTo6R3JhZGll bnQ6Omhhc2gpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50Lmg6CisgICAg ICAgIChHcmFkaWVudCk6CisKIDIwMTMtMDUtMTMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFw cGxlLmNvbT4KIAogICAgICAgICBCVUlMRCBGSVggKHIxNTAwNDkpOiBGaXggUmV0YWluUHRyPD4g dHlwZSBpbiBQYXN0ZWJvYXJkSU9TLm1tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9DYW52YXNHcmFkaWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2Fu dmFzR3JhZGllbnQuaAppbmRleCAxZmY5YzY1NTkyNTRhZGRiNDg5Y2YwODRkODAwNmU0ZmRhYjli NTM5Li44NTI5ZDU4NGRmZGQ0NDk2NzM4NGIyODQyMjk2ZmExMDBjZGYwYzEzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNHcmFkaWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc0dyYWRpZW50LmgKQEAgLTUxLDggKzUxLDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgYWRkQ29sb3JTdG9wKGZsb2F0IHZh bHVlLCBjb25zdCBTdHJpbmcmIGNvbG9yLCBFeGNlcHRpb25Db2RlJik7CiAKLSAgICAgICAgdm9p ZCBnZXRDb2xvcihmbG9hdCB2YWx1ZSwgZmxvYXQqIHIsIGZsb2F0KiBnLCBmbG9hdCogYiwgZmxv YXQqIGEpIGNvbnN0IHsgbV9ncmFkaWVudC0+Z2V0Q29sb3IodmFsdWUsIHIsIGcsIGIsIGEpOyB9 Ci0KICNpZiBFTkFCTEUoREFTSEJPQVJEX1NVUFBPUlQpCiAgICAgICAgIHZvaWQgc2V0RGFzaGJv YXJkQ29tcGF0aWJpbGl0eU1vZGUoKSB7IG1fZGFzaGJhcmRDb21wYXRpYmlsaXR5TW9kZSA9IHRy dWU7IH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhZGllbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGll bnQuY3BwCmluZGV4IGYyZWM4ZGE0YTY3YjY1ZjkyZTBjYjcwNDcxZGZlM2I3YWNkOTAyNmYuLjUz NDVlMTIxYjU0OGI3MzMyYmZjZmU3NjBkZDdjZTdhOTIzMjMyOGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5jcHAKQEAgLTQ0LDcgKzQ0LDYgQEAgR3Jh ZGllbnQ6OkdyYWRpZW50KGNvbnN0IEZsb2F0UG9pbnQmIHAwLCBjb25zdCBGbG9hdFBvaW50JiBw MSkKICAgICAsIG1fcjEoMCkKICAgICAsIG1fYXNwZWN0UmF0aW8oMSkKICAgICAsIG1fc3RvcHNT b3J0ZWQoZmFsc2UpCi0gICAgLCBtX2xhc3RTdG9wKDApCiAgICAgLCBtX3NwcmVhZE1ldGhvZChT cHJlYWRNZXRob2RQYWQpCiAgICAgLCBtX2NhY2hlZEhhc2goMCkKIHsKQEAgLTU5LDcgKzU4LDYg QEAgR3JhZGllbnQ6OkdyYWRpZW50KGNvbnN0IEZsb2F0UG9pbnQmIHAwLCBmbG9hdCByMCwgY29u c3QgRmxvYXRQb2ludCYgcDEsIGZsb2F0IHIKICAgICAsIG1fcjEocjEpCiAgICAgLCBtX2FzcGVj dFJhdGlvKGFzcGVjdFJhdGlvKQogICAgICwgbV9zdG9wc1NvcnRlZChmYWxzZSkKLSAgICAsIG1f bGFzdFN0b3AoMCkKICAgICAsIG1fc3ByZWFkTWV0aG9kKFNwcmVhZE1ldGhvZFBhZCkKICAgICAs IG1fY2FjaGVkSGFzaCgwKQogewpAQCAtMTM4LDczICsxMzYsNiBAQCB2b2lkIEdyYWRpZW50Ojpz b3J0U3RvcHNJZk5lY2Vzc2FyeSgpCiAgICAgaW52YWxpZGF0ZUhhc2goKTsKIH0KIAotdm9pZCBH cmFkaWVudDo6Z2V0Q29sb3IoZmxvYXQgdmFsdWUsIGZsb2F0KiByLCBmbG9hdCogZywgZmxvYXQq IGIsIGZsb2F0KiBhKSBjb25zdAotewotICAgIEFTU0VSVCh2YWx1ZSA+PSAwKTsKLSAgICBBU1NF UlQodmFsdWUgPD0gMSk7Ci0KLSAgICBpZiAobV9zdG9wcy5pc0VtcHR5KCkpIHsKLSAgICAgICAg KnIgPSAwOwotICAgICAgICAqZyA9IDA7Ci0gICAgICAgICpiID0gMDsKLSAgICAgICAgKmEgPSAw OwotICAgICAgICByZXR1cm47Ci0gICAgfQotICAgIGlmICghbV9zdG9wc1NvcnRlZCkgewotICAg ICAgICBpZiAobV9zdG9wcy5zaXplKCkpCi0gICAgICAgICAgICBzdGQ6OnN0YWJsZV9zb3J0KG1f c3RvcHMuYmVnaW4oKSwgbV9zdG9wcy5lbmQoKSwgY29tcGFyZVN0b3BzKTsKLSAgICAgICAgbV9z dG9wc1NvcnRlZCA9IHRydWU7Ci0gICAgfQotICAgIGlmICh2YWx1ZSA8PSAwIHx8IHZhbHVlIDw9 IG1fc3RvcHMuZmlyc3QoKS5zdG9wKSB7Ci0gICAgICAgICpyID0gbV9zdG9wcy5maXJzdCgpLnJl ZDsKLSAgICAgICAgKmcgPSBtX3N0b3BzLmZpcnN0KCkuZ3JlZW47Ci0gICAgICAgICpiID0gbV9z dG9wcy5maXJzdCgpLmJsdWU7Ci0gICAgICAgICphID0gbV9zdG9wcy5maXJzdCgpLmFscGhhOwot ICAgICAgICByZXR1cm47Ci0gICAgfQotICAgIGlmICh2YWx1ZSA+PSAxIHx8IHZhbHVlID49IG1f c3RvcHMubGFzdCgpLnN0b3ApIHsKLSAgICAgICAgKnIgPSBtX3N0b3BzLmxhc3QoKS5yZWQ7Ci0g ICAgICAgICpnID0gbV9zdG9wcy5sYXN0KCkuZ3JlZW47Ci0gICAgICAgICpiID0gbV9zdG9wcy5s YXN0KCkuYmx1ZTsKLSAgICAgICAgKmEgPSBtX3N0b3BzLmxhc3QoKS5hbHBoYTsKLSAgICAgICAg cmV0dXJuOwotICAgIH0KLQotICAgIC8vIEZpbmQgc3RvcCBiZWZvcmUgYW5kIHN0b3AgYWZ0ZXIg YW5kIGludGVycG9sYXRlLgotICAgIGludCBzdG9wID0gZmluZFN0b3AodmFsdWUpOwotICAgIGNv bnN0IENvbG9yU3RvcCYgbGFzdFN0b3AgPSBtX3N0b3BzW3N0b3BdOyAgICAKLSAgICBjb25zdCBD b2xvclN0b3AmIG5leHRTdG9wID0gbV9zdG9wc1tzdG9wICsgMV07Ci0gICAgZmxvYXQgc3RvcEZy YWN0aW9uID0gKHZhbHVlIC0gbGFzdFN0b3Auc3RvcCkgLyAobmV4dFN0b3Auc3RvcCAtIGxhc3RT dG9wLnN0b3ApOwotICAgICpyID0gbGFzdFN0b3AucmVkICsgKG5leHRTdG9wLnJlZCAtIGxhc3RT dG9wLnJlZCkgKiBzdG9wRnJhY3Rpb247Ci0gICAgKmcgPSBsYXN0U3RvcC5ncmVlbiArIChuZXh0 U3RvcC5ncmVlbiAtIGxhc3RTdG9wLmdyZWVuKSAqIHN0b3BGcmFjdGlvbjsKLSAgICAqYiA9IGxh c3RTdG9wLmJsdWUgKyAobmV4dFN0b3AuYmx1ZSAtIGxhc3RTdG9wLmJsdWUpICogc3RvcEZyYWN0 aW9uOwotICAgICphID0gbGFzdFN0b3AuYWxwaGEgKyAobmV4dFN0b3AuYWxwaGEgLSBsYXN0U3Rv cC5hbHBoYSkgKiBzdG9wRnJhY3Rpb247Ci19Ci0KLWludCBHcmFkaWVudDo6ZmluZFN0b3AoZmxv YXQgdmFsdWUpIGNvbnN0Ci17Ci0gICAgQVNTRVJUKHZhbHVlID49IDApOwotICAgIEFTU0VSVCh2 YWx1ZSA8PSAxKTsKLSAgICBBU1NFUlQobV9zdG9wc1NvcnRlZCk7Ci0KLSAgICBpbnQgbnVtU3Rv cHMgPSBtX3N0b3BzLnNpemUoKTsKLSAgICBBU1NFUlQobnVtU3RvcHMgPj0gMik7Ci0gICAgQVNT RVJUKG1fbGFzdFN0b3AgPCBudW1TdG9wcyAtIDEpOwotCi0gICAgaW50IGkgPSBtX2xhc3RTdG9w OwotICAgIGlmICh2YWx1ZSA8IG1fc3RvcHNbaV0uc3RvcCkKLSAgICAgICAgaSA9IDE7Ci0gICAg ZWxzZQotICAgICAgICBpID0gbV9sYXN0U3RvcCArIDE7Ci0KLSAgICBmb3IgKDsgaSA8IG51bVN0 b3BzIC0gMTsgKytpKQotICAgICAgICBpZiAodmFsdWUgPCBtX3N0b3BzW2ldLnN0b3ApCi0gICAg ICAgICAgICBicmVhazsKLQotICAgIG1fbGFzdFN0b3AgPSBpIC0gMTsKLSAgICByZXR1cm4gbV9s YXN0U3RvcDsKLX0KLQogYm9vbCBHcmFkaWVudDo6aGFzQWxwaGEoKSBjb25zdAogewogICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9zdG9wcy5zaXplKCk7IGkrKykgewpAQCAtMjU3LDcgKzE4 OCw2IEBAIHVuc2lnbmVkIEdyYWRpZW50OjpoYXNoKCkgY29uc3QKICAgICAgICAgZmxvYXQgcjA7 CiAgICAgICAgIGZsb2F0IHIxOwogICAgICAgICBmbG9hdCBhc3BlY3RSYXRpbzsKLSAgICAgICAg aW50IGxhc3RTdG9wOwogICAgICAgICBHcmFkaWVudFNwcmVhZE1ldGhvZCBzcHJlYWRNZXRob2Q7 CiAgICAgICAgIGJvb2wgcmFkaWFsOwogICAgIH0gcGFyYW1ldGVyczsKQEAgLTI3NSw3ICsyMDUs NiBAQCB1bnNpZ25lZCBHcmFkaWVudDo6aGFzaCgpIGNvbnN0CiAgICAgcGFyYW1ldGVycy5yMCA9 IG1fcjA7CiAgICAgcGFyYW1ldGVycy5yMSA9IG1fcjE7CiAgICAgcGFyYW1ldGVycy5hc3BlY3RS YXRpbyA9IG1fYXNwZWN0UmF0aW87Ci0gICAgcGFyYW1ldGVycy5sYXN0U3RvcCA9IG1fbGFzdFN0 b3A7CiAgICAgcGFyYW1ldGVycy5zcHJlYWRNZXRob2QgPSBtX3NwcmVhZE1ldGhvZDsKICAgICBw YXJhbWV0ZXJzLnJhZGlhbCA9IG1fcmFkaWFsOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhZGllbnQuaAppbmRleCAzOWM5YjVjMDNlN2Q3Mjg1MThjZDM1NDZiMTFmZThm M2JjZGIxODQ4Li4zZDIzZDczNDk4NjAzYmUzMjFiNTkxMTc2YzdhNzM1YmVmOGZiNGQ4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKQEAgLTg1LDcgKzg1 LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIGFkZENvbG9yU3RvcChjb25z dCBDb2xvclN0b3AmKTsKICAgICAgICAgdm9pZCBhZGRDb2xvclN0b3AoZmxvYXQsIGNvbnN0IENv bG9yJik7CiAKLSAgICAgICAgdm9pZCBnZXRDb2xvcihmbG9hdCB2YWx1ZSwgZmxvYXQqIHIsIGZs b2F0KiBnLCBmbG9hdCogYiwgZmxvYXQqIGEpIGNvbnN0OwogICAgICAgICBib29sIGhhc0FscGhh KCkgY29uc3Q7CiAKICAgICAgICAgYm9vbCBpc1JhZGlhbCgpIGNvbnN0IHsgcmV0dXJuIG1fcmFk aWFsOyB9CkBAIC0xODYsNyArMTg1LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2 b2lkIHBsYXRmb3JtSW5pdCgpIHsgbV9ncmFkaWVudCA9IDA7IH0KICAgICAgICAgdm9pZCBwbGF0 Zm9ybURlc3Ryb3koKTsKIAotICAgICAgICBpbnQgZmluZFN0b3AoZmxvYXQgdmFsdWUpIGNvbnN0 OwogICAgICAgICB2b2lkIHNvcnRTdG9wc0lmTmVjZXNzYXJ5KCk7CiAKICAgICAgICAgLy8gS2Vl cCBhbnkgcGFyYW1ldGVycyByZWxldmFudCB0byByZW5kZXJpbmcgaW4gc3luYyB3aXRoIHRoZSBz dHJ1Y3R1cmUgaW4gR3JhZGllbnQ6Omhhc2goKS4KQEAgLTE5OCw3ICsxOTYsNiBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgICAgIGZsb2F0IG1fYXNwZWN0UmF0aW87IC8vIEZvciBlbGxpcHRp Y2FsIGdyYWRpZW50LCB3aWR0aCAvIGhlaWdodC4KICAgICAgICAgbXV0YWJsZSBWZWN0b3I8Q29s b3JTdG9wLCAyPiBtX3N0b3BzOwogICAgICAgICBtdXRhYmxlIGJvb2wgbV9zdG9wc1NvcnRlZDsK LSAgICAgICAgbXV0YWJsZSBpbnQgbV9sYXN0U3RvcDsKICAgICAgICAgR3JhZGllbnRTcHJlYWRN ZXRob2QgbV9zcHJlYWRNZXRob2Q7CiAgICAgICAgIEFmZmluZVRyYW5zZm9ybSBtX2dyYWRpZW50 U3BhY2VUcmFuc2Zvcm1hdGlvbjsKIAo=