11608 2006-11-15 16:12:49 -0800 [S60] render object of image type was wrongly typecast 2006-12-11 10:33:05 -0800 1 1 1 Unclassified WebKit Layout and Rendering 412 S60 Emulator S60 3rd edition CLOSED FIXED P2 Normal --- 0 shaun.keller webkit-unassigned zalan oldest_to_newest 45705 0 shaun.keller 2006-11-15 16:12:49 -0800 TSW TMCN-6SWLXX 45706 1 11535 shaun.keller 2006-11-15 16:21:08 -0800 Created attachment 11535 render object of image type was wrongly typecast 45641 2 11535 zalan 2006-11-16 08:24:00 -0800 Comment on attachment 11535 render object of image type was wrongly typecast i don't think that if( !type b ) cast to type a is a good pratcice. you could use const char *renderName() to find out the type of that object. 45573 3 11543 shaun.keller 2006-11-16 13:00:31 -0800 Created attachment 11543 render object of image type was wrongly typecast and move brace so changelog script works Includes moving the brace to make the ChangeLog script work. 45574 4 11543 zalan 2006-11-16 13:13:06 -0800 Comment on attachment 11543 render object of image type was wrongly typecast and move brace so changelog script works r=me 45617 5 bradley.morrison 2006-11-17 08:17:42 -0800 Some commments on this: - changelog entry does not reflect the patch - bug metadata is wrong. Please see the S60WebKit bugzilla documentation. 45559 6 bradley.morrison 2006-11-17 12:31:55 -0800 > Some commments on this: > - changelog entry does not reflect the patch Apologies - I'm wrong. I read Zalan's comment and thought you reworded the CL entry for the 2nd patch based on his comments. My bad! > - bug metadata is wrong. Please see the S60WebKit bugzilla documentation. http://trac.webkit.org/projects/webkit/wiki/S60Buzilla - specifically 2nd last line. 45410 7 zalan 2006-11-18 11:36:05 -0800 r17843 42609 8 krishnamurty.podipireddy 2006-12-11 10:33:05 -0800 Closed. 11535 2006-11-15 16:21:08 -0800 2006-11-16 13:00:31 -0800 render object of image type was wrongly typecast focusable.patch text/plain 1568 shaun.keller SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDE3Nzk0KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE0IEBADQorMjAwNi0xMS0xNSAgc2hrZWxsZXIgIDxzaGF1bi5rZWxsZXJA bm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgemFsYW4uDQorICAgICAgICBERVND OiByZW5kZXIgb2JqZWN0IG9mIGltYWdlIHR5cGUgd2FzIHdyb25nbHkgdHlwZWNhc3QNCisJaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MDgNCisNCisgICAgICAgIFdB Uk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRA0KKw0KKyAgICAgICAgKiBraHRt bC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHA6DQorICAgICAgICAoSFRNTEVtYmVkRWxlbWVudElt cGw6OmlzRm9jdXNhYmxlKToNCisNCiAyMDA2LTExLTEzICBsaWdtYW4gIDxqb3NlcGgubGlnbWFu QG5va2lhLmNvbT4NCiANCiAgICAgICAgIFJldmlld2VkIGJ5IFNhY2hpbi4NCkluZGV4OiBXZWJD b3JlL2todG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNv cmUva2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuY3BwCShyZXZpc2lvbiAxNzc4OCkNCisrKyBX ZWJDb3JlL2todG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAkod29ya2luZyBjb3B5KQ0KQEAg LTUxMiw4ICs1MTIsMTIgQEANCiAgICAgaWYgKCFtX3JlbmRlciB8fCAobV9yZW5kZXItPnN0eWxl KCkgJiYgbV9yZW5kZXItPnN0eWxlKCktPnZpc2liaWxpdHkoKSAhPSBWSVNJQkxFKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIGVsc2UgeworICAgICAgaWYgKCFtX3JlbmRlci0+aXNJbWFn ZSgpKSB7CiAgICAgICAgIFJlbmRlclBhcnRPYmplY3QqIHJlbmRlciA9IHN0YXRpY19jYXN0PFJl bmRlclBhcnRPYmplY3QqPiggbV9yZW5kZXIgKTsKICAgICAgICAgcmV0dXJuIHJlbmRlci0+Zm9j dXNhYmxlKCk7CisgICAgICB9IGVsc2UgeworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICB9 CiAgICAgfQogfQogCkBAIC04MTQsOCArODE4LDEyIEBADQogICAgIGlmICghbV9yZW5kZXIgfHwg KG1fcmVuZGVyLT5zdHlsZSgpICYmIG1fcmVuZGVyLT5zdHlsZSgpLT52aXNpYmlsaXR5KCkgIT0g VklTSUJMRSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBlbHNlIHsKKyAgICAgIGlmICgh bV9yZW5kZXItPmlzSW1hZ2UoKSkgewogICAgICAgICBSZW5kZXJQYXJ0T2JqZWN0KiByZW5kZXIg PSBzdGF0aWNfY2FzdDxSZW5kZXJQYXJ0T2JqZWN0Kj4oIG1fcmVuZGVyICk7CiAgICAgICAgIHJl dHVybiByZW5kZXItPmZvY3VzYWJsZSgpOworICAgICAgfSBlbHNlIHsKKyAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgfQogICAgIH0KIH0KIAo= 11543 2006-11-16 13:00:31 -0800 2006-11-16 13:13:06 -0800 render object of image type was wrongly typecast and move brace so changelog script works isFocusable.patch text/plain 2617 shaun.keller SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDE3ODE1KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE2IEBADQorMjAwNi0xMS0xNiAgc2hrZWxsZXIgIDxzaGF1bi5rZWxsZXJA bm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgemFsYW4uDQorICAgICAgICBERVND OiByZW5kZXIgb2JqZWN0IG9mIGltYWdlIHR5cGUgd2FzIHdyb25nbHkgdHlwZWNhc3QgYW5kIG1v dmUgYnJhY2Ugc28gY2hhbmdlbG9nIHNjcmlwdCB3b3Jrcw0KKyAgICAgICAgaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MDgNCisNCisgICAgICAgIFdBUk5JTkc6IE5P IFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRA0KKw0KKyAgICAgICAgKiBraHRtbC9odG1sL2h0 bWxfb2JqZWN0aW1wbC5jcHA6DQorICAgICAgICAoSFRNTEVtYmVkRWxlbWVudEltcGw6OmlzRm9j dXNhYmxlKToNCisgICAgICAgIChIVE1MT2JqZWN0RWxlbWVudEltcGw6OmdldE9iamVjdEluc3Rh bmNlKToNCisgICAgICAgIChIVE1MT2JqZWN0RWxlbWVudEltcGw6OmlzRm9jdXNhYmxlKToNCisN CiAyMDA2LTExLTEzICBsaWdtYW4gIDxqb3NlcGgubGlnbWFuQG5va2lhLmNvbT4NCiANCiAgICAg ICAgIFJldmlld2VkIGJ5IFNhY2hpbi4NCkluZGV4OiBXZWJDb3JlL2todG1sL2h0bWwvaHRtbF9v YmplY3RpbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUva2h0bWwvaHRtbC9odG1sX29i amVjdGltcGwuY3BwCShyZXZpc2lvbiAxNzc4OCkNCisrKyBXZWJDb3JlL2todG1sL2h0bWwvaHRt bF9vYmplY3RpbXBsLmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTUxMiw4ICs1MTIsMTIgQEAgYm9v bCBIVE1MRW1iZWRFbGVtZW50SW1wbDo6aXNGb2N1c2FibGUoKQ0KICAgICBpZiAoIW1fcmVuZGVy IHx8IChtX3JlbmRlci0+c3R5bGUoKSAmJiBtX3JlbmRlci0+c3R5bGUoKS0+dmlzaWJpbGl0eSgp ICE9IFZJU0lCTEUpKQ0KICAgICAgICAgcmV0dXJuIGZhbHNlOw0KICAgICBlbHNlIHsNCisgICAg ICBpZiAoITo6c3RyY21wKG1fcmVuZGVyLT5yZW5kZXJOYW1lKCksICJSZW5kZXJQYXJ0T2JqZWN0 IikpIHsNCiAgICAgICAgIFJlbmRlclBhcnRPYmplY3QqIHJlbmRlciA9IHN0YXRpY19jYXN0PFJl bmRlclBhcnRPYmplY3QqPiggbV9yZW5kZXIgKTsNCiAgICAgICAgIHJldHVybiByZW5kZXItPmZv Y3VzYWJsZSgpOw0KKyAgICAgIH0gZWxzZSB7DQorICAgICAgICByZXR1cm4gZmFsc2U7DQorICAg ICAgfQ0KICAgICB9DQogfQ0KIA0KQEAgLTU4NiwxMCArNTkwLDExIEBAIEtKUzo6QmluZGluZ3M6 Okluc3RhbmNlICpIVE1MT2JqZWN0RWxlbWUNCiAgICAgICAgIGlmIChyLT5pc1dpZGdldCgpKSB7 DQogICAgICAgICAgICAgaWYgKFFXaWRnZXQgKndpZGdldCA9IHN0YXRpY19jYXN0PFJlbmRlcldp ZGdldCAqPihyKS0+d2lkZ2V0KCkpIHsNCiAjaWYgTk9LSUFfQ0hBTkdFUyAgICAgICAgICAgICAg ICANCi0gICAgICAgICAgICAgICAgaWYgKE1XZWJDb3JlV2lkZ2V0ICp2aWV3ID0gd2lkZ2V0LT5n ZXRWaWV3KCkpICB7DQorICAgICAgICAgICAgICAgIGlmIChNV2ViQ29yZVdpZGdldCAqdmlldyA9 IHdpZGdldC0+Z2V0VmlldygpKQ0KICNlbHNlDQotICAgICAgICAgICAgICAgIGlmIChOU1ZpZXcg KnZpZXcgPSB3aWRnZXQtPmdldFZpZXcoKSkgIHsNCisgICAgICAgICAgICAgICAgaWYgKE5TVmll dyAqdmlldyA9IHdpZGdldC0+Z2V0VmlldygpKQ0KICNlbmRpZg0KKyAgICAgICAgICAgICAgICB7 DQogICAgICAgICAgICAgICAgICAgICAvLyBDYWxsIGludG8gdGhlIHBhcnQgKGFuZCBvdmVyIHRo ZSBicmlkZ2UpIHRvIHB1bGwgdGhlIEJpbmRpbmdzOjpJbnN0YW5jZQ0KICAgICAgICAgICAgICAg ICAgICAgLy8gZnJvbSB0aGUgZ3V0cyBvZiB0aGUgcGx1Z2luLg0KICAgICAgICAgICAgICAgICAg ICAgb2JqZWN0SW5zdGFuY2UgPSBLV1EocGFydCktPmdldE9iamVjdEluc3RhbmNlRm9yVmlldyh2 aWV3KTsNCkBAIC04MTQsOCArODE5LDEyIEBAIGJvb2wgSFRNTE9iamVjdEVsZW1lbnRJbXBsOjpp c0ZvY3VzYWJsZSgNCiAgICAgaWYgKCFtX3JlbmRlciB8fCAobV9yZW5kZXItPnN0eWxlKCkgJiYg bV9yZW5kZXItPnN0eWxlKCktPnZpc2liaWxpdHkoKSAhPSBWSVNJQkxFKSkNCiAgICAgICAgIHJl dHVybiBmYWxzZTsNCiAgICAgZWxzZSB7DQorICAgICAgaWYgKCE6OnN0cmNtcChtX3JlbmRlci0+ cmVuZGVyTmFtZSgpLCAiUmVuZGVyUGFydE9iamVjdCIpKSB7DQogICAgICAgICBSZW5kZXJQYXJ0 T2JqZWN0KiByZW5kZXIgPSBzdGF0aWNfY2FzdDxSZW5kZXJQYXJ0T2JqZWN0Kj4oIG1fcmVuZGVy ICk7DQogICAgICAgICByZXR1cm4gcmVuZGVyLT5mb2N1c2FibGUoKTsNCisgICAgICB9IGVsc2Ug ew0KKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KKyAgICAgIH0NCiAgICAgfQ0KIH0NCiANCg==