<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>116079</bug_id>
          
          <creation_ts>2013-05-13 16:45:43 -0700</creation_ts>
          <short_desc>[Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools</short_desc>
          <delta_ts>2013-05-14 10:57:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>benjamin</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>roger_fong</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>888581</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-05-13 16:45:43 -0700</bug_when>
    <thetext>Many of the Windows debugging tools referenced in our build instructions are no longer easily accessible to people just starting to create a build environment. For example, the &quot;Debugging Tools&quot; download package is now replaced with a &quot;Windows 8 SDK&quot; installer that includes the debugging tools as part of its payload.

Since these paths have changed, and most new users will not be able to run tests, we should update old-run-webkit-tests to find the debugging tools in the appropriate spots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888586</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2013-05-13 17:02:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/13881971&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888594</commentid>
    <comment_count>2</comment_count>
      <attachid>201650</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-05-13 17:42:25 -0700</bug_when>
    <thetext>Created attachment 201650
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888694</commentid>
    <comment_count>3</comment_count>
      <attachid>201650</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-05-13 22:11:06 -0700</bug_when>
    <thetext>Comment on attachment 201650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201650&amp;action=review

&gt; Tools/ChangeLog:24
&gt; -2013-05-13  Zan Dobersek  &lt;zdobersek@igalia.com&gt;
&gt; +

Uh?

&gt; Tools/Scripts/old-run-webkit-tests:2846
&gt; +    my $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{PROGRAMFILES}), &quot;Windows Kits&quot;, &quot;8.0&quot;, &quot;Debuggers&quot;, &quot;x64&quot;, &quot;ntsd.exe&quot;);
&gt;      unless (-f $ntsdPath) {
&gt; -        $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{ProgramW6432}), &quot;Debugging Tools for Windows (x64)&quot;, &quot;ntsd.exe&quot;);
&gt; +        $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{PROGRAMFILES}), &quot;Windows Kits&quot;, &quot;8.0&quot;, &quot;Debuggers&quot;, &quot;x86&quot;, &quot;ntsd.exe&quot;);
&gt;          unless (-f $ntsdPath) {
&gt; -            $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{SYSTEMROOT}), &quot;system32&quot;, &quot;ntsd.exe&quot;);
&gt; +            $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{PROGRAMFILES}), &quot;Debugging Tools for Windows (x86)&quot;, &quot;ntsd.exe&quot;);
&gt;              unless (-f $ntsdPath) {
&gt; -                print STDERR &quot;Can&apos;t find ntsd.exe. Crash logs will not be saved.\nSee &lt;http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs&gt;.\n&quot;;
&gt; -                return;
&gt; +                $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{ProgramW6432}), &quot;Debugging Tools for Windows (x64)&quot;, &quot;ntsd.exe&quot;);
&gt; +                unless (-f $ntsdPath) {
&gt; +                    $ntsdPath = File::Spec-&gt;catfile(toCygwinPath($ENV{SYSTEMROOT}), &quot;system32&quot;, &quot;ntsd.exe&quot;);
&gt; +                    unless (-f $ntsdPath) {
&gt; +                        print STDERR &quot;Can&apos;t find ntsd.exe. Crash logs will not be saved.\nSee &lt;http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs&gt;.\n&quot;;
&gt; +                        return;
&gt; +                    }
&gt; +                }
&gt;              }
&gt;          }
&gt;      }

Instead of this crazy nesting, I think we should have a loop going over a list of stuff we are looking for.

&gt; Tools/Scripts/webkitdirs.pm:1657
&gt; +return;

Uh?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888896</commentid>
    <comment_count>4</comment_count>
      <attachid>201729</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-05-14 10:09:03 -0700</bug_when>
    <thetext>Created attachment 201729
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888897</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-05-14 10:10:17 -0700</bug_when>
    <thetext>Cleaned up the messy patch, and switched to a loop over the possible locations for ntsd.exe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888922</commentid>
    <comment_count>6</comment_count>
      <attachid>201729</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2013-05-14 10:47:11 -0700</bug_when>
    <thetext>Comment on attachment 201729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201729&amp;action=review

r=me

&gt; Tools/Scripts/old-run-webkit-tests:2844
&gt; +    my $ntsdPath = shift @possiblePaths;
&gt; +
&gt; +    while (not -f $ntsdPath) {
&gt; +        if (!@possiblePaths) {
&gt; +            print STDERR &quot;Can&apos;t find ntsd.exe. Crash logs will not be saved.\nSee &lt;http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs&gt;.\n&quot;;
&gt; +            return;
&gt;          }
&gt; +
&gt; +        $ntsdPath = shift @possiblePaths;

I think this might be a little clearer written as a for() loop, but I&apos;m also fine landing this version:

my $ntsdPath;
for ($ntsdPath = shift @possiblePaths; not -f $ntsdPath; $ntsdPath = shift @possiblePaths) {
    if (…) { …}
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888923</commentid>
    <comment_count>7</comment_count>
      <attachid>201729</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2013-05-14 10:48:56 -0700</bug_when>
    <thetext>Comment on attachment 201729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201729&amp;action=review

&gt; Tools/Scripts/old-run-webkit-tests:2834
&gt; +    my @possiblePaths = (File::Spec-&gt;catfile(toCygwinPath($ENV{PROGRAMFILES}), &quot;Windows Kits&quot;, &quot;8.0&quot;, &quot;Debuggers&quot;, &quot;x64&quot;, &quot;ntsd.exe&quot;),
&gt; +        File::Spec-&gt;catfile(toCygwinPath($ENV{PROGRAMFILES}), &quot;Windows Kits&quot;, &quot;8.0&quot;, &quot;Debuggers&quot;, &quot;x86&quot;, &quot;ntsd.exe&quot;),
&gt; +        File::Spec-&gt;catfile(toCygwinPath($ENV{PROGRAMFILES}), &quot;Debugging Tools for Windows (x86)&quot;, &quot;ntsd.exe&quot;),
&gt; +        File::Spec-&gt;catfile(toCygwinPath($ENV{ProgramW6432}), &quot;Debugging Tools for Windows (x64)&quot;, &quot;ntsd.exe&quot;),
&gt; +        File::Spec-&gt;catfile(toCygwinPath($ENV{SYSTEMROOT}), &quot;system32&quot;, &quot;ntsd.exe&quot;));

May be slightly easier to read if each File::Spec-&gt;catfile() is on its own line:

    my @possiblePaths = (
        File::Spec-&gt;catfile(…),
        File::Spec-&gt;catfile(…),
        File::Spec-&gt;catfile(…),
        File::Spec-&gt;catfile(…),
        File::Spec-&gt;catfile(…),
    );

But again, it&apos;s fine this way as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>888933</commentid>
    <comment_count>8</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-05-14 10:57:36 -0700</bug_when>
    <thetext>Committed r150077: &lt;http://trac.webkit.org/changeset/150077&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>201650</attachid>
            <date>2013-05-13 17:42:25 -0700</date>
            <delta_ts>2013-05-14 10:09:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-116079-20130513174123.patch</filename>
            <type>text/plain</type>
            <size>4108</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE1MDA0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDEzLTA1LTEzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t
PgorCisgICAgICAgIFtXaW5kb3dzXSBVcGRhdGUgT1JXVCB0byBrbm93IGFib3V0IHRoZSBXaW5k
b3dzIDggU0RLIGFuZCBEZWJ1ZyBUb29scy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTExNjA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0czoKKyAgICAg
ICAgKHNldFVwV2luZG93c0NyYXNoTG9nU2F2aW5nKTogTG9jYXRlIG50c2QuZXhlIGFuZCB1c2Ug
aXQuCisKIDIwMTMtMDUtMTMgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K
IAogICAgICAgICBbd2Via2l0cHldIE1ha2UgRmlsZUluZm8ucmVwb3NpdG9yeV9uYW1lIHN1cHBv
cnQgU1ZOIHZlcnNpb24gPiAxLjYKQEAgLTExLDcgKzIxLDcgQEAKICAgICAgICAgKiBTY3JpcHRz
L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKICAgICAgICAgKEZpbGVJbmZvLnJlcG9z
aXRvcnlfbmFtZSk6CiAKLTIwMTMtMDUtMTMgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2Fs
aWEuY29tPgorCiAKICAgICAgICAgW0dUS10gVXNlIFdlYkNvcmUgbGF5ZXIgYXJjaGl2ZXMgZm9y
IFRlc3RXZWJDb3JlLCBXZWJLaXRQbHVnaW5Qcm9jZXNzCiAgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU5MTgKSW5kZXg6IFRvb2xzL1NjcmlwdHMvb2xk
LXJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdl
YmtpdC10ZXN0cwkocmV2aXNpb24gMTQ5OTExKQorKysgVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdl
YmtpdC10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtMjgyNywxNCArMjgyNywyMCBAQCBzdWIgc2V0
VXBXaW5kb3dzQ3Jhc2hMb2dTYXZpbmcoKQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAg
bXkgJG50c2RQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSh0b0N5Z3dpblBhdGgoJEVOVntQUk9H
UkFNRklMRVN9KSwgIkRlYnVnZ2luZyBUb29scyBmb3IgV2luZG93cyAoeDg2KSIsICJudHNkLmV4
ZSIpOworICAgIG15ICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5QYXRo
KCRFTlZ7UFJPR1JBTUZJTEVTfSksICJXaW5kb3dzIEtpdHMiLCAiOC4wIiwgIkRlYnVnZ2VycyIs
ICJ4NjQiLCAibnRzZC5leGUiKTsKICAgICB1bmxlc3MgKC1mICRudHNkUGF0aCkgewotICAgICAg
ICAkbnRzZFBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1Byb2dy
YW1XNjQzMn0pLCAiRGVidWdnaW5nIFRvb2xzIGZvciBXaW5kb3dzICh4NjQpIiwgIm50c2QuZXhl
Iik7CisgICAgICAgICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5QYXRo
KCRFTlZ7UFJPR1JBTUZJTEVTfSksICJXaW5kb3dzIEtpdHMiLCAiOC4wIiwgIkRlYnVnZ2VycyIs
ICJ4ODYiLCAibnRzZC5leGUiKTsKICAgICAgICAgdW5sZXNzICgtZiAkbnRzZFBhdGgpIHsKLSAg
ICAgICAgICAgICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5QYXRoKCRF
TlZ7U1lTVEVNUk9PVH0pLCAic3lzdGVtMzIiLCAibnRzZC5leGUiKTsKKyAgICAgICAgICAgICRu
dHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5QYXRoKCRFTlZ7UFJPR1JBTUZJ
TEVTfSksICJEZWJ1Z2dpbmcgVG9vbHMgZm9yIFdpbmRvd3MgKHg4NikiLCAibnRzZC5leGUiKTsK
ICAgICAgICAgICAgIHVubGVzcyAoLWYgJG50c2RQYXRoKSB7Ci0gICAgICAgICAgICAgICAgcHJp
bnQgU1RERVJSICJDYW4ndCBmaW5kIG50c2QuZXhlLiBDcmFzaCBsb2dzIHdpbGwgbm90IGJlIHNh
dmVkLlxuU2VlIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQnVpbGRpbmdPbldpbmRvd3Mj
R2V0dGluZ0NyYXNoTG9ncz4uXG4iOwotICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg
ICAgICAgICAkbnRzZFBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5W
e1Byb2dyYW1XNjQzMn0pLCAiRGVidWdnaW5nIFRvb2xzIGZvciBXaW5kb3dzICh4NjQpIiwgIm50
c2QuZXhlIik7CisgICAgICAgICAgICAgICAgdW5sZXNzICgtZiAkbnRzZFBhdGgpIHsKKyAgICAg
ICAgICAgICAgICAgICAgJG50c2RQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSh0b0N5Z3dpblBh
dGgoJEVOVntTWVNURU1ST09UfSksICJzeXN0ZW0zMiIsICJudHNkLmV4ZSIpOworICAgICAgICAg
ICAgICAgICAgICB1bmxlc3MgKC1mICRudHNkUGF0aCkgeworICAgICAgICAgICAgICAgICAgICAg
ICAgcHJpbnQgU1RERVJSICJDYW4ndCBmaW5kIG50c2QuZXhlLiBDcmFzaCBsb2dzIHdpbGwgbm90
IGJlIHNhdmVkLlxuU2VlIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQnVpbGRpbmdPbldp
bmRvd3MjR2V0dGluZ0NyYXNoTG9ncz4uXG4iOworICAgICAgICAgICAgICAgICAgICAgICAgcmV0
dXJuOworICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgfQogICAgICAgICAg
ICAgfQogICAgICAgICB9CiAgICAgfQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTQ5
OTExKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC00
MzQsNyArNDM0LDcgQEAgc3ViIGRldGVybWluZUNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyCiAgICAg
ZGV0ZXJtaW5lQmFzZVByb2R1Y3REaXIoKTsKICAgICBkZXRlcm1pbmVDb25maWd1cmF0aW9uKCk7
CiAgICAgaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSkgewotICAgICAgICAkY29uZmlndXJhdGlvblBy
b2R1Y3REaXIgPSBGaWxlOjpTcGVjLT5jYXRkaXIoJGJhc2VQcm9kdWN0RGlyLCBjb25maWd1cmF0
aW9uRm9yVmlzdWFsU3R1ZGlvKCksICJiaW4iKTsKKyAgICAgICAgJGNvbmZpZ3VyYXRpb25Qcm9k
dWN0RGlyID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRiYXNlUHJvZHVjdERpciwgY29uZmlndXJhdGlv
bkZvclZpc3VhbFN0dWRpbygpLCAiYmluMzIiKTsKICAgICB9IGVsc2UgewogICAgICAgICBpZiAo
dXNlc1BlckNvbmZpZ3VyYXRpb25CdWlsZERpcmVjdG9yeSgpKSB7CiAgICAgICAgICAgICAkY29u
ZmlndXJhdGlvblByb2R1Y3REaXIgPSAiJGJhc2VQcm9kdWN0RGlyIjsKQEAgLTE2NTQsNiArMTY1
NCw3IEBAIHN1YiBkaWVJZldpbmRvd3NQbGF0Zm9ybVNES05vdEluc3RhbGxlZAogICAgICMgRklY
TUU6IEl0IHdvdWxkIGJlIGJldHRlciB0byBkZXRlY3Qgd2hldGhlciB3ZSBhcmUgdXNpbmcgMzIt
IG9yIDY0LWJpdCBXaW5kb3dzCiAgICAgIyBhbmQgb25seSBjaGVjayB0aGUgYXBwcm9wcmlhdGUg
ZW50cnkuIEJ1dCBmb3Igbm93IHdlIGp1c3QgYmxpbmRseSBjaGVjayBib3RoLgogICAgIHJldHVy
biBpZiAoLWUgJHJlZ2lzdHJ5MzJQYXRoIC4gJHdpbmRvd3NQbGF0Zm9ybVNES1JlZ2lzdHJ5RW50
cnkpIHx8ICgtZSAkcmVnaXN0cnk2NFBhdGggLiAkd2luZG93c1BsYXRmb3JtU0RLUmVnaXN0cnlF
bnRyeSk7CityZXR1cm47CiAKICAgICBwcmludCAiKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKlxuIjsKICAgICBwcmludCAiQ2Fubm90
IGZpbmQgcmVnaXN0cnkgZW50cnkgJyR3aW5kb3dzUGxhdGZvcm1TREtSZWdpc3RyeUVudHJ5Jy5c
biI7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>201729</attachid>
            <date>2013-05-14 10:09:03 -0700</date>
            <delta_ts>2013-05-14 10:48:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-116079-20130514100800.patch</filename>
            <type>text/plain</type>
            <size>2583</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE1MDA3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDEzLTA1LTE0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t
PgorCisgICAgICAgIFtXaW5kb3dzXSBVcGRhdGUgT1JXVCB0byBrbm93IGFib3V0IHRoZSBXaW5k
b3dzIDggU0RLIGFuZCBEZWJ1ZyBUb29scy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTExNjA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0czoKKyAgICAg
ICAgKHNldFVwV2luZG93c0NyYXNoTG9nU2F2aW5nKTogTG9jYXRlIG50c2QuZXhlIGFuZCB1c2Ug
aXQuCisKIDIwMTMtMDUtMTMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5AYXBwbGUu
Y29tPgogCiAgICAgICAgIEFkZGVkIHRlc3RSdW5uZXIuc2V0UHJpbnRpbmcuCkluZGV4OiBUb29s
cy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw
dHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDE1MDA3MSkKKysrIFRvb2xzL1Njcmlw
dHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTI4MjcsMTYgKzI4Mjcs
MjEgQEAgc3ViIHNldFVwV2luZG93c0NyYXNoTG9nU2F2aW5nKCkKICAgICAgICAgcmV0dXJuOwog
ICAgIH0KIAotICAgIG15ICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5Q
YXRoKCRFTlZ7UFJPR1JBTUZJTEVTfSksICJEZWJ1Z2dpbmcgVG9vbHMgZm9yIFdpbmRvd3MgKHg4
NikiLCAibnRzZC5leGUiKTsKLSAgICB1bmxlc3MgKC1mICRudHNkUGF0aCkgewotICAgICAgICAk
bnRzZFBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1Byb2dyYW1X
NjQzMn0pLCAiRGVidWdnaW5nIFRvb2xzIGZvciBXaW5kb3dzICh4NjQpIiwgIm50c2QuZXhlIik7
Ci0gICAgICAgIHVubGVzcyAoLWYgJG50c2RQYXRoKSB7Ci0gICAgICAgICAgICAkbnRzZFBhdGgg
PSBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1NZU1RFTVJPT1R9KSwgInN5
c3RlbTMyIiwgIm50c2QuZXhlIik7Ci0gICAgICAgICAgICB1bmxlc3MgKC1mICRudHNkUGF0aCkg
ewotICAgICAgICAgICAgICAgIHByaW50IFNUREVSUiAiQ2FuJ3QgZmluZCBudHNkLmV4ZS4gQ3Jh
c2ggbG9ncyB3aWxsIG5vdCBiZSBzYXZlZC5cblNlZSA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy93
aWtpL0J1aWxkaW5nT25XaW5kb3dzI0dldHRpbmdDcmFzaExvZ3M+LlxuIjsKLSAgICAgICAgICAg
ICAgICByZXR1cm47Ci0gICAgICAgICAgICB9CisgICAgbXkgQHBvc3NpYmxlUGF0aHMgPSAoRmls
ZTo6U3BlYy0+Y2F0ZmlsZSh0b0N5Z3dpblBhdGgoJEVOVntQUk9HUkFNRklMRVN9KSwgIldpbmRv
d3MgS2l0cyIsICI4LjAiLCAiRGVidWdnZXJzIiwgIng2NCIsICJudHNkLmV4ZSIpLAorICAgICAg
ICBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1BST0dSQU1GSUxFU30pLCAi
V2luZG93cyBLaXRzIiwgIjguMCIsICJEZWJ1Z2dlcnMiLCAieDg2IiwgIm50c2QuZXhlIiksCisg
ICAgICAgIEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5QYXRoKCRFTlZ7UFJPR1JBTUZJTEVT
fSksICJEZWJ1Z2dpbmcgVG9vbHMgZm9yIFdpbmRvd3MgKHg4NikiLCAibnRzZC5leGUiKSwKKyAg
ICAgICAgRmlsZTo6U3BlYy0+Y2F0ZmlsZSh0b0N5Z3dpblBhdGgoJEVOVntQcm9ncmFtVzY0MzJ9
KSwgIkRlYnVnZ2luZyBUb29scyBmb3IgV2luZG93cyAoeDY0KSIsICJudHNkLmV4ZSIpLAorICAg
ICAgICBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1NZU1RFTVJPT1R9KSwg
InN5c3RlbTMyIiwgIm50c2QuZXhlIikpOworCisgICAgbXkgJG50c2RQYXRoID0gc2hpZnQgQHBv
c3NpYmxlUGF0aHM7CisKKyAgICB3aGlsZSAobm90IC1mICRudHNkUGF0aCkgeworICAgICAgICBp
ZiAoIUBwb3NzaWJsZVBhdGhzKSB7CisgICAgICAgICAgICBwcmludCBTVERFUlIgIkNhbid0IGZp
bmQgbnRzZC5leGUuIENyYXNoIGxvZ3Mgd2lsbCBub3QgYmUgc2F2ZWQuXG5TZWUgPGh0dHA6Ly90
cmFjLndlYmtpdC5vcmcvd2lraS9CdWlsZGluZ09uV2luZG93cyNHZXR0aW5nQ3Jhc2hMb2dzPi5c
biI7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KKworICAgICAgICAkbnRzZFBhdGgg
PSBzaGlmdCBAcG9zc2libGVQYXRoczsKICAgICB9CiAKICAgICAjIElmIHdlIHVzZWQgLWMgKGlu
c3RlYWQgb2YgLWNmKSB3ZSBjb3VsZCBwYXNzIHRoZSBjb21tYW5kcyBkaXJlY3RseSBvbiB0aGUg
Y29tbWFuZCBsaW5lLiBCdXQK
</data>
<flag name="review"
          id="223080"
          type_id="1"
          status="+"
          setter="ddkilzer"
    />
          </attachment>
      

    </bug>

</bugzilla>