116073 2013-05-13 16:30:38 -0700 Fix wrong assertions in Range::textNodeSplit 2024-01-19 05:56:33 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 116509 BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned ahmad.saleem792 ap bfulgham rniwa oldest_to_newest 888572 0 rniwa 2013-05-13 16:30:38 -0700 We should probably merge https://chromium.googlesource.com/chromium/blink/+/107e79cd424ad62249584a91fc55bded5bcd89ab Fix wrong assertions in Range::textNodeSplit Text::splitText calls Node::insertBefore, in which a DOM mutatino event handler can update the DOM structure. The function calls Document::textNodeSplit too, and Range::textNodeSplit called by Document::textNodeSplit assumed no one updated the DOM structure. 1891485 1 ahmad.saleem792 2022-08-15 16:08:59 -0700 I took the test case from Chromium patch and changed it into JSFiddle: Link - https://jsfiddle.net/foea2v5g/show *** Safari Technology Preview 151 *** No assertion failures even if an DOM mutation event handler updates the new node created by Text::splitText. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". FAIL r.endContainer should be [object Text]. Was [object HTMLDivElement]. FAIL r.endOffset should be 2. Was 1. PASS successfullyParsed is true TEST COMPLETE *** Firefox Nightly 105 *** No assertion failures even if an DOM mutation event handler updates the new node created by Text::splitText. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". FAIL r.endContainer should be [object Text]. Was [object HTMLDivElement]. FAIL r.endOffset should be 2. Was 1. PASS successfullyParsed is true TEST COMPLETE *** Chrome Canary 106 *** No assertion failures even if an DOM mutation event handler updates the new node created by Text::splitText. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". FAIL r.endContainer should be [object Text]. Was [object HTMLDivElement]. FAIL r.endOffset should be 2. Was 1. PASS successfullyParsed is true TEST COMPLETE _________ I can find "nextSibling", which Chrome patch removed in Webkit Github source bit differently: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/Range.cpp#L997 https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/Range.cpp#L979 rniwa@webkit.org - Is this need anymore? Thanks! 1891535 2 ap 2022-08-15 18:50:23 -0700 These assertions failures would only be reproducible in a debug build. Guessing that this isn't relevant any more, but Ryosuke will know for certain. 1920284 3 ahmad.saleem792 2022-12-17 14:04:31 -0800 It seems this was reverted in following commit in favor of other solution: https://src.chromium.org/viewvc/blink?view=revision&revision=150483 and other alternative solution: https://src.chromium.org/viewvc/blink?view=revision&revision=150493 ^ I can do PR based on both, which is suggested approach? @rniwa - Thanks! 2006114 4 ahmad.saleem792 2024-01-19 05:56:33 -0800 *** This bug has been marked as a duplicate of bug 116509 ***