116066 2013-05-13 15:59:10 -0700 Do not bloat HTMLTokenizer with a giant inline InputStreamPreprocessor::peek 2013-05-15 01:28:15 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa benjamin benjamin commit-queue esprehn+autocc kling koivisto oldest_to_newest 888553 0 rniwa 2013-05-13 15:59:10 -0700 We should probably merge https://chromium.googlesource.com/chromium/blink/+/45e0337b2f2db535ab08365f6e763a5015e4d990 Shrunk HTMLTokenizer.o by 28.2% This CL moves the cold code in InputStreamPreprocessor::peek out-of-line, which shrunks HTMLTokenizer.o on Linux by 28.2%. The CL also makes the html-parser.html performance test faster by 1.3% (average of 15 runs). 888890 1 ap 2013-05-14 09:55:15 -0700 Size of a raw object file is a funny metric - perhaps useful as a tool to discover optimization opportunities, but certainly not a goal in itself :) > html-parser.html performance test faster by 1.3% (average of 15 runs). This is of course more interesting. 889017 2 benjamin 2013-05-14 13:41:57 -0700 (In reply to comment #1) > Size of a raw object file is a funny metric - perhaps useful as a tool to discover optimization opportunities, but certainly not a goal in itself :) We were as confused as you by that claim. 889018 3 benjamin 2013-05-14 13:42:14 -0700 I'll take this one. 889095 4 201779 benjamin 2013-05-14 19:17:39 -0700 Created attachment 201779 Patch 889187 5 benjamin 2013-05-15 01:28:15 -0700 Committed r150105: <http://trac.webkit.org/changeset/150105> 201779 2013-05-14 19:17:39 -0700 2013-05-14 19:24:04 -0700 Patch bug-116066-20130514191636.patch text/plain 3907 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWVlYTAxZTIzYWZjZDM5 ZTI4ZTA2Nzc5NmZiNGZlYzJiMDljZGYxNy4uOTk2ODIwM2VlOWUxY2ZjYmEzNTFjODI4NmY2MjFi YTU5NDk1NTJmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTA1LTE0ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIERvIG5vdCBibG9h dCBIVE1MVG9rZW5pemVyIHdpdGggYSBnaWFudCBpbmxpbmUgSW5wdXRTdHJlYW1QcmVwcm9jZXNz b3I6OnBlZWsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjA2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1lcmdlIGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8r LzQ1ZTAzMzdiMmYyZGI1MzVhYjA4MzY1ZjZlNzYzYTUwMTVlNGQ5OTAuCisKKyAgICAgICAgT24g eDg2XzY0LCB0aGlzIHJlbW92ZXMgNDBrYiBmcm9tIHRoZSBiaW5hcnkuIE9uIG15IG1hY2hpbmUg aXQgaXMgY29tcGxldGVseSBuZXV0cmFsIG9uIHBlcmZvcm1hbmNlLgorCisgICAgICAgICogaHRt bC9wYXJzZXIvSW5wdXRTdHJlYW1QcmVwcm9jZXNzb3IuaDoKKyAgICAgICAgKFdlYkNvcmU6Oklu cHV0U3RyZWFtUHJlcHJvY2Vzc29yOjpwZWVrKToKKyAgICAgICAgKElucHV0U3RyZWFtUHJlcHJv Y2Vzc29yKToKKyAgICAgICAgKFdlYkNvcmU6OklucHV0U3RyZWFtUHJlcHJvY2Vzc29yOjphZHZh bmNlKToKKyAgICAgICAgKFdlYkNvcmU6OklucHV0U3RyZWFtUHJlcHJvY2Vzc29yOjpza2lwTmV4 dE5ld0xpbmUpOgorICAgICAgICAoV2ViQ29yZTo6SW5wdXRTdHJlYW1QcmVwcm9jZXNzb3I6OnJl c2V0KToKKyAgICAgICAgKFdlYkNvcmU6OklucHV0U3RyZWFtUHJlcHJvY2Vzc29yOjpwcm9jZXNz TmV4dElucHV0Q2hhcmFjdGVyKToKKworMjAxMy0wNS0xNCAgQmVuamFtaW4gUG91bGFpbiAgPGJw b3VsYWluQGFwcGxlLmNvbT4KKwogICAgICAgICBHZXQgcmlkIG9mIEdyYWRpZW50OjpnZXRDb2xv cigpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYw ODkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSW5wdXRTdHJlYW1Q cmVwcm9jZXNzb3IuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0lucHV0U3RyZWFtUHJl cHJvY2Vzc29yLmgKaW5kZXggMGFhOGQyMmQwMjc4OTdiY2RmOTk0MzAwNWQzNzQwOGQwNDVlMjBi NC4uNmY4ZWViMGM3YjgwNzc5Y2E3NzRhZDgyNTUxZjc4ZDJlNGQ0ZDgxNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSW5wdXRTdHJlYW1QcmVwcm9jZXNzb3IuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9JbnB1dFN0cmVhbVByZXByb2Nlc3Nvci5oCkBA IC01Myw3ICs1Myw2IEBAIHB1YmxpYzoKICAgICAvLyBjaGFyYWN0ZXJzIGluIHxzb3VyY2V8IChh ZnRlciBjb2xsYXBzaW5nIFxyXG4sIGV0YykuCiAgICAgQUxXQVlTX0lOTElORSBib29sIHBlZWso U2VnbWVudGVkU3RyaW5nJiBzb3VyY2UpCiAgICAgewotICAgIFBlZWtBZ2FpbjoKICAgICAgICAg bV9uZXh0SW5wdXRDaGFyYWN0ZXIgPSBzb3VyY2UuY3VycmVudENoYXIoKTsKIAogICAgICAgICAv LyBFdmVyeSBicmFuY2ggaW4gdGhpcyBmdW5jdGlvbiBpcyBleHBlbnNpdmUsIHNvIHdlIGhhdmUg YQpAQCAtNjUsNiArNjQsMzEgQEAgcHVibGljOgogICAgICAgICAgICAgbV9za2lwTmV4dE5ld0xp bmUgPSBmYWxzZTsKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CisgICAgICAg IHJldHVybiBwcm9jZXNzTmV4dElucHV0Q2hhcmFjdGVyKHNvdXJjZSk7CisgICAgfQorCisgICAg Ly8gUmV0dXJucyB3aGV0aGVyIHRoZXJlIGFyZSBtb3JlIGNoYXJhY3RlcnMgaW4gfHNvdXJjZXwg YWZ0ZXIgYWR2YW5jaW5nLgorICAgIEFMV0FZU19JTkxJTkUgYm9vbCBhZHZhbmNlKFNlZ21lbnRl ZFN0cmluZyYgc291cmNlKQorICAgIHsKKyAgICAgICAgc291cmNlLmFkdmFuY2VBbmRVcGRhdGVM aW5lTnVtYmVyKCk7CisgICAgICAgIGlmIChzb3VyY2UuaXNFbXB0eSgpKQorICAgICAgICAgICAg cmV0dXJuIGZhbHNlOworICAgICAgICByZXR1cm4gcGVlayhzb3VyY2UpOworICAgIH0KKworICAg IGJvb2wgc2tpcE5leHROZXdMaW5lKCkgY29uc3QgeyByZXR1cm4gbV9za2lwTmV4dE5ld0xpbmU7 IH0KKworICAgIHZvaWQgcmVzZXQoYm9vbCBza2lwTmV4dE5ld0xpbmUgPSBmYWxzZSkKKyAgICB7 CisgICAgICAgIG1fbmV4dElucHV0Q2hhcmFjdGVyID0gJ1wwJzsKKyAgICAgICAgbV9za2lwTmV4 dE5ld0xpbmUgPSBza2lwTmV4dE5ld0xpbmU7CisgICAgfQorCitwcml2YXRlOgorICAgIGJvb2wg cHJvY2Vzc05leHRJbnB1dENoYXJhY3RlcihTZWdtZW50ZWRTdHJpbmcmIHNvdXJjZSkKKyAgICB7 CisgICAgUHJvY2Vzc0FnYWluOgorICAgICAgICBBU1NFUlQobV9uZXh0SW5wdXRDaGFyYWN0ZXIg PT0gc291cmNlLmN1cnJlbnRDaGFyKCkpOwogCiAgICAgICAgIGlmIChtX25leHRJbnB1dENoYXJh Y3RlciA9PSAnXG4nICYmIG1fc2tpcE5leHROZXdMaW5lKSB7CiAgICAgICAgICAgICBtX3NraXBO ZXh0TmV3TGluZSA9IGZhbHNlOwpAQCAtODcsNyArMTExLDggQEAgcHVibGljOgogICAgICAgICAg ICAgICAgICAgICBzb3VyY2UuYWR2YW5jZVBhc3ROb25OZXdsaW5lKCk7CiAgICAgICAgICAgICAg ICAgICAgIGlmIChzb3VyY2UuaXNFbXB0eSgpKQogICAgICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgICAgICAgICAgICAgICAgICBnb3RvIFBlZWtBZ2FpbjsKKyAgICAgICAg ICAgICAgICAgICAgbV9uZXh0SW5wdXRDaGFyYWN0ZXIgPSBzb3VyY2UuY3VycmVudENoYXIoKTsK KyAgICAgICAgICAgICAgICAgICAgZ290byBQcm9jZXNzQWdhaW47CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgIG1fbmV4dElucHV0Q2hhcmFjdGVyID0gMHhGRkZEOwogICAgICAg ICAgICAgfQpAQCAtOTUsMjQgKzEyMCw2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgfQogCi0gICAgLy8gUmV0dXJucyB3aGV0aGVyIHRoZXJlIGFyZSBtb3JlIGNoYXJhY3Rl cnMgaW4gfHNvdXJjZXwgYWZ0ZXIgYWR2YW5jaW5nLgotICAgIEFMV0FZU19JTkxJTkUgYm9vbCBh ZHZhbmNlKFNlZ21lbnRlZFN0cmluZyYgc291cmNlKQotICAgIHsKLSAgICAgICAgc291cmNlLmFk dmFuY2VBbmRVcGRhdGVMaW5lTnVtYmVyKCk7Ci0gICAgICAgIGlmIChzb3VyY2UuaXNFbXB0eSgp KQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICByZXR1cm4gcGVlayhzb3VyY2Up OwotICAgIH0KLQotICAgIGJvb2wgc2tpcE5leHROZXdMaW5lKCkgY29uc3QgeyByZXR1cm4gbV9z a2lwTmV4dE5ld0xpbmU7IH0KLQotICAgIHZvaWQgcmVzZXQoYm9vbCBza2lwTmV4dE5ld0xpbmUg PSBmYWxzZSkKLSAgICB7Ci0gICAgICAgIG1fbmV4dElucHV0Q2hhcmFjdGVyID0gJ1wwJzsKLSAg ICAgICAgbV9za2lwTmV4dE5ld0xpbmUgPSBza2lwTmV4dE5ld0xpbmU7Ci0gICAgfQotCi1wcml2 YXRlOgogICAgIGJvb2wgc2hvdWxkVHJlYXROdWxsQXNFbmRPZkZpbGVNYXJrZXIoU2VnbWVudGVk U3RyaW5nJiBzb3VyY2UpIGNvbnN0CiAgICAgewogICAgICAgICByZXR1cm4gc291cmNlLmlzQ2xv c2VkKCkgJiYgc291cmNlLmxlbmd0aCgpID09IDE7Cg==