116059 2013-05-13 14:08:52 -0700 [css exclusions] fast/css/variables/var-inside-shape.html is failing 2013-06-12 10:01:41 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115919 1 betravis svillar ap benjamin cdumez commit-queue csaavedra gyuyoung.kim kling koivisto mrowe rakuco svillar tony oldest_to_newest 888517 0 betravis 2013-05-13 14:08:52 -0700 Toggling CSS Exclusions on by default has caused the test to fail. 888547 1 betravis 2013-05-13 15:35:38 -0700 CSS Variables are not working with shape-inside. This was not diagnosed until Exclusions were toggled on by default in 115919, as the test expectation does not enable shape-inside. The expectation ignored the non-variable shape-insides. The test case did not correctly resolve the variable shape-insides. 889886 2 svillar 2013-05-16 10:08:57 -0700 Working on this. Patch to follow. 890248 3 202051 svillar 2013-05-17 02:14:04 -0700 Created attachment 202051 Patch 899590 4 202051 achicu 2013-06-12 09:56:00 -0700 Comment on attachment 202051 Patch Looks good. 899595 5 202051 svillar 2013-06-12 10:01:31 -0700 Comment on attachment 202051 Patch Clearing flags on attachment: 202051 Committed r151506: <http://trac.webkit.org/changeset/151506> 899596 6 svillar 2013-06-12 10:01:41 -0700 All reviewed patches have been landed. Closing bug. 202051 2013-05-17 02:14:04 -0700 2013-06-12 10:01:31 -0700 Patch bug-116059-20130517111256.patch text/plain 5965 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTg0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTk0MzJlYTY4ZTAzODFhNGRlMDhh MjBhOGRmNzRjMDliNjE4OWQ1ZC4uODQ5M2MwNmQ4NzQ0MGQyNTQ2YzgxMDliZjUzOTgyYzA3YmI5 MGQ2OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA1LTE3ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MgZXhjbHVzaW9uc10gZmFz dC9jc3MvdmFyaWFibGVzL3Zhci1pbnNpZGUtc2hhcGUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYwNTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHNoYXBlcyB3ZXJl IGluY29ycmVjdGx5IGRlZmluZWQsIHRoZXJlIHdhcyBhICJyZWN0YW5nZSIKKyAgICAgICAgaW5z dGVhZCBvZiBhICJyZWN0YW5nbGUiIGFuZCBhbHNvIHRoZSBudW1iZXIgb2YgcGFyYW1ldGVycyBh bmQKKyAgICAgICAgdGhlaXIgdHlwZXMgd2FzIHdyb25nLiBBcGFydCBmcm9tIHRoYXQsIGJvdGgg dGhlIENTUyBleGNsdXNpb25zCisgICAgICAgIGFuZCBDU1MgdmFyaWFibGVzIHNldHRpbmdzIHdl cmUgbm90IGVuYWJsZWQgYXQgcnVudGltZS4KKworICAgICAgICBTb21lIGV4dHJhIHRleHQgd2Fz IGFsc28gYWRkZWQgdG8gdGhlIGRpdnMgaW4gb3JkZXIgdG8gdmVyaWZ5IHRoYXQKKyAgICAgICAg dGhlIENTUyBleGNsdXNpb25zIGFyZSB3b3JraW5nIHByb3Blcmx5LgorCisgICAgICAgICogZmFz dC9jc3MvdmFyaWFibGVzL3Zhci1pbnNpZGUtc2hhcGUtZXhwZWN0ZWQuaHRtbDoKKyAgICAgICAg KiBmYXN0L2Nzcy92YXJpYWJsZXMvdmFyLWluc2lkZS1zaGFwZS5odG1sOgorICAgICAgICAqIHBs YXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmVkIHZhci1pbnNpZGUtc2hhcGUuaHRt bC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogRGl0dG8uCisKIDIw MTMtMDUtMTYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAg ICAgICAgRW5hYmxlIHRoZSBDU1NWYXJpYWJsZXMgc2V0dGluZyBpbiBjc3MtdmFyaWFibGUtZGVm aW5pdGlvbi5odG1sIHRlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Zhcmlh Ymxlcy92YXItaW5zaWRlLXNoYXBlLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz cy92YXJpYWJsZXMvdmFyLWluc2lkZS1zaGFwZS1leHBlY3RlZC5odG1sCmluZGV4IDYzNmM4ODA3 ZGE3ZTFhN2RmMzg5YmNiYTIzNDU5YzJkODUyZGVkOGYuLmE3MWMwMDA0NmM2ZmExZDU0NDNkNzI1 ZDQ4YzVmNDM3ODI0YmUxMGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Zhcmlh Ymxlcy92YXItaW5zaWRlLXNoYXBlLWV4cGVjdGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9jc3MvdmFyaWFibGVzL3Zhci1pbnNpZGUtc2hhcGUtZXhwZWN0ZWQuaHRtbApAQCAtMSw1ICsx LDkgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5pbnRl cm5hbHMpCisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldENTU0V4Y2x1c2lvbnNFbmFibGVkKHRy dWUpOworPC9zY3JpcHQ+CiA8c3R5bGU+CiAuYSB7CiAgICAgLXdlYmtpdC1zaGFwZS1pbnNpZGU6 IGVsbGlwc2UoMTAwcHgsIDEwMHB4LCAxMDBweCwgMTAwcHgpOwpAQCAtOCwyMiArMTIsMjMgQEAK ICAgICAtd2Via2l0LXNoYXBlLWluc2lkZTogY2lyY2xlKDEwMHB4LCAxMDBweCwgMTAwcHgpOwog fQogLmMgewotICAgIC13ZWJraXQtc2hhcGUtaW5zaWRlOiByZWN0YW5nZSgxMDBweCk7CisgICAg LXdlYmtpdC1zaGFwZS1pbnNpZGU6IHJlY3RhbmdsZSgxMDBweCwgMTAwcHgsIDEwMHB4LCAxMDBw eCk7CiB9CiAuZCB7Ci0gICAgLXdlYmtpdC1zaGFwZS1pbnNpZGU6IHBvbHlnb24oMTAwcHgsIDEw MHB4LCAxMDBweCwgMTAwcHgsIDEwMHB4KTsKKyAgICBoZWlnaHQ6IDEwMHB4OworICAgIC13ZWJr aXQtc2hhcGUtaW5zaWRlOiBwb2x5Z29uKDEwJSAxMDAlLCAxMDAlIDUwJSwgNTAlIDEwJSk7CiB9 CiA8L3N0eWxlPgogPGRpdiBjbGFzcz0iYSI+Ci1Tb21lIHRleHQuCitTb21lIHRleHQgaW5zaWRl IGFuIGFyZWEgaW5zaWRlIHdoaWNoIGlubGluZSBjb250ZW50IGNhbiBmbG93LgogPC9kaXY+CiA8 ZGl2IGNsYXNzPSJiIj4KLVNvbWUgdGV4dC4KK1NvbWUgdGV4dCBpbnNpZGUgYW4gYXJlYSBpbnNp ZGUgd2hpY2ggaW5saW5lIGNvbnRlbnQgY2FuIGZsb3cuCiA8L2Rpdj4KIDxkaXYgY2xhc3M9ImMi PgotU29tZSB0ZXh0LgorU29tZSB0ZXh0IGluc2lkZSBhbiBhcmVhIGluc2lkZSB3aGljaCBpbmxp bmUgY29udGVudCBjYW4gZmxvdy4KIDwvZGl2PgogPGRpdiBjbGFzcz0iZCI+Ci1Tb21lIHRleHQu CitTb21lIHRleHQgaW5zaWRlIGFuIGFyZWEgaW5zaWRlIHdoaWNoIGlubGluZSBjb250ZW50IGNh biBmbG93LgogPC9kaXY+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nz cy92YXJpYWJsZXMvdmFyLWluc2lkZS1zaGFwZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv dmFyaWFibGVzL3Zhci1pbnNpZGUtc2hhcGUuaHRtbAppbmRleCA3NjcwMWEzMjAzMjJjZDc2NDZh MmIxNGIyOWViMGU5NmE4ZGViMDM5Li42ZDA3YTgwZjk4MWRkODI1ZjczN2Q5MjMwNDYwZWZhMjNl NjlmMzRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvdmFyLWlu c2lkZS1zaGFwZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3ZhcmlhYmxlcy92YXIt aW5zaWRlLXNoYXBlLmh0bWwKQEAgLTEsMzYgKzEsNDIgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0 bWw+CiA8c2NyaXB0PgotaWYgKHdpbmRvdy5pbnRlcm5hbHMpCitpZiAod2luZG93LmludGVybmFs cykgewogICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRDU1NWYXJpYWJsZXNFbmFibGVkKHRydWUp OworICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRDU1NFeGNsdXNpb25zRW5hYmxlZCh0cnVlKTsK K30KIDwvc2NyaXB0PgogPHN0eWxlPgogOnJvb3QgewogICAgIC13ZWJraXQtdmFyLWE6IDEwMHB4 OworICAgIC13ZWJraXQtdmFyLWI6IDEwMCU7CisgICAgLXdlYmtpdC12YXItYzogNTAlOworICAg IC13ZWJraXQtdmFyLWQ6IDEwJTsKIH0KIC5hIHsKICAgICAtd2Via2l0LXNoYXBlLWluc2lkZTog ZWxsaXBzZSgtd2Via2l0LXZhcihhKSwgLXdlYmtpdC12YXIoYSksIC13ZWJraXQtdmFyKGEpLCAt d2Via2l0LXZhcihhKSk7CiB9CiAuYiB7Ci0gICAgLXdlYmtpdC1zaGFwZS1pbnNpZGU6IGNpcmNs ZSgtd2Via2l0LXZhcihhKSwgLXdlYmtpdC12YXIoYSksIC13ZWJraXQtdmFyKGEpKSk7CisgICAg LXdlYmtpdC1zaGFwZS1pbnNpZGU6IGNpcmNsZSgtd2Via2l0LXZhcihhKSwgLXdlYmtpdC12YXIo YSksIC13ZWJraXQtdmFyKGEpKTsKIH0KIC5jIHsKLSAgICAtd2Via2l0LXNoYXBlLWluc2lkZTog cmVjdGFuZ2UoLXdlYmtpdC12YXIoYSkpOworICAgIC13ZWJraXQtc2hhcGUtaW5zaWRlOiByZWN0 YW5nbGUoLXdlYmtpdC12YXIoYSksIC13ZWJraXQtdmFyKGEpLCAtd2Via2l0LXZhcihhKSwgLXdl YmtpdC12YXIoYSkpOwogfQogLmQgewotICAgIC13ZWJraXQtc2hhcGUtaW5zaWRlOiBwb2x5Z29u KC13ZWJraXQtdmFyKGEpLCAtd2Via2l0LXZhcihhKSwgLXdlYmtpdC12YXIoYSksIC13ZWJraXQt dmFyKGEpKTsKKyAgICBoZWlnaHQ6IC13ZWJraXQtdmFyKGEpOworICAgIC13ZWJraXQtc2hhcGUt aW5zaWRlOiBwb2x5Z29uKC13ZWJraXQtdmFyKGQpIC13ZWJraXQtdmFyKGIpLCAtd2Via2l0LXZh cihiKSAtd2Via2l0LXZhcihjKSwgLXdlYmtpdC12YXIoYykgLXdlYmtpdC12YXIoZCkpOwogfQog PC9zdHlsZT4KIDxkaXYgY2xhc3M9ImEiPgotU29tZSB0ZXh0LgorU29tZSB0ZXh0IGluc2lkZSBh biBhcmVhIGluc2lkZSB3aGljaCBpbmxpbmUgY29udGVudCBjYW4gZmxvdy4KIDwvZGl2PgogPGRp diBjbGFzcz0iYiI+Ci1Tb21lIHRleHQuCitTb21lIHRleHQgaW5zaWRlIGFuIGFyZWEgaW5zaWRl IHdoaWNoIGlubGluZSBjb250ZW50IGNhbiBmbG93LgogPC9kaXY+CiA8ZGl2IGNsYXNzPSJjIj4K LVNvbWUgdGV4dC4KK1NvbWUgdGV4dCBpbnNpZGUgYW4gYXJlYSBpbnNpZGUgd2hpY2ggaW5saW5l IGNvbnRlbnQgY2FuIGZsb3cuCiA8L2Rpdj4KIDxkaXYgY2xhc3M9ImQiPgotU29tZSB0ZXh0Lgor U29tZSB0ZXh0IGluc2lkZSBhbiBhcmVhIGluc2lkZSB3aGljaCBpbmxpbmUgY29udGVudCBjYW4g Zmxvdy4KIDwvZGl2PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVj dGF0aW9ucwppbmRleCBiYzIwNjA5NjcwYmUyNzczOTYyYzBiMjQwMzQzZTVjOTA3ZTdiMTEwLi44 NWE1NDUyYmE4YjEyNWU4MTM2YmNkYTEzOTdlOTY2MjZiOTUzYmUxIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTg2Myw5ICsxODYzLDYgQEAgd2Via2l0 Lm9yZy9iLzExNDg3NyBhY2Nlc3NpYmlsaXR5L2xpbmstaW5zaWRlLWJ1dHRvbi1hY2Nlc3NpYmxl LXRleHQuaHRtbCBbIEZhaWwKIAogd2Via2l0Lm9yZy9iLzExNDYxMiBlZGl0aW5nL3N0eWxlL2Js b2NrLXN0eWxlLTAwNS5odG1sIFsgRmFpbHVyZSBdCiAKLSMgUmVncmVzc2lvbihyMTUwMDI1KS4K LXdlYmtpdC5vcmcvYi8xMTU5MTkgZmFzdC9jc3MvdmFyaWFibGVzL3Zhci1pbnNpZGUtc2hhcGUu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotCiAjIFVuaWRlbnRpZmllZCBmYWlsaW5nIG1lZGlh IHRlc3RzCiB3ZWJraXQub3JnL2IvMTE1NDE5IGh0dHAvdGVzdHMvbWVkaWEvcmVsb2FkLWFmdGVy LWRpYWxvZy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTE1NDE5IGh0dHAvdGVzdHMv bWVkaWEvcmVtb3ZlLXdoaWxlLWxvYWRpbmcuaHRtbCBbIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA4ZWJmYmQyY2JkZDNmYTMxZjMxODFm YjBlNWZhYmJhZjA4Yjk2YzhlLi5mNjVkOTkzNWE4MDAxNTNhNzM1NzkxMGFiOGZkNzJmNTY4MmU5 NWE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTM3 Nyw4ICsxMzc3LDYgQEAgd2Via2l0Lm9yZy9iLzExNTQ0MSBtZWRpYS92aWRlby1wb3N0ZXItYmFj a2dyb3VuZC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xMTU2MzMg YWNjZXNzaWJpbGl0eS9tZXRlci1lbGVtZW50Lmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9y Zy9iLzExNjA1OSBmYXN0L2Nzcy92YXJpYWJsZXMvdmFyLWluc2lkZS1zaGFwZS5odG1sIFsgSW1h Z2VPbmx5RmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xMTYxNTMgZmFzdC9jc3MvdGV4dC1vdmVy Zmxvdy1lbGxpcHNpcy1mdWxsLXRydW5jYXRlLXJ0bC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBd CiAKICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg==