116043 2013-05-13 10:29:43 -0700 [GTK][CSS Regions] Provide web setting to control CSS regions run time 2021-05-06 01:53:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 0 obzhirov webkit-unassigned bugs-noreply cdumez cgarcia commit-queue gustavo gyuyoung.kim mario mrobinson rakuco spena WebkitBugTracker oldest_to_newest 888342 0 obzhirov 2013-05-13 10:29:43 -0700 Provide web setting to control CSS regions run time 888344 1 obzhirov 2013-05-13 10:32:44 -0700 Needed to add run time enabling/disabling of CSS regions for GTK port in order to play with CSS regions. 888348 2 201581 obzhirov 2013-05-13 10:44:39 -0700 Created attachment 201581 Patch 888350 3 commit-queue 2013-05-13 10:47:02 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 888356 4 mrobinson 2013-05-13 10:58:38 -0700 I wonder how useful it is make this configurable... Perhaps we should just have it so that when it's turned on at compile-time, it's enabled at runtime. At some point in the future it won't make sense to have support for disabling CSS regions in the API. It's even a liability since the setting may go away some day. 888357 5 201581 cgarcia 2013-05-13 10:58:49 -0700 Comment on attachment 201581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201581&action=review Thanks for the patch. I'm not sure if we want to add new API to WebKit1 which is currently in maintenance mode. I would split the patch into one for wk1 and one for wk2 in any case so that it can be discussed separately. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:34 > +#include "RuntimeEnabledFeatures.h" Please use angle-bracket form for WebCore header file includes. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1113 > + * Since: 2.0 This should be 2.2, 2.0 was already released. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1120 > + TRUE, I don't think we want this to be enabled by default, at least not for now. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2753 > + */ Since 2.2. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2767 > + */ Since 2.2. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2779 > +#if ENABLE(CSS_REGIONS) > + WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled(enabled); > +#endif Do we really need to do this in the UI process too? 888359 6 mrobinson 2013-05-13 11:02:59 -0700 (In reply to comment #5) > I don't think we want this to be enabled by default, at least not for now. This isn't a huge liability since we don't turn it on in release builds. I'm pretty sure this shouldn't even be configurable in the long-term. CSS features are generally not turned on and off at runtime. This setting is useful for other browsers, because they can ship a stable release and still allow developers to play with the setting. They also don't have to worry about API stability as much (notice that this is a private API in WebKit2). Given that, I'm fairly confidant we should not expose this and instead, enable CSS regions when they are turned on at compile-time. 888365 7 gustavo 2013-05-13 11:11:43 -0700 Agree with Martin. If we want to allow experimentation with features such as this one we should probably use a way that does not impact the API for each feature. Perhaps an environment variable that can be set with feature names, for instance? 888366 8 mrobinson 2013-05-13 11:13:10 -0700 (In reply to comment #7) > Agree with Martin. If we want to allow experimentation with features such as this one we should probably use a way that does not impact the API for each feature. Perhaps an environment variable that can be set with feature names, for instance? I'd feel more comfortable with that, for sure. :) 888367 9 cgarcia 2013-05-13 11:15:29 -0700 (In reply to comment #8) > (In reply to comment #7) > > Agree with Martin. If we want to allow experimentation with features such as this one we should probably use a way that does not impact the API for each feature. Perhaps an environment variable that can be set with feature names, for instance? > > I'd feel more comfortable with that, for sure. :) Agree, the public API is not the right the place for this temporary convenient settings to play with experimental features. 889353 10 obzhirov 2013-05-15 09:45:06 -0700 In this case I would suggest just to keep compilation time flag to disable/enable it: --enable-css-regions. 892879 11 obzhirov 2013-05-23 07:45:13 -0700 After talking to Gustavo on IRC it doesn't make sense to proceed with this patch any longer because ENABLE_CSS_REGIONS already can be enabled/disabled in WebKitFeatures 201581 2013-05-13 10:44:39 -0700 2013-05-13 10:58:49 -0700 Patch bug-116043-20130513184428.patch text/plain 14344 obzhirov SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDAy MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1 LTEzICBBbnRvbiBPYnpoaXJvdiAgPGEub2J6aGlyb3ZAc2Ftc3VuZy5jb20+CisKKyAgICAgICAg W0dUS10gUHJvdmlkZSB3ZWIgc2V0dGluZyB0byBjb250cm9sIENTUyByZWdpb25zIHJ1biB0aW1l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTYwNDMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkZWQg dG8gYWRkIHJ1biB0aW1lIGVuYWJsaW5nL2Rpc2FibGluZyBvZiBDU1MgcmVnaW9ucyBmb3IgR1RL IHBvcnQgaW4gb3JkZXIgdG8gcGxheSB3aXRoIENTUyByZWdpb25zLgorCisgICAgICAgICogU291 cmNlL2F1dG90b29scy9QcmludEJ1aWxkQ29uZmlndXJhdGlvbi5tNDoKKyAgICAgICAgKiBTb3Vy Y2UvYXV0b3Rvb2xzL1JlYWRDb21tYW5kTGluZUFyZ3VtZW50cy5tNDoKKyAgICAgICAgKiBTb3Vy Y2UvYXV0b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVyZXMubTQ6CisKIDIwMTMtMDUtMTEgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBh IGJhc2ljIGNtYWtlIGJ1aWxkIGZvciBXVEYgYW5kIEphdmFTY3JpcHRDb3JlCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNTAwMjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wNS0xMyAgQW50b24gT2J6aGlyb3YgIDxh Lm9iemhpcm92QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdIFByb3ZpZGUgd2ViIHNldHRp bmcgdG8gY29udHJvbCBDU1MgcmVnaW9ucyBydW4gdGltZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2MDQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVlZGVkIHRvIGFkZCBydW4gdGltZSBlbmFibGlu Zy9kaXNhYmxpbmcgb2YgQ1NTIHJlZ2lvbnMgZm9yIEdUSyBwb3J0IGluIG9yZGVyIHRvIHBsYXkg d2l0aCBDU1MgcmVnaW9ucy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNl dHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYktpdFNldHRpbmdzU2V0UHJvcGVydHkpOgorICAgICAg ICAod2ViS2l0U2V0dGluZ3NHZXRQcm9wZXJ0eSk6CisgICAgICAgICh3ZWJraXRfc2V0dGluZ3Nf Y2xhc3NfaW5pdCk6CisgICAgICAgICh3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV9jc3NfcmVn aW9ucyk6CisgICAgICAgICh3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9jc3NfcmVnaW9ucyk6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuaDoKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0OgorCiAyMDEz LTA1LTEzICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBOb3Rp ZmljYXRpb24gbWFuYWdlciByZW1vdmFsIHNob3VsZCBub3QgYmUgdGllZCB0byB0ZXJtaW5hdGlv biBvZiB3ZWIgcHJvY2Vzc2VzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRTZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwCShyZXZpc2lvbiAxNTAwMDIpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJX ZWJLaXRTZXR0aW5ncy5oIgogCisjaW5jbHVkZSAiUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIgog I2luY2x1ZGUgIldlYktpdFByaXZhdGUuaCIKICNpbmNsdWRlICJXZWJLaXRTZXR0aW5nc1ByaXZh dGUuaCIKICNpbmNsdWRlIDxXZWJDb3JlL1VzZXJBZ2VudEd0ay5oPgpAQCAtMTMzLDcgKzEzNCw4 IEBAIGVudW0gewogICAgIFBST1BfRU5BQkxFX1BBR0VfQ0FDSEUsCiAgICAgUFJPUF9VU0VSX0FH RU5ULAogICAgIFBST1BfRU5BQkxFX1NNT09USF9TQ1JPTExJTkcsCi0gICAgUFJPUF9FTkFCTEVf QUNDRUxFUkFURURfMkRfQ0FOVkFTCisgICAgUFJPUF9FTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FO VkFTLAorICAgIFBST1BfRU5BQkxFX0NTU19SRUdJT05TCiB9OwogCiBzdGF0aWMgdm9pZCB3ZWJL aXRTZXR0aW5nc1NldFByb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBjb25z dCBHVmFsdWUqIHZhbHVlLCBHUGFyYW1TcGVjKiBwYXJhbVNwZWMpCkBAIC0yNzksNiArMjgxLDkg QEAgc3RhdGljIHZvaWQgd2ViS2l0U2V0dGluZ3NTZXRQcm9wZXJ0eShHTwogICAgIGNhc2UgUFJP UF9FTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTOgogICAgICAgICB3ZWJraXRfc2V0dGluZ3Nf c2V0X2VuYWJsZV9hY2NlbGVyYXRlZF8yZF9jYW52YXMoc2V0dGluZ3MsIGdfdmFsdWVfZ2V0X2Jv b2xlYW4odmFsdWUpKTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX0VOQUJMRV9DU1Nf UkVHSU9OUzoKKyAgICAgICAgd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfY3NzX3JlZ2lvbnMo c2V0dGluZ3MsIGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpKTsKKyAgICAgICAgYnJlYWs7CiAg ICAgZGVmYXVsdDoKICAgICAgICAgR19PQkpFQ1RfV0FSTl9JTlZBTElEX1BST1BFUlRZX0lEKG9i amVjdCwgcHJvcElkLCBwYXJhbVNwZWMpOwogICAgICAgICBicmVhazsKQEAgLTQyMiw2ICs0Mjcs OSBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0dldFByb3BlcnR5KEdPCiAgICAgY2FzZSBQ Uk9QX0VOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVM6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jv b2xlYW4odmFsdWUsIHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2FjY2VsZXJhdGVkXzJkX2Nh bnZhcyhzZXR0aW5ncykpOwogICAgICAgICBicmVhazsKKyAgICBjYXNlIFBST1BfRU5BQkxFX0NT U19SRUdJT05TOgorICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCB3ZWJraXRfc2V0 dGluZ3NfZ2V0X2VuYWJsZV9jc3NfcmVnaW9ucyhzZXR0aW5ncykpOworICAgICAgICBicmVhazsK ICAgICBkZWZhdWx0OgogICAgICAgICBHX09CSkVDVF9XQVJOX0lOVkFMSURfUFJPUEVSVFlfSUQo b2JqZWN0LCBwcm9wSWQsIHBhcmFtU3BlYyk7CiAgICAgICAgIGJyZWFrOwpAQCAtMTA5Niw2ICsx MTA0LDIxIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFcKICAgICAg ICAgICAgIF8oIldoZXRoZXIgdG8gZW5hYmxlIGFjY2VsZXJhdGVkIDJEIGNhbnZhcyIpLAogICAg ICAgICAgICAgRkFMU0UsCiAgICAgICAgICAgICByZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdz KSk7CisKKyAgICAvKioKKyAgICAgKiBXZWJLaXRTZXR0aW5nczplbmFibGUtY3NzLXJlZ2lvbnM6 CisgICAgICoKKyAgICAgKiBFbmFibGUgb3IgZGlzYWJsZSBDU1MgcmVnaW9ucy4gRm9yIG1vcmUg aW5mb3JtYXRpb24gc2VlIGh0dHA6Ly9odG1sLmFkb2JlLmNvbS93ZWJwbGF0Zm9ybS9sYXlvdXQv cmVnaW9ucy8uCisgICAgICoKKyAgICAgKiBTaW5jZTogMi4wCisJICovCisgICAgZ19vYmplY3Rf Y2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnT2JqZWN0Q2xhc3MsCisgICAgICAgIFBST1BfRU5BQkxF X0NTU19SRUdJT05TLAorICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxlLWNzcy1y ZWdpb25zIiwKKyAgICAgICAgICAgIF8oIkVuYWJsZSBDU1MgcmVnaW9ucyIpLAorICAgICAgICAg ICAgXygiV2hldGhlciB0byBlbmFibGUgY3NzIHJlZ2lvbnMiKSwKKyAgICAgICAgICAgIFRSVUUs CisgICAgICAgICAgICByZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdzKSk7CiB9CiAKIFdlYlBy ZWZlcmVuY2VzKiB3ZWJraXRTZXR0aW5nc0dldFByZWZlcmVuY2VzKFdlYktpdFNldHRpbmdzKiBz ZXR0aW5ncykKQEAgLTI3MTksMyArMjc0Miw0MyBAQCB2b2lkIHdlYmtpdF9zZXR0aW5nc19zZXRf ZW5hYmxlX2FjY2VsZXJhCiAgICAgcHJpdi0+cHJlZmVyZW5jZXMtPnNldEFjY2VsZXJhdGVkMmRD YW52YXNFbmFibGVkKGVuYWJsZWQpOwogICAgIGdfb2JqZWN0X25vdGlmeShHX09CSkVDVChzZXR0 aW5ncyksICJlbmFibGUtYWNjZWxlcmF0ZWQtMmQtY2FudmFzIik7CiB9CisKKy8qKgorICogd2Vi a2l0X3NldHRpbmdzX2dldF9lbmFibGVfY3NzX3JlZ2lvbnM6CisgKiBAc2V0dGluZ3M6IGEgI1dl YktpdFNldHRpbmdzCisgKgorICogR2V0IHRoZSAjV2ViS2l0U2V0dGluZ3M6ZW5hYmxlLWNzcy1y ZWdpb25zIHByb3BlcnR5LgorICoKKyAqIFJldHVybnM6ICVUUlVFIGlmIGNzcyByZWdpb25zIGlz IGVuYWJsZWQgb3IgJUZBTFNFIG90aGVyd2lzZS4KKyAqLworZ2Jvb2xlYW4gd2Via2l0X3NldHRp bmdzX2dldF9lbmFibGVfY3NzX3JlZ2lvbnMoV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzKQorewor ICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19TRVRUSU5HUyhzZXR0aW5ncyksIEZB TFNFKTsKKworICAgIHJldHVybiBzZXR0aW5ncy0+cHJpdi0+cHJlZmVyZW5jZXMtPmNzc1JlZ2lv bnNFbmFibGVkKCk7Cit9CisKKy8qKgorICogd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfY3Nz X3JlZ2lvbnM6CisgKiBAc2V0dGluZ3M6IGEgI1dlYktpdFNldHRpbmdzCisgKiBAZW5hYmxlZDog VmFsdWUgdG8gYmUgc2V0CisgKgorICogU2V0IHRoZSAjV2ViS2l0U2V0dGluZ3M6ZW5hYmxlLWNz cy1yZWdpb25zIHByb3BlcnR5LgorICovCit2b2lkIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxl X2Nzc19yZWdpb25zKFdlYktpdFNldHRpbmdzKiBzZXR0aW5ncywgZ2Jvb2xlYW4gZW5hYmxlZCkK K3sKKyAgICBnX3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19TRVRUSU5HUyhzZXR0aW5ncykpOwor CisgICAgV2ViS2l0U2V0dGluZ3NQcml2YXRlKiBwcml2ID0gc2V0dGluZ3MtPnByaXY7CisgICAg Ym9vbCBjdXJyZW50VmFsdWUgPSBwcml2LT5wcmVmZXJlbmNlcy0+Y3NzUmVnaW9uc0VuYWJsZWQo KTsKKyAgICBpZiAoY3VycmVudFZhbHVlID09IGVuYWJsZWQpCisgICAgICAgIHJldHVybjsKKwor I2lmIEVOQUJMRShDU1NfUkVHSU9OUykKKyAgICBXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1 cmVzOjpzZXRDU1NSZWdpb25zRW5hYmxlZChlbmFibGVkKTsKKyNlbmRpZgorCisgICAgcHJpdi0+ cHJlZmVyZW5jZXMtPnNldENTU1JlZ2lvbnNFbmFibGVkKGVuYWJsZWQpOworICAgIGdfb2JqZWN0 X25vdGlmeShHX09CSkVDVChzZXR0aW5ncyksICJlbmFibGUtY3NzLXJlZ2lvbnMiKTsKK30KKwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0 aW5ncy5oCShyZXZpc2lvbiAxNTAwMDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRTZXR0aW5ncy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zODYsNiArMzg2LDEyIEBA IHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2FjY2VsZXJhdGVkXzIKIFdFQktJVF9BUEkgdm9p ZAogd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfYWNjZWxlcmF0ZWRfMmRfY2FudmFzICAgICAg ICAgICAgICAgKFdlYktpdFNldHRpbmdzICpzZXR0aW5ncywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnYm9vbGVhbiAgICAg ICAgZW5hYmxlZCk7CitXRUJLSVRfQVBJIGdib29sZWFuCit3ZWJraXRfc2V0dGluZ3NfZ2V0X2Vu YWJsZV9jc3NfcmVnaW9ucyAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0U2V0dGluZ3Mg KnNldHRpbmdzKTsKKworV0VCS0lUX0FQSSB2b2lkCit3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJs ZV9jc3NfcmVnaW9ucyAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0U2V0dGluZ3MgKnNl dHRpbmdzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGdib29sZWFuICAgICAgICBlbmFibGVkKTsKIAogR19FTkRfREVDTFMK IApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3Rr LXNlY3Rpb25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CShyZXZpc2lvbiAxNTAwMDIpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zMTksNiArMzE5LDggQEAgd2Via2l0X3NldHRpbmdzX2dl dF9lbmFibGVfc21vb3RoX3Njcm9sbAogd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfc21vb3Ro X3Njcm9sbGluZwogd2Via2l0X3NldHRpbmdzX2dldF9lbmFibGVfYWNjZWxlcmF0ZWRfMmRfY2Fu dmFzCiB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9hY2NlbGVyYXRlZF8yZF9jYW52YXMKK3dl YmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2Nzc19yZWdpb25zCit3ZWJraXRfc2V0dGluZ3Nfc2V0 X2VuYWJsZV9jc3NfcmVnaW9ucwogCiA8U1VCU0VDVElPTiBTdGFuZGFyZD4KIFdlYktpdFNldHRp bmdzQ2xhc3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDAyMikKKysrIFNvdXJj ZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisy MDEzLTA1LTEzICBBbnRvbiBPYnpoaXJvdiAgPGEub2J6aGlyb3ZAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0dUS10gUHJvdmlkZSB3ZWIgc2V0dGluZyB0byBjb250cm9sIENTUyByZWdpb25zIHJ1 biB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTYwNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZWVkZWQgdG8gYWRkIHJ1biB0aW1lIGVuYWJsaW5nL2Rpc2FibGluZyBvZiBDU1MgcmVnaW9ucyBm b3IgR1RLIHBvcnQgaW4gb3JkZXIgdG8gcGxheSB3aXRoIENTUyByZWdpb25zLgorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAg KER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6c2V0Q1NTUmVnaW9uc0VuYWJsZWQpOgorICAgICAg ICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3Nl dHRpbmdzX2NsYXNzX2luaXQpOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19zZXRfcHJv cGVydHkpOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19nZXRfcHJvcGVydHkpOgorICAg ICAgICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5nc3ByaXZhdGUuaDoKKwogMjAxMy0wNS0xMiAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgaW5j bHVkaW5nIFVudXNlZFBhcmFtLmgKSW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAkocmV2 aXNpb24gMTUwMDAyKQorKysgU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJl bmRlclRyZWVTdXBwb3J0R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjE2LDcgKzYxNiw5IEBA IHZvaWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzZXRDU1NHcmkKIAogdm9pZCBEdW1wUmVu ZGVyVHJlZVN1cHBvcnRHdGs6OnNldENTU1JlZ2lvbnNFbmFibGVkKFdlYktpdFdlYlZpZXcqIHdl YlZpZXcsIGJvb2wgZW5hYmxlZCkKIHsKKyNpZiBFTkFCTEUoQ1NTX1JFR0lPTlMpCiAgICAgUnVu dGltZUVuYWJsZWRGZWF0dXJlczo6c2V0Q1NTUmVnaW9uc0VuYWJsZWQoZW5hYmxlZCk7CisjZW5k aWYKIH0KIAogdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldENTU0N1c3RvbUZpbHRl ckVuYWJsZWQoV2ViS2l0V2ViVmlldyogd2ViVmlldywgYm9vbCBlbmFibGVkKQpJbmRleDogU291 cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCShyZXZpc2lv biAxNTAwMDIpCisrKyBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3Mu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjIsNiArMTIyLDcgQEAgZW51bSB7CiAgICAgUFJPUF9N RURJQV9QTEFZQkFDS19SRVFVSVJFU19VU0VSX0dFU1RVUkUsCiAgICAgUFJPUF9NRURJQV9QTEFZ QkFDS19BTExPV1NfSU5MSU5FLAogICAgIFBST1BfRU5BQkxFX0NTU19TSEFERVJTLAorICAgIFBS T1BfRU5BQkxFX0NTU19SRUdJT05TLAogICAgIFBST1BfRU5BQkxFX1JVTk5JTkdfT0ZfSU5TRUNV UkVfQ09OVEVOVCwKICAgICBQUk9QX0VOQUJMRV9ESVNQTEFZX09GX0lOU0VDVVJFX0NPTlRFTlQK IH07CkBAIC05OTQsNiArOTk1LDI1IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3Nf Y2xhc3NfaW4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZsYWdzKSk7CiAKICAgICAvKioKKyAgICAqIFdlYktpdFdlYlNldHRpbmdzOmVu YWJsZS1jc3MtcmVnaW9uczoKKyAgICAqCisgICAgKiBFbmFibGUgb3IgZGlzYWJsZSBzdXBwb3J0 IGZvciBjc3MgcmVnaW9ucy4KKyAgICAqIENTUyByZWdpb25zIG5lZWQgdG8gYmUgZW5hYmxlZCBh dCBjb21waWxlIHRpbWUsIGJ1dCBkb2Vzbid0IG5lZWQKKyAgICAqIHRvIGJlIGVuYWJsZWQgYXQg cnVudGltZS4KKyAgICAqCisgICAgKiBTZWUgYWxzbyBodHRwOi8vaHRtbC5hZG9iZS5jb20vd2Vi cGxhdGZvcm0vbGF5b3V0L3JlZ2lvbnMvCisgICAgKgorICAgICogU2luY2U6IDIuMAorICAgICov CisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0X2NsYXNzLAorICAg ICAgICBQUk9QX0VOQUJMRV9DU1NfUkVHSU9OUywKKyAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xl YW4oImVuYWJsZS1jc3MtcmVnaW9ucyIsCisgICAgICAgICAgICBfKCJFbmFibGUgQ1NTIHJlZ2lv bnMiKSwKKyAgICAgICAgICAgIF8oIldoZXRoZXIgdG8gZW5hYmxlIGNzcyByZWdpb25zIiksCisg ICAgICAgICAgICBUUlVFLAorICAgICAgICAgICAgZmxhZ3MpKTsKKworICAgIC8qKgogICAgICog V2ViS2l0V2ViU2V0dGluZ3M6ZW5hYmxlLWRpc3BsYXktb2YtaW5zZWN1cmUtY29udGVudDoKICAg ICAqCiAgICAgKiBXaGV0aGVyIHBhZ2VzIGxvYWRlZCB2aWEgSFRUUFMgc2hvdWxkIGxvYWQgc3Vi cmVzb3VyY2VzIHN1Y2ggYXMKQEAgLTEyMTEsNiArMTIzMSw5IEBAIHN0YXRpYyB2b2lkIHdlYmtp dF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3AKICAgICBjYXNlIFBST1BfRU5BQkxFX0NTU19TSEFERVJT OgogICAgICAgICBwcml2LT5lbmFibGVDU1NTaGFkZXJzID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2 YWx1ZSk7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgUFJPUF9FTkFCTEVfQ1NTX1JFR0lPTlM6 CisgICAgICAgIHByaXYtPmVuYWJsZUNTU1JlZ2lvbnMgPSBnX3ZhbHVlX2dldF9ib29sZWFuKHZh bHVlKTsKKyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX01FRElBX1BMQVlCQUNLX1JFUVVJ UkVTX1VTRVJfR0VTVFVSRToKICAgICAgICAgcHJpdi0+bWVkaWFQbGF5YmFja1JlcXVpcmVzVXNl ckdlc3R1cmUgPSBnX3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKTsKICAgICAgICAgYnJlYWs7CkBA IC0xNDAwLDYgKzE0MjMsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2dldF9w cm9wCiAgICAgY2FzZSBQUk9QX0VOQUJMRV9DU1NfU0hBREVSUzoKICAgICAgICAgZ192YWx1ZV9z ZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+ZW5hYmxlQ1NTU2hhZGVycyk7CiAgICAgICAgIGJyZWFr OworICAgIGNhc2UgUFJPUF9FTkFCTEVfQ1NTX1JFR0lPTlM6CisgICAgICAgIGdfdmFsdWVfc2V0 X2Jvb2xlYW4odmFsdWUsIHByaXYtPmVuYWJsZUNTU1JlZ2lvbnMpOworICAgICAgICBicmVhazsK ICAgICBjYXNlIFBST1BfTUVESUFfUExBWUJBQ0tfUkVRVUlSRVNfVVNFUl9HRVNUVVJFOgogICAg ICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5tZWRpYVBsYXliYWNrUmVxdWly ZXNVc2VyR2VzdHVyZSk7CiAgICAgICAgIGJyZWFrOwpJbmRleDogU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzcHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5nc3ByaXZhdGUuaAkocmV2aXNpb24gMTUw MDAyKQorKysgU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzcHJpdmF0 ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04NCw2ICs4NCw3IEBAIHN0cnVjdCBfV2ViS2l0V2ViU2V0 dGluZ3NQcml2YXRlIHsKICAgICBnYm9vbGVhbiBlbmFibGVBY2NlbGVyYXRlZENvbXBvc2l0aW5n OwogICAgIGdib29sZWFuIGVuYWJsZVNtb290aFNjcm9sbGluZzsKICAgICBnYm9vbGVhbiBlbmFi bGVDU1NTaGFkZXJzOworICAgIGdib29sZWFuIGVuYWJsZUNTU1JlZ2lvbnM7CiAgICAgZ2Jvb2xl YW4gbWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmU7CiAgICAgZ2Jvb2xlYW4gbWVkaWFQ bGF5YmFja0FsbG93c0lubGluZTsKICAgICBnYm9vbGVhbiBlbmFibGVEaXNwbGF5T2ZJbnNlY3Vy ZUNvbnRlbnQ7CkluZGV4OiBTb3VyY2UvYXV0b3Rvb2xzL1ByaW50QnVpbGRDb25maWd1cmF0aW9u Lm00Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9hdXRvdG9vbHMvUHJpbnRCdWlsZENvbmZpZ3VyYXRp b24ubTQJKHJldmlzaW9uIDE1MDAwMikKKysrIFNvdXJjZS9hdXRvdG9vbHMvUHJpbnRCdWlsZENv bmZpZ3VyYXRpb24ubTQJKHdvcmtpbmcgY29weSkKQEAgLTE4LDYgKzE4LDcgQEAgRmVhdHVyZXM6 CiAgQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmcgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOiAkZW5hYmxlX2FjY2VsZXJhdGVkX2NvbXBvc2l0aW5nCiAgQWNjZWxlcmF0ZWQgMkQgY2Fu dmFzICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2FjY2VsZXJh dGVkX2NhbnZhcwogIEJhdHRlcnkgQVBJIHN1cHBvcnQgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDogJGVuYWJsZV9iYXR0ZXJ5X3N0YXR1cworIENTUyBSZWdpb25zICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV9jc3NfcmVn aW9ucwogIEdhbWVwYWQgc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDogJGVuYWJsZV9nYW1lcGFkCiAgR2VvbG9jYXRpb24gc3VwcG9ydCAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2dlb2xvY2F0aW9uCiAgSFRNTDUg dmlkZW8gZWxlbWVudCBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5h YmxlX3ZpZGVvCkluZGV4OiBTb3VyY2UvYXV0b3Rvb2xzL1JlYWRDb21tYW5kTGluZUFyZ3VtZW50 cy5tNAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYXV0b3Rvb2xzL1JlYWRDb21tYW5kTGluZUFyZ3Vt ZW50cy5tNAkocmV2aXNpb24gMTUwMDAyKQorKysgU291cmNlL2F1dG90b29scy9SZWFkQ29tbWFu ZExpbmVBcmd1bWVudHMubTQJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw2ICsxMDMsMTMgQEAgQUNf QVJHX0VOQUJMRShnZW9sb2NhdGlvbiwKICAgICBbZW5hYmxlX2dlb2xvY2F0aW9uPSJ5ZXMiXSkK IEFDX01TR19SRVNVTFQoWyRlbmFibGVfZ2VvbG9jYXRpb25dKQogCitBQ19NU0dfQ0hFQ0tJTkco W3doZXRoZXIgdG8gZW5hYmxlIENTUyByZWdpb25zXSkKK0FDX0FSR19FTkFCTEUoY3NzX3JlZ2lv bnMsCisgICAgQUNfSEVMUF9TVFJJTkcoWy0tZW5hYmxlLWNzcy1yZWdpb25zXSwgW2VuYWJsZSBz dXBwb3J0IGZvciBDU1MgcmVnaW9ucyBbZGVmYXVsdD15ZXNdXSksCisgICAgW10sCisgICAgW2Vu YWJsZV9jc3NfcmVnaW9ucz0ieWVzIl0pCitBQ19NU0dfUkVTVUxUKFskZW5hYmxlX2Nzc19yZWdp b25zXSkKKwogQUNfTVNHX0NIRUNLSU5HKFt3aGV0aGVyIHRvIGVuYWJsZSBTVkcgc3VwcG9ydF0p CiBBQ19BUkdfRU5BQkxFKHN2ZywgCiAgICAgQUNfSEVMUF9TVFJJTkcoWy0tZW5hYmxlLXN2Z10s IFtlbmFibGUgc3VwcG9ydCBmb3IgU1ZHIFtkZWZhdWx0PXllc11dKSwKSW5kZXg6IFNvdXJjZS9h dXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYXV0 b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVyZXMubTQJKHJldmlzaW9uIDE1MDAwMikKKysrIFNvdXJj ZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNAkod29ya2luZyBjb3B5KQpAQCAtNDcs NiArNDcsMTIgQEAgZWxzZQogICAgIENPTkZJR1VSQUJMRV9GRUFUVVJFX0RFRklORVM9IiRDT05G SUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTIEVOQUJMRV9HRU9MT0NBVElPTj0wIgogZmkKIAoraWYg dGVzdCAiJGVuYWJsZV9jc3NfcmVnaW9ucyIgPSAieWVzIjsgdGhlbgorICAgIENPTkZJR1VSQUJM RV9GRUFUVVJFX0RFRklORVM9IiRDT05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTIEVOQUJMRV9D U1NfUkVHSU9OUz0xIgorZWxzZQorICAgIENPTkZJR1VSQUJMRV9GRUFUVVJFX0RFRklORVM9IiRD T05GSUdVUkFCTEVfRkVBVFVSRV9ERUZJTkVTIEVOQUJMRV9DU1NfUkVHSU9OUz0wIgorZmkKKwog aWYgdGVzdCAiJGVuYWJsZV9zdmciID0gInllcyI7IHRoZW4KICAgICBDT05GSUdVUkFCTEVfRkVB VFVSRV9ERUZJTkVTPSIkQ09ORklHVVJBQkxFX0ZFQVRVUkVfREVGSU5FUyBFTkFCTEVfU1ZHPTEi CiBlbHNlCkBAIC0xMDcsNyArMTEzLDcgQEAgJHNyY2Rpci9Ub29scy9ndGsvZ2VuZXJhdGUtZmVh dHVyZS1kZWZpbgogICAgIEVOQUJMRV9DU1NfSU1BR0VfT1JJRU5UQVRJT049MCBcCiAgICAgRU5B QkxFX0NTU19JTUFHRV9SRVNPTFVUSU9OPTAgXAogICAgIEVOQUJMRV9DU1NfSU1BR0VfU0VUPTAg XAotICAgIEVOQUJMRV9DU1NfUkVHSU9OUz0wIFwKKwogICAgIEVOQUJMRV9DU1NfU1RJQ0tZX1BP U0lUSU9OPTAgXAogICAgIEVOQUJMRV9DU1NfVFJBTlNGT1JNU19BTklNQVRJT05TX1VOUFJFRklY RUQ9MCBcCiAgICAgRU5BQkxFX0NTU19WQVJJQUJMRVM9MCBcCg==